summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorandroid-build-team Robot <android-build-team-robot@google.com>2020-04-28 20:25:36 +0000
committerandroid-build-team Robot <android-build-team-robot@google.com>2020-04-28 20:25:36 +0000
commit46c6b95bb0c993efa4049343541355fcd6c24b19 (patch)
treecd50340b6a02196b25774f17505ce70d4ad76268
parenta940864c73df96656815548c6c2bd07b55428f24 (diff)
parent79d0acf62e249d4d3b38cd41e5b47bdee336145a (diff)
downloadbsdiff-46c6b95bb0c993efa4049343541355fcd6c24b19.tar.gz
Change-Id: I56c6a2ef3e0f0c9b42f3f502b9b3c7102278e313
-rw-r--r--Android.bp7
-rw-r--r--OWNERS2
-rw-r--r--bsdiff_arguments.cc2
-rw-r--r--bspatch.cc6
4 files changed, 2 insertions, 15 deletions
diff --git a/Android.bp b/Android.bp
index 9f68463..d0e5933 100644
--- a/Android.bp
+++ b/Android.bp
@@ -33,15 +33,8 @@ cc_defaults {
cc_library_static {
name: "libbspatch",
defaults: ["bsdiff_defaults"],
- vendor_available: true,
recovery_available: true,
- visibility: [
- "//bootable/recovery:__subpackages__",
- "//external/puffin:__subpackages__",
- "//system/update_engine:__subpackages__",
- ],
-
srcs: [
"brotli_decompressor.cc",
"bspatch.cc",
diff --git a/OWNERS b/OWNERS
index ab036c1..ef9a19a 100644
--- a/OWNERS
+++ b/OWNERS
@@ -1,3 +1,3 @@
deymo@google.com
senj@google.com
-xunchang@google.com
+tbao@google.com
diff --git a/bsdiff_arguments.cc b/bsdiff_arguments.cc
index 7ea9b6d..20e6149 100644
--- a/bsdiff_arguments.cc
+++ b/bsdiff_arguments.cc
@@ -75,7 +75,7 @@ bool BsdiffArguments::IsValid() const {
bool BsdiffArguments::ParseCommandLine(int argc, char** argv) {
int opt;
- int option_index = 0;
+ int option_index;
while ((opt = getopt_long(argc, argv, "", OPTIONS, &option_index)) != -1) {
if (opt != 0) {
return false;
diff --git a/bspatch.cc b/bspatch.cc
index d7f1710..d552dcf 100644
--- a/bspatch.cc
+++ b/bspatch.cc
@@ -34,7 +34,6 @@ __FBSDID("$FreeBSD: src/usr.bin/bsdiff/bspatch/bspatch.c,v 1.1 2005/08/06 01:59:
#include <fcntl.h>
#include <inttypes.h>
#include <stdio.h>
-#include <stdint.h>
#include <stdlib.h>
#include <string.h>
#include <sys/stat.h>
@@ -330,8 +329,6 @@ int bspatch(const std::unique_ptr<FileInterface>& old_file,
// Adjust pointers.
newpos += control_entry.diff_size;
- if (oldpos > INT64_MAX - static_cast<int64_t>(control_entry.diff_size))
- return 2;
oldpos += control_entry.diff_size;
if (oldpos > static_cast<int64_t>(old_file_size)) {
@@ -361,9 +358,6 @@ int bspatch(const std::unique_ptr<FileInterface>& old_file,
// Adjust pointers.
newpos += control_entry.extra_size;
- if (control_entry.offset_increment > 0 &&
- oldpos > INT64_MAX - control_entry.offset_increment)
- return 2;
oldpos += control_entry.offset_increment;
}