summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorTreehugger Robot <treehugger-gerrit@google.com>2021-04-20 04:45:43 +0000
committerAutomerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>2021-04-20 04:45:43 +0000
commiteb2172d477147b19142f6ea515396297b78bbc74 (patch)
tree6a5fca95ce93294ff06b53dbdfd4e3a81548cea3
parentc766cc16e00bede852aa58283a676805f9fc9a3b (diff)
parent27b55c2640bf9bcff7fb17d4651d6a36f1645760 (diff)
downloadbsdiff-eb2172d477147b19142f6ea515396297b78bbc74.tar.gz
Merge "Add comment explaining why we need custom logic to parse int" am: be81a990b3 am: 94af5fff58 am: 30ed9f9151 am: 27b55c2640
Original change: https://android-review.googlesource.com/c/platform/external/bsdiff/+/1680665 Change-Id: I95d94b17c7608d054105ba55c53b0484b971f4af
-rw-r--r--utils.cc5
1 files changed, 5 insertions, 0 deletions
diff --git a/utils.cc b/utils.cc
index c3e613e..c82eb98 100644
--- a/utils.cc
+++ b/utils.cc
@@ -7,6 +7,11 @@
namespace bsdiff {
int64_t ParseInt64(const uint8_t* buf) {
+ // BSPatch uses a non-standard encoding of integers.
+ // Highest bit of that integer is used as a sign bit, 1 = negative
+ // and 0 = positive.
+ // Therefore, if the highest bit is set, flip it, then do 2's complement
+ // to get the integer in standard form
int64_t result = buf[7] & 0x7F;
for (int i = 6; i >= 0; i--) {
result <<= 8;