summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAlex Deymo <deymo@google.com>2018-02-13 11:27:30 +0100
committerAlex Deymo <deymo@google.com>2018-02-13 11:29:08 +0100
commit89439c5817b14ddca5af360e1a635856ba45d756 (patch)
treefbd6896513ee8d422f91ca6dbcbe5983932c975e
parent46e8a3d9bd4d6cd77b8556fb243a18f4e886cb0e (diff)
downloadbsdiff-89439c5817b14ddca5af360e1a635856ba45d756.tar.gz
Remove "using" from header files.
Per style guide, we should not have global using clausules in header files since they polute the namespace for everybody including the header. Bug: None Test: It still builds. Change-Id: Id34b18fbed9e71e3c502e4a91c4d242e553b6f88
-rw-r--r--bsdiff_arguments.h10
1 files changed, 4 insertions, 6 deletions
diff --git a/bsdiff_arguments.h b/bsdiff_arguments.h
index fdce065..b330834 100644
--- a/bsdiff_arguments.h
+++ b/bsdiff_arguments.h
@@ -12,8 +12,6 @@
#include "bsdiff/constants.h"
#include "bsdiff/patch_writer_interface.h"
-using std::string;
-
namespace bsdiff {
// Class to store the patch writer options about format, type and quality.
@@ -46,16 +44,16 @@ class BsdiffArguments {
bool ParseCommandLine(int argc, char** argv);
// Parse the compression type from string.
- static bool ParseCompressorType(const string& str, CompressorType* type);
+ static bool ParseCompressorType(const std::string& str, CompressorType* type);
// Parse the minimum length parameter from string.
- static bool ParseMinLength(const string& str, size_t* len);
+ static bool ParseMinLength(const std::string& str, size_t* len);
// Parse the bsdiff format from string.
- static bool ParseBsdiffFormat(const string& str, BsdiffFormat* format);
+ static bool ParseBsdiffFormat(const std::string& str, BsdiffFormat* format);
// Parse the compression quality (for brotli) from string.
- static bool ParseQuality(const string& str, int* quality);
+ static bool ParseQuality(const std::string& str, int* quality);
private:
// Current format supported are the legacy "BSDIFF40" or "BSDF2".