From a8ff454126ed6c2f60fe4c9ae4d8e3e1806791a6 Mon Sep 17 00:00:00 2001 From: Amin Hassani Date: Mon, 13 Nov 2017 16:00:30 -0800 Subject: bsdiff: Redo the gyp file New changes in bsdiff causes a lot of undefined reference failures in the CrOS side. This CL modifies the bsdiff.gyp file to create a static and shared libraries for both bsdiff and bspatch. static libraries are used for unittests, and shared libraries are used in executables and by other external libraries. This way we do not have to export all the symbols that are not required to be exported. BUG=chromium:783437 TEST=unittests pass; 'bsdiff' and 'bspatch' run with no dependency issues. Change-Id: If6ad895756f7ef797844ba95e3dfd174793e10a8 --- include/bsdiff/patch_writer_factory.h | 3 +++ 1 file changed, 3 insertions(+) (limited to 'include') diff --git a/include/bsdiff/patch_writer_factory.h b/include/bsdiff/patch_writer_factory.h index 2320334..930cffb 100644 --- a/include/bsdiff/patch_writer_factory.h +++ b/include/bsdiff/patch_writer_factory.h @@ -9,18 +9,21 @@ #include #include +#include "bsdiff/common.h" #include "bsdiff/patch_writer_interface.h" namespace bsdiff { // Create a patch writer compatible with upstream's "BSDIFF40" patch format // using bz2 as a compressor. +BSDIFF_EXPORT std::unique_ptr CreateBsdiffPatchWriter( const std::string& patch_filename); // Create a patch writer compatible with Android Play Store bsdiff patches, // uncompressed. The data will be written to the passed |patch| vector, which // must be valid until Close() is called or this patch is destroyed. +BSDIFF_EXPORT std::unique_ptr CreateEndsleyPatchWriter( std::vector* patch); -- cgit v1.2.3