diff options
| author | Gabe Black <gabeblack@chromium.org> | 2014-05-15 18:56:09 -0700 |
|---|---|---|
| committer | chrome-internal-fetch <chrome-internal-fetch@google.com> | 2014-05-17 20:11:07 +0000 |
| commit | dd7294fea2d1a565c2f6047402f964e9adaaa3bf (patch) | |
| tree | bfd3b0567f847e9a510764f2eb7e886af974991f /buildbot | |
| parent | 7b5cfdd56f6fafb49471a7a7bc8cdf1906364e3b (diff) | |
| download | chromite-dd7294fea2d1a565c2f6047402f964e9adaaa3bf.tar.gz | |
Change the default for deps_filter_fn in PatchSeries.__init__.
The deps_filter_fn is defined to return True or False according to the
docstring for __init__. The default, however, is a lambda function which
returns its input as its result. While the input patch object logically
evaluates to true just as the actual value True would, it isn't strictly in
line with the definition in the comment. Since it's trivial to fix and has
such an official position as the default defined in the class itself, this
CL changes it to always return True instead.
BUG=None
TEST=Ran run_tests.
Change-Id: I019f039fb2786d6457f1b94846b484e66ea7171c
Reviewed-on: https://chromium-review.googlesource.com/200246
Reviewed-by: David James <davidjames@chromium.org>
Tested-by: Gabe Black <gabeblack@chromium.org>
Commit-Queue: Gabe Black <gabeblack@chromium.org>
Diffstat (limited to 'buildbot')
| -rw-r--r-- | buildbot/validation_pool.py | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/buildbot/validation_pool.py b/buildbot/validation_pool.py index 0bba93ff3..b0fdbac21 100644 --- a/buildbot/validation_pool.py +++ b/buildbot/validation_pool.py @@ -387,7 +387,7 @@ class PatchSeries(object): self._helper_pool = helper_pool self._path = path if deps_filter_fn is None: - deps_filter_fn = lambda x:x + deps_filter_fn = lambda x: True self.deps_filter_fn = deps_filter_fn self._is_submitting = is_submitting |