Make nyan-paladin a full builder to replace daisy_spring-paladin

daisy_spring-paladin is a full builder and also runs HWTest, which
makes it the bottleneck of a CQ run. Fix this by making nyan-paladin
the full builder instead.

Also added a unittest to prevent this from happening again.

BUG=chromium:413486
TEST=`cbuildbot_config_unittest`

Change-Id: Ibb0642820df6d39cb61a5f54fd04b94d37725e12
Reviewed-on: https://chromium-review.googlesource.com/217830
Reviewed-by: David James <davidjames@chromium.org>
Tested-by: Yu-Ju Hong <yjhong@chromium.org>
Commit-Queue: Yu-Ju Hong <yjhong@chromium.org>

1 files changed, 9 insertions, 0 deletions

diff --git a/cbuildbot/cbuildbot_config_unittest.py b/cbuildbot/cbuildbot_config_unittest.py
index 94f8b9b69..0c075e3b9 100755
--- a/cbuildbot/cbuildbot_config_unittest.py
+++ b/cbuildbot/cbuildbot_config_unittest.py
@@ -528,6 +528,15 @@ class CBuildBotTest(cros_test_lib.MoxTestCase):
           self.assertFalse(child_config.important,
                            msg % (child_config.name, build_name, build_name))
 
+  def testFullCQBuilderDoNotRunHWTest(self):
+    """Full CQ configs should not run HWTest."""
+    msg = ('%s should not be a full builder and run HWTest for '
+           'performance reasons')
+    for build_name, config in cbuildbot_config.config.iteritems():
+      if config.build_type == constants.PALADIN_TYPE:
+        self.assertFalse(config.chrome_binhost_only and config.hw_tests,
+                         msg % build_name)
+
 
 class FindFullTest(cros_test_lib.TestCase):
   """Test locating of official build for a board."""