cbuildbot_config: assert that every board is in _all_boards

This makes some follow up cleanup to cbuildbot_config easier to
accomplish.

BUG=chromium:433459
TEST=cbuildbot_config_unittest; diff examination.

Change-Id: I8b1f417898fa793fedbab392f35c0329ee4c7e27
Reviewed-on: https://chromium-review.googlesource.com/256400
Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org>
Commit-Queue: Aviv Keshet <akeshet@chromium.org>
Tested-by: Aviv Keshet <akeshet@chromium.org>

1 files changed, 13 insertions, 0 deletions

diff --git a/cbuildbot/cbuildbot_config_unittest.py b/cbuildbot/cbuildbot_config_unittest.py
index 0e1a341db..81d60928f 100644
--- a/cbuildbot/cbuildbot_config_unittest.py
+++ b/cbuildbot/cbuildbot_config_unittest.py
@@ -540,6 +540,15 @@ class CBuildBotTest(cros_test_lib.TestCase):
             test_config.priority in constants.HWTEST_VALID_PRIORITIES,
             '%s has an invalid hwtest priority.' % build_name)
 
+  def testAllBoardsExist(self):
+    """Verifies that all config boards are in _all_boards."""
+    for build_name, config in cbuildbot_config.config.iteritems():
+      for board in config['boards']:
+        # pylint: disable=protected-access
+        self.assertIn(board, cbuildbot_config._all_boards,
+                      'Config %s has unknown board %s.' %
+                      (build_name, board))
+
   def testPushImagePaygenDependancies(self):
     """Paygen requires PushImage."""
     for build_name, config in cbuildbot_config.config.iteritems():
@@ -709,6 +718,10 @@ class FindFullTest(cros_test_lib.TestCase):
     assert boards
 
     for b in boards:
+      # TODO(akeshet): Figure out why we have both panther_embedded-minimal
+      # release and panther_embedded-release, and eliminate one of them.
+      if b == 'panther_embedded':
+        continue
       external, internal = cbuildbot_config.FindFullConfigsForBoard(b)
       AtMostOneConfig(b, 'external', external)
       AtMostOneConfig(b, 'internal', internal)