diff options
| author | Prathmesh Prabhu <pprabhu@chromium.org> | 2014-11-20 13:05:06 -0800 |
|---|---|---|
| committer | chrome-internal-fetch <chrome-internal-fetch@google.com> | 2014-11-21 02:39:27 +0000 |
| commit | dc93692d31d084df441a0c9fae1013089eef3cef (patch) | |
| tree | 3c24a368e951bf0dad1e17618d98d751e231bf4f /cbuildbot/cbuildbot_config_unittest.py | |
| parent | e56debdc133e05336735cdee8f8b85fa9bd57d66 (diff) | |
| download | chromite-dc93692d31d084df441a0c9fae1013089eef3cef.tar.gz | |
cbuildbot: Don't wait for slaves on master-trybots.
Bots with master configs wait for the salves to finish in the completion stage.
On the waterfall, buildbot kicks off slaves along with the master. When running
a tryjob with a master config, there are no slaves to wait for. This CL
instructs the master tryjob to not wait for any slaves.
BUG=None.
TEST=Run a successful master-paladin tryjob.
Change-Id: Id87d1c64abdb2b7b5d3988b8c01ad2de23a3aa3f
Reviewed-on: https://chromium-review.googlesource.com/231116
Tested-by: Prathmesh Prabhu <pprabhu@chromium.org>
Reviewed-by: Don Garrett <dgarrett@chromium.org>
Commit-Queue: Prathmesh Prabhu <pprabhu@chromium.org>
Diffstat (limited to 'cbuildbot/cbuildbot_config_unittest.py')
| -rwxr-xr-x | cbuildbot/cbuildbot_config_unittest.py | 9 |
1 files changed, 9 insertions, 0 deletions
diff --git a/cbuildbot/cbuildbot_config_unittest.py b/cbuildbot/cbuildbot_config_unittest.py index f02d32e9b..e9ef6fcd9 100755 --- a/cbuildbot/cbuildbot_config_unittest.py +++ b/cbuildbot/cbuildbot_config_unittest.py @@ -264,6 +264,15 @@ class CBuildBotTest(cros_test_lib.MoxTestCase): 'Duplicate board in slaves of %s will cause upload prebuilts' ' failures' % build_name) + def testGetSlavesOnTrybot(self): + """Make sure every master has a sane list of slaves""" + mock_options = mock.Mock() + mock_options.remote_trybot = True + for _, config in cbuildbot_config.config.iteritems(): + if config['master']: + configs = cbuildbot_config.GetSlavesForMaster(config, mock_options) + self.assertEqual([], configs) + def testFactoryFirmwareValidity(self): """Ensures that firmware/factory branches have at least 1 valid name.""" tracking_branch = git.GetChromiteTrackingBranch() |