diff options
author | Don Garrett <dgarrett@google.com> | 2015-05-05 17:40:57 -0700 |
---|---|---|
committer | ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> | 2015-05-07 07:52:10 +0000 |
commit | 541bd6941ffdd2b79943613c5ff33782745aff35 (patch) | |
tree | e799bc1a8a672f746bfcbe3829d443177a68bd68 /cbuildbot/cbuildbot_run_unittest.py | |
parent | 97a0a460481aeb7319ceb2a2ab37c979345698d3 (diff) | |
download | chromite-541bd6941ffdd2b79943613c5ff33782745aff35.tar.gz |
cbuildbot_config: Stop exporting 'config'.
Stop exporting the variable 'config' from cbuildbot_config and
instead export 'GetConfig()'.
Instead of giving every script access to the global variable 'config',
export via a function. This is to simplify upcoming changes that may
need to load the config dynamically, or handle not having one.
TEST=cbuildbot/run_tests && cros lint *.py
BUG=chromium:483566
CQ-DEPEND=CL:269775
Change-Id: Ifaa33a597907cfc18a7e5e99c218609e26eed683
Reviewed-on: https://chromium-review.googlesource.com/269770
Reviewed-by: Don Garrett <dgarrett@chromium.org>
Commit-Queue: Don Garrett <dgarrett@chromium.org>
Tested-by: Don Garrett <dgarrett@chromium.org>
Diffstat (limited to 'cbuildbot/cbuildbot_run_unittest.py')
-rw-r--r-- | cbuildbot/cbuildbot_run_unittest.py | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/cbuildbot/cbuildbot_run_unittest.py b/cbuildbot/cbuildbot_run_unittest.py index 1cddbe2e7..087e7a825 100644 --- a/cbuildbot/cbuildbot_run_unittest.py +++ b/cbuildbot/cbuildbot_run_unittest.py @@ -150,7 +150,7 @@ class BuilderRunPickleTest(_BuilderRunTestCase): """Make sure BuilderRun objects can be pickled.""" def setUp(self): - self.real_config = cbuildbot_config.config['x86-alex-release-group'] + self.real_config = cbuildbot_config.GetConfig()['x86-alex-release-group'] self.PatchObject(cbuildbot_run._BuilderRunBase, 'GetVersion', return_value=DEFAULT_VERSION) |