config_lib: Add the ability to use templates for configs.

This CL adds the ability to use templates for configs, but doesn't turn
it on yet. It also adds tests for configs to ensure the names of the
configs consistently match the template names, and adjusts configs to
match. A list of changes:

- Remove some incorrectly configured "*-chrome-pfq-informational" bots.
  These incorrectly configured bots were unused and building Chromium,
  not Chrome, as the name implies. These were deprecated long ago in
  favor of correctly configured bots.
- Renamed *-telem-chrome-pfq-informational bots to
  telem-chromium-pfq-informational, since they build Chromium, not Chrome.
- Removed pre-cq-group. As a side-effect, this converts storm-pre-cq back to a
  regular pre-cq rather than being a compile-only-pre-cq (the previous
  code had accidentally converted storm-pre-cq to be compile-only.)
- Update amd64-generic-asan-paladin to actually be a paladin builder.
- Removed the unused 'binary' config type.
- Clarified documentation link for 'asan' builder.

This doesn't clean up every inheritance bug / messy situation in the file but
it cleans it up enough that it now passes the new tests.

Since we haven't turned templates on yet, you can see the changes made
by this CL by just looking at the config dump.

BUG=chromium:494824
TEST=New unit tests. Inspection of config dump.

Change-Id: I7d94923e27ec219d8f05bacfdd976e6531e3c921
Reviewed-on: https://chromium-review.googlesource.com/274236
Reviewed-by: David James <davidjames@chromium.org>
Tested-by: David James <davidjames@chromium.org>

1 files changed, 2 insertions, 1 deletions

diff --git a/cbuildbot/stages/sync_stages_unittest.py b/cbuildbot/stages/sync_stages_unittest.py
index 012a9fcfb..9d4c4d0de 100644
--- a/cbuildbot/stages/sync_stages_unittest.py
+++ b/cbuildbot/stages/sync_stages_unittest.py
@@ -284,10 +284,11 @@ class BaseCQTestCase(generic_stages_unittest.StageTestCase):
       for change in changes:
         change.flags['COMR'] = '2'
     if pre_cq_status is not None:
+      config = constants.PRE_CQ_DEFAULT_CONFIGS[0]
       new_build_id = self.fake_db.InsertBuild('Pre cq group',
                                               constants.WATERFALL_TRYBOT,
                                               1,
-                                              constants.PRE_CQ_GROUP_CONFIG,
+                                              config,
                                               'bot-hostname')
       for change in changes:
         action = clactions.TranslatePreCQStatusToAction(pre_cq_status)