diff options
| author | David James <davidjames@google.com> | 2014-06-09 18:54:11 -0700 |
|---|---|---|
| committer | chrome-internal-fetch <chrome-internal-fetch@google.com> | 2014-06-11 22:09:53 +0000 |
| commit | 8319c4828196f90c20c7c309c3a0989c1c52f541 (patch) | |
| tree | e865cce46f279669208fc23e7494371ab9445679 /lib/parallel.py | |
| parent | c60eb387383895ed8d30d67b093708b9de868e8f (diff) | |
| download | chromite-8319c4828196f90c20c7c309c3a0989c1c52f541.tar.gz | |
Set the SILENT_TIMEOUT to under 9000 seconds again, and explain why.
When SILENT_TIMEOUT is under 9000 seconds, then cbuildbot will catch
hanging processes before buildbot does. This allows cbuildbot to catch
hanging processes and to finish its work.
BUG=chromium:382739
TEST=All unit tests.
Change-Id: I5403a62971ff4b766c669bd95f7a47d8a47faefb
Reviewed-on: https://chromium-review.googlesource.com/203182
Reviewed-by: David James <davidjames@chromium.org>
Commit-Queue: David James <davidjames@chromium.org>
Tested-by: David James <davidjames@chromium.org>
Diffstat (limited to 'lib/parallel.py')
| -rw-r--r-- | lib/parallel.py | 8 |
1 files changed, 5 insertions, 3 deletions
diff --git a/lib/parallel.py b/lib/parallel.py index f337e8c7f..028b1c28a 100644 --- a/lib/parallel.py +++ b/lib/parallel.py @@ -117,9 +117,11 @@ class _BackgroundTask(multiprocessing.Process): STARTUP_TIMEOUT = 60 * 5 EXIT_TIMEOUT = 60 * 10 - # TODO: crbug.com/360063 - # The time we allow processes to be silent. - SILENT_TIMEOUT = 60 * 230 + # The time we allow processes to be silent. This is in place so that we + # eventually catch hanging processes, and print the remainder of our output. + # Do not increase this. Instead, adjust your program to print regular progress + # updates, so that cbuildbot (and buildbot) can know that it has not hung. + SILENT_TIMEOUT = 60 * 145 # The amount by which we reduce the SILENT_TIMEOUT every time we launch # a subprocess. This helps ensure that children get a chance to enforce the |