summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2015-06-05cros_sdk: Remove old wrapper.Bertrand SIMONNET
cros_sdk is executed with chromite/bin/cros_sdk. cros_sdk.py is not used anymore. BUG=None TEST=trybots. Change-Id: I58b7009864ba498e2916aa8297d00749a57d1356 Reviewed-on: https://chromium-review.googlesource.com/275342 Trybot-Ready: Bertrand Simonnet <bsimonnet@chromium.org> Tested-by: Bertrand Simonnet <bsimonnet@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> Commit-Queue: Bertrand Simonnet <bsimonnet@chromium.org>
2015-06-05config_lib: Add GetBoards() helper.Don Garrett
Add a helper method to find all boards mentioned in the config. BUG=None TEST=Unitests. Change-Id: I8526b3476ca173bfffd2400987efe75ee5ba792f Reviewed-on: https://chromium-review.googlesource.com/275150 Tested-by: Don Garrett <dgarrett@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> Commit-Queue: Gilad Arnold <garnold@chromium.org>
2015-06-05cros_sdk: Implement --toolchains.Gilad Arnold
This allows specifying an explicit set of toolchains that we want preinstalled in the chroot when it is being created. The underlying logic will look for an SDK overlay tarball containing these toolchains, if one exists, then download and unpack it on top of the SDK tarball. This will enable use of SDK overlays for arbitrary blueprints, which may not be based on a legacy board. The previously introduced --board option remains as a convenience mechanism; it simply expands the set of toolchains for known boards. BUG=brillo:918 TEST=cros_sdk --board link works as intended (contrived overlay). TEST=cros_sdk --toolchains <link-toolchains> works equally well. TEST=cros_sdk --toolchains <link-toolchains-unsorted> works too. Change-Id: I092fc813b3f5f2ec87124892e41645cb2edfd0dd Reviewed-on: https://chromium-review.googlesource.com/275354 Reviewed-by: Gilad Arnold <garnold@chromium.org> Commit-Queue: Gilad Arnold <garnold@chromium.org> Tested-by: Gilad Arnold <garnold@chromium.org> Reviewed-by: Ralph Nathan <ralphnathan@chromium.org>
2015-06-05cros_sdk: convert to commandline.ArgumentParserMike Frysinger
BUG=chromium:496565 TEST=the tree doesn't explode and tests keep passing Change-Id: I16c5dd4930b30e38eaeefd738cfba4609aa2ad82 Reviewed-on: https://chromium-review.googlesource.com/275182 Reviewed-by: Mike Frysinger <vapier@chromium.org> Tested-by: Mike Frysinger <vapier@chromium.org> Commit-Queue: Mike Frysinger <vapier@chromium.org>
2015-06-05deploy_chrome: convert to commandline.ArgumentParserMike Frysinger
BUG=chromium:496565 TEST=precq passes and chrome still installs Change-Id: I4f1a8fc756cf34e69f09053d1c62aa7c06525726 Reviewed-on: https://chromium-review.googlesource.com/275620 Trybot-Ready: Mike Frysinger <vapier@chromium.org> Reviewed-by: Gilad Arnold <garnold@chromium.org> Commit-Queue: Mike Frysinger <vapier@chromium.org> Tested-by: Mike Frysinger <vapier@chromium.org>
2015-06-05gerrit: fix draft deletion supportVadim Bendebury
When deleting drafts, GOB requires HTTP requests of type DELETE. This type of request must not have a body. After processing properly formatted draft delete requests, GOB returns status 204. This patch modifies the code to comply with the requirement and accommodate GOB behavior. BUG=b:21609687 TEST='gerrit deletedraft' invocations do not fail any more. Change-Id: I41e5d580786aaef01f739e693734376a22ad330d Signed-off-by: Vadim Bendebury <vbendeb@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/275108 Reviewed-by: Mike Frysinger <vapier@chromium.org>
2015-06-05cli: standardize --debug/exception displayMike Frysinger
Each tool implements this slightly different (if at all). Pull it back out and into the main runner so we get standard behvaior for all tools. BUG=None TEST=`cros flash ...` shows short error message TEST=`cros --debug flash ...` shows full traceback TEST=`./cbuildbot/run_tests` passes CQ-DEPEND=CL:275395 Change-Id: Icbdc23a63dccbd8afee02bb48ef80f16323f5073 Reviewed-on: https://chromium-review.googlesource.com/274895 Tested-by: Mike Frysinger <vapier@chromium.org> Reviewed-by: Gilad Arnold <garnold@chromium.org> Commit-Queue: Mike Frysinger <vapier@chromium.org>
2015-06-05commandline: fix incorrect super initMike Frysinger
When you use super(), you don't pass yourself to the function. In the __init__ with exceptions case, trying to print this exception leads to an infinite loop: cros: Unhandled exception: Traceback (most recent call last): File "/usr/local/src/chromiumos/chromite/bin/cros", line 142, in <module> commandline.ScriptWrapperMain(FindTarget) File "/usr/local/src/chromiumos/chromite/lib/commandline.py", line 939, in ScriptWrapperMain ret = target(argv[1:]) File "/usr/local/src/chromiumos/chromite/scripts/cros.py", line 78, in main print(e) RuntimeError: maximum recursion depth exceeded while getting the str of an object BUG=None TEST=print shows the right error message now Change-Id: I23e9a45dc902a17d273acdeaa461d100db3e14d5 Reviewed-on: https://chromium-review.googlesource.com/275395 Commit-Queue: Mike Frysinger <vapier@chromium.org> Tested-by: Mike Frysinger <vapier@chromium.org> Reviewed-by: Gilad Arnold <garnold@chromium.org> Reviewed-by: Don Garrett <dgarrett@chromium.org>
2015-06-05creat a llvm configYunlian Jiang
This creats a cbuildbot config which uses llvm as the default compiler. BUG=chromium:493794 TEST=none. Change-Id: I33da0041d08846db0363ab7a0349ad28e8296cc7 Reviewed-on: https://chromium-review.googlesource.com/275361 Reviewed-by: Mike Frysinger <vapier@chromium.org> Tested-by: Yunlian Jiang <yunlian@chromium.org> Commit-Queue: Mike Frysinger <vapier@chromium.org>
2015-06-05Use base_configs for generating AFDO configs.David James
Also remove AFDO configs that can't do HW tests, as HW tests are explicitly needed for generating AFDO data. Similarly remove configs that can't use AFDO data. BUG=none TEST=Inspect config, run unit tests. Change-Id: I3b801e1269883e37b9e9db55e02968c45ebd31e0 Reviewed-on: https://chromium-review.googlesource.com/275294 Reviewed-by: Don Garrett <dgarrett@chromium.org> Tested-by: David James <davidjames@chromium.org> Commit-Queue: David James <davidjames@chromium.org>
2015-06-05config_lib: Create simpler method for adding BuildConfigs.Don Garrett
The new method 'Add' is intended to replace to AddConfig and AddConfigWithoutTemplate and be slightly easier to use. It does not require a base config be specified (like AddConfig does), but supports zero (or more) mixin configs. The fist mixin is treated as a template, if it is a template. BUG=None TEST=None Change-Id: I81f13825a24385320b0a472ef6eea2dc7adfe2c8 Reviewed-on: https://chromium-review.googlesource.com/275142 Reviewed-by: Don Garrett <dgarrett@chromium.org> Commit-Queue: Don Garrett <dgarrett@chromium.org> Tested-by: Don Garrett <dgarrett@chromium.org>
2015-06-05cros flash: Work with older versions of cherrypy.Ralph Nathan
cros flash did not work for older versions of cherrypy. This fixes that to work for cherrypy versions 2.2.0 onwards. BUG=brillo:1151 TEST=`manual tests for cherrypy versions 2.2.0+` Change-Id: I86ab53f4d6d1bb324606bd5885c401fea92c2ef3 Reviewed-on: https://chromium-review.googlesource.com/275009 Reviewed-by: Yiming Chen <yimingc@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> Tested-by: Ralph Nathan <ralphnathan@chromium.org> Commit-Queue: Ralph Nathan <ralphnathan@chromium.org> Trybot-Ready: Ralph Nathan <ralphnathan@chromium.org>
2015-06-05cbuildbot: Add flag to specify bootsrap directory.Prathmesh Prabhu
cbuildbot by default bootstraps in a directory under /tmp. This CL adds a flag that lets the user specify the top level directory under which all bootstrapping directories should be created. This is especially useful on mobbuild, where /tmp is mounted noexec. This will also be used on our builders where we don't want to execute code from /tmp. The default behaviour remains unchanged, so that's what developers get. BUG=chromium:490935 TEST=`cbuildbot --test-bootstrap --bootstrap-dir path/to/custom/dir \ --local -p chromiumos/chromite binhost-pre-cq` and verify that all bootstrap re-executions use the custom directory. Change-Id: Iba4bcf29bc092815b30c9ccbb5a5cfa29ef1d583 Reviewed-on: https://chromium-review.googlesource.com/274913 Reviewed-by: Paul Hobbs <phobbs@google.com> Commit-Queue: Prathmesh Prabhu <pprabhu@chromium.org> Tested-by: Prathmesh Prabhu <pprabhu@chromium.org>
2015-06-05cbuildbot_view_config: Add --full option.Don Garrett
Re-add an option that dumps the 'full' config with no template for default hiding. Useful for viewing fully expanded configs. BUG=None TEST=Ran it, ran "cbuildbot/generate_chromeos_config_unittest". Change-Id: Ia889bbffab91614162f915b173444749c5c13562 Reviewed-on: https://chromium-review.googlesource.com/274972 Tested-by: Don Garrett <dgarrett@chromium.org> Reviewed-by: Don Garrett <dgarrett@chromium.org> Commit-Queue: Don Garrett <dgarrett@chromium.org>
2015-06-05Rename SDK overlay directory and constant.Gilad Arnold
Since we are moving away from "board-specific" overlays, this renames the relevant constants and locations so they are more generally applicable. BUG=brillo:918 TEST=Unit tests Change-Id: I960b5dde91a70921f73e1ecfda03c86f6b68cd3a Reviewed-on: https://chromium-review.googlesource.com/275004 Reviewed-by: David James <davidjames@chromium.org> Commit-Queue: Gilad Arnold <garnold@chromium.org> Tested-by: Gilad Arnold <garnold@chromium.org>
2015-06-05sdk_stages_unittest: Remove unused variable.Gilad Arnold
Introduced by copy-paste. BUG=brillo:918 TEST=Unit tests still work Change-Id: Id7f43c5aae84b6c096aa065c50ff573ca5f1be89 Reviewed-on: https://chromium-review.googlesource.com/275003 Reviewed-by: David James <davidjames@chromium.org> Commit-Queue: Gilad Arnold <garnold@chromium.org> Tested-by: Gilad Arnold <garnold@chromium.org>
2015-06-04generate_chromeos_configs: enable upload_gce_images for lakituAmey Deshpande
This patch enables the 'upload_gce_images' option for lakitu. As a result, each cbuildbot iteration will generate GCE-ready tarball for base and test images. BUG=brillo:782 TEST=Ran lakitu-incremental trybot and verified the tarball for test image. Change-Id: I87b4fe61da17035bc8030c613da0061192725724 Reviewed-on: https://chromium-review.googlesource.com/273671 Tested-by: Amey Deshpande <ameyd@google.com> Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org> Commit-Queue: Amey Deshpande <ameyd@google.com>
2015-06-04check_gdata_token: convert to commandline.ArgumentParserMike Frysinger
This makes the module more like our others and uses the standard cmdline interface. Also polish a few things: - use os.path.expanduser instead of $HOME - drop hardcoded gdata setup as our test wrapper handles this now BUG=None TEST=`check_gdata_token` still works BUG=chromium:496565 Change-Id: Iaa88c2397c088abd225757cc19d1cb9ee5a388f7 Reviewed-on: https://chromium-review.googlesource.com/275094 Reviewed-by: Don Garrett <dgarrett@chromium.org> Commit-Queue: Mike Frysinger <vapier@chromium.org> Tested-by: Mike Frysinger <vapier@chromium.org>
2015-06-04Revert "image_test: Fail the build if image tests fail"Aviv Keshet
BUG=chromium:416022 TEST=None This reverts commit 6397d6409001da437be2a61e1edb16466b000b27. Change-Id: I2ed4399dfcb02f75dbafb7266fe41337be2955bd Reviewed-on: https://chromium-review.googlesource.com/275341 Reviewed-by: David James <davidjames@chromium.org> Tested-by: Aviv Keshet <akeshet@chromium.org>
2015-06-04image_test: Fail the build if image tests failNam T. Nguyen
We have ignored image tests so far because some tests are difficult to really fix, e.g. the missing symbols imported by libthread_db. But recently we started whitelisting binaries such as this, and fixing other tests, image tests should be stable enough to flip the bit now. This CL de-marks ImageTestStage as a ForgivingBuilderStage. BUG=chromium:416022 TEST=trybots on {x86,arm,amd64,mipsel-o32}-generic-full Change-Id: I5a1460714413b3fa9c5a3893d41b56ba333d2e90 Reviewed-on: https://chromium-review.googlesource.com/275064 Reviewed-by: Mike Frysinger <vapier@chromium.org> Tested-by: Nam Nguyen <namnguyen@chromium.org> Commit-Queue: Nam Nguyen <namnguyen@chromium.org>
2015-06-04cbuildbot: add option to create GCE tarballsAmey Deshpande
Adds an optional stage to cbuildbot for generating and uploading GCE-ready image tarballs. These uploads are easy to convert GCE images and then run as GCE VM instanes. In most cases this will be of limited utility, since ChromeOS images do not come with SSH running by default and GCE does not provide serial acccess. The test images, however, do run SSH on startup and can be accessed while running on GCE. The option is disabled by default. For example: $ gcloud compute images create foo-image \ --source-uri gs://${GCS_PATH}/chromiumos_test_image_gce.tar.gz $ gcloud compute instances create foo-instance --image foo-image $ gcloud compute ssh root@foo-instance [ --ssh_key_file=... ] BUG=brillo:782 TEST=None Change-Id: I4b769d3ad757dd7a8610ba6e5ce342df6e137a22 Reviewed-on: https://chromium-review.googlesource.com/264772 Commit-Queue: Amey Deshpande <ameyd@google.com> Tested-by: Amey Deshpande <ameyd@google.com> Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org>
2015-06-04Remove unused configs from ChromeOS config.David James
BUG=none TEST=Unit tests. Inspect config dump. Change-Id: Ie0690b53bb628ccd45eb3dd38487939590b8a4dd Reviewed-on: https://chromium-review.googlesource.com/275056 Trybot-Ready: David James <davidjames@chromium.org> Commit-Queue: David James <davidjames@chromium.org> Reviewed-by: Don Garrett <dgarrett@chromium.org> Tested-by: David James <davidjames@chromium.org>
2015-06-04configs: Disable HW Qual stage on kayleNam T. Nguyen
There is no HW set up for kayle. BUG=None TEST=trybot on kayle-paladdin and it should be green Change-Id: I3685717415b9d2868857fccedf4798ced0f91251 Reviewed-on: https://chromium-review.googlesource.com/275156 Reviewed-by: Mike Frysinger <vapier@chromium.org> Commit-Queue: Nam Nguyen <namnguyen@chromium.org> Tested-by: Nam Nguyen <namnguyen@chromium.org>
2015-06-04report_stages: surface a link from slave build to its masterAviv Keshet
BUG=chromium:496752 TEST=Unit tests enhanced to use fake_cidb, and use a master_build_id. Verified that unit tests are exercising new code path. Change-Id: I89497e449e29cc2c52474e37688891a086e29c48 Reviewed-on: https://chromium-review.googlesource.com/275314 Trybot-Ready: Aviv Keshet <akeshet@chromium.org> Tested-by: Aviv Keshet <akeshet@chromium.org> Reviewed-by: David James <davidjames@chromium.org> Commit-Queue: Aviv Keshet <akeshet@chromium.org>
2015-06-04cros_merge_to_branch: convert to commandline.ArgumentParserMike Frysinger
BUG=None TEST=`cros_merge_to_branch -n 32027 32030 32031 release-R22.2723.B` still works BUG=chromium:496565 Change-Id: I0f63df3e6b00702d7464327b9c51abc6bf723286 Reviewed-on: https://chromium-review.googlesource.com/275118 Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org> Commit-Queue: Mike Frysinger <vapier@chromium.org> Tested-by: Mike Frysinger <vapier@chromium.org>
2015-06-04upload_prebuilts: convert to commandline.ArgumentParserMike Frysinger
Mostly mechanical, but some redundant settings were cleaned up too. BUG=None TEST=ran upload_prebuilts in dry-run using x86-generic-full options TEST=ran upload_prebuilts in dry-run using cq-master options BUG=chromium:496565 Change-Id: I3f6ac418528013d896b3cf735cf51557078872f5 Reviewed-on: https://chromium-review.googlesource.com/275181 Reviewed-by: Gilad Arnold <garnold@chromium.org> Commit-Queue: Mike Frysinger <vapier@chromium.org> Tested-by: Mike Frysinger <vapier@chromium.org>
2015-06-04cros_deps_diff: convert to commandline.ArgumentParserMike Frysinger
BUG=None TEST=`cros_deps_diff` still works BUG=chromium:496565 Change-Id: Ibe5967558db74a498a28d6b306f40c02f3b6b740 Reviewed-on: https://chromium-review.googlesource.com/275180 Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org> Commit-Queue: Mike Frysinger <vapier@chromium.org> Tested-by: Mike Frysinger <vapier@chromium.org>
2015-06-04crosfw: convert to commandline.ArgumentParserMike Frysinger
BUG=None TEST=`crosfw --help` works BUG=chromium:496565 Change-Id: Ia8d3c44d6a7cf51067400ad6837837257e6ca192 Reviewed-on: https://chromium-review.googlesource.com/275104 Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org> Commit-Queue: Mike Frysinger <vapier@chromium.org> Tested-by: Mike Frysinger <vapier@chromium.org>
2015-06-04refresh_package_status: convert to commandline.ArgumentParserMike Frysinger
BUG=None TEST=`refresh_package_status --help` still works TEST=refresh packages builder is OK BUG=chromium:496565 Change-Id: I4a2d9de857ffe6c76a748b81ba16e013f3c05a5a Reviewed-on: https://chromium-review.googlesource.com/275119 Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org> Commit-Queue: Mike Frysinger <vapier@chromium.org> Tested-by: Mike Frysinger <vapier@chromium.org>
2015-06-04portage_util_unittest: convert away from moxMike Frysinger
Rather than do a complete convert from mox to mock, change some of these to operate more on real files in the tempdir. Only mock out some of the more expensive functions (like git interactions). Some of these tests weren't even using mox or mock. BUG=chromium:430770 TEST=`./cbuildbot/run_tests` passes Change-Id: I5b62a5346ad041dca6acb0e89312b4b54ed64257 Reviewed-on: https://chromium-review.googlesource.com/265355 Reviewed-by: Mike Frysinger <vapier@chromium.org> Tested-by: Prathmesh Prabhu <pprabhu@chromium.org> Commit-Queue: Prathmesh Prabhu <pprabhu@chromium.org>
2015-06-04simple_builders_unittest: fix flaky failureAviv Keshet
This CL is a workaround for a subtle and poorly understood bug in cbuildbot_run, which only manifests in unit tests that use ParallelMock. BUG=chromium:470907 TEST=Test passed ~42k times without a failure. Change-Id: Ib0224195d4cff7b39484b15a8dfdfe77473dc95a Reviewed-on: https://chromium-review.googlesource.com/275012 Trybot-Ready: Aviv Keshet <akeshet@chromium.org> Tested-by: Aviv Keshet <akeshet@chromium.org> Reviewed-by: Paul Hobbs <phobbs@google.com> Reviewed-by: Mike Frysinger <vapier@chromium.org> Commit-Queue: Aviv Keshet <akeshet@chromium.org>
2015-06-04Factor out image type and file name constantsAmey Deshpande
This patch adds constants for for dev, recovery and test image file names. It also creates dicts for mapping image types to image file names and vice versa. Finally, it replaces references to these strings under chromite/cbuildbot/ and chromite/lib. There are more such references under chromite/cli/, chromite/lib/ and chromite/scripts/, which will be fixed in a later CL. BUG=brillo:782 TEST=Unittests and 'lumpy-paladin' trybot passed. Change-Id: I37fb2098924a4f1196b375bea6f44b10794bbc07 Reviewed-on: https://chromium-review.googlesource.com/274920 Reviewed-by: Mike Frysinger <vapier@chromium.org> Commit-Queue: Amey Deshpande <ameyd@google.com> Tested-by: Amey Deshpande <ameyd@google.com>
2015-06-04cros_best_revision: Switch script to chromeos_config.Don Garrett
This script is specific to Chrome OS, let it use Chrome OS specific data. This change means that this script will error out for non Chrome OS sites (when those exist). BUG=chromium:483566 TEST=lint + run_tests. Change-Id: I010e3b55cf87e4e66762233d6c0aaf8796a7126d Reviewed-on: https://chromium-review.googlesource.com/274888 Commit-Queue: Don Garrett <dgarrett@chromium.org> Trybot-Ready: Don Garrett <dgarrett@chromium.org> Tested-by: Don Garrett <dgarrett@chromium.org> Reviewed-by: Don Garrett <dgarrett@chromium.org>
2015-06-04cidb: refactor connection arg reading into its own functionAviv Keshet
BUG=chromium:488737 TEST=cidb_integration_test Change-Id: I93a6155226fe91eff610c156acce68985527ac5f Reviewed-on: https://chromium-review.googlesource.com/272672 Reviewed-by: Paul Hobbs <phobbs@google.com> Commit-Queue: Aviv Keshet <akeshet@chromium.org> Tested-by: Aviv Keshet <akeshet@chromium.org>
2015-06-04cros_chrome_sdk: Switch script to chromeos_config.Don Garrett
This script is specific to Chrome OS, let it use Chrome OS specific data. This change means that this script will error out for non Chrome OS sites (when those exist). BUG=chromium:483566 TEST=lint + run_tests. Change-Id: Iede0d117efdc16d44e3b4e139f83b8bf74692efc Reviewed-on: https://chromium-review.googlesource.com/274887 Reviewed-by: David James <davidjames@chromium.org> Commit-Queue: Don Garrett <dgarrett@chromium.org> Trybot-Ready: Don Garrett <dgarrett@chromium.org> Tested-by: Don Garrett <dgarrett@chromium.org>
2015-06-04binhost: Switch binhost to chromeos_config.Don Garrett
This script is specific to Chrome OS, let it use Chrome OS specific data. This change means that this script will error out for non Chrome OS sites (when those exist). BUG=chromium:483566 TEST=lint + run_tests. Change-Id: I58a08a390a1b779ddb40ae918a5b5dc616e5c099 Reviewed-on: https://chromium-review.googlesource.com/274886 Trybot-Ready: Don Garrett <dgarrett@chromium.org> Tested-by: Don Garrett <dgarrett@chromium.org> Reviewed-by: David James <davidjames@chromium.org> Commit-Queue: Don Garrett <dgarrett@chromium.org>
2015-06-04generate_chromeos_config -> chromeos_config.Don Garrett
I originally named the module generate_chromeos_config because I intended to only use it for generate the chromeos specific configuration Json file. However, we are using it for some Chrome OS specific scripts, and won't be able to generalize them for a long time. So... rename the module to reflect how it's being used. BUG=None TEST=cbuildbot/run_tests Change-Id: I8b111c06c48181a43e01c6d494a8a493a0371718 Reviewed-on: https://chromium-review.googlesource.com/275026 Reviewed-by: David James <davidjames@chromium.org> Commit-Queue: Don Garrett <dgarrett@chromium.org> Trybot-Ready: Don Garrett <dgarrett@chromium.org> Tested-by: Don Garrett <dgarrett@chromium.org>
2015-06-04cros_setup_toolchains: Add eclass-overlay to list of chroot overlaysChristopher Wiley
BUG=brillo:1113 TEST=`./update_chroot` Change-Id: I8bcfde2b57262bd1ee0bf4d008d19ffba4bd123b Reviewed-on: https://chromium-review.googlesource.com/274717 Reviewed-by: Christopher Wiley <wiley@chromium.org> Commit-Queue: Christopher Wiley <wiley@chromium.org> Tested-by: Christopher Wiley <wiley@chromium.org>
2015-06-04sandbox_spec_generator: Parse port rangesChristopher Wiley
BUG=brillo:996 TEST=unittests Change-Id: I67a32ec47b5cc1387d277bdc5935ef79c3773efa Reviewed-on: https://chromium-review.googlesource.com/274443 Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org> Commit-Queue: Christopher Wiley <wiley@chromium.org> Tested-by: Christopher Wiley <wiley@chromium.org>
2015-06-03config_lib: Enable using templates.David James
See also https://codereview.chromium.org/1151303005 which updates the infra code to use the templates. BUG=chromium:494824 TEST=Unit tests. Inspect config dump. Change-Id: I22dbba59b761f183c6fdf0e5a297b9684959eabb Reviewed-on: https://chromium-review.googlesource.com/274237 Trybot-Ready: David James <davidjames@chromium.org> Tested-by: David James <davidjames@chromium.org> Reviewed-by: Don Garrett <dgarrett@chromium.org>
2015-06-03Fix typos introduced by CL:274915.David James
While rebasing, some typos were introduced in CL:274915. These cause tests to fail when templates are turned on. Fix the typos. BUG=chromium:494824 TEST=Unit tests Change-Id: Ie55dd7787b5269f48ee32d494c9b8926a8fe4ff6 Reviewed-on: https://chromium-review.googlesource.com/274981 Reviewed-by: Don Garrett <dgarrett@chromium.org> Trybot-Ready: David James <davidjames@chromium.org> Tested-by: David James <davidjames@chromium.org>
2015-06-03Update master Chrome PFQ to send alerts when it fails.David James
BUG=chromium:493718 TEST=Unit tests. Change-Id: Ic6ee486ad674b506964044931dcc0f0215b36b1c Reviewed-on: https://chromium-review.googlesource.com/274964 Trybot-Ready: David James <davidjames@chromium.org> Reviewed-by: Don Garrett <dgarrett@chromium.org> Tested-by: David James <davidjames@chromium.org>
2015-06-03Revert "cbuildbot: Preserve chromite-bootstrap directory during Cleanup."Prathmesh Prabhu
This reverts commit 47eaa5ebb6be1d866654f4e6f769c7ee1c3fa583. The CL that introduced that dir path on the builders was reverted by CL:272284. Because we have this exception to the Cleanup step, the chromite-bootstrap directory is not getting cleaned up from the builders. This directory is no longer part of the build after CL:272284, so it also makes sense to revert this CL, that was trying to preserve that path. BUG=chromium:489870 TEST=Launch a trybot on a slave that has the obsolete path, verify that the path disappears, and that the buildslave remains healthy afterwards. Change-Id: I6b599232b9a80f3f56d0b3cf2fe88b951887c44d Reviewed-on: https://chromium-review.googlesource.com/274532 Tested-by: Prathmesh Prabhu <pprabhu@chromium.org> Trybot-Ready: Prathmesh Prabhu <pprabhu@chromium.org> Reviewed-by: Simran Basi <sbasi@chromium.org> Commit-Queue: Prathmesh Prabhu <pprabhu@chromium.org>
2015-06-03commands: change BuildGceTarball API to be more self-containedAmey Deshpande
This patch changes BuildGceTarball method such that it contains the logic to generate the output file name. This makes it consistent with the other archive functions in this module. BUG=brillo:782 TEST=Unitests Change-Id: I16166ebc90b8e997fd7b0c15a0503e248ad7f414 Reviewed-on: https://chromium-review.googlesource.com/274922 Reviewed-by: Amey Deshpande <ameyd@google.com> Commit-Queue: Amey Deshpande <ameyd@google.com> Tested-by: Amey Deshpande <ameyd@google.com> Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org>
2015-06-03cbuildbot: make --all option clearer in --listMike Frysinger
Add a note to the list output (like we have in the --help) that the default --list is abbreviated and you need to use --all to see all. BUG=chromium:492760 TEST=`cbuildbot -l` includes notice Change-Id: Ie1ddaa50dc03673a6342c8649126dba17a341efa Reviewed-on: https://chromium-review.googlesource.com/274940 Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org> Commit-Queue: Mike Frysinger <vapier@chromium.org> Tested-by: Mike Frysinger <vapier@chromium.org>
2015-06-03cbuildbot_run: Make site_config available to all build stages.Don Garrett
Nobody uses this new value yet, but this CL makes the site config available to all build stages. This is prep for getting rid of the cbuildbot_config global access. Follow on changes will remove references in various stages by using the new shared site_config value instead. BUG=chromium:483566 TEST=run_tests + lint Change-Id: I54532bdc5456cdbcc7eefa99e248a646bc5a23a9 Reviewed-on: https://chromium-review.googlesource.com/274871 Trybot-Ready: Don Garrett <dgarrett@chromium.org> Reviewed-by: David James <davidjames@chromium.org> Commit-Queue: Don Garrett <dgarrett@chromium.org> Tested-by: Don Garrett <dgarrett@chromium.org>
2015-06-03generate_chromeos_config: Generate config in GetConfig().Don Garrett
Stop generating the global config on import, and now do it in the GetConfig method. This gets rid of many global variables, but not all. Enable pylint indention testing, which was turned off in this file, and fix all errors so discovered. BUG=None TEST=Lint + Unitests. Change-Id: Ic5aad988111cde8c645f17fd68daccae4382995f Reviewed-on: https://chromium-review.googlesource.com/274915 Reviewed-by: Don Garrett <dgarrett@chromium.org> Tested-by: Don Garrett <dgarrett@chromium.org> Reviewed-by: David James <davidjames@chromium.org>
2015-06-03image_test: Split into the lib, and the testsNam T. Nguyen
image_test module imports some third party modules. In order for us to not depend on them at bootstrap time, this CL reorganizes those imports into an image_test_lib module, and keep only the tests in image_test module. BUG=brillo:1158 TEST=unittests TEST=trybots on release groups Change-Id: Ia60e74414abf49e8f9f81fbabd28b19d59a0cadf Reviewed-on: https://chromium-review.googlesource.com/274447 Commit-Queue: Nam Nguyen <namnguyen@chromium.org> Tested-by: Nam Nguyen <namnguyen@chromium.org> Trybot-Ready: Nam Nguyen <namnguyen@chromium.org> Reviewed-by: David James <davidjames@chromium.org>
2015-06-03mobmonitor: Basic Mob* Monitor architectureMatthew Sartori
This CL sets up the basic web, rpc, cli architecture for the Mob* Monitor. BUG=chromium:490820,chromium:490816,chromium:490813 TEST=Tested starting the Mob* Monitor on my local machine and executing the mobmon command line script to test the stubbed RPCs. Not yet tested/deployed to moblab. Change-Id: Ibd3e2b0aaf7a1c879406cb1be810000dcbfb194f Reviewed-on: https://chromium-review.googlesource.com/272957 Tested-by: Matthew Sartori <msartori@chromium.org> Reviewed-by: Simran Basi <sbasi@chromium.org> Commit-Queue: Aviv Keshet <akeshet@chromium.org>
2015-06-03cros_shell: Fix known hosts bug with default device.David Pursell
Fixed a bug where trying to remove an old value from the SSH known_hosts file would fail when using a default device with `brillo shell`. Also updated error message handling to avoid printing unnecessary newlines and doubling up on known hosts error messages. Corrected return values so that 1 is returned on all failure cases. Finally, updated unit tests to match the current implementation. Previously the unittests corresponded to old cros_shell code and no longer made sense, it was mostly coincidental that they still worked. BUG=brillo:1094 TEST=cbuildbot/run_tests TEST=`brillo shell` <modify known_hosts to corrupt ID> `brillo shell` now properly updates known_hosts. Change-Id: If25ab60b56f153f53d7214d1b1f393cb05b7bac3 Reviewed-on: https://chromium-review.googlesource.com/274878 Trybot-Ready: David Pursell <dpursell@chromium.org> Tested-by: David Pursell <dpursell@chromium.org> Reviewed-by: Yiming Chen <yimingc@chromium.org> Commit-Queue: David Pursell <dpursell@chromium.org>
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-16 00:45:59 +0000