| Age | Commit message (Collapse) | Author |
|---|
|
Minor fixups:
- don't use shebangs on non-executable files
- drop +x from files that don't need it
- fix blank line spacing
- fix typos in a few module docstrings
BUG=chromium:414895
TEST=`./cbuildbot/run_tests` passes
Change-Id: Idbce70b406254fbfcd5efa4beff2b1d5aa058d11
Reviewed-on: https://chromium-review.googlesource.com/218571
Reviewed-by: David James <davidjames@chromium.org>
Commit-Queue: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
|
|
This change will cause commit messages for published manifests to
include the build id, in the form 'build_id: 1234'. The build id is
taken from the builder run's metadata, if the build id exists, otherwise
none is written.
1) Updated manifest_version.py:GetNextBuildSpec and all its callers.
2) Updated lkgm_manager.py:CreateNewCandidate and all its callers.
3) Updated lkgm_manager.py:CreateFromManifest and all its callers.
4) Updated manifest_version.py:PublishManifest and all its callers.
Associated unit test fixes in lkgm_manager_unittest and
sync_stage_unittest. New unit tests of PublishManifest's commit message
behavior.
BUG=chromium:398267
TEST=New unit tests and existing tests pass.
Change-Id: I47e88b234301bccbece29f5bd94837ce30c4b2b9
Reviewed-on: https://chromium-review.googlesource.com/210094
Reviewed-by: Aviv Keshet <akeshet@chromium.org>
Commit-Queue: Aviv Keshet <akeshet@chromium.org>
Tested-by: Aviv Keshet <akeshet@chromium.org>
|
|
Currently ManifestVersionedSyncStage (used by canaries) uses a
BuildSpecsManager, while MasterSlaveSyncStage (used by PFQ, CQ) uses a
LKGMManager, which derives from BuildSpecsManager.
There is no reason why a master-slave model needs to be tied with a
LKGMManager. In fact, to make canaries adop the master-slave model, we
need to allow BuildSpecsManager to be used in this case.
This CL moves one method, GetBuildersStatus, which is required for
master-slave model, from LKGMManager to BuildSpecsManager. It also
move the timeout values from the manager itself to the Sync/Completion
stage so that they are more visible and easier to maintain.
BUG=chromium:385267
TEST=`cbuildbot/run_tests`
TEST=`cbuildbot --buildbot --debug --remote master-paladin`
Change-Id: Ibf0098fff31bad0c84958b78a7b55a5dc9d2afc9
Reviewed-on: https://chromium-review.googlesource.com/209742
Tested-by: Yu-Ju Hong <yjhong@chromium.org>
Reviewed-by: Aviv Keshet <akeshet@chromium.org>
Commit-Queue: Yu-Ju Hong <yjhong@chromium.org>
|
|
Also add several new arguments in timeout_util.WaitForSuccess so that
it can replace the function in lkgm_manager.
BUG=None
TEST=`cbuildbot/run_tests`
TEST=master-paladin trybot to print the logging messages
Change-Id: I472d3d7c02c67c6f3491334d313f5b12964fbe47
Reviewed-on: https://chromium-review.googlesource.com/209480
Reviewed-by: David James <davidjames@chromium.org>
Tested-by: Yu-Ju Hong <yjhong@chromium.org>
Commit-Queue: Yu-Ju Hong <yjhong@chromium.org>
|
|
PFQ master should write the version of the Chrome in the manifest it
creates. This ensures the the master and all slaves build the same
version.
Note that this CL only writes the version in the manifest, and the
next CL will force the slaves to use the version written the manifest.
BUG=chromium:387252
TEST=`cbuildbot/run_tests`
TEST=`cbuildbot --remote --debug --buildbot x86-generic-chromium-pfq`
Change-Id: I49c7834493410bd023ffa85a6ef94d7dc80a069e
Reviewed-on: https://chromium-review.googlesource.com/205523
Reviewed-by: Yu-Ju Hong <yjhong@chromium.org>
Commit-Queue: Yu-Ju Hong <yjhong@chromium.org>
Tested-by: Yu-Ju Hong <yjhong@chromium.org>
|
|
The cbuildbot script lives in a directory named buildbot. Which is a
bit confusing.
BUG=chromium:373277
TEST=Unitests + cros lint.
CQ-DEPEND=CL:200157
CQ-DEPEND=CL:200165
CQ-DEPEND=CL:200149
CQ-DEPEND=CL:*163598
CQ-DEPEND=CL:*163760
CQ-DEPEND=CL:*163786
Change-Id: Ia5953a4506e8b47d27e1a6908ecb938a439da8c2
Reviewed-on: https://chromium-review.googlesource.com/199664
Reviewed-by: Don Garrett <dgarrett@chromium.org>
Commit-Queue: Don Garrett <dgarrett@chromium.org>
Tested-by: Don Garrett <dgarrett@chromium.org>
|
