| Age | Commit message (Collapse) | Author |
|---|
|
A new lint hook will catch these, so make sure they're cleaned up before
we land it. Also clean up a few other lint errors that have crept into
the codebase somehow.
BUG=None
TEST=`cros lint` is clean after new trailing newline check
Change-Id: Ifdcc8ef72ee944511a821193857bfbf4b2d3ad7b
Reviewed-on: https://chromium-review.googlesource.com/307174
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Daniel Wang <wonderfly@google.com>
|
|
This library partially implemented the Chrome OS Brillo concept of a
workspace. That concept is no longer relevant, so remove the library.
Update assorted users, removing the concept of workspace where it seems
appropriate.
BUG=chromium:530677
TEST=run_tests
Change-Id: Icb43d24428f3c35e89e6c90325cbd03382670ffd
Reviewed-on: https://chromium-review.googlesource.com/305025
Commit-Ready: Don Garrett <dgarrett@chromium.org>
Tested-by: Don Garrett <dgarrett@chromium.org>
Reviewed-by: Don Garrett <dgarrett@chromium.org>
|
|
GetToolset() was used to switch functionality between `cros` and
`brillo`, so is no longer needed.
BUG=chromium:507323
TEST=cbuildbot/run_tests
TEST=cros --help
Change-Id: I652d4e5a2abcf3e318bc0233ae3c53b6b2fd29fb
Reviewed-on: https://chromium-review.googlesource.com/284169
Reviewed-by: David Pursell <dpursell@chromium.org>
Tested-by: David Pursell <dpursell@chromium.org>
Commit-Queue: David Pursell <dpursell@chromium.org>
|
|
Remove the `brillo` CLI command and all subcommands. Also remove `cros
devices` since that was a brillo-specific feature that is no longer
useful.
Next will be to remove brillo-specific libraries and any references to
them.
BUG=chromium:507323
TEST=cbuildbot/run_tests
TEST=`cros` still works as expected.
TEST=`brillo` is no longer available.
Change-Id: I8cc26b6c63c90088acc65b130b865ac1d7b87c5d
Reviewed-on: https://chromium-review.googlesource.com/283111
Reviewed-by: Bertrand Simonnet <bsimonnet@google.com>
Reviewed-by: Steve Fung <stevefung@chromium.org>
Commit-Queue: David Pursell <dpursell@chromium.org>
Trybot-Ready: David Pursell <dpursell@chromium.org>
Tested-by: David Pursell <dpursell@chromium.org>
|
|
Currently, on failure of a brillo operation with a progress bar,
a lot of output is produced. This cleans up the output and
points to user to files where more information can be found.
BUG=brillo:1026
TEST=unittest
Change-Id: I0a2235ff7e1ee2b1360e25bcda5fec3492a81408
Reviewed-on: https://chromium-review.googlesource.com/270817
Reviewed-by: Mike Frysinger <vapier@chromium.org>
Commit-Queue: Ralph Nathan <ralphnathan@chromium.org>
Trybot-Ready: Ralph Nathan <ralphnathan@chromium.org>
Tested-by: Ralph Nathan <ralphnathan@chromium.org>
|
|
Create a log file that stores all logging messages for brillo
commands. The log file is produced at all logging levels and is
stored in build/logs as brillo.log
BUG=brillo:1025
TEST=unittest + manual test
Change-Id: I6931307dd2456077c16650682991b5a5707c266c
Reviewed-on: https://chromium-review.googlesource.com/270336
Reviewed-by: Bertrand Simonnet <bsimonnet@chromium.org>
Commit-Queue: Ralph Nathan <ralphnathan@chromium.org>
Trybot-Ready: Ralph Nathan <ralphnathan@chromium.org>
Tested-by: Ralph Nathan <ralphnathan@chromium.org>
|
|
Change the default log level of brillo commands to notice instead of
info. Cros commands still operate at logging level info.
BUG=brillo:888
TEST=unittest + manual test
CQ-DEPEND=CL:269510, CL:269832
Change-Id: I9a9b1e8bd99f0a2681b826dc95734ae07e47333f
Reviewed-on: https://chromium-review.googlesource.com/266740
Reviewed-by: David Pursell <dpursell@chromium.org>
Commit-Queue: Ralph Nathan <ralphnathan@chromium.org>
Trybot-Ready: Ralph Nathan <ralphnathan@chromium.org>
Tested-by: Ralph Nathan <ralphnathan@chromium.org>
|
|
Provides AddDeviceArgument() function for CLI commands to add a device
to the commandline. The main benefits are:
1. The help message will be the same for all tools.
2. Automatic selection between a positional or optional argument.
`cros` devices arguments should normally be positional to keep backwards
compatibility, but `brillo` device arguments need to be optional so that
a default device can be provided if it is unspecified.
BUG=brillo:82, brillo:620, brillo:623
TEST=cbuildbot/run_tests
Change-Id: Id491097310671e73a6a4742b53d47dfdf392b7e1
Reviewed-on: https://chromium-review.googlesource.com/263988
Reviewed-by: Yiming Chen <yimingc@chromium.org>
Commit-Queue: David Pursell <dpursell@chromium.org>
Trybot-Ready: David Pursell <dpursell@chromium.org>
Tested-by: David Pursell <dpursell@chromium.org>
|
|
This CL generalizes the CLI to handle `cros` or `brillo` by loading a
separate set of tools for each. This allows diverging the toolsets as
well as individual tools when necessary.
BUG=brillo:557
TEST=cbuildbot/run_tests
Change-Id: Ic8aba5d6d1efdf2df8aa070f5fa79b2fe72c1d0d
Reviewed-on: https://chromium-review.googlesource.com/262050
Reviewed-by: David Pursell <dpursell@chromium.org>
Commit-Queue: David Pursell <dpursell@chromium.org>
Trybot-Ready: David Pursell <dpursell@chromium.org>
Tested-by: David Pursell <dpursell@chromium.org>
Reviewed-by: Don Garrett <dgarrett@chromium.org>
|
|
As part of the Brillo entry point, we're restructuring chromite/cros to
chromite/cli/cros instead. This CL just fixes module import paths to
point to the new location to make the restructuring functional.
See brbug.com/557 for more info.
BUG=brillo:557
TEST=cbuildbot/run_tests
Change-Id: I70c783f40e207090c5babf7ac149543613c8817e
Reviewed-on: https://chromium-review.googlesource.com/261183
Reviewed-by: David Pursell <dpursell@chromium.org>
Commit-Queue: David Pursell <dpursell@chromium.org>
Trybot-Ready: David Pursell <dpursell@chromium.org>
Tested-by: David Pursell <dpursell@chromium.org>
|
|
In a previous CL, the chromite/cli package was created and files were
copied over from chromite/cros directly without modification (in order
to help gerrit track file movement). This CL cleans up the new package
structure and modifies import paths appropriately throughout chromite to
make the new cli package functional.
The main cleanup here is the removal of code in __init__.py files, which
is confusing and in this case unnecessary. The code is instead put into
a command.py module containing the high-level code to create and find
CLI commands.
BUG=brillo:557
TEST=cbuildbot/run_tests
Change-Id: Ie9dc29585810206eed0e386fa056ceffdf9289a3
Reviewed-on: https://chromium-review.googlesource.com/261181
Reviewed-by: David Pursell <dpursell@chromium.org>
Commit-Queue: David Pursell <dpursell@chromium.org>
Trybot-Ready: David Pursell <dpursell@chromium.org>
Tested-by: David Pursell <dpursell@chromium.org>
|
|
This CL creates the cli/ package and moves the cli command modules in.
Note that this CL is NOT functional, but gerrit works better if we don't
move and modify files in the same CL.
See brbug.com/557 for background and motivation.
BUG=brillo:557.
TEST=Nothing (non-functional CL).
CQ-DEPEND=CL:261181, CL:261182, CL:261183
Change-Id: I162758e3738dd41acd803a1720bce994b0958c61
Reviewed-on: https://chromium-review.googlesource.com/261180
Reviewed-by: David Pursell <dpursell@chromium.org>
Commit-Queue: David Pursell <dpursell@chromium.org>
Trybot-Ready: David Pursell <dpursell@chromium.org>
Tested-by: David Pursell <dpursell@chromium.org>
|
