summaryrefslogtreecommitdiff
path: root/android_webview
diff options
context:
space:
mode:
authorTorne (Richard Coles) <torne@google.com>2013-05-15 11:34:50 +0100
committerTorne (Richard Coles) <torne@google.com>2013-05-15 11:34:50 +0100
commita93a17c8d99d686bd4a1511e5504e5e6cc9fcadf (patch)
tree2fc96923f36ddec68fee218d79dd407c28fa46f8 /android_webview
parent770489ea635fbf896c1ace4db0d08d6981a2db8b (diff)
downloadchromium_org-a93a17c8d99d686bd4a1511e5504e5e6cc9fcadf.tar.gz
Merge from Chromium at DEPS revision r200144
This commit was generated by merge_to_master.py. Change-Id: I85f3a249ae157fd8253431215fb2dfcd12ee9bf3
Diffstat (limited to 'android_webview')
-rw-r--r--android_webview/android_webview_common.target.darwin-arm.mk2
-rw-r--r--android_webview/android_webview_common.target.darwin-x86.mk2
-rw-r--r--android_webview/android_webview_common.target.linux-arm.mk2
-rw-r--r--android_webview/android_webview_common.target.linux-x86.mk2
-rw-r--r--android_webview/browser/browser_view_renderer_impl.cc40
-rw-r--r--android_webview/browser/net/android_stream_reader_url_request_job_unittest.cc34
-rw-r--r--android_webview/browser/net/aw_url_request_context_getter.cc2
-rw-r--r--android_webview/javatests/src/org/chromium/android_webview/test/AndroidViewIntegrationTest.java15
-rw-r--r--android_webview/libwebviewchromium.target.darwin-arm.mk6
-rw-r--r--android_webview/libwebviewchromium.target.darwin-x86.mk6
-rw-r--r--android_webview/libwebviewchromium.target.linux-arm.mk6
-rw-r--r--android_webview/libwebviewchromium.target.linux-x86.mk6
-rw-r--r--android_webview/native/aw_contents_io_thread_client_impl.cc2
-rw-r--r--android_webview/native/webview_native.target.darwin-arm.mk2
-rw-r--r--android_webview/native/webview_native.target.darwin-x86.mk2
-rw-r--r--android_webview/native/webview_native.target.linux-arm.mk2
-rw-r--r--android_webview/native/webview_native.target.linux-x86.mk2
17 files changed, 70 insertions, 63 deletions
diff --git a/android_webview/android_webview_common.target.darwin-arm.mk b/android_webview/android_webview_common.target.darwin-arm.mk
index acb88647b3..705c79504d 100644
--- a/android_webview/android_webview_common.target.darwin-arm.mk
+++ b/android_webview/android_webview_common.target.darwin-arm.mk
@@ -125,7 +125,7 @@ MY_DEFS := \
'-DGR_AGGRESSIVE_SHADER_OPTS=1' \
'-DSK_ENABLE_INST_COUNT=0' \
'-DSK_USE_POSIX_THREADS' \
- '-DSK_BUILD_FOR_ANDROID_NDK' \
+ '-DSK_BUILD_FOR_ANDROID' \
'-D__STDC_CONSTANT_MACROS' \
'-D__STDC_FORMAT_MACROS' \
'-DANDROID' \
diff --git a/android_webview/android_webview_common.target.darwin-x86.mk b/android_webview/android_webview_common.target.darwin-x86.mk
index 42e9e305f3..58a83837bc 100644
--- a/android_webview/android_webview_common.target.darwin-x86.mk
+++ b/android_webview/android_webview_common.target.darwin-x86.mk
@@ -127,7 +127,7 @@ MY_DEFS := \
'-DGR_AGGRESSIVE_SHADER_OPTS=1' \
'-DSK_ENABLE_INST_COUNT=0' \
'-DSK_USE_POSIX_THREADS' \
- '-DSK_BUILD_FOR_ANDROID_NDK' \
+ '-DSK_BUILD_FOR_ANDROID' \
'-D__STDC_CONSTANT_MACROS' \
'-D__STDC_FORMAT_MACROS' \
'-DANDROID' \
diff --git a/android_webview/android_webview_common.target.linux-arm.mk b/android_webview/android_webview_common.target.linux-arm.mk
index acb88647b3..705c79504d 100644
--- a/android_webview/android_webview_common.target.linux-arm.mk
+++ b/android_webview/android_webview_common.target.linux-arm.mk
@@ -125,7 +125,7 @@ MY_DEFS := \
'-DGR_AGGRESSIVE_SHADER_OPTS=1' \
'-DSK_ENABLE_INST_COUNT=0' \
'-DSK_USE_POSIX_THREADS' \
- '-DSK_BUILD_FOR_ANDROID_NDK' \
+ '-DSK_BUILD_FOR_ANDROID' \
'-D__STDC_CONSTANT_MACROS' \
'-D__STDC_FORMAT_MACROS' \
'-DANDROID' \
diff --git a/android_webview/android_webview_common.target.linux-x86.mk b/android_webview/android_webview_common.target.linux-x86.mk
index 42e9e305f3..58a83837bc 100644
--- a/android_webview/android_webview_common.target.linux-x86.mk
+++ b/android_webview/android_webview_common.target.linux-x86.mk
@@ -127,7 +127,7 @@ MY_DEFS := \
'-DGR_AGGRESSIVE_SHADER_OPTS=1' \
'-DSK_ENABLE_INST_COUNT=0' \
'-DSK_USE_POSIX_THREADS' \
- '-DSK_BUILD_FOR_ANDROID_NDK' \
+ '-DSK_BUILD_FOR_ANDROID' \
'-D__STDC_CONSTANT_MACROS' \
'-D__STDC_FORMAT_MACROS' \
'-DANDROID' \
diff --git a/android_webview/browser/browser_view_renderer_impl.cc b/android_webview/browser/browser_view_renderer_impl.cc
index b21541b979..837f85b73f 100644
--- a/android_webview/browser/browser_view_renderer_impl.cc
+++ b/android_webview/browser/browser_view_renderer_impl.cc
@@ -52,11 +52,11 @@ bool g_is_skia_version_compatible = false;
typedef base::Callback<bool(SkCanvas*)> RenderMethod;
-static bool RasterizeIntoBitmap(JNIEnv* env,
- const JavaRef<jobject>& jbitmap,
- int scroll_x,
- int scroll_y,
- const RenderMethod& renderer) {
+bool RasterizeIntoBitmap(JNIEnv* env,
+ const JavaRef<jobject>& jbitmap,
+ int scroll_x,
+ int scroll_y,
+ const RenderMethod& renderer) {
DCHECK(jbitmap.obj());
AndroidBitmapInfo bitmap_info;
@@ -94,6 +94,11 @@ static bool RasterizeIntoBitmap(JNIEnv* env,
return succeeded;
}
+bool RenderPictureToCanvas(SkPicture* picture, SkCanvas* canvas) {
+ canvas->drawPicture(*picture);
+ return true;
+}
+
const void* kUserDataKey = &kUserDataKey;
} // namespace
@@ -374,22 +379,31 @@ bool BrowserViewRendererImpl::DrawSW(jobject java_canvas,
}
ScopedJavaLocalRef<jobject> BrowserViewRendererImpl::CapturePicture() {
- // TODO(joth): reimplement this in terms of a call to RenderPicture (vitual
- // method) passing in a recordingt canvas, rather than using the picture map.
- skia::RefPtr<SkPicture> picture = GetLastCapturedPicture();
- if (!picture || !g_sw_draw_functions)
+ if (!g_sw_draw_functions)
return ScopedJavaLocalRef<jobject>();
+ gfx::Size record_size = ToCeiledSize(content_size_css_);
+
// Return empty Picture objects for empty SkPictures.
JNIEnv* env = AttachCurrentThread();
- if (picture->width() <= 0 || picture->height() <= 0) {
+ if (record_size.width() <= 0 || record_size.height() <= 0) {
return java_helper_->RecordBitmapIntoPicture(
env, ScopedJavaLocalRef<jobject>());
}
+ skia::RefPtr<SkPicture> picture = skia::AdoptRef(new SkPicture);
+ SkCanvas* rec_canvas = picture->beginRecording(record_size.width(),
+ record_size.height(),
+ 0);
+ if (!RenderPicture(rec_canvas))
+ return ScopedJavaLocalRef<jobject>();
+ picture->endRecording();
+
if (g_is_skia_version_compatible) {
+ // Add a reference that the create_picture() will take ownership of.
+ picture->ref();
return ScopedJavaLocalRef<jobject>(env,
- g_sw_draw_functions->create_picture(env, picture->clone()));
+ g_sw_draw_functions->create_picture(env, picture.get()));
}
// If Skia versions are not compatible, workaround it by rasterizing the
@@ -400,8 +414,8 @@ ScopedJavaLocalRef<jobject> BrowserViewRendererImpl::CapturePicture() {
return ScopedJavaLocalRef<jobject>();
if (!RasterizeIntoBitmap(env, jbitmap, 0, 0,
- base::Bind(&BrowserViewRendererImpl::RenderPicture,
- base::Unretained(this)))) {
+ base::Bind(&RenderPictureToCanvas,
+ base::Unretained(picture.get())))) {
return ScopedJavaLocalRef<jobject>();
}
diff --git a/android_webview/browser/net/android_stream_reader_url_request_job_unittest.cc b/android_webview/browser/net/android_stream_reader_url_request_job_unittest.cc
index 0e83a40b8b..33e826c1fe 100644
--- a/android_webview/browser/net/android_stream_reader_url_request_job_unittest.cc
+++ b/android_webview/browser/net/android_stream_reader_url_request_job_unittest.cc
@@ -47,15 +47,15 @@ class NotImplInputStream : public InputStream {
public:
NotImplInputStream() {}
virtual ~NotImplInputStream() {}
- virtual bool BytesAvailable(int* bytes_available) const {
+ virtual bool BytesAvailable(int* bytes_available) const OVERRIDE {
NOTIMPLEMENTED();
return false;
}
- virtual bool Skip(int64_t n, int64_t* bytes_skipped) {
+ virtual bool Skip(int64_t n, int64_t* bytes_skipped) OVERRIDE {
NOTIMPLEMENTED();
return false;
}
- virtual bool Read(net::IOBuffer* dest, int length, int* bytes_read) {
+ virtual bool Read(net::IOBuffer* dest, int length, int* bytes_read) OVERRIDE {
NOTIMPLEMENTED();
return false;
}
@@ -69,28 +69,26 @@ class StreamReaderDelegate :
virtual scoped_ptr<InputStream> OpenInputStream(
JNIEnv* env,
- const GURL& url) {
+ const GURL& url) OVERRIDE {
return make_scoped_ptr<InputStream>(new NotImplInputStream());
}
virtual void OnInputStreamOpenFailed(net::URLRequest* request,
- bool* restart) {
+ bool* restart) OVERRIDE {
*restart = false;
}
- virtual bool GetMimeType(
- JNIEnv* env,
- net::URLRequest* request,
- android_webview::InputStream* stream,
- std::string* mime_type) {
+ virtual bool GetMimeType(JNIEnv* env,
+ net::URLRequest* request,
+ android_webview::InputStream* stream,
+ std::string* mime_type) OVERRIDE {
return false;
}
- virtual bool GetCharset(
- JNIEnv* env,
- net::URLRequest* request,
- android_webview::InputStream* stream,
- std::string* charset) {
+ virtual bool GetCharset(JNIEnv* env,
+ net::URLRequest* request,
+ android_webview::InputStream* stream,
+ std::string* charset) OVERRIDE {
return false;
}
};
@@ -101,7 +99,7 @@ class NullStreamReaderDelegate : public StreamReaderDelegate {
virtual scoped_ptr<InputStream> OpenInputStream(
JNIEnv* env,
- const GURL& url) {
+ const GURL& url) OVERRIDE {
return make_scoped_ptr<InputStream>(NULL);
}
};
@@ -131,13 +129,13 @@ class TestStreamReaderJob : public AndroidStreamReaderURLRequestJob {
}
virtual scoped_ptr<InputStreamReader> CreateStreamReader(
- InputStream* stream) {
+ InputStream* stream) OVERRIDE {
return stream_reader_.Pass();
}
protected:
virtual ~TestStreamReaderJob() {}
- virtual base::TaskRunner* GetWorkerThreadRunner() {
+ virtual base::TaskRunner* GetWorkerThreadRunner() OVERRIDE {
return message_loop_proxy_.get();
}
diff --git a/android_webview/browser/net/aw_url_request_context_getter.cc b/android_webview/browser/net/aw_url_request_context_getter.cc
index e84e2dac91..a3320c92a7 100644
--- a/android_webview/browser/net/aw_url_request_context_getter.cc
+++ b/android_webview/browser/net/aw_url_request_context_getter.cc
@@ -16,6 +16,7 @@
#include "content/public/browser/content_browser_client.h"
#include "content/public/common/content_client.h"
#include "content/public/common/url_constants.h"
+#include "net/base/cache_type.h"
#include "net/cookies/cookie_store.h"
#include "net/http/http_cache.h"
#include "net/proxy/proxy_service.h"
@@ -69,6 +70,7 @@ void AwURLRequestContextGetter::Init() {
network_session_params,
new net::HttpCache::DefaultBackend(
net::DISK_CACHE,
+ net::CACHE_BACKEND_DEFAULT,
browser_context_->GetPath().Append(FILE_PATH_LITERAL("Cache")),
10 * 1024 * 1024, // 10M
BrowserThread::GetMessageLoopProxyForThread(BrowserThread::CACHE)));
diff --git a/android_webview/javatests/src/org/chromium/android_webview/test/AndroidViewIntegrationTest.java b/android_webview/javatests/src/org/chromium/android_webview/test/AndroidViewIntegrationTest.java
index d71689afd8..72e62a60a8 100644
--- a/android_webview/javatests/src/org/chromium/android_webview/test/AndroidViewIntegrationTest.java
+++ b/android_webview/javatests/src/org/chromium/android_webview/test/AndroidViewIntegrationTest.java
@@ -15,7 +15,6 @@ import org.chromium.android_webview.AwContents;
import org.chromium.android_webview.AwContentsClient;
import org.chromium.android_webview.AwLayoutSizer;
import org.chromium.android_webview.test.util.CommonResources;
-import org.chromium.base.test.util.DisabledTest;
import org.chromium.base.test.util.Feature;
import org.chromium.content.browser.ContentViewCore;
import org.chromium.content.browser.test.util.CallbackHelper;
@@ -125,12 +124,9 @@ public class AndroidViewIntegrationTest extends AwTestBase {
* view (since the user can't see it anyway) and only do so after the view's size is non-zero.
* Such behavior is unacceptable for the WebView and this test is to ensure that such behavior
* is not re-introduced.
- *
- * @SmallTest
- * @Feature({"AndroidWebView"})
- * crbug.com/239439
*/
- @DisabledTest
+ @SmallTest
+ @Feature({"AndroidWebView"})
public void testZeroByZeroViewLoadsContent() throws Throwable {
final TestAwContentsClient contentsClient = new TestAwContentsClient();
final AwTestContainerView testContainerView = createCustomTestContainerViewOnMainSync(
@@ -150,12 +146,9 @@ public class AndroidViewIntegrationTest extends AwTestBase {
*
* This makes sure that any optimizations related to the view's visibility don't inhibit
* the ability to load pages. Many applications keep the WebView hidden when it's loading.
- *
- * @SmallTest
- * @Feature({"AndroidWebView"})
- * crbug.com/239439
*/
- @DisabledTest
+ @SmallTest
+ @Feature({"AndroidWebView"})
public void testInvisibleViewLoadsContent() throws Throwable {
final TestAwContentsClient contentsClient = new TestAwContentsClient();
final AwTestContainerView testContainerView = createCustomTestContainerViewOnMainSync(
diff --git a/android_webview/libwebviewchromium.target.darwin-arm.mk b/android_webview/libwebviewchromium.target.darwin-arm.mk
index 31949016d4..a07dba53bf 100644
--- a/android_webview/libwebviewchromium.target.darwin-arm.mk
+++ b/android_webview/libwebviewchromium.target.darwin-arm.mk
@@ -108,7 +108,7 @@ GYP_TARGET_DEPENDENCIES := \
$(call intermediates-dir-for,GYP,third_party_WebKit_Source_bindings_bindings_derived_sources_gyp)/bindings_derived_sources.stamp \
$(call intermediates-dir-for,GYP,third_party_WebKit_Source_bindings_supplemental_dependencies_gyp)/supplemental_dependencies.stamp \
$(call intermediates-dir-for,GYP,third_party_WebKit_Source_config_gyp)/config.stamp \
- $(call intermediates-dir-for,STATIC_LIBRARIES,third_party_WebKit_Source_origin_origin_gyp)/third_party_WebKit_Source_origin_origin_gyp.a \
+ $(call intermediates-dir-for,STATIC_LIBRARIES,third_party_WebKit_Source_weborigin_weborigin_gyp)/third_party_WebKit_Source_weborigin_weborigin_gyp.a \
$(call intermediates-dir-for,STATIC_LIBRARIES,gpu_gles2_c_lib_gyp)/gpu_gles2_c_lib_gyp.a \
$(call intermediates-dir-for,STATIC_LIBRARIES,gpu_gles2_implementation_gyp)/gpu_gles2_implementation_gyp.a \
$(call intermediates-dir-for,STATIC_LIBRARIES,third_party_iccjpeg_iccjpeg_gyp)/third_party_iccjpeg_iccjpeg_gyp.a \
@@ -203,7 +203,7 @@ GYP_TARGET_DEPENDENCIES := \
$(call intermediates-dir-for,STATIC_LIBRARIES,sandbox_sandbox_services_gyp)/sandbox_sandbox_services_gyp.a \
$(call intermediates-dir-for,STATIC_LIBRARIES,sandbox_seccomp_bpf_gyp)/sandbox_seccomp_bpf_gyp.a \
$(call intermediates-dir-for,GYP,sandbox_sandbox_services_headers_gyp)/sandbox_services_headers.stamp \
- $(call intermediates-dir-for,GYP,chrome_chrome_strings_gyp)/chrome_strings.stamp \
+ $(call intermediates-dir-for,GYP,components_component_resources_gyp)/component_resources.stamp \
$(call intermediates-dir-for,STATIC_LIBRARIES,components_web_contents_delegate_android_gyp)/components_web_contents_delegate_android_gyp.a \
$(call intermediates-dir-for,GYP,components_web_contents_delegate_android_jni_headers_gyp)/web_contents_delegate_android_jni_headers.stamp \
$(call intermediates-dir-for,GYP,android_webview_native_android_webview_native_jni_gyp)/android_webview_native_jni.stamp \
@@ -397,7 +397,7 @@ LOCAL_STATIC_LIBRARIES := \
third_party_WebKit_Source_WebKit_chromium_webkit_gyp \
third_party_WebKit_Source_wtf_wtf_gyp \
third_party_WebKit_Source_core_core_gyp_webcore_dom_gyp \
- third_party_WebKit_Source_origin_origin_gyp \
+ third_party_WebKit_Source_weborigin_weborigin_gyp \
gpu_gles2_c_lib_gyp \
gpu_gles2_implementation_gyp \
third_party_iccjpeg_iccjpeg_gyp \
diff --git a/android_webview/libwebviewchromium.target.darwin-x86.mk b/android_webview/libwebviewchromium.target.darwin-x86.mk
index 84897ac1ff..555f39f8e0 100644
--- a/android_webview/libwebviewchromium.target.darwin-x86.mk
+++ b/android_webview/libwebviewchromium.target.darwin-x86.mk
@@ -109,7 +109,7 @@ GYP_TARGET_DEPENDENCIES := \
$(call intermediates-dir-for,GYP,third_party_WebKit_Source_bindings_bindings_derived_sources_gyp)/bindings_derived_sources.stamp \
$(call intermediates-dir-for,GYP,third_party_WebKit_Source_bindings_supplemental_dependencies_gyp)/supplemental_dependencies.stamp \
$(call intermediates-dir-for,GYP,third_party_WebKit_Source_config_gyp)/config.stamp \
- $(call intermediates-dir-for,STATIC_LIBRARIES,third_party_WebKit_Source_origin_origin_gyp)/third_party_WebKit_Source_origin_origin_gyp.a \
+ $(call intermediates-dir-for,STATIC_LIBRARIES,third_party_WebKit_Source_weborigin_weborigin_gyp)/third_party_WebKit_Source_weborigin_weborigin_gyp.a \
$(call intermediates-dir-for,STATIC_LIBRARIES,gpu_gles2_c_lib_gyp)/gpu_gles2_c_lib_gyp.a \
$(call intermediates-dir-for,STATIC_LIBRARIES,gpu_gles2_implementation_gyp)/gpu_gles2_implementation_gyp.a \
$(call intermediates-dir-for,STATIC_LIBRARIES,third_party_iccjpeg_iccjpeg_gyp)/third_party_iccjpeg_iccjpeg_gyp.a \
@@ -203,7 +203,7 @@ GYP_TARGET_DEPENDENCIES := \
$(call intermediates-dir-for,STATIC_LIBRARIES,sandbox_sandbox_services_gyp)/sandbox_sandbox_services_gyp.a \
$(call intermediates-dir-for,STATIC_LIBRARIES,sandbox_seccomp_bpf_gyp)/sandbox_seccomp_bpf_gyp.a \
$(call intermediates-dir-for,GYP,sandbox_sandbox_services_headers_gyp)/sandbox_services_headers.stamp \
- $(call intermediates-dir-for,GYP,chrome_chrome_strings_gyp)/chrome_strings.stamp \
+ $(call intermediates-dir-for,GYP,components_component_resources_gyp)/component_resources.stamp \
$(call intermediates-dir-for,STATIC_LIBRARIES,components_web_contents_delegate_android_gyp)/components_web_contents_delegate_android_gyp.a \
$(call intermediates-dir-for,GYP,components_web_contents_delegate_android_jni_headers_gyp)/web_contents_delegate_android_jni_headers.stamp \
$(call intermediates-dir-for,GYP,android_webview_native_android_webview_native_jni_gyp)/android_webview_native_jni.stamp \
@@ -397,7 +397,7 @@ LOCAL_STATIC_LIBRARIES := \
third_party_WebKit_Source_WebKit_chromium_webkit_gyp \
third_party_WebKit_Source_wtf_wtf_gyp \
third_party_WebKit_Source_core_core_gyp_webcore_dom_gyp \
- third_party_WebKit_Source_origin_origin_gyp \
+ third_party_WebKit_Source_weborigin_weborigin_gyp \
gpu_gles2_c_lib_gyp \
gpu_gles2_implementation_gyp \
third_party_iccjpeg_iccjpeg_gyp \
diff --git a/android_webview/libwebviewchromium.target.linux-arm.mk b/android_webview/libwebviewchromium.target.linux-arm.mk
index 31949016d4..a07dba53bf 100644
--- a/android_webview/libwebviewchromium.target.linux-arm.mk
+++ b/android_webview/libwebviewchromium.target.linux-arm.mk
@@ -108,7 +108,7 @@ GYP_TARGET_DEPENDENCIES := \
$(call intermediates-dir-for,GYP,third_party_WebKit_Source_bindings_bindings_derived_sources_gyp)/bindings_derived_sources.stamp \
$(call intermediates-dir-for,GYP,third_party_WebKit_Source_bindings_supplemental_dependencies_gyp)/supplemental_dependencies.stamp \
$(call intermediates-dir-for,GYP,third_party_WebKit_Source_config_gyp)/config.stamp \
- $(call intermediates-dir-for,STATIC_LIBRARIES,third_party_WebKit_Source_origin_origin_gyp)/third_party_WebKit_Source_origin_origin_gyp.a \
+ $(call intermediates-dir-for,STATIC_LIBRARIES,third_party_WebKit_Source_weborigin_weborigin_gyp)/third_party_WebKit_Source_weborigin_weborigin_gyp.a \
$(call intermediates-dir-for,STATIC_LIBRARIES,gpu_gles2_c_lib_gyp)/gpu_gles2_c_lib_gyp.a \
$(call intermediates-dir-for,STATIC_LIBRARIES,gpu_gles2_implementation_gyp)/gpu_gles2_implementation_gyp.a \
$(call intermediates-dir-for,STATIC_LIBRARIES,third_party_iccjpeg_iccjpeg_gyp)/third_party_iccjpeg_iccjpeg_gyp.a \
@@ -203,7 +203,7 @@ GYP_TARGET_DEPENDENCIES := \
$(call intermediates-dir-for,STATIC_LIBRARIES,sandbox_sandbox_services_gyp)/sandbox_sandbox_services_gyp.a \
$(call intermediates-dir-for,STATIC_LIBRARIES,sandbox_seccomp_bpf_gyp)/sandbox_seccomp_bpf_gyp.a \
$(call intermediates-dir-for,GYP,sandbox_sandbox_services_headers_gyp)/sandbox_services_headers.stamp \
- $(call intermediates-dir-for,GYP,chrome_chrome_strings_gyp)/chrome_strings.stamp \
+ $(call intermediates-dir-for,GYP,components_component_resources_gyp)/component_resources.stamp \
$(call intermediates-dir-for,STATIC_LIBRARIES,components_web_contents_delegate_android_gyp)/components_web_contents_delegate_android_gyp.a \
$(call intermediates-dir-for,GYP,components_web_contents_delegate_android_jni_headers_gyp)/web_contents_delegate_android_jni_headers.stamp \
$(call intermediates-dir-for,GYP,android_webview_native_android_webview_native_jni_gyp)/android_webview_native_jni.stamp \
@@ -397,7 +397,7 @@ LOCAL_STATIC_LIBRARIES := \
third_party_WebKit_Source_WebKit_chromium_webkit_gyp \
third_party_WebKit_Source_wtf_wtf_gyp \
third_party_WebKit_Source_core_core_gyp_webcore_dom_gyp \
- third_party_WebKit_Source_origin_origin_gyp \
+ third_party_WebKit_Source_weborigin_weborigin_gyp \
gpu_gles2_c_lib_gyp \
gpu_gles2_implementation_gyp \
third_party_iccjpeg_iccjpeg_gyp \
diff --git a/android_webview/libwebviewchromium.target.linux-x86.mk b/android_webview/libwebviewchromium.target.linux-x86.mk
index 84897ac1ff..555f39f8e0 100644
--- a/android_webview/libwebviewchromium.target.linux-x86.mk
+++ b/android_webview/libwebviewchromium.target.linux-x86.mk
@@ -109,7 +109,7 @@ GYP_TARGET_DEPENDENCIES := \
$(call intermediates-dir-for,GYP,third_party_WebKit_Source_bindings_bindings_derived_sources_gyp)/bindings_derived_sources.stamp \
$(call intermediates-dir-for,GYP,third_party_WebKit_Source_bindings_supplemental_dependencies_gyp)/supplemental_dependencies.stamp \
$(call intermediates-dir-for,GYP,third_party_WebKit_Source_config_gyp)/config.stamp \
- $(call intermediates-dir-for,STATIC_LIBRARIES,third_party_WebKit_Source_origin_origin_gyp)/third_party_WebKit_Source_origin_origin_gyp.a \
+ $(call intermediates-dir-for,STATIC_LIBRARIES,third_party_WebKit_Source_weborigin_weborigin_gyp)/third_party_WebKit_Source_weborigin_weborigin_gyp.a \
$(call intermediates-dir-for,STATIC_LIBRARIES,gpu_gles2_c_lib_gyp)/gpu_gles2_c_lib_gyp.a \
$(call intermediates-dir-for,STATIC_LIBRARIES,gpu_gles2_implementation_gyp)/gpu_gles2_implementation_gyp.a \
$(call intermediates-dir-for,STATIC_LIBRARIES,third_party_iccjpeg_iccjpeg_gyp)/third_party_iccjpeg_iccjpeg_gyp.a \
@@ -203,7 +203,7 @@ GYP_TARGET_DEPENDENCIES := \
$(call intermediates-dir-for,STATIC_LIBRARIES,sandbox_sandbox_services_gyp)/sandbox_sandbox_services_gyp.a \
$(call intermediates-dir-for,STATIC_LIBRARIES,sandbox_seccomp_bpf_gyp)/sandbox_seccomp_bpf_gyp.a \
$(call intermediates-dir-for,GYP,sandbox_sandbox_services_headers_gyp)/sandbox_services_headers.stamp \
- $(call intermediates-dir-for,GYP,chrome_chrome_strings_gyp)/chrome_strings.stamp \
+ $(call intermediates-dir-for,GYP,components_component_resources_gyp)/component_resources.stamp \
$(call intermediates-dir-for,STATIC_LIBRARIES,components_web_contents_delegate_android_gyp)/components_web_contents_delegate_android_gyp.a \
$(call intermediates-dir-for,GYP,components_web_contents_delegate_android_jni_headers_gyp)/web_contents_delegate_android_jni_headers.stamp \
$(call intermediates-dir-for,GYP,android_webview_native_android_webview_native_jni_gyp)/android_webview_native_jni.stamp \
@@ -397,7 +397,7 @@ LOCAL_STATIC_LIBRARIES := \
third_party_WebKit_Source_WebKit_chromium_webkit_gyp \
third_party_WebKit_Source_wtf_wtf_gyp \
third_party_WebKit_Source_core_core_gyp_webcore_dom_gyp \
- third_party_WebKit_Source_origin_origin_gyp \
+ third_party_WebKit_Source_weborigin_weborigin_gyp \
gpu_gles2_c_lib_gyp \
gpu_gles2_implementation_gyp \
third_party_iccjpeg_iccjpeg_gyp \
diff --git a/android_webview/native/aw_contents_io_thread_client_impl.cc b/android_webview/native/aw_contents_io_thread_client_impl.cc
index de8f1b1a9d..226ba55114 100644
--- a/android_webview/native/aw_contents_io_thread_client_impl.cc
+++ b/android_webview/native/aw_contents_io_thread_client_impl.cc
@@ -104,7 +104,7 @@ class ClientMapEntryUpdater : public content::WebContentsObserver {
virtual void RenderViewForInterstitialPageCreated(
RenderViewHost* render_view_host) OVERRIDE;
virtual void RenderViewDeleted(RenderViewHost* render_view_host) OVERRIDE;
- virtual void WebContentsDestroyed(WebContents* web_contents);
+ virtual void WebContentsDestroyed(WebContents* web_contents) OVERRIDE;
private:
JavaObjectWeakGlobalRef jdelegate_;
diff --git a/android_webview/native/webview_native.target.darwin-arm.mk b/android_webview/native/webview_native.target.darwin-arm.mk
index eb5e10d00e..73b3b6daef 100644
--- a/android_webview/native/webview_native.target.darwin-arm.mk
+++ b/android_webview/native/webview_native.target.darwin-arm.mk
@@ -102,7 +102,7 @@ MY_DEFS := \
'-DGR_AGGRESSIVE_SHADER_OPTS=1' \
'-DSK_ENABLE_INST_COUNT=0' \
'-DSK_USE_POSIX_THREADS' \
- '-DSK_BUILD_FOR_ANDROID_NDK' \
+ '-DSK_BUILD_FOR_ANDROID' \
'-DU_USING_ICU_NAMESPACE=0' \
'-D__STDC_CONSTANT_MACROS' \
'-D__STDC_FORMAT_MACROS' \
diff --git a/android_webview/native/webview_native.target.darwin-x86.mk b/android_webview/native/webview_native.target.darwin-x86.mk
index 41dbabe6ba..582fd6842d 100644
--- a/android_webview/native/webview_native.target.darwin-x86.mk
+++ b/android_webview/native/webview_native.target.darwin-x86.mk
@@ -103,7 +103,7 @@ MY_DEFS := \
'-DGR_AGGRESSIVE_SHADER_OPTS=1' \
'-DSK_ENABLE_INST_COUNT=0' \
'-DSK_USE_POSIX_THREADS' \
- '-DSK_BUILD_FOR_ANDROID_NDK' \
+ '-DSK_BUILD_FOR_ANDROID' \
'-DU_USING_ICU_NAMESPACE=0' \
'-D__STDC_CONSTANT_MACROS' \
'-D__STDC_FORMAT_MACROS' \
diff --git a/android_webview/native/webview_native.target.linux-arm.mk b/android_webview/native/webview_native.target.linux-arm.mk
index eb5e10d00e..73b3b6daef 100644
--- a/android_webview/native/webview_native.target.linux-arm.mk
+++ b/android_webview/native/webview_native.target.linux-arm.mk
@@ -102,7 +102,7 @@ MY_DEFS := \
'-DGR_AGGRESSIVE_SHADER_OPTS=1' \
'-DSK_ENABLE_INST_COUNT=0' \
'-DSK_USE_POSIX_THREADS' \
- '-DSK_BUILD_FOR_ANDROID_NDK' \
+ '-DSK_BUILD_FOR_ANDROID' \
'-DU_USING_ICU_NAMESPACE=0' \
'-D__STDC_CONSTANT_MACROS' \
'-D__STDC_FORMAT_MACROS' \
diff --git a/android_webview/native/webview_native.target.linux-x86.mk b/android_webview/native/webview_native.target.linux-x86.mk
index 41dbabe6ba..582fd6842d 100644
--- a/android_webview/native/webview_native.target.linux-x86.mk
+++ b/android_webview/native/webview_native.target.linux-x86.mk
@@ -103,7 +103,7 @@ MY_DEFS := \
'-DGR_AGGRESSIVE_SHADER_OPTS=1' \
'-DSK_ENABLE_INST_COUNT=0' \
'-DSK_USE_POSIX_THREADS' \
- '-DSK_BUILD_FOR_ANDROID_NDK' \
+ '-DSK_BUILD_FOR_ANDROID' \
'-DU_USING_ICU_NAMESPACE=0' \
'-D__STDC_CONSTANT_MACROS' \
'-D__STDC_FORMAT_MACROS' \