diff options
author | Torne (Richard Coles) <torne@google.com> | 2014-05-14 12:12:37 +0100 |
---|---|---|
committer | Torne (Richard Coles) <torne@google.com> | 2014-05-14 12:12:37 +0100 |
commit | 010d83a9304c5a91596085d917d248abff47903a (patch) | |
tree | 41ef1a01862f352f9653c7a9cfa817abefe2cce2 /build | |
parent | 08c107de54178bb0990a09adec724924e8bc9486 (diff) | |
download | chromium_org-010d83a9304c5a91596085d917d248abff47903a.tar.gz |
Merge from Chromium at DEPS revision 269336
This commit was generated by merge_to_master.py.
Change-Id: I8b9c77f10eccd2a8b4c7ce373ffda18568af54ff
Diffstat (limited to 'build')
-rw-r--r-- | build/all.gyp | 13 | ||||
-rwxr-xr-x | build/android/adb_profile_chrome.py | 46 | ||||
-rwxr-xr-x | build/android/buildbot/bb_device_status_check.py | 5 | ||||
-rwxr-xr-x | build/android/buildbot/bb_device_steps.py | 8 | ||||
-rw-r--r-- | build/android/findbugs_filter/findbugs_known_bugs.txt | 8 | ||||
-rw-r--r-- | build/android/pylib/android_commands.py | 64 | ||||
-rw-r--r-- | build/android/pylib/gtest/filter/content_browsertests_disabled | 3 | ||||
-rw-r--r-- | build/android/pylib/gtest/filter/webkit_unit_tests_disabled | 5 | ||||
-rw-r--r-- | build/common.gypi | 109 | ||||
-rw-r--r-- | build/config/BUILD.gn | 2 | ||||
-rw-r--r-- | build/config/clang/BUILD.gn | 2 | ||||
-rw-r--r-- | build/copy_test_data_ios.gypi | 7 | ||||
-rwxr-xr-x | build/download_nacl_toolchains.py | 28 | ||||
-rw-r--r-- | build/filename_rules.gypi | 2 | ||||
-rwxr-xr-x | build/gyp_chromium | 11 | ||||
-rw-r--r-- | build/ios/grit_whitelist.txt | 6 | ||||
-rw-r--r-- | build/util/LASTCHANGE | 2 | ||||
-rw-r--r-- | build/util/LASTCHANGE.blink | 2 | ||||
-rw-r--r-- | build/whitespace_file.txt | 2 |
19 files changed, 185 insertions, 140 deletions
diff --git a/build/all.gyp b/build/all.gyp index ac14c86eaf..d3f558f034 100644 --- a/build/all.gyp +++ b/build/all.gyp @@ -604,11 +604,10 @@ 'target_name': 'chromium_builder_webrtc', 'type': 'none', 'dependencies': [ - 'chromium_builder_qa', # needed for perf pyauto tests + 'chromium_builder_qa', # TODO(phoglund): not sure if needed? '../chrome/chrome.gyp:browser_tests', '../content/content_shell_and_tests.gyp:content_browsertests', '../content/content_shell_and_tests.gyp:content_unittests', - '../third_party/libjingle/libjingle.gyp:peerconnection_server', '../third_party/webrtc/tools/tools.gyp:frame_analyzer', '../third_party/webrtc/tools/tools.gyp:rgba_to_i420_converter', ], @@ -642,6 +641,7 @@ 'conditions': [ ['OS!="win"', { 'dependencies': [ + '../net/net.gyp:hpack_fuzz_wrapper', '../net/net.gyp:dns_fuzz_stub', '../skia/skia.gyp:filter_fuzz_stub', ], @@ -973,6 +973,7 @@ 'dependencies': [ '../cc/cc_tests.gyp:cc_unittests', '../chrome/chrome.gyp:browser_tests', + '../chrome/chrome.gyp:crash_service', '../chrome/chrome.gyp:gcapi_test', '../chrome/chrome.gyp:installer_util_unittests', '../chrome/chrome.gyp:interactive_ui_tests', @@ -1012,6 +1013,13 @@ '../url/url.gyp:url_unittests', '../webkit/renderer/compositor_bindings/compositor_bindings_tests.gyp:webkit_compositor_bindings_unittests', ], + 'conditions': [ + ['target_arch=="ia32"', { + 'dependencies': [ + '../chrome/chrome.gyp:crash_service_win64', + ], + }], + ], }, { 'target_name': 'chromium_builder_win_cf', @@ -1058,6 +1066,7 @@ '../ipc/ipc.gyp:ipc_tests', '../jingle/jingle.gyp:jingle_unittests', '../media/media.gyp:media_unittests', + '../mojo/mojo.gyp:mojo', '../net/net.gyp:net_unittests', '../google_apis/gcm/gcm.gyp:gcm_unit_tests', '../gpu/gpu.gyp:gpu_unittests', diff --git a/build/android/adb_profile_chrome.py b/build/android/adb_profile_chrome.py index 37f250c19a..2e25d9c407 100755 --- a/build/android/adb_profile_chrome.py +++ b/build/android/adb_profile_chrome.py @@ -5,6 +5,7 @@ # found in the LICENSE file. import gzip +import json import logging import optparse import os @@ -53,6 +54,28 @@ class ChromeTracingController(object): def __str__(self): return 'chrome trace' + @staticmethod + def GetCategories(device, package_info): + device.old_interface.BroadcastIntent( + package_info.package, 'GPU_PROFILER_LIST_CATEGORIES') + try: + json_category_list = device.old_interface.WaitForLogMatch( + re.compile(r'{"traceCategoriesList(.*)'), None, timeout=5).group(0) + except pexpect.TIMEOUT: + raise RuntimeError('Performance trace category list marker not found. ' + 'Is the correct version of the browser running?') + + record_categories = [] + disabled_by_default_categories = [] + json_data = json.loads(json_category_list)['traceCategoriesList'] + for item in json_data: + if item.startswith('disabled-by-default'): + disabled_by_default_categories.append(item) + else: + record_categories.append(item) + + return record_categories, disabled_by_default_categories + def StartTracing(self, interval): self._trace_interval = interval self._device.old_interface.SyncLogCat() @@ -324,7 +347,8 @@ def main(): 'categories with comma-delimited wildcards, ' 'e.g., "*", "cat1*,-cat1a". Omit this option to trace ' 'Chrome\'s default categories. Chrome tracing can be ' - 'disabled with "--categories=\'\'".', + 'disabled with "--categories=\'\'". Use "list" to see ' + 'the available categories.', metavar='CHROME_CATEGORIES', dest='chrome_categories', default=_DEFAULT_CHROME_CATEGORIES) categories.add_option('-s', '--systrace', help='Capture a systrace with the ' @@ -383,6 +407,25 @@ When in doubt, just try out --trace-frame-viewer. if len(devices) != 1: parser.error('Exactly 1 device much be attached.') device = device_utils.DeviceUtils(devices[0]) + package_info = _GetSupportedBrowsers()[options.browser] + + if options.chrome_categories in ['list', 'help']: + _PrintMessage('Collecting record categories list...', eol='') + record_categories = [] + disabled_by_default_categories = [] + record_categories, disabled_by_default_categories = \ + ChromeTracingController.GetCategories(device, package_info) + + _PrintMessage('done') + _PrintMessage('Record Categories:') + _PrintMessage('\n'.join('\t%s' % item \ + for item in sorted(record_categories))) + + _PrintMessage('\nDisabled by Default Categories:') + _PrintMessage('\n'.join('\t%s' % item \ + for item in sorted(disabled_by_default_categories))) + + return 0 if options.systrace_categories in ['list', 'help']: _PrintMessage('\n'.join(SystraceController.GetCategories(device))) @@ -394,7 +437,6 @@ When in doubt, just try out --trace-frame-viewer. chrome_categories = _ComputeChromeCategories(options) systrace_categories = _ComputeSystraceCategories(options) - package_info = _GetSupportedBrowsers()[options.browser] if chrome_categories and 'webview' in systrace_categories: logging.warning('Using the "webview" category in systrace together with ' diff --git a/build/android/buildbot/bb_device_status_check.py b/build/android/buildbot/bb_device_status_check.py index f9998f481e..94c741fe13 100755 --- a/build/android/buildbot/bb_device_status_check.py +++ b/build/android/buildbot/bb_device_status_check.py @@ -65,16 +65,13 @@ def DeviceInfo(serial, options): ac_power = _GetData('AC powered: (\w+)', battery) battery_level = _GetData('level: (\d+)', battery) - battery_temp = _GetData('temperature: (\d+)', battery, - lambda x: float(x) / 10.0) imei_slice = _GetData('Device ID = (\d+)', device_adb.old_interface.GetSubscriberInfo(), lambda x: x[-6:]) report = ['Device %s (%s)' % (serial, device_type), ' Build: %s (%s)' % (device_build, device_adb.old_interface.GetBuildFingerprint()), - ' Battery: %s%%' % battery_level, - ' Battery temp: %s' % battery_temp, + ' %s' % '\n '.join(battery.split('\n')), ' IMEI slice: %s' % imei_slice, ' Wifi IP: %s' % device_adb.old_interface.GetWifiIP(), ''] diff --git a/build/android/buildbot/bb_device_steps.py b/build/android/buildbot/bb_device_steps.py index dc2212b229..d95529888c 100755 --- a/build/android/buildbot/bb_device_steps.py +++ b/build/android/buildbot/bb_device_steps.py @@ -569,12 +569,12 @@ def GenerateJavaCoverageReport(options): def LogcatDump(options): # Print logcat, kill logcat monitor bb_annotations.PrintNamedStep('logcat_dump') - logcat_file = os.path.join(CHROME_OUT_DIR, options.target, 'full_log') + logcat_file = os.path.join(CHROME_OUT_DIR, options.target, 'full_log.txt') RunCmd([SrcPath('build' , 'android', 'adb_logcat_printer.py'), '--output-path', logcat_file, LOGCAT_DIR]) gs_path = MakeGSPath(options, 'chromium-android/logcat_dumps') - RunCmd([bb_utils.GSUTIL_PATH, '-h', 'Content-Type:text/plain', - 'cp', logcat_file, 'gs://%s' % gs_path]) + RunCmd([bb_utils.GSUTIL_PATH, 'cp', '-z', 'txt', logcat_file, + 'gs://%s' % gs_path]) bb_annotations.PrintLink('logcat dump', '%s/%s' % (GS_AUTH_URL, gs_path)) @@ -584,7 +584,7 @@ def RunStackToolSteps(options): Stack tool is run for logcat dump, optionally for ASAN. """ bb_annotations.PrintNamedStep('Run stack tool with logcat dump') - logcat_file = os.path.join(CHROME_OUT_DIR, options.target, 'full_log') + logcat_file = os.path.join(CHROME_OUT_DIR, options.target, 'full_log.txt') RunCmd([os.path.join(CHROME_SRC_DIR, 'third_party', 'android_platform', 'development', 'scripts', 'stack'), '--more-info', logcat_file]) diff --git a/build/android/findbugs_filter/findbugs_known_bugs.txt b/build/android/findbugs_filter/findbugs_known_bugs.txt index 3b825a61c8..6372d53f70 100644 --- a/build/android/findbugs_filter/findbugs_known_bugs.txt +++ b/build/android/findbugs_filter/findbugs_known_bugs.txt @@ -23,13 +23,5 @@ M V EI2: org.chromium.content.browser.LoadUrlParams.setPostData(byte[]) may expo M V EI: org.chromium.chrome.browser.ChromeBrowserProvider$BookmarkNode.favicon() may expose internal representation by returning ChromeBrowserProvider$BookmarkNode.mFavicon At ChromeBrowserProvider.java M V EI: org.chromium.chrome.browser.ChromeBrowserProvider$BookmarkNode.thumbnail() may expose internal representation by returning ChromeBrowserProvider$BookmarkNode.mThumbnail At ChromeBrowserProvider.java M V EI: org.chromium.content.browser.LoadUrlParams.getPostData() may expose internal representation by returning LoadUrlParams.mPostData At LoadUrlParams.java -M V MS: org.chromium.content.browser.LoadUrlParams.LOAD_TYPE_BROWSER_INITIATED_HTTP_POST should be package protected In LoadUrlParams.java -M V MS: org.chromium.content.browser.LoadUrlParams.LOAD_TYPE_DATA isn't final and can't be protected from malicious code In LoadUrlParams.java -M V MS: org.chromium.content.browser.LoadUrlParams.LOAD_TYPE_DEFAULT should be package protected In LoadUrlParams.java -M V MS: org.chromium.content.browser.LoadUrlParams.UA_OVERRIDE_INHERIT should be package protected In LoadUrlParams.java -M V MS: org.chromium.content.browser.LoadUrlParams.UA_OVERRIDE_TRUE isn't final and can't be protected from malicious code In LoadUrlParams.java M M LI: Incorrect lazy initialization of static field org.chromium.chrome.browser.sync.ProfileSyncService.sSyncSetupManager in org.chromium.chrome.browser.sync.ProfileSyncService.get(Context) At ProfileSyncService.java M B OS: org.chromium.tools.binary_size.Addr2LineWorkerPool$Addr2LineWorker$Addr2LineTask.run() may fail to close stream At Addr2LineWorkerPool.java -M B RV: Exceptional return value of java.io.File.mkdirs() ignored in new org.chromium.tools.binary_size.NmDumper$Output(NmDumper) At NmDumper.java -M C CSM: Shouldn't use synchronized method, please narrow down the synchronization scope. At NmDumper.java -M D REC: Exception is caught when Exception is not thrown in org.chromium.tools.binary_size.Addr2LineWorkerPool$Addr2LineWorker$Addr2LineTask.run() At Addr2LineWorkerPool.java diff --git a/build/android/pylib/android_commands.py b/build/android/pylib/android_commands.py index 0a710f9e0e..64eedb1525 100644 --- a/build/android/pylib/android_commands.py +++ b/build/android/pylib/android_commands.py @@ -1160,25 +1160,33 @@ class AndroidCommands(object): This is less efficient than SetFileContents. """ + # TODO(skyostil): Remove this once it has been through all the bots. + for file_name in (AndroidCommands._TEMP_FILE_BASE_FMT, + AndroidCommands._TEMP_SCRIPT_FILE_BASE_FMT): + self.RunShellCommand('rm ' + self.GetExternalStorage() + '/' + + file_name.replace('%d', '*')) + temp_file = self._GetDeviceTempFileName(AndroidCommands._TEMP_FILE_BASE_FMT) temp_script = self._GetDeviceTempFileName( AndroidCommands._TEMP_SCRIPT_FILE_BASE_FMT) - # Put the contents in a temporary file - self.SetFileContents(temp_file, contents) - # Create a script to copy the file contents to its final destination - self.SetFileContents(temp_script, 'cat %s > %s' % (temp_file, filename)) - - command = 'sh %s' % temp_script - command_runner = self._GetProtectedFileCommandRunner() - if command_runner: - return command_runner(command) - else: - logging.warning('Could not set contents of protected file: %s' % filename) - - # And remove the temporary files - self.RunShellCommand('rm ' + temp_file) - self.RunShellCommand('rm ' + temp_script) + try: + # Put the contents in a temporary file + self.SetFileContents(temp_file, contents) + # Create a script to copy the file contents to its final destination + self.SetFileContents(temp_script, 'cat %s > %s' % (temp_file, filename)) + + command = 'sh %s' % temp_script + command_runner = self._GetProtectedFileCommandRunner() + if command_runner: + return command_runner(command) + else: + logging.warning( + 'Could not set contents of protected file: %s' % filename) + finally: + # And remove the temporary files + self.RunShellCommand('rm ' + temp_file) + self.RunShellCommand('rm ' + temp_script) def RemovePushedFiles(self): """Removes all files pushed with PushIfNeeded() from the device.""" @@ -1891,17 +1899,21 @@ class AndroidCommands(object): 'android', 'pylib', 'efficient_android_directory_copy.sh') - self._adb.Push(host_script_path, temp_script_file) - self.EnableAdbRoot - out = self.RunShellCommand('sh %s %s %s' % (temp_script_file, source, dest), - timeout_time=120) - if self._device: - device_repr = self._device[-4:] - else: - device_repr = '????' - for line in out: - logging.info('[%s]> %s', device_repr, line) - self.RunShellCommand('rm %s' % temp_script_file) + try: + self._adb.Push(host_script_path, temp_script_file) + self.EnableAdbRoot() + out = self.RunShellCommand('sh %s %s %s' % (temp_script_file, + source, + dest), + timeout_time=120) + if self._device: + device_repr = self._device[-4:] + else: + device_repr = '????' + for line in out: + logging.info('[%s]> %s', device_repr, line) + finally: + self.RunShellCommand('rm %s' % temp_script_file) def _GetControlUsbChargingCommand(self): if self._control_usb_charging_command['cached']: diff --git a/build/android/pylib/gtest/filter/content_browsertests_disabled b/build/android/pylib/gtest/filter/content_browsertests_disabled index 2978ce06c7..c96ce6c802 100644 --- a/build/android/pylib/gtest/filter/content_browsertests_disabled +++ b/build/android/pylib/gtest/filter/content_browsertests_disabled @@ -120,6 +120,3 @@ TracingControllerTest.EnableCaptureAndDisableMonitoringWithFilePath # http://crbug.com/343604 MSE_ClearKey/EncryptedMediaTest.ConfigChangeVideo/0 - -# http://crbug.com/362852 -WebRtcBrowserTests/WebRtcBrowserTest.* diff --git a/build/android/pylib/gtest/filter/webkit_unit_tests_disabled b/build/android/pylib/gtest/filter/webkit_unit_tests_disabled index 3e34a00cec..1ffa325899 100644 --- a/build/android/pylib/gtest/filter/webkit_unit_tests_disabled +++ b/build/android/pylib/gtest/filter/webkit_unit_tests_disabled @@ -16,5 +16,10 @@ WebViewTest.VisitedLinkCrash # Disabled until blink roll r151682 DeferredImageDecoderTest.drawScaledIntoSkPicture +# Disabled until blink roll r173540 +DeferredImageDecoderTest.decodeOnOtherThread +DeferredImageDecoderTest.drawIntoSkPicture +DeferredImageDecoderTest.drawIntoSkPictureProgressive + # crbug.com/320005 CoreAnimationCompositorAnimationsTest.ConvertTimingForCompositorIterationCount diff --git a/build/common.gypi b/build/common.gypi index f49174bdf8..def3eaf76e 100644 --- a/build/common.gypi +++ b/build/common.gypi @@ -332,6 +332,8 @@ 'safe_browsing%': 1, # Speech input is compiled in by default. Set to 0 to disable. + # TODO(tommyw): Speech Input doesn't exist anymore. Clarify the scope + # of this flag (and probably rename it). 'input_speech%': 1, # Notifications are compiled in by default. Set to 0 to disable. @@ -480,9 +482,16 @@ # Enables used resource whitelist generation; disabled by default. 'enable_resource_whitelist_generation%': 0, + # Enable FILE support by default. + 'disable_file_support%': 0, + # Enable FTP support by default. 'disable_ftp_support%': 0, + # Use native android functions in place of ICU. Not supported by most + # components. + 'use_icu_alternatives_on_android%': 0, + # XInput2 multitouch support is enabled by default (use_xi2_mt=2). # Setting to zero value disables XI2 MT. When XI2 MT is enabled, # the input value also defines the required XI2 minor minimum version. @@ -811,10 +820,7 @@ ['OS=="linux" and target_arch=="arm" and chromeos==0', { # Set some defaults for arm/linux chrome builds - # TODO(dmikurube): Change the default of use_allocator to "none". - # TODO(dmikurube): Kill linux_use_tcmalloc. http://crbug.com/345554 - 'linux_use_tcmalloc%': 0, - 'use_allocator%': 'see_use_tcmalloc', + 'use_allocator%': 'none', # sysroot needs to be an absolute path otherwise it generates # incorrect results when passed to pkg-config 'sysroot%': '<!(cd <(DEPTH) && pwd -P)/arm-sysroot', @@ -853,12 +859,12 @@ 'test_isolation_mode%': 'noop', }], # Whether Android ARM or x86 build uses OpenMAX DL FFT. - ['OS=="android" and ((target_arch=="arm" and arm_version >= 7) or target_arch=="ia32" or target_arch=="x64") and android_webview_build==0', { - # Currently only supported on Android ARMv7+, ia32 or x64 - # without webview. When enabled, this will also enable - # WebAudio support on Android ARM, ia32 and x64. Default is - # enabled. Whether WebAudio is actually available depends - # on runtime settings and flags. + ['OS=="android" and ((target_arch=="arm" and arm_version >= 7) or target_arch=="ia32" or target_arch=="x64")', { + # Currently only supported on Android ARMv7+, ia32 or x64. + # When enabled, this will also enable WebAudio support on + # Android ARM, ia32 and x64. Default is enabled. Whether + # WebAudio is actually available depends on runtime settings + # and flags. 'use_openmax_dl_fft%': 1, }, { 'use_openmax_dl_fft%': 0, @@ -1038,7 +1044,9 @@ 'cld2_dynamic%': '<(cld2_dynamic)', 'cld2_is_component%': '<(cld2_is_component)', 'enable_captive_portal_detection%': '<(enable_captive_portal_detection)', + 'disable_file_support%': '<(disable_file_support)', 'disable_ftp_support%': '<(disable_ftp_support)', + 'use_icu_alternatives_on_android%': '<(use_icu_alternatives_on_android)', 'enable_task_manager%': '<(enable_task_manager)', 'sas_dll_path%': '<(sas_dll_path)', 'wix_path%': '<(wix_path)', @@ -1211,15 +1219,8 @@ 'binutils_dir%': '', # Enable TCMalloc. - # TODO(dmikurube): Change Linux default of use_allocator to "tcmalloc". - # TODO(dmikurube): Change Android default of use_allocator to "none". - # TODO(dmikurube): Kill {linux|android}_use_tcmalloc. http://crbug.com/345554 - # {linux|android}_use_tcmalloc are to be replaced with use_allocator. - # They are now used only if use_allocator=="see_use_tcmalloc" (default). - # TODO(dmikurube): Assert when {linux|android}_use_tcmalloc is explicitly specified. - 'linux_use_tcmalloc%': 1, - 'android_use_tcmalloc%': 0, - 'use_allocator%': 'see_use_tcmalloc', + # Default of 'use_allocator' is set to 'none' if OS=='android' later. + 'use_allocator%': 'tcmalloc', # Set to 1 to link against libgnome-keyring instead of using dlopen(). 'linux_link_gnome_keyring%': 0, @@ -1449,10 +1450,7 @@ 'werror%': '', 'disable_nacl%': 1, 'nacl_untrusted_build%': 0, - # TODO(dmikurube): Change the default of use_allocator to "none". - # TODO(dmikurube): Kill linux_use_tcmalloc. http://crbug.com/345554 - 'linux_use_tcmalloc%': 0, - 'use_allocator%': 'see_use_tcmalloc', + 'use_allocator%': 'none', }], ['OS=="linux" and target_arch=="mipsel"', { 'sysroot%': '<(sysroot)', @@ -1639,10 +1637,7 @@ 'input_speech%': 0, 'java_bridge%': 1, 'build_ffmpegsumo%': 0, - # TODO(dmikurube): Change the default of use_allocator to "none". - # TODO(dmikurube): Kill linux_use_tcmalloc. http://crbug.com/345554 - 'linux_use_tcmalloc%': 0, - 'use_allocator%': 'see_use_tcmalloc', + 'use_allocator%': 'none', # Disable Native Client. 'disable_nacl%': 1, @@ -2002,6 +1997,12 @@ ], }], + ['OS=="win"', { + # The Clang plugins don't currently work on Windows. + # TODO(hans): One day, this will work. (crbug.com/82385) + 'clang_use_chrome_plugins%': 0, + }], + # On valgrind bots, override the optimizer settings so we don't inline too # much and make the stacks harder to figure out. # @@ -2026,10 +2027,7 @@ 'win_release_InlineFunctionExpansion': '0', 'win_release_OmitFramePointers': '0', - # TODO(dmikurube): Change the default of use_allocator to "tcmalloc". - # TODO(dmikurube): Kill linux_use_tcmalloc. http://crbug.com/345554 - 'linux_use_tcmalloc%': 1, - 'use_allocator': 'see_use_tcmalloc', + 'use_allocator': 'tcmalloc', 'release_valgrind_build': 1, 'werror': '', 'component': 'static_library', @@ -2105,9 +2103,11 @@ 'ozone_platform%': "test", # Enable built-in ozone platforms if ozone is enabled. + 'ozone_platform_caca%': 0, 'ozone_platform_dri%': 1, 'ozone_platform_test%': 1, }, { # use_ozone==0 + 'ozone_platform_caca%': 0, 'ozone_platform_dri%': 0, 'ozone_platform_test%': 0, }], @@ -2280,8 +2280,7 @@ '<(DEPTH)/build/mac/asan.gyp:asan_dynamic_runtime', ], }], - # TODO(dmikurube): Kill linux_use_tcmalloc. http://crbug.com/345554 - ['OS=="linux" and ((use_allocator!="none" and use_allocator!="see_use_tcmalloc") or (use_allocator=="see_use_tcmalloc" and linux_use_tcmalloc==1)) and clang_type_profiler==1', { + ['OS=="linux" and use_allocator!="none" and clang_type_profiler==1', { 'cflags_cc!': ['-fno-rtti'], 'cflags_cc+': [ '-frtti', @@ -2389,9 +2388,6 @@ ['configuration_policy==1', { 'defines': ['ENABLE_CONFIGURATION_POLICY'], }], - ['input_speech==1', { - 'defines': ['ENABLE_INPUT_SPEECH'], - }], ['notifications==1', { 'defines': ['ENABLE_NOTIFICATIONS'], }], @@ -2500,6 +2496,12 @@ 'ENABLE_EGLIMAGE=1', ], }], + ['asan==1', { + 'defines': [ + 'ADDRESS_SANITIZER', + 'MEMORY_TOOL_REPLACES_ALLOCATOR', + ], + }], ['syzyasan==1', { # SyzyAsan needs /PROFILE turned on to produce appropriate pdbs. 'msvs_settings': { @@ -2605,9 +2607,15 @@ ['enable_settings_app==1', { 'defines': ['ENABLE_SETTINGS_APP=1'], }], + ['disable_file_support==1', { + 'defines': ['DISABLE_FILE_SUPPORT=1'], + }], ['disable_ftp_support==1', { 'defines': ['DISABLE_FTP_SUPPORT=1'], }], + ['use_icu_alternatives_on_android==1', { + 'defines': ['USE_ICU_ALTERNATIVES_ON_ANDROID=1'], + }], ['enable_managed_users==1', { 'defines': ['ENABLE_MANAGED_USERS=1'], }], @@ -3375,9 +3383,6 @@ 'conditions': [ # Use gold linker for Android ia32 target. ['OS=="android"', { - 'cflags': [ - '-fuse-ld=gold', - ], 'ldflags': [ '-fuse-ld=gold', ], @@ -3403,9 +3408,6 @@ 'conditions': [ # Use gold linker for Android x64 target. ['OS=="android"', { - 'cflags': [ - '-fuse-ld=gold', - ], 'ldflags': [ '-fuse-ld=gold', ], @@ -3469,7 +3471,6 @@ # compiler (r5-r7). This can be verified using # webkit_unit_tests' WTF.Checked_int8_t test. '-fno-tree-sra', - '-fuse-ld=gold', '-Wno-psabi', ], # Android now supports .relro sections properly. @@ -3497,7 +3498,6 @@ '-mthumb-interwork', '-finline-limit=64', '-fno-tree-sra', - '-fuse-ld=gold', '-Wno-psabi', ], 'cflags': [ @@ -3713,9 +3713,6 @@ 'ldflags': [ '-fsanitize=address', ], - 'defines': [ - 'ADDRESS_SANITIZER', - ], }], ], 'conditions': [ @@ -3809,8 +3806,7 @@ }], ['use_custom_libcxx==1', { 'dependencies': [ - '<(DEPTH)/third_party/libc++/libc++.gyp:libc++', - '<(DEPTH)/third_party/libc++abi/libc++abi.gyp:libc++abi', + '<(DEPTH)/third_party/libc++/libc++.gyp:libcxx_proxy', ], }], ['order_profiling!=0 and (chromeos==1 or OS=="linux" or OS=="android")', { @@ -3849,8 +3845,7 @@ }], ], }], - # TODO(dmikurube): Kill {linux|android}_use_tcmalloc. http://crbug.com/345554 - ['use_allocator!="tcmalloc" and (use_allocator!="see_use_tcmalloc" or ((OS=="linux" and linux_use_tcmalloc==0) or (OS=="android" and android_use_tcmalloc==0)))', { + ['use_allocator!="tcmalloc"', { 'defines': ['NO_TCMALLOC'], }], ['linux_use_gold_flags==1', { @@ -3892,9 +3887,6 @@ ['gcc_version>=48', { 'target_conditions': [ ['_toolset=="target"', { - 'cflags': [ - '-fuse-ld=gold', - ], 'ldflags': [ '-fuse-ld=gold', ], @@ -3904,9 +3896,6 @@ ['host_gcc_version>=48', { 'target_conditions': [ ['_toolset=="host"', { - 'cflags': [ - '-fuse-ld=gold', - ], 'ldflags': [ '-fuse-ld=gold', ], @@ -4449,10 +4438,6 @@ '-w', # http://crbug.com/162783 ], }, - 'defines': [ - 'ADDRESS_SANITIZER', - 'MEMORY_TOOL_REPLACES_ALLOCATOR', - ], }], ['asan_coverage!=0', { 'target_conditions': [ @@ -5056,7 +5041,7 @@ 'VCLinkerTool': { 'AdditionalLibraryDirectories': [ # TODO(hans): If make_clang_dir is absolute, this breaks. - '<(DEPTH)/<(make_clang_dir)/lib/clang/3.5/lib/windows', + '<(DEPTH)/<(make_clang_dir)/lib/clang/3.5.0/lib/windows', ], }, 'target_conditions': [ diff --git a/build/config/BUILD.gn b/build/config/BUILD.gn index 866c9a8d25..d83a221aa5 100644 --- a/build/config/BUILD.gn +++ b/build/config/BUILD.gn @@ -24,12 +24,10 @@ config("feature_flags") { # TODO(brettw) most of these need to be parameterized. defines = [ "CHROMIUM_BUILD", - "USE_LIBJPEG_TURBO=1", "ENABLE_ONE_CLICK_SIGNIN", "ENABLE_REMOTING=1", "ENABLE_WEBRTC=1", "ENABLE_CONFIGURATION_POLICY", - "ENABLE_INPUT_SPEECH", "ENABLE_NOTIFICATIONS", "ENABLE_EGLIMAGE=1", "ENABLE_TASK_MANAGER=1", diff --git a/build/config/clang/BUILD.gn b/build/config/clang/BUILD.gn index f96bc73142..00fb9e066c 100644 --- a/build/config/clang/BUILD.gn +++ b/build/config/clang/BUILD.gn @@ -32,7 +32,7 @@ config("find_bad_constructs") { # compile with these so may want to remove this config. config("extra_warnings") { cflags = [ - "-Wheader-hygiene" + "-Wheader-hygiene", # Warns when a const char[] is converted to bool. "-Wstring-conversion", diff --git a/build/copy_test_data_ios.gypi b/build/copy_test_data_ios.gypi index 56a222f9f8..576a0f26ec 100644 --- a/build/copy_test_data_ios.gypi +++ b/build/copy_test_data_ios.gypi @@ -34,7 +34,12 @@ { 'inputs': [ - '<!@pymod_do_main(copy_test_data_ios --inputs <(test_data_files))', + # The |-o <(test_data_prefix)| is ignored; it is there to work around a + # caching bug in gyp (https://code.google.com/p/gyp/issues/detail?id=112). + # It caches command output when the string is the same, so if two copy + # steps have the same relative paths, there can be bogus cache hits that + # cause compile failures unless something varies. + '<!@pymod_do_main(copy_test_data_ios -o <(test_data_prefix) --inputs <(test_data_files))', ], 'outputs': [ '<!@pymod_do_main(copy_test_data_ios -o <(PRODUCT_DIR)/<(_target_name).app/<(test_data_prefix) --outputs <(test_data_files))', diff --git a/build/download_nacl_toolchains.py b/build/download_nacl_toolchains.py index 3a4cb1b8bf..4895c1a3fd 100755 --- a/build/download_nacl_toolchains.py +++ b/build/download_nacl_toolchains.py @@ -17,16 +17,16 @@ def Main(args): src_dir = os.path.dirname(script_dir) nacl_dir = os.path.join(src_dir, 'native_client') nacl_build_dir = os.path.join(nacl_dir, 'build') - download_script = os.path.join(nacl_build_dir, 'download_toolchains.py') - if not os.path.exists(download_script): - print "Can't find '%s'" % download_script + package_version_dir = os.path.join(nacl_build_dir, 'package_version') + package_version = os.path.join(package_version_dir, 'package_version.py') + if not os.path.exists(package_version): + print "Can't find '%s'" % package_version print 'Presumably you are intentionally building without NativeClient.' print 'Skipping NativeClient toolchain download.' sys.exit(0) - sys.path.insert(0, nacl_build_dir) - import download_toolchains + sys.path.insert(0, package_version_dir) + import package_version - # TODO (robertm): Finish getting PNaCl ready for prime time. # BUG: # We remove this --optional-pnacl argument, and instead replace it with # --no-pnacl for most cases. However, if the bot name is an sdk @@ -41,21 +41,17 @@ def Main(args): if use_pnacl: print '\n*** DOWNLOADING PNACL TOOLCHAIN ***\n' else: - args.append('--no-pnacl') + args.extend(['--exclude', 'pnacl_newlib']) # Only download the ARM gcc toolchain if we are building for ARM # TODO(olonho): we need to invent more reliable way to get build # configuration info, to know if we're building for ARM. - if 'target_arch=arm' in os.environ.get('GYP_DEFINES', ''): - args.append('--arm-untrusted') + if 'target_arch=arm' not in os.environ.get('GYP_DEFINES', ''): + args.extend(['--exclude', 'nacl_arm_newlib']) - # Append the name of the file to use as a version and hash source. - # NOTE: While not recommended, it is possible to redirect this file to - # a chrome location to avoid branching NaCl if just a toolchain needs - # to be bumped. - args.append(os.path.join(nacl_dir, 'TOOL_REVISIONS')) - - download_toolchains.main(args) + args.append('sync') + args.append('--extract') + package_version.main(args) return 0 diff --git a/build/filename_rules.gypi b/build/filename_rules.gypi index 001b975c87..8b492025fa 100644 --- a/build/filename_rules.gypi +++ b/build/filename_rules.gypi @@ -72,7 +72,7 @@ ], }], ['<(toolkit_views)==0 or >(nacl_untrusted_build)==1', { - 'sources/': [ ['exclude', '_views\\.(h|cc)$'] ] + 'sources/': [ ['exclude', '_views(_browsertest|_unittest)?\\.(h|cc)$'] ] }], ['<(use_aura)==0 or >(nacl_untrusted_build)==1', { 'sources/': [ ['exclude', '_aura(_browsertest|_unittest)?\\.(h|cc)$'], diff --git a/build/gyp_chromium b/build/gyp_chromium index 201e5a0fa7..26028dc2c4 100755 --- a/build/gyp_chromium +++ b/build/gyp_chromium @@ -277,6 +277,17 @@ if __name__ == '__main__': supplemental_includes = GetSupplementalFiles() gyp_vars_dict = GetGypVars(supplemental_includes) + # TODO(dmikurube): Remove these checks and messages after a while. + if ('linux_use_tcmalloc' in gyp_vars_dict or + 'android_use_tcmalloc' in gyp_vars_dict): + print '*****************************************************************' + print '"linux_use_tcmalloc" and "android_use_tcmalloc" are deprecated!' + print '-----------------------------------------------------------------' + print 'You specify "linux_use_tcmalloc" or "android_use_tcmalloc" in' + print 'your GYP_DEFINES. Please switch them into "use_allocator" now.' + print 'See http://crbug.com/345554 for the details.' + print '*****************************************************************' + # Automatically turn on crosscompile support for platforms that need it. # (The Chrome OS build sets CC_host / CC_target which implicitly enables # this mode.) diff --git a/build/ios/grit_whitelist.txt b/build/ios/grit_whitelist.txt index a9f660bb30..e7673e4af6 100644 --- a/build/ios/grit_whitelist.txt +++ b/build/ios/grit_whitelist.txt @@ -833,12 +833,6 @@ IDS_SHOW_HISTORY IDS_SIGNED_IN_WITH_SYNC_DISABLED IDS_SIGNED_IN_WITH_SYNC_SUPPRESSED IDS_SIGNIN_ERROR_BUBBLE_VIEW_TITLE -IDS_SPEECH_INPUT_ABORTED -IDS_SPEECH_INPUT_MIC_ERROR -IDS_SPEECH_INPUT_NET_ERROR -IDS_SPEECH_INPUT_NO_MIC -IDS_SPEECH_INPUT_NO_RESULTS -IDS_SPEECH_INPUT_NO_SPEECH IDS_SSL_BLOCKING_PAGE_TITLE IDS_SYNC_ACCOUNT_SYNCING_TO_USER IDS_SYNC_ACCOUNT_SYNCING_TO_USER_WITH_MANAGE_LINK diff --git a/build/util/LASTCHANGE b/build/util/LASTCHANGE index 7eb6be5cf5..f21b849826 100644 --- a/build/util/LASTCHANGE +++ b/build/util/LASTCHANGE @@ -1 +1 @@ -LASTCHANGE=267519 +LASTCHANGE=269336 diff --git a/build/util/LASTCHANGE.blink b/build/util/LASTCHANGE.blink index 47cd938f46..b18a46f0ab 100644 --- a/build/util/LASTCHANGE.blink +++ b/build/util/LASTCHANGE.blink @@ -1 +1 @@ -LASTCHANGE=173042 +LASTCHANGE=173743 diff --git a/build/whitespace_file.txt b/build/whitespace_file.txt index 57d555cbc4..6cc0abe92f 100644 --- a/build/whitespace_file.txt +++ b/build/whitespace_file.txt @@ -88,3 +88,5 @@ What could possibly go wrong? We've already ate our cake. Hello from tutorial! + +I want a 1917 build and you will give me what I want. |