summaryrefslogtreecommitdiff
path: root/gpu
diff options
context:
space:
mode:
authorTorne (Richard Coles) <torne@google.com>2014-08-19 13:00:08 +0100
committerTorne (Richard Coles) <torne@google.com>2014-08-19 13:00:08 +0100
commit6e8cce623b6e4fe0c9e4af605d675dd9d0338c38 (patch)
tree8d824ad26fac42e008142b86aa9631b2be7e4705 /gpu
parent4f7316adb45db5ec3c9c1181ba9510c004566df8 (diff)
downloadchromium_org-6e8cce623b6e4fe0c9e4af605d675dd9d0338c38.tar.gz
Merge from Chromium at DEPS revision 290040
This commit was generated by merge_to_master.py. Change-Id: I694ec52d1e0b553f163c2faf4373d63270ab1aac
Diffstat (limited to 'gpu')
-rw-r--r--gpu/BUILD.gn1
-rw-r--r--gpu/GLES2/extensions/CHROMIUM/CHROMIUM_copy_texture.txt13
-rw-r--r--gpu/GLES2/extensions/CHROMIUM/EGL_CHROMIUM_get_sync_values.txt131
-rwxr-xr-xgpu/command_buffer/build_gles2_cmd_buffer.py96
-rw-r--r--gpu/command_buffer/client/BUILD.gn1
-rw-r--r--gpu/command_buffer/client/gl_in_process_context.cc85
-rw-r--r--gpu/command_buffer/client/gl_in_process_context.h19
-rw-r--r--gpu/command_buffer/client/gles2_implementation.cc1
-rw-r--r--gpu/command_buffer/client/gles2_implementation_unittest.cc10
-rw-r--r--gpu/command_buffer/client/share_group.h2
-rw-r--r--gpu/command_buffer/common/gles2_cmd_utils.cc109
-rw-r--r--gpu/command_buffer/common/gles2_cmd_utils.h30
-rw-r--r--gpu/command_buffer/gles2_utils.target.darwin-arm.mk2
-rw-r--r--gpu/command_buffer/gles2_utils.target.darwin-arm64.mk2
-rw-r--r--gpu/command_buffer/gles2_utils.target.darwin-mips.mk2
-rw-r--r--gpu/command_buffer/gles2_utils.target.darwin-x86.mk2
-rw-r--r--gpu/command_buffer/gles2_utils.target.darwin-x86_64.mk2
-rw-r--r--gpu/command_buffer/gles2_utils.target.linux-arm.mk2
-rw-r--r--gpu/command_buffer/gles2_utils.target.linux-arm64.mk2
-rw-r--r--gpu/command_buffer/gles2_utils.target.linux-mips.mk2
-rw-r--r--gpu/command_buffer/gles2_utils.target.linux-x86.mk2
-rw-r--r--gpu/command_buffer/gles2_utils.target.linux-x86_64.mk2
-rw-r--r--gpu/command_buffer/service/async_pixel_transfer_manager_android.cc4
-rw-r--r--gpu/command_buffer/service/feature_info.cc2
-rw-r--r--gpu/command_buffer/service/gles2_cmd_copy_texture_chromium.cc162
-rw-r--r--gpu/command_buffer/service/gles2_cmd_copy_texture_chromium.h28
-rw-r--r--gpu/command_buffer/service/gles2_cmd_decoder.cc91
-rw-r--r--gpu/command_buffer/service/gles2_cmd_decoder_autogen.h2
-rw-r--r--gpu/command_buffer/service/gles2_cmd_decoder_unittest_1_autogen.h8
-rw-r--r--gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc2
-rw-r--r--gpu/command_buffer/service/in_process_command_buffer.cc22
-rw-r--r--gpu/command_buffer/service/in_process_command_buffer.h4
-rw-r--r--gpu/command_buffer/service/test_helper.cc4
-rw-r--r--gpu/command_buffer/tests/gl_manager.cc10
-rw-r--r--gpu/command_buffer_client.target.darwin-arm.mk2
-rw-r--r--gpu/command_buffer_client.target.darwin-arm64.mk2
-rw-r--r--gpu/command_buffer_client.target.darwin-mips.mk2
-rw-r--r--gpu/command_buffer_client.target.darwin-x86.mk2
-rw-r--r--gpu/command_buffer_client.target.darwin-x86_64.mk2
-rw-r--r--gpu/command_buffer_client.target.linux-arm.mk2
-rw-r--r--gpu/command_buffer_client.target.linux-arm64.mk2
-rw-r--r--gpu/command_buffer_client.target.linux-mips.mk2
-rw-r--r--gpu/command_buffer_client.target.linux-x86.mk2
-rw-r--r--gpu/command_buffer_client.target.linux-x86_64.mk2
-rw-r--r--gpu/command_buffer_common.target.darwin-arm.mk2
-rw-r--r--gpu/command_buffer_common.target.darwin-arm64.mk2
-rw-r--r--gpu/command_buffer_common.target.darwin-mips.mk2
-rw-r--r--gpu/command_buffer_common.target.darwin-x86.mk2
-rw-r--r--gpu/command_buffer_common.target.darwin-x86_64.mk2
-rw-r--r--gpu/command_buffer_common.target.linux-arm.mk2
-rw-r--r--gpu/command_buffer_common.target.linux-arm64.mk2
-rw-r--r--gpu/command_buffer_common.target.linux-mips.mk2
-rw-r--r--gpu/command_buffer_common.target.linux-x86.mk2
-rw-r--r--gpu/command_buffer_common.target.linux-x86_64.mk2
-rw-r--r--gpu/command_buffer_service.target.darwin-arm.mk2
-rw-r--r--gpu/command_buffer_service.target.darwin-arm64.mk2
-rw-r--r--gpu/command_buffer_service.target.darwin-mips.mk2
-rw-r--r--gpu/command_buffer_service.target.darwin-x86.mk2
-rw-r--r--gpu/command_buffer_service.target.darwin-x86_64.mk2
-rw-r--r--gpu/command_buffer_service.target.linux-arm.mk2
-rw-r--r--gpu/command_buffer_service.target.linux-arm64.mk2
-rw-r--r--gpu/command_buffer_service.target.linux-mips.mk2
-rw-r--r--gpu/command_buffer_service.target.linux-x86.mk2
-rw-r--r--gpu/command_buffer_service.target.linux-x86_64.mk2
-rw-r--r--gpu/config/BUILD.gn2
-rw-r--r--gpu/config/gpu_control_list.cc147
-rw-r--r--gpu/config/gpu_control_list.h51
-rw-r--r--gpu/config/gpu_control_list_entry_unittest.cc200
-rw-r--r--gpu/config/gpu_control_list_format.txt20
-rw-r--r--gpu/config/gpu_control_list_string_info_unittest.cc98
-rw-r--r--gpu/config/gpu_control_list_unittest.cc5
-rw-r--r--gpu/config/gpu_driver_bug_list_json.cc203
-rw-r--r--gpu/config/software_rendering_list_json.cc175
-rw-r--r--gpu/disk_cache_proto.target.darwin-arm.mk2
-rw-r--r--gpu/disk_cache_proto.target.darwin-arm64.mk2
-rw-r--r--gpu/disk_cache_proto.target.darwin-mips.mk2
-rw-r--r--gpu/disk_cache_proto.target.darwin-x86.mk2
-rw-r--r--gpu/disk_cache_proto.target.darwin-x86_64.mk2
-rw-r--r--gpu/disk_cache_proto.target.linux-arm.mk2
-rw-r--r--gpu/disk_cache_proto.target.linux-arm64.mk2
-rw-r--r--gpu/disk_cache_proto.target.linux-mips.mk2
-rw-r--r--gpu/disk_cache_proto.target.linux-x86.mk2
-rw-r--r--gpu/disk_cache_proto.target.linux-x86_64.mk2
-rw-r--r--gpu/gl_in_process_context.target.darwin-arm.mk2
-rw-r--r--gpu/gl_in_process_context.target.darwin-arm64.mk2
-rw-r--r--gpu/gl_in_process_context.target.darwin-mips.mk2
-rw-r--r--gpu/gl_in_process_context.target.darwin-x86.mk2
-rw-r--r--gpu/gl_in_process_context.target.darwin-x86_64.mk2
-rw-r--r--gpu/gl_in_process_context.target.linux-arm.mk2
-rw-r--r--gpu/gl_in_process_context.target.linux-arm64.mk2
-rw-r--r--gpu/gl_in_process_context.target.linux-mips.mk2
-rw-r--r--gpu/gl_in_process_context.target.linux-x86.mk2
-rw-r--r--gpu/gl_in_process_context.target.linux-x86_64.mk2
-rw-r--r--gpu/gles2_c_lib.target.darwin-arm.mk2
-rw-r--r--gpu/gles2_c_lib.target.darwin-arm64.mk2
-rw-r--r--gpu/gles2_c_lib.target.darwin-mips.mk2
-rw-r--r--gpu/gles2_c_lib.target.darwin-x86.mk2
-rw-r--r--gpu/gles2_c_lib.target.darwin-x86_64.mk2
-rw-r--r--gpu/gles2_c_lib.target.linux-arm.mk2
-rw-r--r--gpu/gles2_c_lib.target.linux-arm64.mk2
-rw-r--r--gpu/gles2_c_lib.target.linux-mips.mk2
-rw-r--r--gpu/gles2_c_lib.target.linux-x86.mk2
-rw-r--r--gpu/gles2_c_lib.target.linux-x86_64.mk2
-rw-r--r--gpu/gles2_cmd_helper.target.darwin-arm.mk2
-rw-r--r--gpu/gles2_cmd_helper.target.darwin-arm64.mk2
-rw-r--r--gpu/gles2_cmd_helper.target.darwin-mips.mk2
-rw-r--r--gpu/gles2_cmd_helper.target.darwin-x86.mk2
-rw-r--r--gpu/gles2_cmd_helper.target.darwin-x86_64.mk2
-rw-r--r--gpu/gles2_cmd_helper.target.linux-arm.mk2
-rw-r--r--gpu/gles2_cmd_helper.target.linux-arm64.mk2
-rw-r--r--gpu/gles2_cmd_helper.target.linux-mips.mk2
-rw-r--r--gpu/gles2_cmd_helper.target.linux-x86.mk2
-rw-r--r--gpu/gles2_cmd_helper.target.linux-x86_64.mk2
-rw-r--r--gpu/gles2_implementation.target.darwin-arm.mk2
-rw-r--r--gpu/gles2_implementation.target.darwin-arm64.mk2
-rw-r--r--gpu/gles2_implementation.target.darwin-mips.mk2
-rw-r--r--gpu/gles2_implementation.target.darwin-x86.mk2
-rw-r--r--gpu/gles2_implementation.target.darwin-x86_64.mk2
-rw-r--r--gpu/gles2_implementation.target.linux-arm.mk2
-rw-r--r--gpu/gles2_implementation.target.linux-arm64.mk2
-rw-r--r--gpu/gles2_implementation.target.linux-mips.mk2
-rw-r--r--gpu/gles2_implementation.target.linux-x86.mk2
-rw-r--r--gpu/gles2_implementation.target.linux-x86_64.mk2
-rw-r--r--gpu/gpu.gyp2
-rw-r--r--gpu/gpu.target.darwin-arm.mk2
-rw-r--r--gpu/gpu.target.darwin-arm64.mk2
-rw-r--r--gpu/gpu.target.darwin-mips.mk2
-rw-r--r--gpu/gpu.target.darwin-x86.mk2
-rw-r--r--gpu/gpu.target.darwin-x86_64.mk2
-rw-r--r--gpu/gpu.target.linux-arm.mk2
-rw-r--r--gpu/gpu.target.linux-arm64.mk2
-rw-r--r--gpu/gpu.target.linux-mips.mk2
-rw-r--r--gpu/gpu.target.linux-x86.mk2
-rw-r--r--gpu/gpu.target.linux-x86_64.mk2
-rw-r--r--gpu/gpu_config.gypi2
-rw-r--r--gpu/gpu_config.target.darwin-arm.mk2
-rw-r--r--gpu/gpu_config.target.darwin-arm64.mk2
-rw-r--r--gpu/gpu_config.target.darwin-mips.mk2
-rw-r--r--gpu/gpu_config.target.darwin-x86.mk2
-rw-r--r--gpu/gpu_config.target.darwin-x86_64.mk2
-rw-r--r--gpu/gpu_config.target.linux-arm.mk2
-rw-r--r--gpu/gpu_config.target.linux-arm64.mk2
-rw-r--r--gpu/gpu_config.target.linux-mips.mk2
-rw-r--r--gpu/gpu_config.target.linux-x86.mk2
-rw-r--r--gpu/gpu_config.target.linux-x86_64.mk2
-rw-r--r--gpu/gpu_ipc.target.darwin-arm.mk2
-rw-r--r--gpu/gpu_ipc.target.darwin-arm64.mk2
-rw-r--r--gpu/gpu_ipc.target.darwin-mips.mk2
-rw-r--r--gpu/gpu_ipc.target.darwin-x86.mk2
-rw-r--r--gpu/gpu_ipc.target.darwin-x86_64.mk2
-rw-r--r--gpu/gpu_ipc.target.linux-arm.mk2
-rw-r--r--gpu/gpu_ipc.target.linux-arm64.mk2
-rw-r--r--gpu/gpu_ipc.target.linux-mips.mk2
-rw-r--r--gpu/gpu_ipc.target.linux-x86.mk2
-rw-r--r--gpu/gpu_ipc.target.linux-x86_64.mk2
-rw-r--r--gpu/skia_bindings/gpu_skia_bindings.target.darwin-arm.mk2
-rw-r--r--gpu/skia_bindings/gpu_skia_bindings.target.darwin-arm64.mk2
-rw-r--r--gpu/skia_bindings/gpu_skia_bindings.target.darwin-mips.mk2
-rw-r--r--gpu/skia_bindings/gpu_skia_bindings.target.darwin-x86.mk2
-rw-r--r--gpu/skia_bindings/gpu_skia_bindings.target.darwin-x86_64.mk2
-rw-r--r--gpu/skia_bindings/gpu_skia_bindings.target.linux-arm.mk2
-rw-r--r--gpu/skia_bindings/gpu_skia_bindings.target.linux-arm64.mk2
-rw-r--r--gpu/skia_bindings/gpu_skia_bindings.target.linux-mips.mk2
-rw-r--r--gpu/skia_bindings/gpu_skia_bindings.target.linux-x86.mk2
-rw-r--r--gpu/skia_bindings/gpu_skia_bindings.target.linux-x86_64.mk2
165 files changed, 890 insertions, 1112 deletions
diff --git a/gpu/BUILD.gn b/gpu/BUILD.gn
index 7c8acc8f63..fc7a4ac489 100644
--- a/gpu/BUILD.gn
+++ b/gpu/BUILD.gn
@@ -209,7 +209,6 @@ test("gpu_unittests") {
"config/gpu_control_list_entry_unittest.cc",
"config/gpu_control_list_number_info_unittest.cc",
"config/gpu_control_list_os_info_unittest.cc",
- "config/gpu_control_list_string_info_unittest.cc",
"config/gpu_control_list_unittest.cc",
"config/gpu_control_list_version_info_unittest.cc",
"config/gpu_driver_bug_list_unittest.cc",
diff --git a/gpu/GLES2/extensions/CHROMIUM/CHROMIUM_copy_texture.txt b/gpu/GLES2/extensions/CHROMIUM/CHROMIUM_copy_texture.txt
index 4431e4938f..fdaa7d64b7 100644
--- a/gpu/GLES2/extensions/CHROMIUM/CHROMIUM_copy_texture.txt
+++ b/gpu/GLES2/extensions/CHROMIUM/CHROMIUM_copy_texture.txt
@@ -47,7 +47,18 @@ New Procedures and Functions
destination texture. The level parameter must be 0 at present.
The internal format of the destination texture is converted to that
- specified by <internal_format>.
+ specified by <internal_format>. Must be one of the following symbolic
+ constants: GL_ALPHA, GL_LUMINANCE, GL_LUMINANCE_ALPHA, GL_RGB, GL_RGBA
+ When <source_id> texture doens't contain a superset of the component
+ required by <internal_format>, fill the components by following rules.
+
+ source format color components
+ =================================================
+ GL_ALPHA (0, 0, 0, A)
+ GL_LUMINANCE (L, L, L, 1)
+ GL_LUMINANCE_ALPHA (L, L, L, A)
+ GL_RGB (R, G, B, 1)
+ GL_RGBA (R, G, B, A)
The format type of the destination texture is converted to that specified
by <dest_type>.
diff --git a/gpu/GLES2/extensions/CHROMIUM/EGL_CHROMIUM_get_sync_values.txt b/gpu/GLES2/extensions/CHROMIUM/EGL_CHROMIUM_get_sync_values.txt
new file mode 100644
index 0000000000..d95b348c84
--- /dev/null
+++ b/gpu/GLES2/extensions/CHROMIUM/EGL_CHROMIUM_get_sync_values.txt
@@ -0,0 +1,131 @@
+Name
+
+ CHROMIUM_get_sync_values
+
+Name Strings
+
+ EGL_CHROMIUM_get_sync_values
+
+Contact
+
+ Stéphane Marchesin, Google (marcheu 'at' google.com)
+
+Status
+
+ Draft.
+
+Version
+
+ Last Modified Date: N/A Revision: 1.0
+
+ Based on GLX_OML_sync_control Revision 6.0
+
+Number
+
+ ???
+
+Dependencies
+
+ The extension is written against the EGL 1.2 Specification, although it
+ should work on other versions of these specifications. This extension
+ also requires an operating system which supports CLOCK_MONOTONIC.
+
+Overview
+
+ This extension provides counters which let applications know about the
+ timing of the last vertical retrace. By looking at the system clock, as
+ well as the refresh rate of the monitor, this should enable applications
+ to predict the position of future retraces so as to schedule an optimal
+ workload.
+
+ This extension incorporates the use of three counters that provide
+ the necessary synchronization. The Unadjusted System Time (or UST)
+ is the 64-bit CLOCK_MONOTONIC clock; in particular this lets the
+ application schedule future vertical retraces by querying this clock.
+ The graphics Media Stream Counter (or graphics MSC) is a counter
+ that is unique to the graphics subsystem and increments for each
+ vertical retrace that occurs. The Swap Buffer Counter (SBC) is an
+ attribute of an EGLSurface and is incremented each time a swap
+ buffer action is performed on the associated surface.
+
+ The use of these three counters allows the application to
+ synchronize graphics rendering to vertical retraces and/or swap
+ buffer actions. For example, by querying the synchronization values for
+ a given surface, the application can accurately predict the timing for
+ the next vertical retraces and schedule rendering accordingly.
+
+Issues
+
+ None.
+
+IP Status
+
+ No known issues.
+
+New Procedures and Functions
+
+ Bool eglGetSyncValuesCHROMIUM(EGLDisplay dpy,
+ EGLSurface surface,
+ int64_t* ust,
+ int64_t* msc,
+ int64_t* sbc)
+
+
+New Tokens
+
+ None
+
+Additions to the EGL 1.3 Specification
+
+ eglGetSyncValuesCHROMIUM returns the current UST/MSC/SBC triple. A UST
+ timestamp is obtained each time the graphics MSC is incremented.
+ If this value does not reflect the value of the UST at the time the
+ first scan line of the display begins passing through the video
+ output port, it will be adjusted by the graphics driver to do so
+ prior to being returned by any of the functions defined by this
+ extension.
+
+ This UST timestamp, together with the current graphics MSC and the
+ current SBC, comprise the current UST/MSC/SBC triple. The UST,
+ graphics MSC, and SBC values are not part of the render context
+ state. These values cannot be pushed or popped. The graphics MSC
+ value is initialized to 0 when the graphics device is initialized.
+ The SBC is per-surface state and is initialized to 0 when the
+ EGLSurface data structure is initialized.
+
+ The SBC value is incremented by the graphics driver at the completion
+ of each buffer swap (e.g., the pixel copy has been completed or the
+ hardware register that swaps memory banks has been written). For pixel
+ formats that do not contain a back buffer, the SBC will always be
+ returned as 0.
+
+ The graphics MSC value is incremented once for each screen refresh.
+ For a non-interlaced display, this means that the graphics MSC value
+ is incremented for each frame. For an interlaced display, it means
+ that it will be incremented for each field. For a multi-monitor
+ system, the monitor used to determine MSC is the one where the surface
+ is located. If the surface spans multiple monitors, the monitor used
+ to determine MSC is the one with the biggest coverage in pixels.
+
+ The function eglGetSyncValuesCHROMIUM will return TRUE if the function
+ completed successfully, FALSE otherwise.
+
+ Each time eglSwapBuffer succeeds, the SBC will be increased within a
+ finite time period.
+
+Errors
+
+ eglGetSyncValuesCHROMIUM will return FALSE if there is no current
+ EGLContext.
+
+New State
+
+ Get Value Get Command Type Initial Value
+ --------- ----------- ---- -------------
+ [UST] eglGetSyncValuesCHROMIUM Z unspecified
+ [MSC] eglGetSyncValuesCHROMIUM Z 0
+ [SBC] eglGetSyncValuesCHROMIUM Z 0
+
+New Implementation Dependent State
+
+ None
diff --git a/gpu/command_buffer/build_gles2_cmd_buffer.py b/gpu/command_buffer/build_gles2_cmd_buffer.py
index 1216a7f45a..56f59fcfde 100755
--- a/gpu/command_buffer/build_gles2_cmd_buffer.py
+++ b/gpu/command_buffer/build_gles2_cmd_buffer.py
@@ -425,6 +425,7 @@ _STATES = {
'type': 'GLfloat',
'default': '1.0f',
'range_checks': [{'check': "<= 0.0f", 'test_value': "0.0f"}],
+ 'nan_check': True,
}],
},
'DepthMask': {
@@ -1382,7 +1383,7 @@ _FUNCTION_INFO = {
'count': 64, # GL_MAILBOX_SIZE_CHROMIUM
'unit_test': False,
'client_test': False,
- 'extension': True,
+ 'extension': "CHROMIUM_texture_mailbox",
'chromium': True,
'trace_level': 1,
},
@@ -1393,7 +1394,7 @@ _FUNCTION_INFO = {
'data_transfer_methods': ['immediate'],
'unit_test': False,
'client_test': False,
- 'extension': True,
+ 'extension': "CHROMIUM_texture_mailbox",
'chromium': True,
},
'ClearStencil': {
@@ -1648,7 +1649,7 @@ _FUNCTION_INFO = {
'GenMailboxCHROMIUM': {
'type': 'HandWritten',
'impl_func': False,
- 'extension': True,
+ 'extension': "CHROMIUM_texture_mailbox",
'chromium': True,
},
'GenFramebuffers': {
@@ -1976,7 +1977,7 @@ _FUNCTION_INFO = {
'count': 64, # GL_MAILBOX_SIZE_CHROMIUM
'unit_test': False,
'client_test': False,
- 'extension': True,
+ 'extension': "CHROMIUM_texture_mailbox",
'chromium': True,
'trace_level': 1,
},
@@ -1987,7 +1988,7 @@ _FUNCTION_INFO = {
'count': 64, # GL_MAILBOX_SIZE_CHROMIUM
'unit_test': False,
'client_test': False,
- 'extension': True,
+ 'extension': "CHROMIUM_texture_mailbox",
'chromium': True,
'trace_level': 1,
},
@@ -2559,13 +2560,13 @@ _FUNCTION_INFO = {
'InsertSyncPointCHROMIUM': {
'type': 'HandWritten',
'impl_func': False,
- 'extension': True,
+ 'extension': "CHROMIUM_sync_point",
'chromium': True,
},
'WaitSyncPointCHROMIUM': {
'type': 'Custom',
'impl_func': True,
- 'extension': True,
+ 'extension': "CHROMIUM_sync_point",
'chromium': True,
'trace_level': 1,
},
@@ -3324,19 +3325,27 @@ class StateSetHandler(TypeHandler):
state = _STATES[state_name]
states = state['states']
args = func.GetOriginalArgs()
- code = []
for ndx,item in enumerate(states):
+ code = []
if 'range_checks' in item:
for range_check in item['range_checks']:
code.append("%s %s" % (args[ndx].name, range_check['check']))
- if len(code):
- file.Write(" if (%s) {\n" % " ||\n ".join(code))
- file.Write(
- ' LOCAL_SET_GL_ERROR(GL_INVALID_VALUE,'
- ' "%s", "%s out of range");\n' %
- (func.name, args[ndx].name))
- file.Write(" return error::kNoError;\n")
- file.Write(" }\n")
+ if 'nan_check' in item:
+ # Drivers might generate an INVALID_VALUE error when a value is set
+ # to NaN. This is allowed behavior under GLES 3.0 section 2.1.1 or
+ # OpenGL 4.5 section 2.3.4.1 - providing NaN allows undefined results.
+ # Make this behavior consistent within Chromium, and avoid leaking GL
+ # errors by generating the error in the command buffer instead of
+ # letting the GL driver generate it.
+ code.append("base::IsNaN(%s)" % args[ndx].name)
+ if len(code):
+ file.Write(" if (%s) {\n" % " ||\n ".join(code))
+ file.Write(
+ ' LOCAL_SET_GL_ERROR(GL_INVALID_VALUE,'
+ ' "%s", "%s out of range");\n' %
+ (func.name, args[ndx].name))
+ file.Write(" return error::kNoError;\n")
+ file.Write(" }\n")
code = []
for ndx,item in enumerate(states):
code.append("state_.%s != %s" % (item['name'], args[ndx].name))
@@ -3387,6 +3396,30 @@ TEST_P(%(test_name)s, %(name)sInvalidValue%(ndx)d_%(check_ndx)d) {
'args': ", ".join(arg_strings),
}
file.Write(valid_test % vars)
+ if 'nan_check' in item:
+ valid_test = """
+TEST_P(%(test_name)s, %(name)sNaNValue%(ndx)d) {
+ SpecializedSetup<cmds::%(name)s, 0>(false);
+ cmds::%(name)s cmd;
+ cmd.Init(%(args)s);
+ EXPECT_EQ(error::kNoError, ExecuteCmd(cmd));
+ EXPECT_EQ(GL_INVALID_VALUE, GetGLError());
+}
+"""
+ name = func.name
+ arg_strings = [
+ arg.GetValidArg(func) \
+ for arg in func.GetOriginalArgs() if not arg.IsConstant()
+ ]
+
+ arg_strings[ndx] = 'nanf("")'
+ vars = {
+ 'test_name': 'GLES2DecoderTest%d' % file.file_num,
+ 'name': name,
+ 'ndx': ndx,
+ 'args': ", ".join(arg_strings),
+ }
+ file.Write(valid_test % vars)
class StateSetRGBAlphaHandler(TypeHandler):
@@ -8225,6 +8258,22 @@ const size_t GLES2Util::enum_to_string_table_len_ =
file.Close()
+ def WriteMojoGLCallVisitorForExtension(self, filename, extension):
+ """Provides the GL implementation for mojo for a particular extension"""
+ file = CWriter(filename)
+ file.Write(_LICENSE)
+ file.Write(_DO_NOT_EDIT_WARNING)
+
+ for func in self.original_functions:
+ if func.GetInfo("extension") != extension:
+ continue
+ file.Write("VISIT_GL_CALL(%s, %s, (%s), (%s))\n" %
+ (func.name, func.return_type,
+ func.MakeTypedOriginalArgString(""),
+ func.MakeOriginalArgString("")))
+
+ file.Close()
+
def Format(generated_files):
for filename in generated_files:
call(["clang-format", "-i", "-style=chromium", filename])
@@ -8306,8 +8355,14 @@ def main(argv):
gen.WriteCommonUtilsHeader("common/gles2_cmd_utils_autogen.h")
gen.WriteCommonUtilsImpl("common/gles2_cmd_utils_implementation_autogen.h")
gen.WriteGLES2Header("../GLES2/gl2chromium_autogen.h")
- gen.WriteMojoGLCallVisitor(
- "../../mojo/public/c/gles2/gles2_call_visitor_autogen.h")
+ mojo_gles2_prefix = "../../mojo/public/c/gles2/gles2_call_visitor"
+ gen.WriteMojoGLCallVisitor(mojo_gles2_prefix + "_autogen.h")
+ gen.WriteMojoGLCallVisitorForExtension(
+ mojo_gles2_prefix + "_chromium_texture_mailbox_autogen.h",
+ "CHROMIUM_texture_mailbox")
+ gen.WriteMojoGLCallVisitorForExtension(
+ mojo_gles2_prefix + "_chromium_sync_point_autogen.h",
+ "CHROMIUM_sync_point")
Format([
"common/gles2_cmd_format_autogen.h",
@@ -8337,9 +8392,12 @@ def main(argv):
"service/gles2_cmd_validation_autogen.h",
"service/gles2_cmd_validation_implementation_autogen.h"])
os.chdir("../..")
+ mojo_gles2_prefix = "mojo/public/c/gles2/gles2_call_visitor"
Format([
"gpu/GLES2/gl2chromium_autogen.h",
- "mojo/public/c/gles2/gles2_call_visitor_autogen.h",
+ mojo_gles2_prefix + "_autogen.h",
+ mojo_gles2_prefix + "_chromium_texture_mailbox_autogen.h",
+ mojo_gles2_prefix + "_chromium_sync_point_autogen.h",
"ppapi/c/dev/ppb_opengles2ext_dev.h",
"ppapi/c/ppb_opengles2.h",
"ppapi/lib/gl/gles2/gles2.c",
diff --git a/gpu/command_buffer/client/BUILD.gn b/gpu/command_buffer/client/BUILD.gn
index bbfe4d0a18..d3e9b42590 100644
--- a/gpu/command_buffer/client/BUILD.gn
+++ b/gpu/command_buffer/client/BUILD.gn
@@ -152,6 +152,7 @@ component("gl_in_process_context") {
deps = [
":gles2_implementation",
"//gpu",
+ "//gpu/command_buffer/common:gles2_utils",
"//base",
"//base/third_party/dynamic_annotations",
"//ui/gfx/geometry",
diff --git a/gpu/command_buffer/client/gl_in_process_context.cc b/gpu/command_buffer/client/gl_in_process_context.cc
index bfcea4ab87..0a8294ada4 100644
--- a/gpu/command_buffer/client/gl_in_process_context.cc
+++ b/gpu/command_buffer/client/gl_in_process_context.cc
@@ -58,7 +58,7 @@ class GLInProcessContextImpl
GLInProcessContext* share_context,
gfx::AcceleratedWidget window,
const gfx::Size& size,
- const GLInProcessContextAttribs& attribs,
+ const gpu::gles2::ContextCreationAttribHelper& attribs,
gfx::GpuPreference gpu_preference,
const scoped_refptr<InProcessCommandBuffer::Service>& service);
@@ -126,71 +126,14 @@ bool GLInProcessContextImpl::Initialize(
GLInProcessContext* share_context,
gfx::AcceleratedWidget window,
const gfx::Size& size,
- const GLInProcessContextAttribs& attribs,
+ const gles2::ContextCreationAttribHelper& attribs,
gfx::GpuPreference gpu_preference,
const scoped_refptr<InProcessCommandBuffer::Service>& service) {
DCHECK(!use_global_share_group || !share_context);
DCHECK(size.width() >= 0 && size.height() >= 0);
- // Changes to these values should also be copied to
- // gpu/command_buffer/client/gl_in_process_context.cc and to
- // content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.h
- const int32 ALPHA_SIZE = 0x3021;
- const int32 BLUE_SIZE = 0x3022;
- const int32 GREEN_SIZE = 0x3023;
- const int32 RED_SIZE = 0x3024;
- const int32 DEPTH_SIZE = 0x3025;
- const int32 STENCIL_SIZE = 0x3026;
- const int32 SAMPLES = 0x3031;
- const int32 SAMPLE_BUFFERS = 0x3032;
- const int32 NONE = 0x3038;
-
- // Chromium-specific attributes
- const int32 FAIL_IF_MAJOR_PERF_CAVEAT = 0x10002;
- const int32 LOSE_CONTEXT_WHEN_OUT_OF_MEMORY = 0x10003;
-
std::vector<int32> attrib_vector;
- if (attribs.alpha_size >= 0) {
- attrib_vector.push_back(ALPHA_SIZE);
- attrib_vector.push_back(attribs.alpha_size);
- }
- if (attribs.blue_size >= 0) {
- attrib_vector.push_back(BLUE_SIZE);
- attrib_vector.push_back(attribs.blue_size);
- }
- if (attribs.green_size >= 0) {
- attrib_vector.push_back(GREEN_SIZE);
- attrib_vector.push_back(attribs.green_size);
- }
- if (attribs.red_size >= 0) {
- attrib_vector.push_back(RED_SIZE);
- attrib_vector.push_back(attribs.red_size);
- }
- if (attribs.depth_size >= 0) {
- attrib_vector.push_back(DEPTH_SIZE);
- attrib_vector.push_back(attribs.depth_size);
- }
- if (attribs.stencil_size >= 0) {
- attrib_vector.push_back(STENCIL_SIZE);
- attrib_vector.push_back(attribs.stencil_size);
- }
- if (attribs.samples >= 0) {
- attrib_vector.push_back(SAMPLES);
- attrib_vector.push_back(attribs.samples);
- }
- if (attribs.sample_buffers >= 0) {
- attrib_vector.push_back(SAMPLE_BUFFERS);
- attrib_vector.push_back(attribs.sample_buffers);
- }
- if (attribs.fail_if_major_perf_caveat > 0) {
- attrib_vector.push_back(FAIL_IF_MAJOR_PERF_CAVEAT);
- attrib_vector.push_back(attribs.fail_if_major_perf_caveat);
- }
- if (attribs.lose_context_when_out_of_memory > 0) {
- attrib_vector.push_back(LOSE_CONTEXT_WHEN_OUT_OF_MEMORY);
- attrib_vector.push_back(attribs.lose_context_when_out_of_memory);
- }
- attrib_vector.push_back(NONE);
+ attribs.Serialize(&attrib_vector);
base::Closure wrapped_callback =
base::Bind(&GLInProcessContextImpl::OnContextLost, AsWeakPtr());
@@ -247,15 +190,17 @@ bool GLInProcessContextImpl::Initialize(
// Create a transfer buffer.
transfer_buffer_.reset(new TransferBuffer(gles2_helper_.get()));
- bool bind_generates_resources = false;
+ // Check for consistency.
+ DCHECK(!attribs.bind_generates_resource);
+ bool bind_generates_resource = false;
// Create the object exposing the OpenGL API.
gles2_implementation_.reset(new gles2::GLES2Implementation(
gles2_helper_.get(),
share_group,
transfer_buffer_.get(),
- bind_generates_resources,
- attribs.lose_context_when_out_of_memory > 0,
+ bind_generates_resource,
+ attribs.lose_context_when_out_of_memory,
command_buffer_.get()));
if (use_global_share_group) {
@@ -300,18 +245,6 @@ GLInProcessContextImpl::GetSurfaceTexture(uint32 stream_id) {
} // anonymous namespace
-GLInProcessContextAttribs::GLInProcessContextAttribs()
- : alpha_size(-1),
- blue_size(-1),
- green_size(-1),
- red_size(-1),
- depth_size(-1),
- stencil_size(-1),
- samples(-1),
- sample_buffers(-1),
- fail_if_major_perf_caveat(-1),
- lose_context_when_out_of_memory(-1) {}
-
GLInProcessContext* GLInProcessContext::Create(
scoped_refptr<gpu::InProcessCommandBuffer::Service> service,
scoped_refptr<gfx::GLSurface> surface,
@@ -320,7 +253,7 @@ GLInProcessContext* GLInProcessContext::Create(
const gfx::Size& size,
GLInProcessContext* share_context,
bool use_global_share_group,
- const GLInProcessContextAttribs& attribs,
+ const ::gpu::gles2::ContextCreationAttribHelper& attribs,
gfx::GpuPreference gpu_preference) {
DCHECK(!use_global_share_group || !share_context);
if (surface.get()) {
diff --git a/gpu/command_buffer/client/gl_in_process_context.h b/gpu/command_buffer/client/gl_in_process_context.h
index 6c3a485972..6175cc556a 100644
--- a/gpu/command_buffer/client/gl_in_process_context.h
+++ b/gpu/command_buffer/client/gl_in_process_context.h
@@ -8,6 +8,7 @@
#include "base/callback.h"
#include "base/compiler_specific.h"
#include "gl_in_process_context_export.h"
+#include "gpu/command_buffer/common/gles2_cmd_utils.h"
#include "gpu/command_buffer/service/in_process_command_buffer.h"
#include "ui/gfx/native_widget_types.h"
#include "ui/gl/gl_surface.h"
@@ -29,22 +30,6 @@ namespace gles2 {
class GLES2Implementation;
}
-// The default uninitialized value is -1.
-struct GL_IN_PROCESS_CONTEXT_EXPORT GLInProcessContextAttribs {
- GLInProcessContextAttribs();
-
- int32 alpha_size;
- int32 blue_size;
- int32 green_size;
- int32 red_size;
- int32 depth_size;
- int32 stencil_size;
- int32 samples;
- int32 sample_buffers;
- int32 fail_if_major_perf_caveat;
- int32 lose_context_when_out_of_memory;
-};
-
class GL_IN_PROCESS_CONTEXT_EXPORT GLInProcessContext {
public:
virtual ~GLInProcessContext() {}
@@ -67,7 +52,7 @@ class GL_IN_PROCESS_CONTEXT_EXPORT GLInProcessContext {
const gfx::Size& size,
GLInProcessContext* share_context,
bool use_global_share_group,
- const GLInProcessContextAttribs& attribs,
+ const gpu::gles2::ContextCreationAttribHelper& attribs,
gfx::GpuPreference gpu_preference);
virtual void SetContextLostCallback(const base::Closure& callback) = 0;
diff --git a/gpu/command_buffer/client/gles2_implementation.cc b/gpu/command_buffer/client/gles2_implementation.cc
index cb92e395e9..974fd7541a 100644
--- a/gpu/command_buffer/client/gles2_implementation.cc
+++ b/gpu/command_buffer/client/gles2_implementation.cc
@@ -135,6 +135,7 @@ GLES2Implementation::GLES2Implementation(
share_group_ =
(share_group ? share_group : new ShareGroup(bind_generates_resource));
+ DCHECK(share_group_->bind_generates_resource() == bind_generates_resource);
memset(&reserved_ids_, 0, sizeof(reserved_ids_));
}
diff --git a/gpu/command_buffer/client/gles2_implementation_unittest.cc b/gpu/command_buffer/client/gles2_implementation_unittest.cc
index a318ab8f33..80a2e41613 100644
--- a/gpu/command_buffer/client/gles2_implementation_unittest.cc
+++ b/gpu/command_buffer/client/gles2_implementation_unittest.cc
@@ -393,7 +393,8 @@ class GLES2ImplementationTest : public testing::Test {
TestContext() : commands_(NULL), token_(0) {}
bool Initialize(ShareGroup* share_group,
- bool bind_generates_resource,
+ bool bind_generates_resource_client,
+ bool bind_generates_resource_service,
bool lose_context_when_out_of_memory) {
command_buffer_.reset(new StrictMock<MockClientCommandBuffer>());
if (!command_buffer_->Initialize())
@@ -428,7 +429,7 @@ class GLES2ImplementationTest : public testing::Test {
int_state.num_compressed_texture_formats = kNumCompressedTextureFormats;
int_state.num_shader_binary_formats = kNumShaderBinaryFormats;
int_state.bind_generates_resource_chromium =
- bind_generates_resource ? 1 : 0;
+ bind_generates_resource_service ? 1 : 0;
// This just happens to work for now because IntState has 1 GLint per
// state.
@@ -449,7 +450,7 @@ class GLES2ImplementationTest : public testing::Test {
gl_.reset(new GLES2Implementation(helper_.get(),
share_group,
transfer_buffer_.get(),
- bind_generates_resource,
+ bind_generates_resource_client,
lose_context_when_out_of_memory,
gpu_control_.get()));
@@ -537,12 +538,13 @@ class GLES2ImplementationTest : public testing::Test {
bool Initialize(const ContextInitOptions& init_options) {
bool success = true;
- share_group_ = new ShareGroup(init_options.bind_generates_resource_service);
+ share_group_ = new ShareGroup(init_options.bind_generates_resource_client);
for (int i = 0; i < kNumTestContexts; i++) {
if (!test_contexts_[i].Initialize(
share_group_.get(),
init_options.bind_generates_resource_client,
+ init_options.bind_generates_resource_service,
init_options.lose_context_when_out_of_memory))
success = false;
}
diff --git a/gpu/command_buffer/client/share_group.h b/gpu/command_buffer/client/share_group.h
index 341dd58683..c66704b7fd 100644
--- a/gpu/command_buffer/client/share_group.h
+++ b/gpu/command_buffer/client/share_group.h
@@ -71,8 +71,6 @@ class GLES2_IMPL_EXPORT ShareGroup
return bind_generates_resource_;
}
- bool Initialize();
-
IdHandlerInterface* GetIdHandler(int namespace_id) const {
return id_handlers_[namespace_id].get();
}
diff --git a/gpu/command_buffer/common/gles2_cmd_utils.cc b/gpu/command_buffer/common/gles2_cmd_utils.cc
index 37d10447e3..3b5097cd43 100644
--- a/gpu/command_buffer/common/gles2_cmd_utils.cc
+++ b/gpu/command_buffer/common/gles2_cmd_utils.cc
@@ -784,6 +784,10 @@ bool GLES2Util::ParseUniformName(
namespace {
+// WebGraphicsContext3DCommandBufferImpl configuration attributes. Those in
+// the 16-bit range are the same as used by EGL. Those outside the 16-bit range
+// are unique to Chromium. Attributes are matched using a closest fit algorithm.
+
// From <EGL/egl.h>.
const int32 kAlphaSize = 0x3021; // EGL_ALPHA_SIZE
const int32 kBlueSize = 0x3022; // EGL_BLUE_SIZE
@@ -799,71 +803,67 @@ const int32 kBufferPreserved = 0x3094; // EGL_BUFFER_PRESERVED
const int32 kBufferDestroyed = 0x3095; // EGL_BUFFER_DESTROYED
// Chromium only.
-const int32 kShareResources = 0x10000;
-const int32 kBindGeneratesResource = 0x10001;
-const int32 kFailIfMajorPerfCaveat = 0x10002;
-const int32 kLoseContextWhenOutOfMemory = 0x10003;
+const int32 kBindGeneratesResource = 0x10000;
+const int32 kFailIfMajorPerfCaveat = 0x10001;
+const int32 kLoseContextWhenOutOfMemory = 0x10002;
} // namespace
ContextCreationAttribHelper::ContextCreationAttribHelper()
- : alpha_size_(-1),
- blue_size_(-1),
- green_size_(-1),
- red_size_(-1),
- depth_size_(-1),
- stencil_size_(-1),
- samples_(-1),
- sample_buffers_(-1),
- buffer_preserved_(true),
- share_resources_(false),
- bind_generates_resource_(true),
- fail_if_major_perf_caveat_(false),
- lose_context_when_out_of_memory_(false) {}
-
-void ContextCreationAttribHelper::Serialize(std::vector<int32>* attribs) {
- if (alpha_size_ != -1) {
+ : alpha_size(-1),
+ blue_size(-1),
+ green_size(-1),
+ red_size(-1),
+ depth_size(-1),
+ stencil_size(-1),
+ samples(-1),
+ sample_buffers(-1),
+ buffer_preserved(true),
+ bind_generates_resource(true),
+ fail_if_major_perf_caveat(false),
+ lose_context_when_out_of_memory(false) {}
+
+void ContextCreationAttribHelper::Serialize(std::vector<int32>* attribs) const {
+ if (alpha_size != -1) {
attribs->push_back(kAlphaSize);
- attribs->push_back(alpha_size_);
+ attribs->push_back(alpha_size);
}
- if (blue_size_ != -1) {
+ if (blue_size != -1) {
attribs->push_back(kBlueSize);
- attribs->push_back(blue_size_);
+ attribs->push_back(blue_size);
}
- if (green_size_ != -1) {
+ if (green_size != -1) {
attribs->push_back(kGreenSize);
- attribs->push_back(green_size_);
+ attribs->push_back(green_size);
}
- if (red_size_ != -1) {
+ if (red_size != -1) {
attribs->push_back(kRedSize);
- attribs->push_back(red_size_);
+ attribs->push_back(red_size);
}
- if (depth_size_ != -1) {
+ if (depth_size != -1) {
attribs->push_back(kDepthSize);
- attribs->push_back(depth_size_);
+ attribs->push_back(depth_size);
}
- if (stencil_size_ != -1) {
+ if (stencil_size != -1) {
attribs->push_back(kStencilSize);
- attribs->push_back(stencil_size_);
+ attribs->push_back(stencil_size);
}
- if (samples_ != -1) {
+ if (samples != -1) {
attribs->push_back(kSamples);
- attribs->push_back(samples_);
+ attribs->push_back(samples);
}
- if (sample_buffers_ != -1) {
+ if (sample_buffers != -1) {
attribs->push_back(kSampleBuffers);
- attribs->push_back(sample_buffers_);
+ attribs->push_back(sample_buffers);
}
attribs->push_back(kSwapBehavior);
- attribs->push_back(buffer_preserved_ ? kBufferPreserved : kBufferDestroyed);
- attribs->push_back(kShareResources);
- attribs->push_back(share_resources_ ? 1 : 0);
+ attribs->push_back(buffer_preserved ? kBufferPreserved : kBufferDestroyed);
attribs->push_back(kBindGeneratesResource);
- attribs->push_back(bind_generates_resource_ ? 1 : 0);
+ attribs->push_back(bind_generates_resource ? 1 : 0);
attribs->push_back(kFailIfMajorPerfCaveat);
- attribs->push_back(fail_if_major_perf_caveat_ ? 1 : 0);
+ attribs->push_back(fail_if_major_perf_caveat ? 1 : 0);
attribs->push_back(kLoseContextWhenOutOfMemory);
- attribs->push_back(lose_context_when_out_of_memory_ ? 1 : 0);
+ attribs->push_back(lose_context_when_out_of_memory ? 1 : 0);
attribs->push_back(kNone);
}
@@ -883,43 +883,40 @@ bool ContextCreationAttribHelper::Parse(const std::vector<int32>& attribs) {
const int32 value = attribs[i+1];
switch (attrib) {
case kAlphaSize:
- alpha_size_ = value;
+ alpha_size = value;
break;
case kBlueSize:
- blue_size_ = value;
+ blue_size = value;
break;
case kGreenSize:
- green_size_ = value;
+ green_size = value;
break;
case kRedSize:
- red_size_ = value;
+ red_size = value;
break;
case kDepthSize:
- depth_size_ = value;
+ depth_size = value;
break;
case kStencilSize:
- stencil_size_ = value;
+ stencil_size = value;
break;
case kSamples:
- samples_ = value;
+ samples = value;
break;
case kSampleBuffers:
- sample_buffers_ = value;
+ sample_buffers = value;
break;
case kSwapBehavior:
- buffer_preserved_ = value == kBufferPreserved;
- break;
- case kShareResources:
- share_resources_ = value != 0;
+ buffer_preserved = value == kBufferPreserved;
break;
case kBindGeneratesResource:
- bind_generates_resource_ = value != 0;
+ bind_generates_resource = value != 0;
break;
case kFailIfMajorPerfCaveat:
- fail_if_major_perf_caveat_ = value != 0;
+ fail_if_major_perf_caveat = value != 0;
break;
case kLoseContextWhenOutOfMemory:
- lose_context_when_out_of_memory_ = value != 0;
+ lose_context_when_out_of_memory = value != 0;
break;
case kNone:
// Terminate list, even if more attributes.
diff --git a/gpu/command_buffer/common/gles2_cmd_utils.h b/gpu/command_buffer/common/gles2_cmd_utils.h
index 15f3b57e0a..163ffc008c 100644
--- a/gpu/command_buffer/common/gles2_cmd_utils.h
+++ b/gpu/command_buffer/common/gles2_cmd_utils.h
@@ -196,27 +196,25 @@ class GLES2_UTILS_EXPORT GLES2Util {
int num_shader_binary_formats_;
};
-class GLES2_UTILS_EXPORT ContextCreationAttribHelper {
- public:
+struct GLES2_UTILS_EXPORT ContextCreationAttribHelper {
ContextCreationAttribHelper();
- void Serialize(std::vector<int32_t>* attribs);
+ void Serialize(std::vector<int32_t>* attribs) const;
bool Parse(const std::vector<int32_t>& attribs);
// -1 if invalid or unspecified.
- int32_t alpha_size_;
- int32_t blue_size_;
- int32_t green_size_;
- int32_t red_size_;
- int32_t depth_size_;
- int32_t stencil_size_;
- int32_t samples_;
- int32_t sample_buffers_;
- bool buffer_preserved_;
- bool share_resources_;
- bool bind_generates_resource_;
- bool fail_if_major_perf_caveat_;
- bool lose_context_when_out_of_memory_;
+ int32_t alpha_size;
+ int32_t blue_size;
+ int32_t green_size;
+ int32_t red_size;
+ int32_t depth_size;
+ int32_t stencil_size;
+ int32_t samples;
+ int32_t sample_buffers;
+ bool buffer_preserved;
+ bool bind_generates_resource;
+ bool fail_if_major_perf_caveat;
+ bool lose_context_when_out_of_memory;
};
} // namespace gles2
diff --git a/gpu/command_buffer/gles2_utils.target.darwin-arm.mk b/gpu/command_buffer/gles2_utils.target.darwin-arm.mk
index ae09e02b79..00b0045a71 100644
--- a/gpu/command_buffer/gles2_utils.target.darwin-arm.mk
+++ b/gpu/command_buffer/gles2_utils.target.darwin-arm.mk
@@ -71,7 +71,6 @@ MY_CFLAGS_Debug := \
MY_DEFS_Debug := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
@@ -177,7 +176,6 @@ MY_CFLAGS_Release := \
MY_DEFS_Release := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
diff --git a/gpu/command_buffer/gles2_utils.target.darwin-arm64.mk b/gpu/command_buffer/gles2_utils.target.darwin-arm64.mk
index f9b21d0f98..d6789718ba 100644
--- a/gpu/command_buffer/gles2_utils.target.darwin-arm64.mk
+++ b/gpu/command_buffer/gles2_utils.target.darwin-arm64.mk
@@ -60,7 +60,6 @@ MY_CFLAGS_Debug := \
MY_DEFS_Debug := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
@@ -154,7 +153,6 @@ MY_CFLAGS_Release := \
MY_DEFS_Release := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
diff --git a/gpu/command_buffer/gles2_utils.target.darwin-mips.mk b/gpu/command_buffer/gles2_utils.target.darwin-mips.mk
index 3885518722..3c71bd7449 100644
--- a/gpu/command_buffer/gles2_utils.target.darwin-mips.mk
+++ b/gpu/command_buffer/gles2_utils.target.darwin-mips.mk
@@ -65,7 +65,6 @@ MY_CFLAGS_Debug := \
MY_DEFS_Debug := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
@@ -165,7 +164,6 @@ MY_CFLAGS_Release := \
MY_DEFS_Release := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
diff --git a/gpu/command_buffer/gles2_utils.target.darwin-x86.mk b/gpu/command_buffer/gles2_utils.target.darwin-x86.mk
index ebbcabb188..c1abf78b2f 100644
--- a/gpu/command_buffer/gles2_utils.target.darwin-x86.mk
+++ b/gpu/command_buffer/gles2_utils.target.darwin-x86.mk
@@ -66,7 +66,6 @@ MY_CFLAGS_Debug := \
MY_DEFS_Debug := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
@@ -166,7 +165,6 @@ MY_CFLAGS_Release := \
MY_DEFS_Release := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
diff --git a/gpu/command_buffer/gles2_utils.target.darwin-x86_64.mk b/gpu/command_buffer/gles2_utils.target.darwin-x86_64.mk
index 62e845d851..68d336f09c 100644
--- a/gpu/command_buffer/gles2_utils.target.darwin-x86_64.mk
+++ b/gpu/command_buffer/gles2_utils.target.darwin-x86_64.mk
@@ -65,7 +65,6 @@ MY_CFLAGS_Debug := \
MY_DEFS_Debug := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
@@ -164,7 +163,6 @@ MY_CFLAGS_Release := \
MY_DEFS_Release := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
diff --git a/gpu/command_buffer/gles2_utils.target.linux-arm.mk b/gpu/command_buffer/gles2_utils.target.linux-arm.mk
index ae09e02b79..00b0045a71 100644
--- a/gpu/command_buffer/gles2_utils.target.linux-arm.mk
+++ b/gpu/command_buffer/gles2_utils.target.linux-arm.mk
@@ -71,7 +71,6 @@ MY_CFLAGS_Debug := \
MY_DEFS_Debug := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
@@ -177,7 +176,6 @@ MY_CFLAGS_Release := \
MY_DEFS_Release := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
diff --git a/gpu/command_buffer/gles2_utils.target.linux-arm64.mk b/gpu/command_buffer/gles2_utils.target.linux-arm64.mk
index f9b21d0f98..d6789718ba 100644
--- a/gpu/command_buffer/gles2_utils.target.linux-arm64.mk
+++ b/gpu/command_buffer/gles2_utils.target.linux-arm64.mk
@@ -60,7 +60,6 @@ MY_CFLAGS_Debug := \
MY_DEFS_Debug := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
@@ -154,7 +153,6 @@ MY_CFLAGS_Release := \
MY_DEFS_Release := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
diff --git a/gpu/command_buffer/gles2_utils.target.linux-mips.mk b/gpu/command_buffer/gles2_utils.target.linux-mips.mk
index 3885518722..3c71bd7449 100644
--- a/gpu/command_buffer/gles2_utils.target.linux-mips.mk
+++ b/gpu/command_buffer/gles2_utils.target.linux-mips.mk
@@ -65,7 +65,6 @@ MY_CFLAGS_Debug := \
MY_DEFS_Debug := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
@@ -165,7 +164,6 @@ MY_CFLAGS_Release := \
MY_DEFS_Release := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
diff --git a/gpu/command_buffer/gles2_utils.target.linux-x86.mk b/gpu/command_buffer/gles2_utils.target.linux-x86.mk
index ebbcabb188..c1abf78b2f 100644
--- a/gpu/command_buffer/gles2_utils.target.linux-x86.mk
+++ b/gpu/command_buffer/gles2_utils.target.linux-x86.mk
@@ -66,7 +66,6 @@ MY_CFLAGS_Debug := \
MY_DEFS_Debug := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
@@ -166,7 +165,6 @@ MY_CFLAGS_Release := \
MY_DEFS_Release := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
diff --git a/gpu/command_buffer/gles2_utils.target.linux-x86_64.mk b/gpu/command_buffer/gles2_utils.target.linux-x86_64.mk
index 62e845d851..68d336f09c 100644
--- a/gpu/command_buffer/gles2_utils.target.linux-x86_64.mk
+++ b/gpu/command_buffer/gles2_utils.target.linux-x86_64.mk
@@ -65,7 +65,6 @@ MY_CFLAGS_Debug := \
MY_DEFS_Debug := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
@@ -164,7 +163,6 @@ MY_CFLAGS_Release := \
MY_DEFS_Release := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
diff --git a/gpu/command_buffer/service/async_pixel_transfer_manager_android.cc b/gpu/command_buffer/service/async_pixel_transfer_manager_android.cc
index 618bd0e953..ba1ad2e419 100644
--- a/gpu/command_buffer/service/async_pixel_transfer_manager_android.cc
+++ b/gpu/command_buffer/service/async_pixel_transfer_manager_android.cc
@@ -10,7 +10,6 @@
#include "gpu/command_buffer/service/async_pixel_transfer_manager_idle.h"
#include "gpu/command_buffer/service/async_pixel_transfer_manager_stub.h"
#include "gpu/command_buffer/service/async_pixel_transfer_manager_sync.h"
-#include "gpu/command_buffer/service/mailbox_synchronizer.h"
#include "ui/gl/gl_context.h"
#include "ui/gl/gl_implementation.h"
@@ -64,8 +63,7 @@ AsyncPixelTransferManager* AsyncPixelTransferManager::Create(
!IsBroadcom() &&
!IsImagination() &&
!IsNvidia31() &&
- !base::SysInfo::IsLowEndDevice() &&
- !gles2::MailboxSynchronizer::GetInstance()) {
+ !base::SysInfo::IsLowEndDevice()) {
return new AsyncPixelTransferManagerEGL;
}
return new AsyncPixelTransferManagerIdle;
diff --git a/gpu/command_buffer/service/feature_info.cc b/gpu/command_buffer/service/feature_info.cc
index b3f1b935ac..e58e6c21fc 100644
--- a/gpu/command_buffer/service/feature_info.cc
+++ b/gpu/command_buffer/service/feature_info.cc
@@ -239,7 +239,7 @@ void FeatureInfo::InitializeFeatures() {
const char* version_str =
reinterpret_cast<const char*>(glGetString(GL_VERSION));
if (version_str) {
- std::string lstr(StringToLowerASCII(std::string(version_str)));
+ std::string lstr(base::StringToLowerASCII(std::string(version_str)));
is_es3 = (lstr.substr(0, 12) == "opengl es 3.");
}
diff --git a/gpu/command_buffer/service/gles2_cmd_copy_texture_chromium.cc b/gpu/command_buffer/service/gles2_cmd_copy_texture_chromium.cc
index bda65ac6a6..f98ca2e242 100644
--- a/gpu/command_buffer/service/gles2_cmd_copy_texture_chromium.cc
+++ b/gpu/command_buffer/service/gles2_cmd_copy_texture_chromium.cc
@@ -167,7 +167,7 @@ FragmentShaderId GetFragmentShaderId(bool premultiply_alpha,
}
NOTREACHED();
- return shader_ids[index][SAMPLER_2D];
+ return shader_ids[0][SAMPLER_2D];
}
void CompileShader(GLuint shader, const char* shader_source) {
@@ -186,6 +186,68 @@ void DeleteShader(GLuint shader) {
glDeleteShader(shader);
}
+bool BindFramebufferTexture2D(GLenum target,
+ GLuint texture_id,
+ GLint level,
+ GLuint framebuffer) {
+ DCHECK(target == GL_TEXTURE_2D || target == GL_TEXTURE_RECTANGLE_ARB);
+ glActiveTexture(GL_TEXTURE0);
+ glBindTexture(target, texture_id);
+ // NVidia drivers require texture settings to be a certain way
+ // or they won't report FRAMEBUFFER_COMPLETE.
+ glTexParameterf(target, GL_TEXTURE_WRAP_S, GL_CLAMP_TO_EDGE);
+ glTexParameterf(target, GL_TEXTURE_WRAP_T, GL_CLAMP_TO_EDGE);
+ glTexParameteri(target, GL_TEXTURE_MAG_FILTER, GL_NEAREST);
+ glTexParameteri(target, GL_TEXTURE_MIN_FILTER, GL_NEAREST);
+ glBindFramebufferEXT(GL_FRAMEBUFFER_EXT, framebuffer);
+ glFramebufferTexture2DEXT(
+ GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, target, texture_id, level);
+
+#ifndef NDEBUG
+ GLenum fb_status = glCheckFramebufferStatusEXT(GL_FRAMEBUFFER);
+ if (GL_FRAMEBUFFER_COMPLETE != fb_status) {
+ DLOG(ERROR) << "CopyTextureCHROMIUM: Incomplete framebuffer.";
+ return false;
+ }
+#endif
+ return true;
+}
+
+void DoCopyTexImage2D(const gpu::gles2::GLES2Decoder* decoder,
+ GLenum source_target,
+ GLuint source_id,
+ GLuint dest_id,
+ GLint dest_level,
+ GLenum dest_internal_format,
+ GLsizei width,
+ GLsizei height,
+ GLuint framebuffer) {
+ DCHECK(source_target == GL_TEXTURE_2D ||
+ source_target == GL_TEXTURE_RECTANGLE_ARB);
+ if (BindFramebufferTexture2D(
+ source_target, source_id, 0 /* level */, framebuffer)) {
+ glBindTexture(GL_TEXTURE_2D, dest_id);
+ glTexParameterf(GL_TEXTURE_2D, GL_TEXTURE_WRAP_S, GL_CLAMP_TO_EDGE);
+ glTexParameterf(GL_TEXTURE_2D, GL_TEXTURE_WRAP_T, GL_CLAMP_TO_EDGE);
+ glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MAG_FILTER, GL_NEAREST);
+ glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MIN_FILTER, GL_NEAREST);
+ glCopyTexImage2D(GL_TEXTURE_2D,
+ dest_level,
+ dest_internal_format,
+ 0 /* x */,
+ 0 /* y */,
+ width,
+ height,
+ 0 /* border */);
+ }
+
+ decoder->RestoreTextureState(source_id);
+ decoder->RestoreTextureState(dest_id);
+ decoder->RestoreTextureUnitBindings(0);
+ decoder->RestoreActiveTexture();
+ decoder->RestoreFramebufferBindings();
+}
+
} // namespace
namespace gpu {
@@ -197,13 +259,19 @@ CopyTextureCHROMIUMResourceManager::CopyTextureCHROMIUMResourceManager()
buffer_id_(0u),
framebuffer_(0u) {}
-CopyTextureCHROMIUMResourceManager::~CopyTextureCHROMIUMResourceManager() {}
+CopyTextureCHROMIUMResourceManager::~CopyTextureCHROMIUMResourceManager() {
+ DCHECK(!buffer_id_);
+ DCHECK(!framebuffer_);
+}
void CopyTextureCHROMIUMResourceManager::Initialize(
const gles2::GLES2Decoder* decoder) {
COMPILE_ASSERT(
kVertexPositionAttrib == 0u,
Position_attribs_must_be_0);
+ DCHECK(!buffer_id_);
+ DCHECK(!framebuffer_);
+ DCHECK(programs_.empty());
// Initialize all of the GPU resources required to perform the copy.
glGenBuffersARB(1, &buffer_id_);
@@ -227,6 +295,7 @@ void CopyTextureCHROMIUMResourceManager::Destroy() {
return;
glDeleteFramebuffersEXT(1, &framebuffer_);
+ framebuffer_ = 0;
std::for_each(vertex_shaders_.begin(), vertex_shaders_.end(), DeleteShader);
std::for_each(
@@ -239,37 +308,70 @@ void CopyTextureCHROMIUMResourceManager::Destroy() {
}
glDeleteBuffersARB(1, &buffer_id_);
+ buffer_id_ = 0;
}
void CopyTextureCHROMIUMResourceManager::DoCopyTexture(
const gles2::GLES2Decoder* decoder,
GLenum source_target,
- GLenum dest_target,
GLuint source_id,
+ GLenum source_internal_format,
GLuint dest_id,
- GLint level,
+ GLint dest_level,
+ GLenum dest_internal_format,
GLsizei width,
GLsizei height,
bool flip_y,
bool premultiply_alpha,
bool unpremultiply_alpha) {
+ bool premultiply_alpha_change = premultiply_alpha ^ unpremultiply_alpha;
+ // GL_INVALID_OPERATION is generated if the currently bound framebuffer's
+ // format does not contain a superset of the components required by the base
+ // format of internalformat.
+ // https://www.khronos.org/opengles/sdk/docs/man/xhtml/glCopyTexImage2D.xml
+ bool source_format_contain_superset_of_dest_format =
+ source_internal_format == dest_internal_format ||
+ (source_internal_format == GL_RGBA && dest_internal_format == GL_RGB);
+ // GL_TEXTURE_RECTANGLE_ARB on FBO is supported by OpenGL, not GLES2,
+ // so restrict this to GL_TEXTURE_2D.
+ if (source_target == GL_TEXTURE_2D && !flip_y && !premultiply_alpha_change &&
+ source_format_contain_superset_of_dest_format) {
+ DoCopyTexImage2D(decoder,
+ source_target,
+ source_id,
+ dest_id,
+ dest_level,
+ dest_internal_format,
+ width,
+ height,
+ framebuffer_);
+ return;
+ }
+
// Use default transform matrix if no transform passed in.
const static GLfloat default_matrix[16] = {1.0f, 0.0f, 0.0f, 0.0f,
0.0f, 1.0f, 0.0f, 0.0f,
0.0f, 0.0f, 1.0f, 0.0f,
0.0f, 0.0f, 0.0f, 1.0f};
- DoCopyTextureWithTransform(decoder, source_target, dest_target, source_id,
- dest_id, level, width, height, flip_y, premultiply_alpha,
- unpremultiply_alpha, default_matrix);
+ DoCopyTextureWithTransform(decoder,
+ source_target,
+ source_id,
+ dest_id,
+ dest_level,
+ width,
+ height,
+ flip_y,
+ premultiply_alpha,
+ unpremultiply_alpha,
+ default_matrix);
}
void CopyTextureCHROMIUMResourceManager::DoCopyTextureWithTransform(
const gles2::GLES2Decoder* decoder,
GLenum source_target,
- GLenum dest_target,
GLuint source_id,
GLuint dest_id,
- GLint level,
+ GLint dest_level,
GLsizei width,
GLsizei height,
bool flip_y,
@@ -286,27 +388,27 @@ void CopyTextureCHROMIUMResourceManager::DoCopyTextureWithTransform(
VertexShaderId vertex_shader_id = GetVertexShaderId(flip_y);
DCHECK_LT(static_cast<size_t>(vertex_shader_id), vertex_shaders_.size());
- GLuint* vertex_shader = &vertex_shaders_[vertex_shader_id];
- if (!*vertex_shader) {
- *vertex_shader = glCreateShader(GL_VERTEX_SHADER);
- CompileShader(*vertex_shader, vertex_shader_source[vertex_shader_id]);
- }
-
FragmentShaderId fragment_shader_id = GetFragmentShaderId(
premultiply_alpha, unpremultiply_alpha, source_target);
DCHECK_LT(static_cast<size_t>(fragment_shader_id), fragment_shaders_.size());
- GLuint* fragment_shader = &fragment_shaders_[fragment_shader_id];
- if (!*fragment_shader) {
- *fragment_shader = glCreateShader(GL_FRAGMENT_SHADER);
- CompileShader(*fragment_shader, fragment_shader_source[fragment_shader_id]);
- }
ProgramMapKey key(vertex_shader_id, fragment_shader_id);
ProgramInfo* info = &programs_[key];
// Create program if necessary.
if (!info->program) {
info->program = glCreateProgram();
+ GLuint* vertex_shader = &vertex_shaders_[vertex_shader_id];
+ if (!*vertex_shader) {
+ *vertex_shader = glCreateShader(GL_VERTEX_SHADER);
+ CompileShader(*vertex_shader, vertex_shader_source[vertex_shader_id]);
+ }
glAttachShader(info->program, *vertex_shader);
+ GLuint* fragment_shader = &fragment_shaders_[fragment_shader_id];
+ if (!*fragment_shader) {
+ *fragment_shader = glCreateShader(GL_FRAGMENT_SHADER);
+ CompileShader(*fragment_shader,
+ fragment_shader_source[fragment_shader_id]);
+ }
glAttachShader(info->program, *fragment_shader);
glBindAttribLocation(info->program, kVertexPositionAttrib, "a_position");
glLinkProgram(info->program);
@@ -337,25 +439,9 @@ void CopyTextureCHROMIUMResourceManager::DoCopyTextureWithTransform(
glUniform2f(info->half_size_handle, width / 2.0f, height / 2.0f);
else
glUniform2f(info->half_size_handle, 0.5f, 0.5f);
- glActiveTexture(GL_TEXTURE0);
- glBindTexture(GL_TEXTURE_2D, dest_id);
- // NVidia drivers require texture settings to be a certain way
- // or they won't report FRAMEBUFFER_COMPLETE.
- glTexParameterf(GL_TEXTURE_2D, GL_TEXTURE_WRAP_S, GL_CLAMP_TO_EDGE);
- glTexParameterf(GL_TEXTURE_2D, GL_TEXTURE_WRAP_T, GL_CLAMP_TO_EDGE);
- glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MAG_FILTER, GL_NEAREST);
- glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MIN_FILTER, GL_NEAREST);
- glBindFramebufferEXT(GL_FRAMEBUFFER_EXT, framebuffer_);
- glFramebufferTexture2DEXT(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, dest_target,
- dest_id, level);
-#ifndef NDEBUG
- GLenum fb_status = glCheckFramebufferStatusEXT(GL_FRAMEBUFFER);
- if (GL_FRAMEBUFFER_COMPLETE != fb_status) {
- DLOG(ERROR) << "CopyTextureCHROMIUM: Incomplete framebuffer.";
- } else
-#endif
- {
+ if (BindFramebufferTexture2D(
+ GL_TEXTURE_2D, dest_id, dest_level, framebuffer_)) {
decoder->ClearAllAttributes();
glEnableVertexAttribArray(kVertexPositionAttrib);
diff --git a/gpu/command_buffer/service/gles2_cmd_copy_texture_chromium.h b/gpu/command_buffer/service/gles2_cmd_copy_texture_chromium.h
index 17290f8ed2..083fc4c857 100644
--- a/gpu/command_buffer/service/gles2_cmd_copy_texture_chromium.h
+++ b/gpu/command_buffer/service/gles2_cmd_copy_texture_chromium.h
@@ -20,7 +20,8 @@ class GLES2Decoder;
// This class encapsulates the resources required to implement the
// GL_CHROMIUM_copy_texture extension. The copy operation is performed
-// via a blit to a framebuffer object.
+// via glCopyTexImage2D() or a blit to a framebuffer object.
+// The target of |dest_id| texture must be GL_TEXTURE_2D.
class GPU_EXPORT CopyTextureCHROMIUMResourceManager {
public:
CopyTextureCHROMIUMResourceManager();
@@ -29,18 +30,29 @@ class GPU_EXPORT CopyTextureCHROMIUMResourceManager {
void Initialize(const gles2::GLES2Decoder* decoder);
void Destroy();
- void DoCopyTexture(const gles2::GLES2Decoder* decoder, GLenum source_target,
- GLenum dest_target, GLuint source_id, GLuint dest_id,
- GLint level, GLsizei width, GLsizei height,
- bool flip_y, bool premultiply_alpha,
+ void DoCopyTexture(const gles2::GLES2Decoder* decoder,
+ GLenum source_target,
+ GLuint source_id,
+ GLenum source_internal_format,
+ GLuint dest_id,
+ GLint dest_level,
+ GLenum dest_internal_format,
+ GLsizei width,
+ GLsizei height,
+ bool flip_y,
+ bool premultiply_alpha,
bool unpremultiply_alpha);
// This will apply a transform on the source texture before copying to
// destination texture.
void DoCopyTextureWithTransform(const gles2::GLES2Decoder* decoder,
- GLenum source_target, GLenum dest_target,
- GLuint source_id, GLuint dest_id, GLint level,
- GLsizei width, GLsizei height, bool flip_y,
+ GLenum source_target,
+ GLuint source_id,
+ GLuint dest_id,
+ GLint dest_level,
+ GLsizei width,
+ GLsizei height,
+ bool flip_y,
bool premultiply_alpha,
bool unpremultiply_alpha,
const GLfloat transform_matrix[16]);
diff --git a/gpu/command_buffer/service/gles2_cmd_decoder.cc b/gpu/command_buffer/service/gles2_cmd_decoder.cc
index 7e5f942236..7513ff2b19 100644
--- a/gpu/command_buffer/service/gles2_cmd_decoder.cc
+++ b/gpu/command_buffer/service/gles2_cmd_decoder.cc
@@ -19,6 +19,7 @@
#include "base/command_line.h"
#include "base/debug/trace_event.h"
#include "base/debug/trace_event_synthetic_delay.h"
+#include "base/float_util.h"
#include "base/memory/scoped_ptr.h"
#include "base/numerics/safe_math.h"
#include "base/strings/string_number_conversions.h"
@@ -2374,11 +2375,11 @@ bool GLES2DecoderImpl::Initialize(
// Save the loseContextWhenOutOfMemory context creation attribute.
lose_context_when_out_of_memory_ =
- attrib_parser.lose_context_when_out_of_memory_;
+ attrib_parser.lose_context_when_out_of_memory;
// If the failIfMajorPerformanceCaveat context creation attribute was true
// and we are using a software renderer, fail.
- if (attrib_parser.fail_if_major_perf_caveat_ &&
+ if (attrib_parser.fail_if_major_perf_caveat &&
feature_info_->feature_flags().is_swiftshader) {
group_ = NULL; // Must not destroy ContextGroup if it is not initialized.
Destroy(true);
@@ -2461,19 +2462,19 @@ bool GLES2DecoderImpl::Initialize(
CHECK_GL_ERROR();
if (offscreen) {
- if (attrib_parser.samples_ > 0 && attrib_parser.sample_buffers_ > 0 &&
+ if (attrib_parser.samples > 0 && attrib_parser.sample_buffers > 0 &&
features().chromium_framebuffer_multisample) {
// Per ext_framebuffer_multisample spec, need max bound on sample count.
// max_sample_count must be initialized to a sane value. If
// glGetIntegerv() throws a GL error, it leaves its argument unchanged.
GLint max_sample_count = 1;
glGetIntegerv(GL_MAX_SAMPLES_EXT, &max_sample_count);
- offscreen_target_samples_ = std::min(attrib_parser.samples_,
+ offscreen_target_samples_ = std::min(attrib_parser.samples,
max_sample_count);
} else {
offscreen_target_samples_ = 1;
}
- offscreen_target_buffer_preserved_ = attrib_parser.buffer_preserved_;
+ offscreen_target_buffer_preserved_ = attrib_parser.buffer_preserved;
if (gfx::GetGLImplementation() == gfx::kGLImplementationEGLGLES2) {
const bool rgb8_supported =
@@ -2482,11 +2483,11 @@ bool GLES2DecoderImpl::Initialize(
// little precision. Don't enable multisampling unless 8-bit render
// buffer formats are available--instead fall back to 8-bit textures.
if (rgb8_supported && offscreen_target_samples_ > 1) {
- offscreen_target_color_format_ = attrib_parser.alpha_size_ > 0 ?
+ offscreen_target_color_format_ = attrib_parser.alpha_size > 0 ?
GL_RGBA8 : GL_RGB8;
} else {
offscreen_target_samples_ = 1;
- offscreen_target_color_format_ = attrib_parser.alpha_size_ > 0 ?
+ offscreen_target_color_format_ = attrib_parser.alpha_size > 0 ?
GL_RGBA : GL_RGB;
}
@@ -2496,20 +2497,20 @@ bool GLES2DecoderImpl::Initialize(
feature_info_->feature_flags().packed_depth24_stencil8;
VLOG(1) << "GL_OES_packed_depth_stencil "
<< (depth24_stencil8_supported ? "" : "not ") << "supported.";
- if ((attrib_parser.depth_size_ > 0 || attrib_parser.stencil_size_ > 0) &&
+ if ((attrib_parser.depth_size > 0 || attrib_parser.stencil_size > 0) &&
depth24_stencil8_supported) {
offscreen_target_depth_format_ = GL_DEPTH24_STENCIL8;
offscreen_target_stencil_format_ = 0;
} else {
// It may be the case that this depth/stencil combination is not
// supported, but this will be checked later by CheckFramebufferStatus.
- offscreen_target_depth_format_ = attrib_parser.depth_size_ > 0 ?
+ offscreen_target_depth_format_ = attrib_parser.depth_size > 0 ?
GL_DEPTH_COMPONENT16 : 0;
- offscreen_target_stencil_format_ = attrib_parser.stencil_size_ > 0 ?
+ offscreen_target_stencil_format_ = attrib_parser.stencil_size > 0 ?
GL_STENCIL_INDEX8 : 0;
}
} else {
- offscreen_target_color_format_ = attrib_parser.alpha_size_ > 0 ?
+ offscreen_target_color_format_ = attrib_parser.alpha_size > 0 ?
GL_RGBA : GL_RGB;
// If depth is requested at all, use the packed depth stencil format if
@@ -2520,19 +2521,19 @@ bool GLES2DecoderImpl::Initialize(
VLOG(1) << "GL_EXT_packed_depth_stencil "
<< (depth24_stencil8_supported ? "" : "not ") << "supported.";
- if ((attrib_parser.depth_size_ > 0 || attrib_parser.stencil_size_ > 0) &&
+ if ((attrib_parser.depth_size > 0 || attrib_parser.stencil_size > 0) &&
depth24_stencil8_supported) {
offscreen_target_depth_format_ = GL_DEPTH24_STENCIL8;
offscreen_target_stencil_format_ = 0;
} else {
- offscreen_target_depth_format_ = attrib_parser.depth_size_ > 0 ?
+ offscreen_target_depth_format_ = attrib_parser.depth_size > 0 ?
GL_DEPTH_COMPONENT : 0;
- offscreen_target_stencil_format_ = attrib_parser.stencil_size_ > 0 ?
+ offscreen_target_stencil_format_ = attrib_parser.stencil_size > 0 ?
GL_STENCIL_INDEX : 0;
}
}
- offscreen_saved_color_format_ = attrib_parser.alpha_size_ > 0 ?
+ offscreen_saved_color_format_ = attrib_parser.alpha_size > 0 ?
GL_RGBA : GL_RGB;
// Create the target frame buffer. This is the one that the client renders
@@ -2608,11 +2609,11 @@ bool GLES2DecoderImpl::Initialize(
// user requested RGB then RGB. If the user did not specify a preference
// than use whatever we were given. Same for DEPTH and STENCIL.
back_buffer_color_format_ =
- (attrib_parser.alpha_size_ != 0 && v > 0) ? GL_RGBA : GL_RGB;
+ (attrib_parser.alpha_size != 0 && v > 0) ? GL_RGBA : GL_RGB;
glGetIntegerv(GL_DEPTH_BITS, &v);
- back_buffer_has_depth_ = attrib_parser.depth_size_ != 0 && v > 0;
+ back_buffer_has_depth_ = attrib_parser.depth_size != 0 && v > 0;
glGetIntegerv(GL_STENCIL_BITS, &v);
- back_buffer_has_stencil_ = attrib_parser.stencil_size_ != 0 && v > 0;
+ back_buffer_has_stencil_ = attrib_parser.stencil_size != 0 && v > 0;
}
// OpenGL ES 2.0 implicitly enables the desktop GL capability
@@ -5085,7 +5086,8 @@ void GLES2DecoderImpl::ClearUnclearedAttachments(
1.0f);
state_.SetDeviceColorMask(GL_TRUE, GL_TRUE, GL_TRUE, GL_TRUE);
clear_bits |= GL_COLOR_BUFFER_BIT;
- framebuffer->PrepareDrawBuffersForClear();
+ if (feature_info_->feature_flags().ext_draw_buffers)
+ framebuffer->PrepareDrawBuffersForClear();
}
if (framebuffer->HasUnclearedAttachment(GL_STENCIL_ATTACHMENT) ||
@@ -5106,7 +5108,8 @@ void GLES2DecoderImpl::ClearUnclearedAttachments(
state_.SetDeviceCapabilityState(GL_SCISSOR_TEST, false);
glClear(clear_bits);
- if ((clear_bits | GL_COLOR_BUFFER_BIT) != 0)
+ if ((clear_bits | GL_COLOR_BUFFER_BIT) != 0 &&
+ feature_info_->feature_flags().ext_draw_buffers)
framebuffer->RestoreDrawBuffersAfterClear();
framebuffer_manager()->MarkAttachmentsAsCleared(
@@ -10053,6 +10056,11 @@ void GLES2DecoderImpl::DoCopyTextureCHROMIUM(
return;
}
+ GLenum source_type = 0;
+ GLenum source_internal_format = 0;
+ source_texture->GetLevelType(
+ source_texture->target(), 0, &source_type, &source_internal_format);
+
GLenum dest_type_previous = dest_type;
GLenum dest_internal_format = internal_format;
bool dest_level_defined = dest_texture->GetLevelSize(
@@ -10063,6 +10071,20 @@ void GLES2DecoderImpl::DoCopyTextureCHROMIUM(
&dest_internal_format);
}
+ // The destination format should be GL_ALPHA, GL_RGB, GL_RGBA, GL_LUMINANCE,
+ // or GL_LUMINANCE_ALPHA.
+ bool valid_dest_format = dest_internal_format >= GL_ALPHA &&
+ dest_internal_format <= GL_LUMINANCE_ALPHA;
+ // The source format can be GL_BGRA_EXT.
+ bool valid_source_format = (source_internal_format >= GL_ALPHA &&
+ source_internal_format <= GL_LUMINANCE_ALPHA) ||
+ source_internal_format == GL_BGRA_EXT;
+ if (!valid_source_format || !valid_dest_format) {
+ LOCAL_SET_GL_ERROR(
+ GL_INVALID_VALUE, "glCopyTextureCHROMIUM", "invalid internal format");
+ return;
+ }
+
// Resize the destination texture to the dimensions of the source texture.
if (!dest_level_defined || dest_width != source_width ||
dest_height != source_height ||
@@ -10103,25 +10125,28 @@ void GLES2DecoderImpl::DoCopyTextureCHROMIUM(
copy_texture_CHROMIUM_->DoCopyTextureWithTransform(
this,
source_texture->target(),
- dest_texture->target(),
source_texture->service_id(),
- dest_texture->service_id(), level,
- source_width, source_height,
+ dest_texture->service_id(),
+ level,
+ source_width,
+ source_height,
unpack_flip_y_,
unpack_premultiply_alpha_,
unpack_unpremultiply_alpha_,
default_matrix);
} else {
- copy_texture_CHROMIUM_->DoCopyTexture(
- this,
- source_texture->target(),
- dest_texture->target(),
- source_texture->service_id(),
- dest_texture->service_id(), level,
- source_width, source_height,
- unpack_flip_y_,
- unpack_premultiply_alpha_,
- unpack_unpremultiply_alpha_);
+ copy_texture_CHROMIUM_->DoCopyTexture(this,
+ source_texture->target(),
+ source_texture->service_id(),
+ source_internal_format,
+ dest_texture->service_id(),
+ level,
+ internal_format,
+ source_width,
+ source_height,
+ unpack_flip_y_,
+ unpack_premultiply_alpha_,
+ unpack_unpremultiply_alpha_);
}
DoDidUseTexImageIfNeeded(source_texture, source_texture->target());
diff --git a/gpu/command_buffer/service/gles2_cmd_decoder_autogen.h b/gpu/command_buffer/service/gles2_cmd_decoder_autogen.h
index 8011ab1999..b35899cfbc 100644
--- a/gpu/command_buffer/service/gles2_cmd_decoder_autogen.h
+++ b/gpu/command_buffer/service/gles2_cmd_decoder_autogen.h
@@ -1360,7 +1360,7 @@ error::Error GLES2DecoderImpl::HandleLineWidth(
uint32_t immediate_data_size,
const gles2::cmds::LineWidth& c) {
GLfloat width = static_cast<GLfloat>(c.width);
- if (width <= 0.0f) {
+ if (width <= 0.0f || base::IsNaN(width)) {
LOCAL_SET_GL_ERROR(GL_INVALID_VALUE, "LineWidth", "width out of range");
return error::kNoError;
}
diff --git a/gpu/command_buffer/service/gles2_cmd_decoder_unittest_1_autogen.h b/gpu/command_buffer/service/gles2_cmd_decoder_unittest_1_autogen.h
index 32e20d8272..b60bd3e4aa 100644
--- a/gpu/command_buffer/service/gles2_cmd_decoder_unittest_1_autogen.h
+++ b/gpu/command_buffer/service/gles2_cmd_decoder_unittest_1_autogen.h
@@ -1887,6 +1887,14 @@ TEST_P(GLES2DecoderTest1, LineWidthInvalidValue0_0) {
EXPECT_EQ(GL_INVALID_VALUE, GetGLError());
}
+TEST_P(GLES2DecoderTest1, LineWidthNaNValue0) {
+ SpecializedSetup<cmds::LineWidth, 0>(false);
+ cmds::LineWidth cmd;
+ cmd.Init(nanf(""));
+ EXPECT_EQ(error::kNoError, ExecuteCmd(cmd));
+ EXPECT_EQ(GL_INVALID_VALUE, GetGLError());
+}
+
TEST_P(GLES2DecoderTest1, LinkProgramValidArgs) {
EXPECT_CALL(*gl_, LinkProgram(kServiceProgramId));
SpecializedSetup<cmds::LinkProgram, 0>(true);
diff --git a/gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc b/gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc
index 491749cce2..ab7d6c0f02 100644
--- a/gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc
+++ b/gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc
@@ -353,7 +353,7 @@ void GLES2DecoderTestBase::InitDecoderWithCommandLine(
shared_memory_id_ = kSharedMemoryId;
shared_memory_base_ = buffer->memory();
- static const int32 kLoseContextWhenOutOfMemory = 0x10003;
+ static const int32 kLoseContextWhenOutOfMemory = 0x10002;
int32 attributes[] = {
EGL_ALPHA_SIZE,
diff --git a/gpu/command_buffer/service/in_process_command_buffer.cc b/gpu/command_buffer/service/in_process_command_buffer.cc
index 4a3def924a..6aa7cfbfc8 100644
--- a/gpu/command_buffer/service/in_process_command_buffer.cc
+++ b/gpu/command_buffer/service/in_process_command_buffer.cc
@@ -206,6 +206,7 @@ InProcessCommandBuffer::GetDefaultService() {
InProcessCommandBuffer::InProcessCommandBuffer(
const scoped_refptr<Service>& service)
: context_lost_(false),
+ idle_work_pending_(false),
last_put_offset_(-1),
flush_event_(false, false),
service_(service.get() ? service : GetDefaultService()),
@@ -505,23 +506,30 @@ void InProcessCommandBuffer::FlushOnGpuThread(int32 put_offset) {
// pump idle work until the query is passed.
if (put_offset == state_after_last_flush_.get_offset &&
gpu_scheduler_->HasMoreWork()) {
- service_->ScheduleIdleWork(
- base::Bind(&InProcessCommandBuffer::ScheduleMoreIdleWork,
- gpu_thread_weak_ptr_));
+ ScheduleIdleWorkOnGpuThread();
}
}
-void InProcessCommandBuffer::ScheduleMoreIdleWork() {
+void InProcessCommandBuffer::PerformIdleWork() {
CheckSequencedThread();
+ idle_work_pending_ = false;
base::AutoLock lock(command_buffer_lock_);
if (gpu_scheduler_->HasMoreWork()) {
gpu_scheduler_->PerformIdleWork();
- service_->ScheduleIdleWork(
- base::Bind(&InProcessCommandBuffer::ScheduleMoreIdleWork,
- gpu_thread_weak_ptr_));
+ ScheduleIdleWorkOnGpuThread();
}
}
+void InProcessCommandBuffer::ScheduleIdleWorkOnGpuThread() {
+ CheckSequencedThread();
+ if (idle_work_pending_)
+ return;
+ idle_work_pending_ = true;
+ service_->ScheduleIdleWork(
+ base::Bind(&InProcessCommandBuffer::PerformIdleWork,
+ gpu_thread_weak_ptr_));
+}
+
void InProcessCommandBuffer::Flush(int32 put_offset) {
CheckSequencedThread();
if (last_state_.error != gpu::error::kNoError)
diff --git a/gpu/command_buffer/service/in_process_command_buffer.h b/gpu/command_buffer/service/in_process_command_buffer.h
index 7fece0eccb..531d0ef688 100644
--- a/gpu/command_buffer/service/in_process_command_buffer.h
+++ b/gpu/command_buffer/service/in_process_command_buffer.h
@@ -189,6 +189,7 @@ class GPU_EXPORT InProcessCommandBuffer : public CommandBuffer,
bool InitializeOnGpuThread(const InitializeOnGpuThreadParams& params);
bool DestroyOnGpuThread();
void FlushOnGpuThread(int32 put_offset);
+ void ScheduleIdleWorkOnGpuThread();
uint32 CreateStreamTextureOnGpuThread(uint32 client_texture_id);
bool MakeCurrent();
base::Closure WrapCallback(const base::Closure& callback);
@@ -213,7 +214,7 @@ class GPU_EXPORT InProcessCommandBuffer : public CommandBuffer,
void OnResizeView(gfx::Size size, float scale_factor);
bool GetBufferChanged(int32 transfer_buffer_id);
void PumpCommands();
- void ScheduleMoreIdleWork();
+ void PerformIdleWork();
static scoped_refptr<Service> GetDefaultService();
@@ -226,6 +227,7 @@ class GPU_EXPORT InProcessCommandBuffer : public CommandBuffer,
scoped_refptr<gfx::GLContext> context_;
scoped_refptr<gfx::GLSurface> surface_;
base::Closure context_lost_callback_;
+ bool idle_work_pending_; // Used to throttle PerformIdleWork.
// Members accessed on the client thread:
State last_state_;
diff --git a/gpu/command_buffer/service/test_helper.cc b/gpu/command_buffer/service/test_helper.cc
index c589be4326..2323808391 100644
--- a/gpu/command_buffer/service/test_helper.cc
+++ b/gpu/command_buffer/service/test_helper.cc
@@ -249,7 +249,7 @@ void TestHelper::SetupContextGroupInitExpectations(
SetupFeatureInfoInitExpectationsWithGLVersion(gl, extensions, "", gl_version);
- std::string l_version(StringToLowerASCII(std::string(gl_version)));
+ std::string l_version(base::StringToLowerASCII(std::string(gl_version)));
bool is_es3 = (l_version.substr(0, 12) == "opengl es 3.");
EXPECT_CALL(*gl, GetIntegerv(GL_MAX_RENDERBUFFER_SIZE, _))
@@ -319,7 +319,7 @@ void TestHelper::SetupFeatureInfoInitExpectationsWithGLVersion(
.WillOnce(Return(reinterpret_cast<const uint8*>(gl_version)))
.RetiresOnSaturation();
- std::string l_version(StringToLowerASCII(std::string(gl_version)));
+ std::string l_version(base::StringToLowerASCII(std::string(gl_version)));
bool is_es3 = (l_version.substr(0, 12) == "opengl es 3.");
if (strstr(extensions, "GL_ARB_texture_float") ||
diff --git a/gpu/command_buffer/tests/gl_manager.cc b/gpu/command_buffer/tests/gl_manager.cc
index 6b43e5b2e1..c143db8efd 100644
--- a/gpu/command_buffer/tests/gl_manager.cc
+++ b/gpu/command_buffer/tests/gl_manager.cc
@@ -158,11 +158,11 @@ void GLManager::Initialize(const GLManager::Options& options) {
gfx::GpuPreference gpu_preference(gfx::PreferDiscreteGpu);
std::vector<int32> attribs;
gles2::ContextCreationAttribHelper attrib_helper;
- attrib_helper.red_size_ = 8;
- attrib_helper.green_size_ = 8;
- attrib_helper.blue_size_ = 8;
- attrib_helper.alpha_size_ = 8;
- attrib_helper.depth_size_ = 16;
+ attrib_helper.red_size = 8;
+ attrib_helper.green_size = 8;
+ attrib_helper.blue_size = 8;
+ attrib_helper.alpha_size = 8;
+ attrib_helper.depth_size = 16;
attrib_helper.Serialize(&attribs);
if (!context_group) {
diff --git a/gpu/command_buffer_client.target.darwin-arm.mk b/gpu/command_buffer_client.target.darwin-arm.mk
index 61c4c397cb..8d73ab5651 100644
--- a/gpu/command_buffer_client.target.darwin-arm.mk
+++ b/gpu/command_buffer_client.target.darwin-arm.mk
@@ -75,7 +75,6 @@ MY_CFLAGS_Debug := \
MY_DEFS_Debug := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
@@ -180,7 +179,6 @@ MY_CFLAGS_Release := \
MY_DEFS_Release := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
diff --git a/gpu/command_buffer_client.target.darwin-arm64.mk b/gpu/command_buffer_client.target.darwin-arm64.mk
index f622fe54d0..d987d8d4dc 100644
--- a/gpu/command_buffer_client.target.darwin-arm64.mk
+++ b/gpu/command_buffer_client.target.darwin-arm64.mk
@@ -64,7 +64,6 @@ MY_CFLAGS_Debug := \
MY_DEFS_Debug := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
@@ -157,7 +156,6 @@ MY_CFLAGS_Release := \
MY_DEFS_Release := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
diff --git a/gpu/command_buffer_client.target.darwin-mips.mk b/gpu/command_buffer_client.target.darwin-mips.mk
index 0519b39898..e96519f8b5 100644
--- a/gpu/command_buffer_client.target.darwin-mips.mk
+++ b/gpu/command_buffer_client.target.darwin-mips.mk
@@ -69,7 +69,6 @@ MY_CFLAGS_Debug := \
MY_DEFS_Debug := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
@@ -168,7 +167,6 @@ MY_CFLAGS_Release := \
MY_DEFS_Release := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
diff --git a/gpu/command_buffer_client.target.darwin-x86.mk b/gpu/command_buffer_client.target.darwin-x86.mk
index af8eccb240..bd5a7b92d4 100644
--- a/gpu/command_buffer_client.target.darwin-x86.mk
+++ b/gpu/command_buffer_client.target.darwin-x86.mk
@@ -70,7 +70,6 @@ MY_CFLAGS_Debug := \
MY_DEFS_Debug := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
@@ -169,7 +168,6 @@ MY_CFLAGS_Release := \
MY_DEFS_Release := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
diff --git a/gpu/command_buffer_client.target.darwin-x86_64.mk b/gpu/command_buffer_client.target.darwin-x86_64.mk
index a3cc38bc93..934391a3e1 100644
--- a/gpu/command_buffer_client.target.darwin-x86_64.mk
+++ b/gpu/command_buffer_client.target.darwin-x86_64.mk
@@ -69,7 +69,6 @@ MY_CFLAGS_Debug := \
MY_DEFS_Debug := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
@@ -167,7 +166,6 @@ MY_CFLAGS_Release := \
MY_DEFS_Release := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
diff --git a/gpu/command_buffer_client.target.linux-arm.mk b/gpu/command_buffer_client.target.linux-arm.mk
index 61c4c397cb..8d73ab5651 100644
--- a/gpu/command_buffer_client.target.linux-arm.mk
+++ b/gpu/command_buffer_client.target.linux-arm.mk
@@ -75,7 +75,6 @@ MY_CFLAGS_Debug := \
MY_DEFS_Debug := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
@@ -180,7 +179,6 @@ MY_CFLAGS_Release := \
MY_DEFS_Release := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
diff --git a/gpu/command_buffer_client.target.linux-arm64.mk b/gpu/command_buffer_client.target.linux-arm64.mk
index f622fe54d0..d987d8d4dc 100644
--- a/gpu/command_buffer_client.target.linux-arm64.mk
+++ b/gpu/command_buffer_client.target.linux-arm64.mk
@@ -64,7 +64,6 @@ MY_CFLAGS_Debug := \
MY_DEFS_Debug := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
@@ -157,7 +156,6 @@ MY_CFLAGS_Release := \
MY_DEFS_Release := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
diff --git a/gpu/command_buffer_client.target.linux-mips.mk b/gpu/command_buffer_client.target.linux-mips.mk
index 0519b39898..e96519f8b5 100644
--- a/gpu/command_buffer_client.target.linux-mips.mk
+++ b/gpu/command_buffer_client.target.linux-mips.mk
@@ -69,7 +69,6 @@ MY_CFLAGS_Debug := \
MY_DEFS_Debug := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
@@ -168,7 +167,6 @@ MY_CFLAGS_Release := \
MY_DEFS_Release := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
diff --git a/gpu/command_buffer_client.target.linux-x86.mk b/gpu/command_buffer_client.target.linux-x86.mk
index af8eccb240..bd5a7b92d4 100644
--- a/gpu/command_buffer_client.target.linux-x86.mk
+++ b/gpu/command_buffer_client.target.linux-x86.mk
@@ -70,7 +70,6 @@ MY_CFLAGS_Debug := \
MY_DEFS_Debug := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
@@ -169,7 +168,6 @@ MY_CFLAGS_Release := \
MY_DEFS_Release := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
diff --git a/gpu/command_buffer_client.target.linux-x86_64.mk b/gpu/command_buffer_client.target.linux-x86_64.mk
index a3cc38bc93..934391a3e1 100644
--- a/gpu/command_buffer_client.target.linux-x86_64.mk
+++ b/gpu/command_buffer_client.target.linux-x86_64.mk
@@ -69,7 +69,6 @@ MY_CFLAGS_Debug := \
MY_DEFS_Debug := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
@@ -167,7 +166,6 @@ MY_CFLAGS_Release := \
MY_DEFS_Release := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
diff --git a/gpu/command_buffer_common.target.darwin-arm.mk b/gpu/command_buffer_common.target.darwin-arm.mk
index a0c5d00c0c..b601802672 100644
--- a/gpu/command_buffer_common.target.darwin-arm.mk
+++ b/gpu/command_buffer_common.target.darwin-arm.mk
@@ -78,7 +78,6 @@ MY_CFLAGS_Debug := \
MY_DEFS_Debug := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
@@ -183,7 +182,6 @@ MY_CFLAGS_Release := \
MY_DEFS_Release := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
diff --git a/gpu/command_buffer_common.target.darwin-arm64.mk b/gpu/command_buffer_common.target.darwin-arm64.mk
index c48390fe47..38d88c0e26 100644
--- a/gpu/command_buffer_common.target.darwin-arm64.mk
+++ b/gpu/command_buffer_common.target.darwin-arm64.mk
@@ -67,7 +67,6 @@ MY_CFLAGS_Debug := \
MY_DEFS_Debug := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
@@ -160,7 +159,6 @@ MY_CFLAGS_Release := \
MY_DEFS_Release := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
diff --git a/gpu/command_buffer_common.target.darwin-mips.mk b/gpu/command_buffer_common.target.darwin-mips.mk
index 06c2272aa2..7d5bf67291 100644
--- a/gpu/command_buffer_common.target.darwin-mips.mk
+++ b/gpu/command_buffer_common.target.darwin-mips.mk
@@ -72,7 +72,6 @@ MY_CFLAGS_Debug := \
MY_DEFS_Debug := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
@@ -171,7 +170,6 @@ MY_CFLAGS_Release := \
MY_DEFS_Release := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
diff --git a/gpu/command_buffer_common.target.darwin-x86.mk b/gpu/command_buffer_common.target.darwin-x86.mk
index f3cce162ec..4f3cc2ee4f 100644
--- a/gpu/command_buffer_common.target.darwin-x86.mk
+++ b/gpu/command_buffer_common.target.darwin-x86.mk
@@ -73,7 +73,6 @@ MY_CFLAGS_Debug := \
MY_DEFS_Debug := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
@@ -172,7 +171,6 @@ MY_CFLAGS_Release := \
MY_DEFS_Release := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
diff --git a/gpu/command_buffer_common.target.darwin-x86_64.mk b/gpu/command_buffer_common.target.darwin-x86_64.mk
index 930ff825f1..1d8820c6b1 100644
--- a/gpu/command_buffer_common.target.darwin-x86_64.mk
+++ b/gpu/command_buffer_common.target.darwin-x86_64.mk
@@ -72,7 +72,6 @@ MY_CFLAGS_Debug := \
MY_DEFS_Debug := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
@@ -170,7 +169,6 @@ MY_CFLAGS_Release := \
MY_DEFS_Release := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
diff --git a/gpu/command_buffer_common.target.linux-arm.mk b/gpu/command_buffer_common.target.linux-arm.mk
index a0c5d00c0c..b601802672 100644
--- a/gpu/command_buffer_common.target.linux-arm.mk
+++ b/gpu/command_buffer_common.target.linux-arm.mk
@@ -78,7 +78,6 @@ MY_CFLAGS_Debug := \
MY_DEFS_Debug := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
@@ -183,7 +182,6 @@ MY_CFLAGS_Release := \
MY_DEFS_Release := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
diff --git a/gpu/command_buffer_common.target.linux-arm64.mk b/gpu/command_buffer_common.target.linux-arm64.mk
index c48390fe47..38d88c0e26 100644
--- a/gpu/command_buffer_common.target.linux-arm64.mk
+++ b/gpu/command_buffer_common.target.linux-arm64.mk
@@ -67,7 +67,6 @@ MY_CFLAGS_Debug := \
MY_DEFS_Debug := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
@@ -160,7 +159,6 @@ MY_CFLAGS_Release := \
MY_DEFS_Release := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
diff --git a/gpu/command_buffer_common.target.linux-mips.mk b/gpu/command_buffer_common.target.linux-mips.mk
index 06c2272aa2..7d5bf67291 100644
--- a/gpu/command_buffer_common.target.linux-mips.mk
+++ b/gpu/command_buffer_common.target.linux-mips.mk
@@ -72,7 +72,6 @@ MY_CFLAGS_Debug := \
MY_DEFS_Debug := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
@@ -171,7 +170,6 @@ MY_CFLAGS_Release := \
MY_DEFS_Release := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
diff --git a/gpu/command_buffer_common.target.linux-x86.mk b/gpu/command_buffer_common.target.linux-x86.mk
index f3cce162ec..4f3cc2ee4f 100644
--- a/gpu/command_buffer_common.target.linux-x86.mk
+++ b/gpu/command_buffer_common.target.linux-x86.mk
@@ -73,7 +73,6 @@ MY_CFLAGS_Debug := \
MY_DEFS_Debug := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
@@ -172,7 +171,6 @@ MY_CFLAGS_Release := \
MY_DEFS_Release := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
diff --git a/gpu/command_buffer_common.target.linux-x86_64.mk b/gpu/command_buffer_common.target.linux-x86_64.mk
index 930ff825f1..1d8820c6b1 100644
--- a/gpu/command_buffer_common.target.linux-x86_64.mk
+++ b/gpu/command_buffer_common.target.linux-x86_64.mk
@@ -72,7 +72,6 @@ MY_CFLAGS_Debug := \
MY_DEFS_Debug := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
@@ -170,7 +169,6 @@ MY_CFLAGS_Release := \
MY_DEFS_Release := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
diff --git a/gpu/command_buffer_service.target.darwin-arm.mk b/gpu/command_buffer_service.target.darwin-arm.mk
index 09c47521e9..23012c0237 100644
--- a/gpu/command_buffer_service.target.darwin-arm.mk
+++ b/gpu/command_buffer_service.target.darwin-arm.mk
@@ -119,7 +119,6 @@ MY_CFLAGS_Debug := \
MY_DEFS_Debug := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
@@ -267,7 +266,6 @@ MY_CFLAGS_Release := \
MY_DEFS_Release := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
diff --git a/gpu/command_buffer_service.target.darwin-arm64.mk b/gpu/command_buffer_service.target.darwin-arm64.mk
index 592261ab88..680146f9d6 100644
--- a/gpu/command_buffer_service.target.darwin-arm64.mk
+++ b/gpu/command_buffer_service.target.darwin-arm64.mk
@@ -108,7 +108,6 @@ MY_CFLAGS_Debug := \
MY_DEFS_Debug := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
@@ -244,7 +243,6 @@ MY_CFLAGS_Release := \
MY_DEFS_Release := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
diff --git a/gpu/command_buffer_service.target.darwin-mips.mk b/gpu/command_buffer_service.target.darwin-mips.mk
index 81b1aee772..38ff69ceae 100644
--- a/gpu/command_buffer_service.target.darwin-mips.mk
+++ b/gpu/command_buffer_service.target.darwin-mips.mk
@@ -113,7 +113,6 @@ MY_CFLAGS_Debug := \
MY_DEFS_Debug := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
@@ -255,7 +254,6 @@ MY_CFLAGS_Release := \
MY_DEFS_Release := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
diff --git a/gpu/command_buffer_service.target.darwin-x86.mk b/gpu/command_buffer_service.target.darwin-x86.mk
index 721333d04d..54488be74b 100644
--- a/gpu/command_buffer_service.target.darwin-x86.mk
+++ b/gpu/command_buffer_service.target.darwin-x86.mk
@@ -114,7 +114,6 @@ MY_CFLAGS_Debug := \
MY_DEFS_Debug := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
@@ -256,7 +255,6 @@ MY_CFLAGS_Release := \
MY_DEFS_Release := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
diff --git a/gpu/command_buffer_service.target.darwin-x86_64.mk b/gpu/command_buffer_service.target.darwin-x86_64.mk
index 171e8d4c70..d862e39b41 100644
--- a/gpu/command_buffer_service.target.darwin-x86_64.mk
+++ b/gpu/command_buffer_service.target.darwin-x86_64.mk
@@ -113,7 +113,6 @@ MY_CFLAGS_Debug := \
MY_DEFS_Debug := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
@@ -254,7 +253,6 @@ MY_CFLAGS_Release := \
MY_DEFS_Release := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
diff --git a/gpu/command_buffer_service.target.linux-arm.mk b/gpu/command_buffer_service.target.linux-arm.mk
index 09c47521e9..23012c0237 100644
--- a/gpu/command_buffer_service.target.linux-arm.mk
+++ b/gpu/command_buffer_service.target.linux-arm.mk
@@ -119,7 +119,6 @@ MY_CFLAGS_Debug := \
MY_DEFS_Debug := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
@@ -267,7 +266,6 @@ MY_CFLAGS_Release := \
MY_DEFS_Release := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
diff --git a/gpu/command_buffer_service.target.linux-arm64.mk b/gpu/command_buffer_service.target.linux-arm64.mk
index 592261ab88..680146f9d6 100644
--- a/gpu/command_buffer_service.target.linux-arm64.mk
+++ b/gpu/command_buffer_service.target.linux-arm64.mk
@@ -108,7 +108,6 @@ MY_CFLAGS_Debug := \
MY_DEFS_Debug := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
@@ -244,7 +243,6 @@ MY_CFLAGS_Release := \
MY_DEFS_Release := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
diff --git a/gpu/command_buffer_service.target.linux-mips.mk b/gpu/command_buffer_service.target.linux-mips.mk
index 81b1aee772..38ff69ceae 100644
--- a/gpu/command_buffer_service.target.linux-mips.mk
+++ b/gpu/command_buffer_service.target.linux-mips.mk
@@ -113,7 +113,6 @@ MY_CFLAGS_Debug := \
MY_DEFS_Debug := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
@@ -255,7 +254,6 @@ MY_CFLAGS_Release := \
MY_DEFS_Release := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
diff --git a/gpu/command_buffer_service.target.linux-x86.mk b/gpu/command_buffer_service.target.linux-x86.mk
index 721333d04d..54488be74b 100644
--- a/gpu/command_buffer_service.target.linux-x86.mk
+++ b/gpu/command_buffer_service.target.linux-x86.mk
@@ -114,7 +114,6 @@ MY_CFLAGS_Debug := \
MY_DEFS_Debug := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
@@ -256,7 +255,6 @@ MY_CFLAGS_Release := \
MY_DEFS_Release := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
diff --git a/gpu/command_buffer_service.target.linux-x86_64.mk b/gpu/command_buffer_service.target.linux-x86_64.mk
index 171e8d4c70..d862e39b41 100644
--- a/gpu/command_buffer_service.target.linux-x86_64.mk
+++ b/gpu/command_buffer_service.target.linux-x86_64.mk
@@ -113,7 +113,6 @@ MY_CFLAGS_Debug := \
MY_DEFS_Debug := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
@@ -254,7 +253,6 @@ MY_CFLAGS_Release := \
MY_DEFS_Release := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
diff --git a/gpu/config/BUILD.gn b/gpu/config/BUILD.gn
index 30984e308a..ef64887cc2 100644
--- a/gpu/config/BUILD.gn
+++ b/gpu/config/BUILD.gn
@@ -59,7 +59,7 @@ source_set("config") {
]
}
}
- if (is_linux) {
+ if (is_linux && (use_x11 || use_ozone)) {
deps += [
"//build/config/linux:libpci",
]
diff --git a/gpu/config/gpu_control_list.cc b/gpu/config/gpu_control_list.cc
index dc5c75c11f..f5ccd61e29 100644
--- a/gpu/config/gpu_control_list.cc
+++ b/gpu/config/gpu_control_list.cc
@@ -14,6 +14,7 @@
#include "base/sys_info.h"
#include "gpu/config/gpu_info.h"
#include "gpu/config/gpu_util.h"
+#include "third_party/re2/re2/re2.h"
namespace gpu {
namespace {
@@ -89,6 +90,13 @@ int CompareLexicalNumberStrings(
return 0;
}
+// A mismatch is identified only if both |input| and |pattern| are not empty.
+bool StringMismatch(const std::string& input, const std::string& pattern) {
+ if (input.empty() || pattern.empty())
+ return false;
+ return !RE2::FullMatch(input, pattern);
+}
+
const char kMultiGpuStyleStringAMDSwitchable[] = "amd_switchable";
const char kMultiGpuStyleStringAMDSwitchableDiscrete[] =
"amd_switchable_discrete";
@@ -261,45 +269,6 @@ GpuControlList::OsType GpuControlList::OsInfo::StringToOsType(
return kOsUnknown;
}
-GpuControlList::StringInfo::StringInfo(const std::string& string_op,
- const std::string& string_value) {
- op_ = StringToOp(string_op);
- value_ = StringToLowerASCII(string_value);
-}
-
-bool GpuControlList::StringInfo::Contains(const std::string& value) const {
- std::string my_value = StringToLowerASCII(value);
- switch (op_) {
- case kContains:
- return strstr(my_value.c_str(), value_.c_str()) != NULL;
- case kBeginWith:
- return StartsWithASCII(my_value, value_, false);
- case kEndWith:
- return EndsWith(my_value, value_, false);
- case kEQ:
- return value_ == my_value;
- default:
- return false;
- }
-}
-
-bool GpuControlList::StringInfo::IsValid() const {
- return op_ != kUnknown;
-}
-
-GpuControlList::StringInfo::Op GpuControlList::StringInfo::StringToOp(
- const std::string& string_op) {
- if (string_op == "=")
- return kEQ;
- else if (string_op == "contains")
- return kContains;
- else if (string_op == "beginwith")
- return kBeginWith;
- else if (string_op == "endwith")
- return kEndWith;
- return kUnknown;
-}
-
GpuControlList::FloatInfo::FloatInfo(const std::string& float_op,
const std::string& float_value,
const std::string& float_value2)
@@ -520,13 +489,9 @@ GpuControlList::GpuControlListEntry::GetEntryFromValue(
dictionary_entry_count++;
}
- const base::DictionaryValue* driver_vendor_value = NULL;
- if (value->GetDictionary("driver_vendor", &driver_vendor_value)) {
- std::string vendor_op;
- std::string vendor_value;
- driver_vendor_value->GetString(kOp, &vendor_op);
- driver_vendor_value->GetString("value", &vendor_value);
- if (!entry->SetDriverVendorInfo(vendor_op, vendor_value)) {
+ std::string driver_vendor_value;
+ if (value->GetString("driver_vendor", &driver_vendor_value)) {
+ if (!entry->SetDriverVendorInfo(driver_vendor_value)) {
LOG(WARNING) << "Malformed driver_vendor entry " << entry->id();
return NULL;
}
@@ -594,39 +559,27 @@ GpuControlList::GpuControlListEntry::GetEntryFromValue(
dictionary_entry_count++;
}
- const base::DictionaryValue* gl_vendor_value = NULL;
- if (value->GetDictionary("gl_vendor", &gl_vendor_value)) {
- std::string vendor_op;
- std::string vendor_value;
- gl_vendor_value->GetString(kOp, &vendor_op);
- gl_vendor_value->GetString("value", &vendor_value);
- if (!entry->SetGLVendorInfo(vendor_op, vendor_value)) {
+ std::string gl_vendor_value;
+ if (value->GetString("gl_vendor", &gl_vendor_value)) {
+ if (!entry->SetGLVendorInfo(gl_vendor_value)) {
LOG(WARNING) << "Malformed gl_vendor entry " << entry->id();
return NULL;
}
dictionary_entry_count++;
}
- const base::DictionaryValue* gl_renderer_value = NULL;
- if (value->GetDictionary("gl_renderer", &gl_renderer_value)) {
- std::string renderer_op;
- std::string renderer_value;
- gl_renderer_value->GetString(kOp, &renderer_op);
- gl_renderer_value->GetString("value", &renderer_value);
- if (!entry->SetGLRendererInfo(renderer_op, renderer_value)) {
+ std::string gl_renderer_value;
+ if (value->GetString("gl_renderer", &gl_renderer_value)) {
+ if (!entry->SetGLRendererInfo(gl_renderer_value)) {
LOG(WARNING) << "Malformed gl_renderer entry " << entry->id();
return NULL;
}
dictionary_entry_count++;
}
- const base::DictionaryValue* gl_extensions_value = NULL;
- if (value->GetDictionary("gl_extensions", &gl_extensions_value)) {
- std::string extensions_op;
- std::string extensions_value;
- gl_extensions_value->GetString(kOp, &extensions_op);
- gl_extensions_value->GetString("value", &extensions_value);
- if (!entry->SetGLExtensionsInfo(extensions_op, extensions_value)) {
+ std::string gl_extensions_value;
+ if (value->GetString("gl_extensions", &gl_extensions_value)) {
+ if (!entry->SetGLExtensionsInfo(gl_extensions_value)) {
LOG(WARNING) << "Malformed gl_extensions entry " << entry->id();
return NULL;
}
@@ -651,13 +604,9 @@ GpuControlList::GpuControlListEntry::GetEntryFromValue(
dictionary_entry_count++;
}
- const base::DictionaryValue* cpu_brand_value = NULL;
- if (value->GetDictionary("cpu_info", &cpu_brand_value)) {
- std::string cpu_op;
- std::string cpu_value;
- cpu_brand_value->GetString(kOp, &cpu_op);
- cpu_brand_value->GetString("value", &cpu_value);
- if (!entry->SetCpuBrand(cpu_op, cpu_value)) {
+ std::string cpu_brand_value;
+ if (value->GetString("cpu_info", &cpu_brand_value)) {
+ if (!entry->SetCpuBrand(cpu_brand_value)) {
LOG(WARNING) << "Malformed cpu_brand entry " << entry->id();
return NULL;
}
@@ -898,10 +847,9 @@ bool GpuControlList::GpuControlListEntry::SetGLType(
}
bool GpuControlList::GpuControlListEntry::SetDriverVendorInfo(
- const std::string& vendor_op,
const std::string& vendor_value) {
- driver_vendor_info_.reset(new StringInfo(vendor_op, vendor_value));
- return driver_vendor_info_->IsValid();
+ driver_vendor_info_ = vendor_value;
+ return !driver_vendor_info_.empty();
}
bool GpuControlList::GpuControlListEntry::SetDriverVersionInfo(
@@ -933,24 +881,21 @@ bool GpuControlList::GpuControlListEntry::SetGLVersionInfo(
}
bool GpuControlList::GpuControlListEntry::SetGLVendorInfo(
- const std::string& vendor_op,
const std::string& vendor_value) {
- gl_vendor_info_.reset(new StringInfo(vendor_op, vendor_value));
- return gl_vendor_info_->IsValid();
+ gl_vendor_info_ = vendor_value;
+ return !gl_vendor_info_.empty();
}
bool GpuControlList::GpuControlListEntry::SetGLRendererInfo(
- const std::string& renderer_op,
const std::string& renderer_value) {
- gl_renderer_info_.reset(new StringInfo(renderer_op, renderer_value));
- return gl_renderer_info_->IsValid();
+ gl_renderer_info_ = renderer_value;
+ return !gl_renderer_info_.empty();
}
bool GpuControlList::GpuControlListEntry::SetGLExtensionsInfo(
- const std::string& extensions_op,
const std::string& extensions_value) {
- gl_extensions_info_.reset(new StringInfo(extensions_op, extensions_value));
- return gl_extensions_info_->IsValid();
+ gl_extensions_info_ = extensions_value;
+ return !gl_extensions_info_.empty();
}
bool GpuControlList::GpuControlListEntry::SetGLResetNotificationStrategyInfo(
@@ -963,10 +908,9 @@ bool GpuControlList::GpuControlListEntry::SetGLResetNotificationStrategyInfo(
}
bool GpuControlList::GpuControlListEntry::SetCpuBrand(
- const std::string& cpu_op,
const std::string& cpu_value) {
- cpu_brand_.reset(new StringInfo(cpu_op, cpu_value));
- return cpu_brand_->IsValid();
+ cpu_brand_ = cpu_value;
+ return !cpu_brand_.empty();
}
bool GpuControlList::GpuControlListEntry::SetPerfGraphicsInfo(
@@ -1236,8 +1180,7 @@ bool GpuControlList::GpuControlListEntry::Contains(
case kMultiGpuStyleNone:
break;
}
- if (driver_vendor_info_.get() != NULL && !gpu_info.driver_vendor.empty() &&
- !driver_vendor_info_->Contains(gpu_info.driver_vendor))
+ if (StringMismatch(gpu_info.driver_vendor, driver_vendor_info_))
return false;
if (driver_version_info_.get() != NULL && !gpu_info.driver_version.empty()) {
if (!driver_version_info_->Contains(gpu_info.driver_version))
@@ -1249,14 +1192,11 @@ bool GpuControlList::GpuControlListEntry::Contains(
}
if (GLVersionInfoMismatch(gpu_info.gl_version))
return false;
- if (gl_vendor_info_.get() != NULL && !gpu_info.gl_vendor.empty() &&
- !gl_vendor_info_->Contains(gpu_info.gl_vendor))
+ if (StringMismatch(gpu_info.gl_vendor, gl_vendor_info_))
return false;
- if (gl_renderer_info_.get() != NULL && !gpu_info.gl_renderer.empty() &&
- !gl_renderer_info_->Contains(gpu_info.gl_renderer))
+ if (StringMismatch(gpu_info.gl_renderer, gl_renderer_info_))
return false;
- if (gl_extensions_info_.get() != NULL && !gpu_info.gl_extensions.empty() &&
- !gl_extensions_info_->Contains(gpu_info.gl_extensions))
+ if (StringMismatch(gpu_info.gl_extensions, gl_extensions_info_))
return false;
if (gl_reset_notification_strategy_info_.get() != NULL &&
!gl_reset_notification_strategy_info_->Contains(
@@ -1279,7 +1219,8 @@ bool GpuControlList::GpuControlListEntry::Contains(
return false;
bool found_match = false;
for (size_t ii = 0; ii < machine_model_name_list_.size(); ++ii) {
- if (machine_model_name_list_[ii] == gpu_info.machine_model_name) {
+ if (RE2::FullMatch(gpu_info.machine_model_name,
+ machine_model_name_list_[ii])) {
found_match = true;
break;
}
@@ -1297,9 +1238,9 @@ bool GpuControlList::GpuControlListEntry::Contains(
if (direct_rendering_info_.get() != NULL &&
!direct_rendering_info_->Contains(gpu_info.direct_rendering))
return false;
- if (cpu_brand_.get() != NULL) {
+ if (!cpu_brand_.empty()) {
base::CPU cpu_info;
- if (!cpu_brand_->Contains(cpu_info.cpu_brand()))
+ if (StringMismatch(cpu_info.cpu_brand(), cpu_brand_))
return false;
}
@@ -1317,13 +1258,13 @@ bool GpuControlList::GpuControlListEntry::NeedsMoreInfo(
// If certain info is missing due to some error, say, we fail to collect
// vendor_id/device_id, then even if we launch GPU process and create a gl
// context, we won't gather such missing info, so we still return false.
- if (driver_vendor_info_.get() && gpu_info.driver_vendor.empty())
+ if (!driver_vendor_info_.empty() && gpu_info.driver_vendor.empty())
return true;
if (driver_version_info_.get() && gpu_info.driver_version.empty())
return true;
- if (gl_vendor_info_.get() && gpu_info.gl_vendor.empty())
+ if (!gl_vendor_info_.empty() && gpu_info.gl_vendor.empty())
return true;
- if (gl_renderer_info_.get() && gpu_info.gl_renderer.empty())
+ if (!gl_renderer_info_.empty() && gpu_info.gl_renderer.empty())
return true;
for (size_t i = 0; i < exceptions_.size(); ++i) {
if (exceptions_[i]->NeedsMoreInfo(gpu_info))
diff --git a/gpu/config/gpu_control_list.h b/gpu/config/gpu_control_list.h
index b2daa47eb3..a5abf52363 100644
--- a/gpu/config/gpu_control_list.h
+++ b/gpu/config/gpu_control_list.h
@@ -192,32 +192,6 @@ class GPU_EXPORT GpuControlList {
scoped_ptr<VersionInfo> version_info_;
};
- class GPU_EXPORT StringInfo {
- public:
- StringInfo(const std::string& string_op, const std::string& string_value);
-
- // Determines if a given string is included in the StringInfo.
- bool Contains(const std::string& value) const;
-
- // Determines if the StringInfo contains valid information.
- bool IsValid() const;
-
- private:
- enum Op {
- kContains,
- kBeginWith,
- kEndWith,
- kEQ, // =
- kUnknown // Indicates StringInfo data is invalid.
- };
-
- // Maps string to Op; returns kUnknown if it's not a valid Op.
- static Op StringToOp(const std::string& string_op);
-
- Op op_;
- std::string value_;
- };
-
class GPU_EXPORT FloatInfo {
public:
FloatInfo(const std::string& float_op,
@@ -370,8 +344,7 @@ class GPU_EXPORT GpuControlList {
bool SetGLType(const std::string& gl_type_string);
- bool SetDriverVendorInfo(const std::string& vendor_op,
- const std::string& vendor_value);
+ bool SetDriverVendorInfo(const std::string& vendor_value);
bool SetDriverVersionInfo(const std::string& version_op,
const std::string& version_style,
@@ -386,21 +359,17 @@ class GPU_EXPORT GpuControlList {
const std::string& version_string,
const std::string& version_string2);
- bool SetGLVendorInfo(const std::string& vendor_op,
- const std::string& vendor_value);
+ bool SetGLVendorInfo(const std::string& vendor_value);
- bool SetGLRendererInfo(const std::string& renderer_op,
- const std::string& renderer_value);
+ bool SetGLRendererInfo(const std::string& renderer_value);
- bool SetGLExtensionsInfo(const std::string& extensions_op,
- const std::string& extensions_value);
+ bool SetGLExtensionsInfo(const std::string& extensions_value);
bool SetGLResetNotificationStrategyInfo(const std::string& op,
const std::string& int_string,
const std::string& int_string2);
- bool SetCpuBrand(const std::string& cpu_op,
- const std::string& cpu_value);
+ bool SetCpuBrand(const std::string& cpu_value);
bool SetPerfGraphicsInfo(const std::string& op,
const std::string& float_string,
@@ -464,15 +433,15 @@ class GPU_EXPORT GpuControlList {
MultiGpuStyle multi_gpu_style_;
MultiGpuCategory multi_gpu_category_;
GLType gl_type_;
- scoped_ptr<StringInfo> driver_vendor_info_;
+ std::string driver_vendor_info_;
scoped_ptr<VersionInfo> driver_version_info_;
scoped_ptr<VersionInfo> driver_date_info_;
scoped_ptr<VersionInfo> gl_version_info_;
- scoped_ptr<StringInfo> gl_vendor_info_;
- scoped_ptr<StringInfo> gl_renderer_info_;
- scoped_ptr<StringInfo> gl_extensions_info_;
+ std::string gl_vendor_info_;
+ std::string gl_renderer_info_;
+ std::string gl_extensions_info_;
scoped_ptr<IntInfo> gl_reset_notification_strategy_info_;
- scoped_ptr<StringInfo> cpu_brand_;
+ std::string cpu_brand_;
scoped_ptr<FloatInfo> perf_graphics_info_;
scoped_ptr<FloatInfo> perf_gaming_info_;
scoped_ptr<FloatInfo> perf_overall_info_;
diff --git a/gpu/config/gpu_control_list_entry_unittest.cc b/gpu/config/gpu_control_list_entry_unittest.cc
index 6ae866b774..d693d85115 100644
--- a/gpu/config/gpu_control_list_entry_unittest.cc
+++ b/gpu/config/gpu_control_list_entry_unittest.cc
@@ -470,14 +470,11 @@ TEST_F(GpuControlListEntryTest, GlVersionGLEntry) {
EXPECT_FALSE(entry->Contains(GpuControlList::kOsWin, "6.1", gpu_info));
}
-TEST_F(GpuControlListEntryTest, GlVendorEntry) {
+TEST_F(GpuControlListEntryTest, GlVendorEqual) {
const std::string json = LONG_STRING_CONST(
{
"id": 1,
- "gl_vendor": {
- "op": "beginwith",
- "value": "NVIDIA"
- },
+ "gl_vendor": "NVIDIA",
"features": [
"test_feature_0"
]
@@ -486,25 +483,26 @@ TEST_F(GpuControlListEntryTest, GlVendorEntry) {
ScopedEntry entry(GetEntryFromString(json));
EXPECT_TRUE(entry.get() != NULL);
- const GpuControlList::OsType os_type[] = {
- GpuControlList::kOsMacosx,
- GpuControlList::kOsWin,
- GpuControlList::kOsLinux,
- GpuControlList::kOsChromeOS,
- GpuControlList::kOsAndroid
- };
- for (size_t i = 0; i < arraysize(os_type); ++i)
- EXPECT_TRUE(entry->Contains(os_type[i], "10.6", gpu_info()));
+ GPUInfo gpu_info;
+ gpu_info.gl_vendor = "NVIDIA";
+ EXPECT_TRUE(entry->Contains(
+ GpuControlList::kOsMacosx, "10.9", gpu_info));
+
+ // Case sensitive.
+ gpu_info.gl_vendor = "NVidia";
+ EXPECT_FALSE(entry->Contains(
+ GpuControlList::kOsMacosx, "10.9", gpu_info));
+
+ gpu_info.gl_vendor = "NVIDIA-x";
+ EXPECT_FALSE(entry->Contains(
+ GpuControlList::kOsMacosx, "10.9", gpu_info));
}
-TEST_F(GpuControlListEntryTest, GlRendererEntry) {
+TEST_F(GpuControlListEntryTest, GlVendorWithDot) {
const std::string json = LONG_STRING_CONST(
{
"id": 1,
- "gl_renderer": {
- "op": "contains",
- "value": "GeForce"
- },
+ "gl_vendor": "X\\.Org.*",
"features": [
"test_feature_0"
]
@@ -513,15 +511,100 @@ TEST_F(GpuControlListEntryTest, GlRendererEntry) {
ScopedEntry entry(GetEntryFromString(json));
EXPECT_TRUE(entry.get() != NULL);
- const GpuControlList::OsType os_type[] = {
- GpuControlList::kOsMacosx,
- GpuControlList::kOsWin,
- GpuControlList::kOsLinux,
- GpuControlList::kOsChromeOS,
- GpuControlList::kOsAndroid
- };
- for (size_t i = 0; i < arraysize(os_type); ++i)
- EXPECT_TRUE(entry->Contains(os_type[i], "10.6", gpu_info()));
+ GPUInfo gpu_info;
+ gpu_info.gl_vendor = "X.Org R300 Project";
+ EXPECT_TRUE(entry->Contains(
+ GpuControlList::kOsLinux, "", gpu_info));
+
+ gpu_info.gl_vendor = "X.Org";
+ EXPECT_TRUE(entry->Contains(
+ GpuControlList::kOsLinux, "", gpu_info));
+}
+
+TEST_F(GpuControlListEntryTest, GlRendererContains) {
+ const std::string json = LONG_STRING_CONST(
+ {
+ "id": 1,
+ "gl_renderer": ".*GeForce.*",
+ "features": [
+ "test_feature_0"
+ ]
+ }
+ );
+ ScopedEntry entry(GetEntryFromString(json));
+ EXPECT_TRUE(entry.get() != NULL);
+
+ GPUInfo gpu_info;
+ gpu_info.gl_renderer = "NVIDIA GeForce GT 120 OpenGL Engine";
+ EXPECT_TRUE(entry->Contains(
+ GpuControlList::kOsMacosx, "10.9", gpu_info));
+
+ // Case sensitive.
+ gpu_info.gl_renderer = "NVIDIA GEFORCE GT 120 OpenGL Engine";
+ EXPECT_FALSE(entry->Contains(
+ GpuControlList::kOsMacosx, "10.9", gpu_info));
+
+ gpu_info.gl_renderer = "GeForce GT 120 OpenGL Engine";
+ EXPECT_TRUE(entry->Contains(
+ GpuControlList::kOsMacosx, "10.9", gpu_info));
+
+ gpu_info.gl_renderer = "NVIDIA GeForce";
+ EXPECT_TRUE(entry->Contains(
+ GpuControlList::kOsMacosx, "10.9", gpu_info));
+
+ gpu_info.gl_renderer = "NVIDIA Ge Force";
+ EXPECT_FALSE(entry->Contains(
+ GpuControlList::kOsMacosx, "10.9", gpu_info));
+}
+
+TEST_F(GpuControlListEntryTest, GlRendererCaseInsensitive) {
+ const std::string json = LONG_STRING_CONST(
+ {
+ "id": 1,
+ "gl_renderer": "(?i).*software.*",
+ "features": [
+ "test_feature_0"
+ ]
+ }
+ );
+ ScopedEntry entry(GetEntryFromString(json));
+ EXPECT_TRUE(entry.get() != NULL);
+
+ GPUInfo gpu_info;
+ gpu_info.gl_renderer = "software rasterizer";
+ EXPECT_TRUE(entry->Contains(
+ GpuControlList::kOsMacosx, "10.9", gpu_info));
+
+ gpu_info.gl_renderer = "Software Rasterizer";
+ EXPECT_TRUE(entry->Contains(
+ GpuControlList::kOsMacosx, "10.9", gpu_info));
+}
+
+TEST_F(GpuControlListEntryTest, GlExtensionsEndWith) {
+ const std::string json = LONG_STRING_CONST(
+ {
+ "id": 1,
+ "gl_extensions": ".*GL_SUN_slice_accum",
+ "features": [
+ "test_feature_0"
+ ]
+ }
+ );
+ ScopedEntry entry(GetEntryFromString(json));
+ EXPECT_TRUE(entry.get() != NULL);
+
+ GPUInfo gpu_info;
+ gpu_info.gl_extensions = "GL_SGIS_generate_mipmap "
+ "GL_SGIX_shadow "
+ "GL_SUN_slice_accum";
+ EXPECT_TRUE(entry->Contains(
+ GpuControlList::kOsMacosx, "10.9", gpu_info));
+
+ gpu_info.gl_extensions = "GL_SGIS_generate_mipmap "
+ "GL_SUN_slice_accum "
+ "GL_SGIX_shadow";
+ EXPECT_FALSE(entry->Contains(
+ GpuControlList::kOsMacosx, "10.9", gpu_info));
}
TEST_F(GpuControlListEntryTest, PerfGraphicsEntry) {
@@ -640,6 +723,38 @@ TEST_F(GpuControlListEntryTest, AMDSwitchableEntry) {
GpuControlList::kOsMacosx, "10.6", gpu_info));
}
+TEST_F(GpuControlListEntryTest, DriverVendorBeginWith) {
+ const std::string json = LONG_STRING_CONST(
+ {
+ "id": 1,
+ "driver_vendor": "NVIDIA.*",
+ "features": [
+ "test_feature_0"
+ ]
+ }
+ );
+ ScopedEntry entry(GetEntryFromString(json));
+ EXPECT_TRUE(entry.get() != NULL);
+
+ GPUInfo gpu_info;
+ gpu_info.driver_vendor = "NVIDIA Corporation";
+ EXPECT_TRUE(entry->Contains(
+ GpuControlList::kOsMacosx, "10.9", gpu_info));
+
+ // Case sensitive.
+ gpu_info.driver_vendor = "NVidia Corporation";
+ EXPECT_FALSE(entry->Contains(
+ GpuControlList::kOsMacosx, "10.9", gpu_info));
+
+ gpu_info.driver_vendor = "NVIDIA";
+ EXPECT_TRUE(entry->Contains(
+ GpuControlList::kOsMacosx, "10.9", gpu_info));
+
+ gpu_info.driver_vendor = "USA NVIDIA";
+ EXPECT_FALSE(entry->Contains(
+ GpuControlList::kOsMacosx, "10.9", gpu_info));
+}
+
TEST_F(GpuControlListEntryTest, LexicalDriverVersionEntry) {
const std::string json = LONG_STRING_CONST(
{
@@ -710,10 +825,7 @@ TEST_F(GpuControlListEntryTest, NeedsMoreInfoForExceptionsEntry) {
"vendor_id": "0x8086",
"exceptions": [
{
- "gl_renderer": {
- "op": "contains",
- "value": "mesa"
- }
+ "gl_renderer": ".*mesa.*"
}
],
"features": [
@@ -807,7 +919,9 @@ TEST_F(GpuControlListEntryTest, MachineModelName) {
"os": {
"type": "android"
},
- "machine_model_name": ["Nexus 4", "XT1032"],
+ "machine_model_name": [
+ "Nexus 4", "XT1032", "GT-.*", "SCH-.*"
+ ],
"features": [
"test_feature_0"
]
@@ -841,6 +955,18 @@ TEST_F(GpuControlListEntryTest, MachineModelName) {
gpu_info.machine_model_name = "";
EXPECT_FALSE(entry->Contains(
GpuControlList::kOsAndroid, "4.1", gpu_info));
+
+ gpu_info.machine_model_name = "GT-N7100";
+ EXPECT_TRUE(entry->Contains(
+ GpuControlList::kOsAndroid, "4.1", gpu_info));
+
+ gpu_info.machine_model_name = "GT-I9300";
+ EXPECT_TRUE(entry->Contains(
+ GpuControlList::kOsAndroid, "4.1", gpu_info));
+
+ gpu_info.machine_model_name = "SCH-I545";
+ EXPECT_TRUE(entry->Contains(
+ GpuControlList::kOsAndroid, "4.1", gpu_info));
}
TEST_F(GpuControlListEntryTest, MachineModelNameException) {
@@ -852,7 +978,7 @@ TEST_F(GpuControlListEntryTest, MachineModelNameException) {
"os": {
"type": "android"
},
- "machine_model_name": ["Nexus 4"]
+ "machine_model_name": ["Nexus.*"]
}
],
"features": [
@@ -871,6 +997,12 @@ TEST_F(GpuControlListEntryTest, MachineModelNameException) {
EXPECT_TRUE(entry->Contains(
GpuControlList::kOsLinux, "4.1", gpu_info));
+ gpu_info.machine_model_name = "Nexus 7";
+ EXPECT_FALSE(entry->Contains(
+ GpuControlList::kOsAndroid, "4.1", gpu_info));
+ EXPECT_TRUE(entry->Contains(
+ GpuControlList::kOsLinux, "4.1", gpu_info));
+
gpu_info.machine_model_name = "";
EXPECT_TRUE(entry->Contains(
GpuControlList::kOsAndroid, "4.1", gpu_info));
diff --git a/gpu/config/gpu_control_list_format.txt b/gpu/config/gpu_control_list_format.txt
index 71c569c839..c897cb6fd3 100644
--- a/gpu/config/gpu_control_list_format.txt
+++ b/gpu/config/gpu_control_list_format.txt
@@ -32,7 +32,7 @@
// 6. "multi_gpu_category" is a string, valid values include "any", "primary",
// "secondary", and "active". If unspecified, the default value is "primary".
// See gpu_control_list.h for more details on the meanings of the strings.
-// 7. "driver_vendor" is a STRING structure (defined below).
+// 7. "driver_vendor" is a string pattern.
// 8. "driver_version" is a VERSION structure (defined below).
// 9. "driver_date" is a VERSION structure (defined below).
// The version is interpreted as "year.month.day".
@@ -41,17 +41,16 @@
// The default value on Android is "gles", on Windows is "angle", on other
// platforms is "gl".
// 11. "gl_version" is a VERSION structure (defined below).
-// 12. "gl_vendor" is a STRING structure (defined below).
-// 13. "gl_renderer" is a STRING structure (defined below).
-// 14. "gl_extensions" is a STRING structure (defined below).
+// 12. "gl_vendor" is a string pattern.
+// 13. "gl_renderer" is a string pattern.
+// 14. "gl_extensions" is a string pattern.
// 15. "perf_graphics" is a FLOAT structure (defined below).
// 16. "perf_gaming" is a FLOAT structure (defined below).
// 17. "perf_overall" is a FLOAT structure (defined below).
-// 18. "machine_model_name" is an array of strings. The strings can contain
-// any characters.
+// 18. "machine_model_name" is an array of string patterns.
// 19. "machine_model_version" is a VERSION structure (defined below).
// 20. "gpu_count" is a INT structure (defined below).
-// 21 "cpu_info" is a STRING structure (defined below).
+// 21 "cpu_info" is a string pattern.
// 22. "exceptions" is a list of entries.
// 23. "features" is a list of gpu control list options, which can be
// configured by a specific list. See its *_json.cc file for a list of
@@ -74,12 +73,11 @@
// Only "driver_version" supports lexical style if the format is major.minor;
// in that case, major is still numerical, but minor is lexical.
//
-// STRING includes "op" and "value". "op" can be any of the following values:
-// "contains", "beginwith", "endwith", "=". "value" is a string.
-//
// FLOAT includes "op" "value", and "value2". "op" can be any of the
// following values: "=", "<", "<=", ">", ">=", "any", "between". "value2" is
// only used if "op" is "between". "value" is used for all "op" values except
// "any". "value" and "value2" are valid float numbers.
// INT is very much like FLOAT, except that the values need to be integers.
-
+//
+// String pattern syntax can be found at
+// https://code.google.com/p/re2/wiki/Syntax.
diff --git a/gpu/config/gpu_control_list_string_info_unittest.cc b/gpu/config/gpu_control_list_string_info_unittest.cc
deleted file mode 100644
index 39e2f5800c..0000000000
--- a/gpu/config/gpu_control_list_string_info_unittest.cc
+++ /dev/null
@@ -1,98 +0,0 @@
-// Copyright (c) 2013 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include "gpu/config/gpu_control_list.h"
-#include "testing/gtest/include/gtest/gtest.h"
-
-namespace gpu {
-
-class StringInfoTest : public testing::Test {
- public:
- StringInfoTest() { }
- virtual ~StringInfoTest() { }
-
- typedef GpuControlList::StringInfo StringInfo;
-};
-
-TEST_F(StringInfoTest, ValidStringInfo) {
- const std::string op[] = {
- "contains",
- "beginwith",
- "endwith",
- "="
- };
- for (size_t i = 0; i < arraysize(op); ++i) {
- {
- StringInfo info(op[i], std::string());
- EXPECT_TRUE(info.IsValid());
- }
- {
- StringInfo info(op[i], "hello");
- EXPECT_TRUE(info.IsValid());
- }
- }
-}
-
-TEST_F(StringInfoTest, InvalidStringInfo) {
- const std::string op[] = {
- "Contains",
- "BeginWith",
- "EndWith",
- " =",
- "= "
- };
- for (size_t i = 0; i < arraysize(op); ++i) {
- StringInfo info(op[i], "hello");
- EXPECT_FALSE(info.IsValid());
- }
-}
-
-TEST_F(StringInfoTest, StringComparison) {
- {
- StringInfo info("contains", "happy");
- EXPECT_TRUE(info.Contains("unhappy"));
- EXPECT_TRUE(info.Contains("happy1"));
- EXPECT_TRUE(info.Contains("happy"));
- EXPECT_TRUE(info.Contains("a happy dog"));
- EXPECT_TRUE(info.Contains("Happy"));
- EXPECT_TRUE(info.Contains("HAPPY"));
- EXPECT_FALSE(info.Contains("ha-ppy"));
- }
- {
- StringInfo info("beginwith", "happy");
- EXPECT_FALSE(info.Contains("unhappy"));
- EXPECT_TRUE(info.Contains("happy1"));
- EXPECT_TRUE(info.Contains("happy"));
- EXPECT_FALSE(info.Contains("a happy dog"));
- EXPECT_TRUE(info.Contains("Happy"));
- EXPECT_TRUE(info.Contains("HAPPY"));
- EXPECT_FALSE(info.Contains("ha-ppy"));
- }
- {
- StringInfo info("endwith", "happy");
- EXPECT_TRUE(info.Contains("unhappy"));
- EXPECT_FALSE(info.Contains("happy1"));
- EXPECT_TRUE(info.Contains("happy"));
- EXPECT_FALSE(info.Contains("a happy dog"));
- EXPECT_TRUE(info.Contains("Happy"));
- EXPECT_TRUE(info.Contains("HAPPY"));
- EXPECT_FALSE(info.Contains("ha-ppy"));
- }
- {
- StringInfo info("=", "happy");
- EXPECT_FALSE(info.Contains("unhappy"));
- EXPECT_FALSE(info.Contains("happy1"));
- EXPECT_TRUE(info.Contains("happy"));
- EXPECT_FALSE(info.Contains("a happy dog"));
- EXPECT_TRUE(info.Contains("Happy"));
- EXPECT_TRUE(info.Contains("HAPPY"));
- EXPECT_FALSE(info.Contains("ha-ppy"));
- EXPECT_FALSE(info.Contains("ha ppy"));
- EXPECT_FALSE(info.Contains(" happy"));
- EXPECT_FALSE(info.Contains("happy "));
- }
-}
-
-} // namespace gpu
-
diff --git a/gpu/config/gpu_control_list_unittest.cc b/gpu/config/gpu_control_list_unittest.cc
index 03a7d0e249..9ba06b897a 100644
--- a/gpu/config/gpu_control_list_unittest.cc
+++ b/gpu/config/gpu_control_list_unittest.cc
@@ -303,10 +303,7 @@ TEST_F(GpuControlListTest, NeedsMoreInfoForExceptions) {
"vendor_id": "0x8086",
"exceptions": [
{
- "gl_renderer": {
- "op": "contains",
- "value": "mesa"
- }
+ "gl_renderer": ".*mesa.*"
}
],
"features": [
diff --git a/gpu/config/gpu_driver_bug_list_json.cc b/gpu/config/gpu_driver_bug_list_json.cc
index 30ddda861a..ffaa929e57 100644
--- a/gpu/config/gpu_driver_bug_list_json.cc
+++ b/gpu/config/gpu_driver_bug_list_json.cc
@@ -19,7 +19,7 @@ const char kGpuDriverBugListJson[] = LONG_STRING_CONST(
{
"name": "gpu driver bug list",
// Please update the version number whenever you change this file.
- "version": "6.9",
+ "version": "7.0",
"entries": [
{
"id": 1,
@@ -27,10 +27,7 @@ const char kGpuDriverBugListJson[] = LONG_STRING_CONST(
"os": {
"type": "android"
},
- "gl_vendor": {
- "op": "beginwith",
- "value": "Imagination"
- },
+ "gl_vendor": "Imagination.*",
"features": [
"use_client_side_arrays_for_stream_buffers"
]
@@ -41,10 +38,7 @@ const char kGpuDriverBugListJson[] = LONG_STRING_CONST(
"os": {
"type": "android"
},
- "gl_vendor": {
- "op": "beginwith",
- "value": "ARM"
- },
+ "gl_vendor": "ARM.*",
"features": [
"use_client_side_arrays_for_stream_buffers"
]
@@ -112,10 +106,7 @@ const char kGpuDriverBugListJson[] = LONG_STRING_CONST(
"value": "4.3"
}
},
- "gl_vendor": {
- "op": "beginwith",
- "value": "Qualcomm"
- },
+ "gl_vendor": "Qualcomm.*",
"features": [
"restore_scissor_on_fbo_change"
]
@@ -256,10 +247,7 @@ const char kGpuDriverBugListJson[] = LONG_STRING_CONST(
"os": {
"type": "android"
},
- "gl_vendor": {
- "op": "beginwith",
- "value": "Qualcomm"
- },
+ "gl_vendor": "Qualcomm.*",
"features": [
"disable_depth_texture"
]
@@ -284,10 +272,7 @@ const char kGpuDriverBugListJson[] = LONG_STRING_CONST(
"os": {
"type": "android"
},
- "gl_extensions": {
- "op": "contains",
- "value": "GL_VIV_shader_binary"
- },
+ "gl_extensions": ".*GL_VIV_shader_binary.*",
"features": [
"unbind_fbo_on_context_switch"
]
@@ -299,10 +284,7 @@ const char kGpuDriverBugListJson[] = LONG_STRING_CONST(
"os": {
"type": "android"
},
- "gl_vendor": {
- "op": "beginwith",
- "value": "Imagination"
- },
+ "gl_vendor": "Imagination.*",
"features": [
"unbind_fbo_on_context_switch"
]
@@ -327,14 +309,8 @@ const char kGpuDriverBugListJson[] = LONG_STRING_CONST(
"os": {
"type": "android"
},
- "gl_vendor": {
- "op": "beginwith",
- "value": "ARM"
- },
- "gl_renderer": {
- "op": "contains",
- "value": "Mali-400"
- },
+ "gl_vendor": "ARM.*",
+ "gl_renderer": ".*Mali-400.*",
"features": [
"use_non_zero_size_for_client_side_stream_buffers"
]
@@ -397,14 +373,8 @@ const char kGpuDriverBugListJson[] = LONG_STRING_CONST(
"id": 31,
"cr_bugs": [154715, 10068, 269829, 294779, 285292],
"description": "The Mali-Txxx driver does not guarantee flush ordering",
- "gl_vendor": {
- "op": "beginwith",
- "value": "ARM"
- },
- "gl_renderer": {
- "op": "beginwith",
- "value": "Mali-T"
- },
+ "gl_vendor": "ARM.*",
+ "gl_renderer": "Mali-T.*",
"features": [
"use_virtualized_gl_contexts"
]
@@ -416,10 +386,7 @@ const char kGpuDriverBugListJson[] = LONG_STRING_CONST(
"os": {
"type": "android"
},
- "gl_vendor": {
- "op": "beginwith",
- "value": "Broadcom"
- },
+ "gl_vendor": "Broadcom.*",
"features": [
"use_virtualized_gl_contexts"
]
@@ -430,10 +397,7 @@ const char kGpuDriverBugListJson[] = LONG_STRING_CONST(
"os": {
"type": "android"
},
- "gl_vendor": {
- "op": "beginwith",
- "value": "Imagination"
- },
+ "gl_vendor": "Imagination.*",
"features": [
"use_virtualized_gl_contexts"
]
@@ -445,10 +409,7 @@ const char kGpuDriverBugListJson[] = LONG_STRING_CONST(
"os": {
"type": "android"
},
- "gl_extensions": {
- "op": "contains",
- "value": "GL_VIV_shader_binary"
- },
+ "gl_extensions": ".*GL_VIV_shader_binary.*",
"features": [
"use_virtualized_gl_contexts"
]
@@ -464,10 +425,7 @@ const char kGpuDriverBugListJson[] = LONG_STRING_CONST(
"value": "4.3"
}
},
- "gl_vendor": {
- "op": "beginwith",
- "value": "NVIDIA"
- },
+ "gl_vendor": "NVIDIA.*",
"features": [
"use_virtualized_gl_contexts"
]
@@ -483,10 +441,7 @@ const char kGpuDriverBugListJson[] = LONG_STRING_CONST(
"value": "4.3"
}
},
- "gl_vendor": {
- "op": "beginwith",
- "value": "Qualcomm"
- },
+ "gl_vendor": "Qualcomm.*",
"features": [
"use_virtualized_gl_contexts"
]
@@ -510,10 +465,7 @@ const char kGpuDriverBugListJson[] = LONG_STRING_CONST(
"os": {
"type": "android"
},
- "gl_vendor": {
- "op": "beginwith",
- "value": "Qualcomm"
- },
+ "gl_vendor": "Qualcomm.*",
"features": [
"use_virtualized_gl_contexts"
]
@@ -540,10 +492,7 @@ const char kGpuDriverBugListJson[] = LONG_STRING_CONST(
"value": "4.4"
}
},
- "gl_vendor": {
- "op": "beginwith",
- "value": "ARM"
- },
+ "gl_vendor": "ARM.*",
"features": [
"disable_ext_discard_framebuffer"
]
@@ -555,14 +504,8 @@ const char kGpuDriverBugListJson[] = LONG_STRING_CONST(
"os": {
"type": "android"
},
- "gl_vendor": {
- "op": "beginwith",
- "value": "Imagination"
- },
- "gl_renderer": {
- "op": "=",
- "value": "PowerVR SGX 540"
- },
+ "gl_vendor": "Imagination.*",
+ "gl_renderer": "PowerVR SGX 540",
"features": [
"disable_ext_discard_framebuffer"
]
@@ -574,10 +517,7 @@ const char kGpuDriverBugListJson[] = LONG_STRING_CONST(
"os": {
"type": "android"
},
- "gl_extensions": {
- "op": "contains",
- "value": "GL_VIV_shader_binary"
- },
+ "gl_extensions": ".*GL_VIV_shader_binary.*",
"features": [
"disable_ext_discard_framebuffer"
]
@@ -635,10 +575,7 @@ const char kGpuDriverBugListJson[] = LONG_STRING_CONST(
"os": {
"type": "android"
},
- "gl_vendor": {
- "op": "beginwith",
- "value": "Qualcomm"
- },
+ "gl_vendor": "Qualcomm.*",
"features": [
"wake_up_gpu_before_drawing"
]
@@ -654,10 +591,7 @@ const char kGpuDriverBugListJson[] = LONG_STRING_CONST(
"op": "<",
"value": "3.1"
},
- "gl_vendor": {
- "op": "beginwith",
- "value": "NVIDIA"
- },
+ "gl_vendor": "NVIDIA.*",
"features": [
"release_image_after_use"
]
@@ -668,10 +602,7 @@ const char kGpuDriverBugListJson[] = LONG_STRING_CONST(
"os": {
"type": "win"
},
- "gl_renderer": {
- "op": "beginwith",
- "value": "ANGLE"
- },
+ "gl_renderer": "ANGLE.*",
"features": [
"texsubimage2d_faster_than_teximage2d"
]
@@ -682,10 +613,7 @@ const char kGpuDriverBugListJson[] = LONG_STRING_CONST(
"os": {
"type": "android"
},
- "gl_vendor": {
- "op": "beginwith",
- "value": "Qualcomm"
- },
+ "gl_vendor": "Qualcomm.*",
"features": [
"disable_multisampling"
]
@@ -716,10 +644,7 @@ const char kGpuDriverBugListJson[] = LONG_STRING_CONST(
"os": {
"type": "linux"
},
- "driver_vendor": {
- "op": "=",
- "value": "Mesa"
- },
+ "driver_vendor": "Mesa",
"features": [
"count_all_in_varyings_packing"
]
@@ -731,10 +656,7 @@ const char kGpuDriverBugListJson[] = LONG_STRING_CONST(
"os": {
"type": "chromeos"
},
- "driver_vendor": {
- "op": "=",
- "value": "Mesa"
- },
+ "driver_vendor": "Mesa",
"features": [
"count_all_in_varyings_packing"
]
@@ -865,10 +787,7 @@ const char kGpuDriverBugListJson[] = LONG_STRING_CONST(
"id": 69,
"description": "Some shaders in Skia need more than the min available vertex and fragment shader uniform vectors in case of OSMesa",
"cr_bugs": [174845],
- "driver_vendor": {
- "op": "=",
- "value": "osmesa"
- },
+ "driver_vendor": "osmesa",
"features": [
"max_fragment_uniform_vectors_32",
"max_varying_vectors_16",
@@ -898,10 +817,7 @@ const char kGpuDriverBugListJson[] = LONG_STRING_CONST(
"os": {
"type": "android"
},
- "gl_extensions": {
- "op": "contains",
- "value": "GL_VIV_shader_binary"
- },
+ "gl_extensions": ".*GL_VIV_shader_binary.*",
"features": [
"disable_oes_standard_derivatives"
]
@@ -918,10 +834,7 @@ const char kGpuDriverBugListJson[] = LONG_STRING_CONST(
"op": "=",
"value": "3.1"
},
- "gl_vendor": {
- "op": "beginwith",
- "value": "NVidia"
- },
+ "gl_vendor": "NVIDIA.*",
"features": [
"use_virtualized_gl_contexts"
]
@@ -952,10 +865,7 @@ LONG_STRING_CONST(
"value": "4.4.4"
}
},
- "gl_vendor": {
- "op": "beginwith",
- "value": "Qualcomm"
- },
+ "gl_vendor": "Qualcomm.*",
"features": [
"disable_egl_khr_fence_sync"
]
@@ -971,14 +881,8 @@ LONG_STRING_CONST(
"value": "4.3"
}
},
- "gl_vendor": {
- "op": "beginwith",
- "value": "ARM"
- },
- "gl_renderer": {
- "op": "contains",
- "value": "Mali-400"
- },
+ "gl_vendor": "ARM.*",
+ "gl_renderer": ".*Mali-400.*",
"features": [
"disable_multisampling"
]
@@ -994,10 +898,7 @@ LONG_STRING_CONST(
"value": "4.4.4"
}
},
- "gl_vendor": {
- "op": "beginwith",
- "value": "Imagination Technologies"
- },
+ "gl_vendor": "Imagination Technologies.*",
"features": [
"disable_egl_khr_fence_sync"
]
@@ -1013,14 +914,8 @@ LONG_STRING_CONST(
"value": "4.4.4"
}
},
- "gl_vendor": {
- "op": "beginwith",
- "value": "ARM"
- },
- "gl_renderer": {
- "op": "beginwith",
- "value": "Mali-400 MP"
- },
+ "gl_vendor": "ARM.*",
+ "gl_renderer": "Mali-400 MP.*",
"features": [
"disable_egl_khr_fence_sync"
]
@@ -1036,10 +931,7 @@ LONG_STRING_CONST(
"value": "4.4.4"
}
},
- "gl_vendor": {
- "op": "beginwith",
- "value": "Broadcom"
- },
+ "gl_vendor": "Broadcom.*",
"features": [
"disable_egl_khr_fence_sync"
]
@@ -1066,10 +958,7 @@ LONG_STRING_CONST(
"value": "4.3"
}
},
- "gl_vendor": {
- "op": "beginwith",
- "value": "Qualcomm"
- },
+ "gl_vendor": "Qualcomm.*",
"features": [
"disable_async_readpixels"
]
@@ -1085,6 +974,22 @@ LONG_STRING_CONST(
"features": [
"disable_d3d11"
]
+ },
+ {
+ "id": 87,
+ "description": "Disable use of Direct3D 11 on older AMD drivers",
+ "cr_bugs": [402134],
+ "os": {
+ "type": "win"
+ },
+ "vendor_id": "0x1002",
+ "driver_date": {
+ "op": "<",
+ "value": "2011.1"
+ },
+ "features": [
+ "disable_d3d11"
+ ]
}
]
}
diff --git a/gpu/config/software_rendering_list_json.cc b/gpu/config/software_rendering_list_json.cc
index e0eab81a52..cfa5292405 100644
--- a/gpu/config/software_rendering_list_json.cc
+++ b/gpu/config/software_rendering_list_json.cc
@@ -18,7 +18,7 @@ const char kSoftwareRenderingListJson[] = LONG_STRING_CONST(
{
"name": "software rendering list",
// Please update the version number whenever you change this file.
- "version": "8.10",
+ "version": "9.0",
"entries": [
{
"id": 1,
@@ -42,10 +42,7 @@ const char kSoftwareRenderingListJson[] = LONG_STRING_CONST(
"os": {
"type": "linux"
},
- "gl_renderer": {
- "op": "contains",
- "value": "software"
- },
+ "gl_renderer": "(?i).*software.*",
"features": [
"all"
]
@@ -76,10 +73,7 @@ const char kSoftwareRenderingListJson[] = LONG_STRING_CONST(
"vendor_id": "0x1002",
"exceptions": [
{
- "driver_vendor": {
- "op": "contains",
- "value": "AMD"
- },
+ "driver_vendor": ".*AMD.*",
"driver_version": {
"op": ">=",
"style": "lexical",
@@ -87,10 +81,7 @@ const char kSoftwareRenderingListJson[] = LONG_STRING_CONST(
}
},
{
- "driver_vendor": {
- "op": "=",
- "value": "Mesa"
- },
+ "driver_vendor": "Mesa",
"driver_version": {
"op": ">=",
"value": "10.0.4"
@@ -150,10 +141,7 @@ const char kSoftwareRenderingListJson[] = LONG_STRING_CONST(
}
},
{
- "driver_vendor": {
- "op": "=",
- "value": "osmesa"
- }
+ "driver_vendor": "osmesa"
},
{
"vendor_id": "0x1414",
@@ -172,10 +160,7 @@ const char kSoftwareRenderingListJson[] = LONG_STRING_CONST(
"type": "linux"
},
"vendor_id": "0x8086",
- "driver_vendor": {
- "op": "=",
- "value": "Mesa"
- },
+ "driver_vendor": "Mesa",
"driver_version": {
"op": "<",
"value": "10.1"
@@ -240,20 +225,14 @@ const char kSoftwareRenderingListJson[] = LONG_STRING_CONST(
"os": {
"type": "linux"
},
- "driver_vendor": {
- "op": "=",
- "value": "Mesa"
- },
+ "driver_vendor": "Mesa",
"driver_version": {
"op": "<",
"value": "7.11"
},
"exceptions": [
{
- "driver_vendor": {
- "op": "=",
- "value": "osmesa"
- }
+ "driver_vendor": "osmesa"
}
],
"features": [
@@ -277,16 +256,10 @@ const char kSoftwareRenderingListJson[] = LONG_STRING_CONST(
"os": {
"type": "linux"
},
- "gl_vendor": {
- "op": "beginwith",
- "value": "ATI"
- },
+ "gl_vendor": "ATI.*",
"exceptions": [
{
- "driver_vendor": {
- "op": "contains",
- "value": "AMD"
- },
+ "driver_vendor": ".*AMD.*",
"driver_version": {
"op": ">=",
"style": "lexical",
@@ -294,10 +267,7 @@ const char kSoftwareRenderingListJson[] = LONG_STRING_CONST(
}
},
{
- "driver_vendor": {
- "op": "=",
- "value": "Mesa"
- },
+ "driver_vendor": "Mesa",
"driver_version": {
"op": ">=",
"value": "10.0.4"
@@ -315,20 +285,11 @@ const char kSoftwareRenderingListJson[] = LONG_STRING_CONST(
"os": {
"type": "linux"
},
- "gl_vendor": {
- "op": "beginwith",
- "value": "X.Org"
- },
- "gl_renderer": {
- "op": "contains",
- "value": "AMD"
- },
+ "gl_vendor": "X\\.Org.*",
+ "gl_renderer": ".*AMD.*",
"exceptions": [
{
- "driver_vendor": {
- "op": "=",
- "value": "Mesa"
- },
+ "driver_vendor": "Mesa",
"driver_version": {
"op": ">=",
"value": "10.0.4"
@@ -346,20 +307,11 @@ const char kSoftwareRenderingListJson[] = LONG_STRING_CONST(
"os": {
"type": "linux"
},
- "gl_vendor": {
- "op": "beginwith",
- "value": "X.Org"
- },
- "gl_renderer": {
- "op": "contains",
- "value": "ATI"
- },
+ "gl_vendor": "X\\.Org.*",
+ "gl_renderer": ".*ATI.*",
"exceptions": [
{
- "driver_vendor": {
- "op": "=",
- "value": "Mesa"
- },
+ "driver_vendor": "Mesa",
"driver_version": {
"op": ">=",
"value": "10.0.4"
@@ -378,10 +330,7 @@ const char kSoftwareRenderingListJson[] = LONG_STRING_CONST(
"type": "linux"
},
"vendor_id": "0x10de",
- "gl_vendor": {
- "op": "beginwith",
- "value": "nouveau"
- },
+ "gl_vendor": "(?i)nouveau.*",
"features": [
"all"
]
@@ -405,10 +354,7 @@ const char kSoftwareRenderingListJson[] = LONG_STRING_CONST(
}
},
{
- "cpu_info": {
- "op": "contains",
- "value": "Atom"
- }
+ "cpu_info": "(?i).*Atom.*"
}
],
"features": [
@@ -449,18 +395,12 @@ const char kSoftwareRenderingListJson[] = LONG_STRING_CONST(
"multi_gpu_style": "optimus",
"exceptions": [
{
- "driver_vendor": {
- "op": "=",
- "value": "Mesa"
- },
+ "driver_vendor": "Mesa",
"driver_version": {
"op": ">=",
"value": "10.1"
},
- "gl_vendor": {
- "op": "beginwith",
- "value": "Intel"
- }
+ "gl_vendor": "Intel.*"
}
],
"features": [
@@ -557,10 +497,7 @@ const char kSoftwareRenderingListJson[] = LONG_STRING_CONST(
"type": "linux"
},
"vendor_id": "0x10de",
- "driver_vendor": {
- "op": "=",
- "value": "NVIDIA"
- },
+ "driver_vendor": "NVIDIA",
"driver_version": {
"op": "<",
"value": "295"
@@ -621,24 +558,15 @@ const char kSoftwareRenderingListJson[] = LONG_STRING_CONST(
"os": {
"type": "linux"
},
- "gl_vendor": {
- "op": "beginwith",
- "value": "VMware"
- },
+ "gl_vendor": "VMware.*",
"exceptions": [
{
- "driver_vendor": {
- "op": "=",
- "value": "Mesa"
- },
+ "driver_vendor": "Mesa",
"driver_version": {
"op": ">=",
"value": "9.2.1"
},
- "gl_renderer": {
- "op": "contains",
- "value": "SVGA3D"
- }
+ "gl_renderer": ".*SVGA3D.*"
}
],
"features": [
@@ -663,10 +591,7 @@ const char kSoftwareRenderingListJson[] = LONG_STRING_CONST(
"type": "linux"
},
"vendor_id": "0x10de",
- "driver_vendor": {
- "op": "=",
- "value": "NVIDIA"
- },
+ "driver_vendor": "NVIDIA",
"features": [
"accelerated_video_decode",
"flash_3d",
@@ -716,10 +641,7 @@ const char kSoftwareRenderingListJson[] = LONG_STRING_CONST(
"os": {
"type": "android"
},
- "gl_renderer": {
- "op": "contains",
- "value": "Adreno"
- },
+ "gl_renderer": ".*Adreno.*",
"driver_version": {
"op": "<",
"value": "4.1"
@@ -848,10 +770,7 @@ const char kSoftwareRenderingListJson[] = LONG_STRING_CONST(
"os": {
"type": "win"
},
- "driver_vendor": {
- "op": "=",
- "value": "Microsoft"
- },
+ "driver_vendor": "Microsoft",
"exceptions": [
{
"vendor_id": "0x1414",
@@ -1112,10 +1031,7 @@ LONG_STRING_CONST(
"type": "linux"
},
"vendor_id": "0x1002",
- "driver_vendor": {
- "op": "contains",
- "value": "AMD"
- },
+ "driver_vendor": ".*AMD.*",
"driver_version": {
"op": "=",
"value": "13.101"
@@ -1126,13 +1042,13 @@ LONG_STRING_CONST(
},
{
"id": 96,
- "description": "GPU rasterization is whitelisted on N4, N5, N7 and Moto X",
+ "description": "GPU rasterization is whitelisted on N4, N5, N7 and Moto X, and on Qualcomm GPUs on Android 4.4",
"cr_bugs": [362779],
+ "os": {
+ "type": "android"
+ },
"exceptions": [
{
- "os": {
- "type": "android"
- },
"machine_model_name": ["Nexus 4", "Nexus 5", "Nexus 7",
"XT1049", "XT1050", "XT1052", "XT1053",
"XT1055", "XT1056", "XT1058", "XT1060"]
@@ -1145,6 +1061,16 @@ LONG_STRING_CONST(
"value": "4.4.99"
}
}
+ },
+ {
+ "os": {
+ "type": "android",
+ "version": {
+ "op": ">=",
+ "value": "4.4"
+ }
+ },
+ "gl_vendor": "Qualcomm.*"
}
],
"features": [
@@ -1191,6 +1117,21 @@ LONG_STRING_CONST(
"features": [
"gpu_rasterization_expanded_heuristics"
]
+ },
+ {
+ "id": 99,
+ "description": "GPU rasterization is blacklisted on non-Android",
+ "cr_bugs": [362779],
+ "exceptions": [
+ {
+ "os": {
+ "type": "android"
+ }
+ }
+ ],
+ "features": [
+ "gpu_rasterization"
+ ]
}
]
}
diff --git a/gpu/disk_cache_proto.target.darwin-arm.mk b/gpu/disk_cache_proto.target.darwin-arm.mk
index a2a2e39a66..a12fbf9594 100644
--- a/gpu/disk_cache_proto.target.darwin-arm.mk
+++ b/gpu/disk_cache_proto.target.darwin-arm.mk
@@ -94,7 +94,6 @@ MY_CFLAGS_Debug := \
MY_DEFS_Debug := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
@@ -202,7 +201,6 @@ MY_CFLAGS_Release := \
MY_DEFS_Release := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
diff --git a/gpu/disk_cache_proto.target.darwin-arm64.mk b/gpu/disk_cache_proto.target.darwin-arm64.mk
index 327d4fd933..23a89b6eb5 100644
--- a/gpu/disk_cache_proto.target.darwin-arm64.mk
+++ b/gpu/disk_cache_proto.target.darwin-arm64.mk
@@ -83,7 +83,6 @@ MY_CFLAGS_Debug := \
MY_DEFS_Debug := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
@@ -179,7 +178,6 @@ MY_CFLAGS_Release := \
MY_DEFS_Release := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
diff --git a/gpu/disk_cache_proto.target.darwin-mips.mk b/gpu/disk_cache_proto.target.darwin-mips.mk
index 8d5f1d6d83..39e0a4834f 100644
--- a/gpu/disk_cache_proto.target.darwin-mips.mk
+++ b/gpu/disk_cache_proto.target.darwin-mips.mk
@@ -88,7 +88,6 @@ MY_CFLAGS_Debug := \
MY_DEFS_Debug := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
@@ -190,7 +189,6 @@ MY_CFLAGS_Release := \
MY_DEFS_Release := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
diff --git a/gpu/disk_cache_proto.target.darwin-x86.mk b/gpu/disk_cache_proto.target.darwin-x86.mk
index 310fd20792..7fb672f9d3 100644
--- a/gpu/disk_cache_proto.target.darwin-x86.mk
+++ b/gpu/disk_cache_proto.target.darwin-x86.mk
@@ -89,7 +89,6 @@ MY_CFLAGS_Debug := \
MY_DEFS_Debug := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
@@ -191,7 +190,6 @@ MY_CFLAGS_Release := \
MY_DEFS_Release := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
diff --git a/gpu/disk_cache_proto.target.darwin-x86_64.mk b/gpu/disk_cache_proto.target.darwin-x86_64.mk
index e4ec0155e8..12ef477c4b 100644
--- a/gpu/disk_cache_proto.target.darwin-x86_64.mk
+++ b/gpu/disk_cache_proto.target.darwin-x86_64.mk
@@ -88,7 +88,6 @@ MY_CFLAGS_Debug := \
MY_DEFS_Debug := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
@@ -189,7 +188,6 @@ MY_CFLAGS_Release := \
MY_DEFS_Release := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
diff --git a/gpu/disk_cache_proto.target.linux-arm.mk b/gpu/disk_cache_proto.target.linux-arm.mk
index a2a2e39a66..a12fbf9594 100644
--- a/gpu/disk_cache_proto.target.linux-arm.mk
+++ b/gpu/disk_cache_proto.target.linux-arm.mk
@@ -94,7 +94,6 @@ MY_CFLAGS_Debug := \
MY_DEFS_Debug := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
@@ -202,7 +201,6 @@ MY_CFLAGS_Release := \
MY_DEFS_Release := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
diff --git a/gpu/disk_cache_proto.target.linux-arm64.mk b/gpu/disk_cache_proto.target.linux-arm64.mk
index 327d4fd933..23a89b6eb5 100644
--- a/gpu/disk_cache_proto.target.linux-arm64.mk
+++ b/gpu/disk_cache_proto.target.linux-arm64.mk
@@ -83,7 +83,6 @@ MY_CFLAGS_Debug := \
MY_DEFS_Debug := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
@@ -179,7 +178,6 @@ MY_CFLAGS_Release := \
MY_DEFS_Release := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
diff --git a/gpu/disk_cache_proto.target.linux-mips.mk b/gpu/disk_cache_proto.target.linux-mips.mk
index 8d5f1d6d83..39e0a4834f 100644
--- a/gpu/disk_cache_proto.target.linux-mips.mk
+++ b/gpu/disk_cache_proto.target.linux-mips.mk
@@ -88,7 +88,6 @@ MY_CFLAGS_Debug := \
MY_DEFS_Debug := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
@@ -190,7 +189,6 @@ MY_CFLAGS_Release := \
MY_DEFS_Release := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
diff --git a/gpu/disk_cache_proto.target.linux-x86.mk b/gpu/disk_cache_proto.target.linux-x86.mk
index 310fd20792..7fb672f9d3 100644
--- a/gpu/disk_cache_proto.target.linux-x86.mk
+++ b/gpu/disk_cache_proto.target.linux-x86.mk
@@ -89,7 +89,6 @@ MY_CFLAGS_Debug := \
MY_DEFS_Debug := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
@@ -191,7 +190,6 @@ MY_CFLAGS_Release := \
MY_DEFS_Release := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
diff --git a/gpu/disk_cache_proto.target.linux-x86_64.mk b/gpu/disk_cache_proto.target.linux-x86_64.mk
index e4ec0155e8..12ef477c4b 100644
--- a/gpu/disk_cache_proto.target.linux-x86_64.mk
+++ b/gpu/disk_cache_proto.target.linux-x86_64.mk
@@ -88,7 +88,6 @@ MY_CFLAGS_Debug := \
MY_DEFS_Debug := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
@@ -189,7 +188,6 @@ MY_CFLAGS_Release := \
MY_DEFS_Release := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
diff --git a/gpu/gl_in_process_context.target.darwin-arm.mk b/gpu/gl_in_process_context.target.darwin-arm.mk
index 7a26834b06..725169cb7b 100644
--- a/gpu/gl_in_process_context.target.darwin-arm.mk
+++ b/gpu/gl_in_process_context.target.darwin-arm.mk
@@ -72,7 +72,6 @@ MY_CFLAGS_Debug := \
MY_DEFS_Debug := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
@@ -184,7 +183,6 @@ MY_CFLAGS_Release := \
MY_DEFS_Release := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
diff --git a/gpu/gl_in_process_context.target.darwin-arm64.mk b/gpu/gl_in_process_context.target.darwin-arm64.mk
index fd6d75ea94..bc6c5a916c 100644
--- a/gpu/gl_in_process_context.target.darwin-arm64.mk
+++ b/gpu/gl_in_process_context.target.darwin-arm64.mk
@@ -61,7 +61,6 @@ MY_CFLAGS_Debug := \
MY_DEFS_Debug := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
@@ -161,7 +160,6 @@ MY_CFLAGS_Release := \
MY_DEFS_Release := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
diff --git a/gpu/gl_in_process_context.target.darwin-mips.mk b/gpu/gl_in_process_context.target.darwin-mips.mk
index 20d37aaa71..d3f7f44b98 100644
--- a/gpu/gl_in_process_context.target.darwin-mips.mk
+++ b/gpu/gl_in_process_context.target.darwin-mips.mk
@@ -66,7 +66,6 @@ MY_CFLAGS_Debug := \
MY_DEFS_Debug := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
@@ -172,7 +171,6 @@ MY_CFLAGS_Release := \
MY_DEFS_Release := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
diff --git a/gpu/gl_in_process_context.target.darwin-x86.mk b/gpu/gl_in_process_context.target.darwin-x86.mk
index b5cc3bf2b9..92d0dd6ca6 100644
--- a/gpu/gl_in_process_context.target.darwin-x86.mk
+++ b/gpu/gl_in_process_context.target.darwin-x86.mk
@@ -67,7 +67,6 @@ MY_CFLAGS_Debug := \
MY_DEFS_Debug := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
@@ -173,7 +172,6 @@ MY_CFLAGS_Release := \
MY_DEFS_Release := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
diff --git a/gpu/gl_in_process_context.target.darwin-x86_64.mk b/gpu/gl_in_process_context.target.darwin-x86_64.mk
index e39dc1c35b..30789d6103 100644
--- a/gpu/gl_in_process_context.target.darwin-x86_64.mk
+++ b/gpu/gl_in_process_context.target.darwin-x86_64.mk
@@ -66,7 +66,6 @@ MY_CFLAGS_Debug := \
MY_DEFS_Debug := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
@@ -171,7 +170,6 @@ MY_CFLAGS_Release := \
MY_DEFS_Release := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
diff --git a/gpu/gl_in_process_context.target.linux-arm.mk b/gpu/gl_in_process_context.target.linux-arm.mk
index 7a26834b06..725169cb7b 100644
--- a/gpu/gl_in_process_context.target.linux-arm.mk
+++ b/gpu/gl_in_process_context.target.linux-arm.mk
@@ -72,7 +72,6 @@ MY_CFLAGS_Debug := \
MY_DEFS_Debug := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
@@ -184,7 +183,6 @@ MY_CFLAGS_Release := \
MY_DEFS_Release := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
diff --git a/gpu/gl_in_process_context.target.linux-arm64.mk b/gpu/gl_in_process_context.target.linux-arm64.mk
index fd6d75ea94..bc6c5a916c 100644
--- a/gpu/gl_in_process_context.target.linux-arm64.mk
+++ b/gpu/gl_in_process_context.target.linux-arm64.mk
@@ -61,7 +61,6 @@ MY_CFLAGS_Debug := \
MY_DEFS_Debug := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
@@ -161,7 +160,6 @@ MY_CFLAGS_Release := \
MY_DEFS_Release := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
diff --git a/gpu/gl_in_process_context.target.linux-mips.mk b/gpu/gl_in_process_context.target.linux-mips.mk
index 20d37aaa71..d3f7f44b98 100644
--- a/gpu/gl_in_process_context.target.linux-mips.mk
+++ b/gpu/gl_in_process_context.target.linux-mips.mk
@@ -66,7 +66,6 @@ MY_CFLAGS_Debug := \
MY_DEFS_Debug := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
@@ -172,7 +171,6 @@ MY_CFLAGS_Release := \
MY_DEFS_Release := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
diff --git a/gpu/gl_in_process_context.target.linux-x86.mk b/gpu/gl_in_process_context.target.linux-x86.mk
index b5cc3bf2b9..92d0dd6ca6 100644
--- a/gpu/gl_in_process_context.target.linux-x86.mk
+++ b/gpu/gl_in_process_context.target.linux-x86.mk
@@ -67,7 +67,6 @@ MY_CFLAGS_Debug := \
MY_DEFS_Debug := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
@@ -173,7 +172,6 @@ MY_CFLAGS_Release := \
MY_DEFS_Release := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
diff --git a/gpu/gl_in_process_context.target.linux-x86_64.mk b/gpu/gl_in_process_context.target.linux-x86_64.mk
index e39dc1c35b..30789d6103 100644
--- a/gpu/gl_in_process_context.target.linux-x86_64.mk
+++ b/gpu/gl_in_process_context.target.linux-x86_64.mk
@@ -66,7 +66,6 @@ MY_CFLAGS_Debug := \
MY_DEFS_Debug := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
@@ -171,7 +170,6 @@ MY_CFLAGS_Release := \
MY_DEFS_Release := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
diff --git a/gpu/gles2_c_lib.target.darwin-arm.mk b/gpu/gles2_c_lib.target.darwin-arm.mk
index 8130f97e42..17e3188b1f 100644
--- a/gpu/gles2_c_lib.target.darwin-arm.mk
+++ b/gpu/gles2_c_lib.target.darwin-arm.mk
@@ -71,7 +71,6 @@ MY_CFLAGS_Debug := \
MY_DEFS_Debug := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
@@ -177,7 +176,6 @@ MY_CFLAGS_Release := \
MY_DEFS_Release := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
diff --git a/gpu/gles2_c_lib.target.darwin-arm64.mk b/gpu/gles2_c_lib.target.darwin-arm64.mk
index 8e5d4af30a..3915d971d7 100644
--- a/gpu/gles2_c_lib.target.darwin-arm64.mk
+++ b/gpu/gles2_c_lib.target.darwin-arm64.mk
@@ -60,7 +60,6 @@ MY_CFLAGS_Debug := \
MY_DEFS_Debug := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
@@ -154,7 +153,6 @@ MY_CFLAGS_Release := \
MY_DEFS_Release := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
diff --git a/gpu/gles2_c_lib.target.darwin-mips.mk b/gpu/gles2_c_lib.target.darwin-mips.mk
index 2f9f9fe06b..f00fdeb649 100644
--- a/gpu/gles2_c_lib.target.darwin-mips.mk
+++ b/gpu/gles2_c_lib.target.darwin-mips.mk
@@ -65,7 +65,6 @@ MY_CFLAGS_Debug := \
MY_DEFS_Debug := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
@@ -165,7 +164,6 @@ MY_CFLAGS_Release := \
MY_DEFS_Release := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
diff --git a/gpu/gles2_c_lib.target.darwin-x86.mk b/gpu/gles2_c_lib.target.darwin-x86.mk
index ad2882e4da..e735ff9079 100644
--- a/gpu/gles2_c_lib.target.darwin-x86.mk
+++ b/gpu/gles2_c_lib.target.darwin-x86.mk
@@ -66,7 +66,6 @@ MY_CFLAGS_Debug := \
MY_DEFS_Debug := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
@@ -166,7 +165,6 @@ MY_CFLAGS_Release := \
MY_DEFS_Release := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
diff --git a/gpu/gles2_c_lib.target.darwin-x86_64.mk b/gpu/gles2_c_lib.target.darwin-x86_64.mk
index ba896263d0..3db4a3b450 100644
--- a/gpu/gles2_c_lib.target.darwin-x86_64.mk
+++ b/gpu/gles2_c_lib.target.darwin-x86_64.mk
@@ -65,7 +65,6 @@ MY_CFLAGS_Debug := \
MY_DEFS_Debug := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
@@ -164,7 +163,6 @@ MY_CFLAGS_Release := \
MY_DEFS_Release := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
diff --git a/gpu/gles2_c_lib.target.linux-arm.mk b/gpu/gles2_c_lib.target.linux-arm.mk
index 8130f97e42..17e3188b1f 100644
--- a/gpu/gles2_c_lib.target.linux-arm.mk
+++ b/gpu/gles2_c_lib.target.linux-arm.mk
@@ -71,7 +71,6 @@ MY_CFLAGS_Debug := \
MY_DEFS_Debug := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
@@ -177,7 +176,6 @@ MY_CFLAGS_Release := \
MY_DEFS_Release := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
diff --git a/gpu/gles2_c_lib.target.linux-arm64.mk b/gpu/gles2_c_lib.target.linux-arm64.mk
index 8e5d4af30a..3915d971d7 100644
--- a/gpu/gles2_c_lib.target.linux-arm64.mk
+++ b/gpu/gles2_c_lib.target.linux-arm64.mk
@@ -60,7 +60,6 @@ MY_CFLAGS_Debug := \
MY_DEFS_Debug := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
@@ -154,7 +153,6 @@ MY_CFLAGS_Release := \
MY_DEFS_Release := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
diff --git a/gpu/gles2_c_lib.target.linux-mips.mk b/gpu/gles2_c_lib.target.linux-mips.mk
index 2f9f9fe06b..f00fdeb649 100644
--- a/gpu/gles2_c_lib.target.linux-mips.mk
+++ b/gpu/gles2_c_lib.target.linux-mips.mk
@@ -65,7 +65,6 @@ MY_CFLAGS_Debug := \
MY_DEFS_Debug := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
@@ -165,7 +164,6 @@ MY_CFLAGS_Release := \
MY_DEFS_Release := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
diff --git a/gpu/gles2_c_lib.target.linux-x86.mk b/gpu/gles2_c_lib.target.linux-x86.mk
index ad2882e4da..e735ff9079 100644
--- a/gpu/gles2_c_lib.target.linux-x86.mk
+++ b/gpu/gles2_c_lib.target.linux-x86.mk
@@ -66,7 +66,6 @@ MY_CFLAGS_Debug := \
MY_DEFS_Debug := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
@@ -166,7 +165,6 @@ MY_CFLAGS_Release := \
MY_DEFS_Release := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
diff --git a/gpu/gles2_c_lib.target.linux-x86_64.mk b/gpu/gles2_c_lib.target.linux-x86_64.mk
index ba896263d0..3db4a3b450 100644
--- a/gpu/gles2_c_lib.target.linux-x86_64.mk
+++ b/gpu/gles2_c_lib.target.linux-x86_64.mk
@@ -65,7 +65,6 @@ MY_CFLAGS_Debug := \
MY_DEFS_Debug := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
@@ -164,7 +163,6 @@ MY_CFLAGS_Release := \
MY_DEFS_Release := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
diff --git a/gpu/gles2_cmd_helper.target.darwin-arm.mk b/gpu/gles2_cmd_helper.target.darwin-arm.mk
index fbbc59d1eb..c56bc98135 100644
--- a/gpu/gles2_cmd_helper.target.darwin-arm.mk
+++ b/gpu/gles2_cmd_helper.target.darwin-arm.mk
@@ -70,7 +70,6 @@ MY_CFLAGS_Debug := \
MY_DEFS_Debug := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
@@ -175,7 +174,6 @@ MY_CFLAGS_Release := \
MY_DEFS_Release := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
diff --git a/gpu/gles2_cmd_helper.target.darwin-arm64.mk b/gpu/gles2_cmd_helper.target.darwin-arm64.mk
index d5fb3f50fd..7ac7ba8bc2 100644
--- a/gpu/gles2_cmd_helper.target.darwin-arm64.mk
+++ b/gpu/gles2_cmd_helper.target.darwin-arm64.mk
@@ -59,7 +59,6 @@ MY_CFLAGS_Debug := \
MY_DEFS_Debug := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
@@ -152,7 +151,6 @@ MY_CFLAGS_Release := \
MY_DEFS_Release := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
diff --git a/gpu/gles2_cmd_helper.target.darwin-mips.mk b/gpu/gles2_cmd_helper.target.darwin-mips.mk
index 12fcdd2750..be230413c9 100644
--- a/gpu/gles2_cmd_helper.target.darwin-mips.mk
+++ b/gpu/gles2_cmd_helper.target.darwin-mips.mk
@@ -64,7 +64,6 @@ MY_CFLAGS_Debug := \
MY_DEFS_Debug := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
@@ -163,7 +162,6 @@ MY_CFLAGS_Release := \
MY_DEFS_Release := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
diff --git a/gpu/gles2_cmd_helper.target.darwin-x86.mk b/gpu/gles2_cmd_helper.target.darwin-x86.mk
index 0dfde4ac46..514c58fd92 100644
--- a/gpu/gles2_cmd_helper.target.darwin-x86.mk
+++ b/gpu/gles2_cmd_helper.target.darwin-x86.mk
@@ -65,7 +65,6 @@ MY_CFLAGS_Debug := \
MY_DEFS_Debug := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
@@ -164,7 +163,6 @@ MY_CFLAGS_Release := \
MY_DEFS_Release := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
diff --git a/gpu/gles2_cmd_helper.target.darwin-x86_64.mk b/gpu/gles2_cmd_helper.target.darwin-x86_64.mk
index 1f3a9633fa..2cad5db532 100644
--- a/gpu/gles2_cmd_helper.target.darwin-x86_64.mk
+++ b/gpu/gles2_cmd_helper.target.darwin-x86_64.mk
@@ -64,7 +64,6 @@ MY_CFLAGS_Debug := \
MY_DEFS_Debug := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
@@ -162,7 +161,6 @@ MY_CFLAGS_Release := \
MY_DEFS_Release := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
diff --git a/gpu/gles2_cmd_helper.target.linux-arm.mk b/gpu/gles2_cmd_helper.target.linux-arm.mk
index fbbc59d1eb..c56bc98135 100644
--- a/gpu/gles2_cmd_helper.target.linux-arm.mk
+++ b/gpu/gles2_cmd_helper.target.linux-arm.mk
@@ -70,7 +70,6 @@ MY_CFLAGS_Debug := \
MY_DEFS_Debug := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
@@ -175,7 +174,6 @@ MY_CFLAGS_Release := \
MY_DEFS_Release := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
diff --git a/gpu/gles2_cmd_helper.target.linux-arm64.mk b/gpu/gles2_cmd_helper.target.linux-arm64.mk
index d5fb3f50fd..7ac7ba8bc2 100644
--- a/gpu/gles2_cmd_helper.target.linux-arm64.mk
+++ b/gpu/gles2_cmd_helper.target.linux-arm64.mk
@@ -59,7 +59,6 @@ MY_CFLAGS_Debug := \
MY_DEFS_Debug := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
@@ -152,7 +151,6 @@ MY_CFLAGS_Release := \
MY_DEFS_Release := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
diff --git a/gpu/gles2_cmd_helper.target.linux-mips.mk b/gpu/gles2_cmd_helper.target.linux-mips.mk
index 12fcdd2750..be230413c9 100644
--- a/gpu/gles2_cmd_helper.target.linux-mips.mk
+++ b/gpu/gles2_cmd_helper.target.linux-mips.mk
@@ -64,7 +64,6 @@ MY_CFLAGS_Debug := \
MY_DEFS_Debug := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
@@ -163,7 +162,6 @@ MY_CFLAGS_Release := \
MY_DEFS_Release := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
diff --git a/gpu/gles2_cmd_helper.target.linux-x86.mk b/gpu/gles2_cmd_helper.target.linux-x86.mk
index 0dfde4ac46..514c58fd92 100644
--- a/gpu/gles2_cmd_helper.target.linux-x86.mk
+++ b/gpu/gles2_cmd_helper.target.linux-x86.mk
@@ -65,7 +65,6 @@ MY_CFLAGS_Debug := \
MY_DEFS_Debug := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
@@ -164,7 +163,6 @@ MY_CFLAGS_Release := \
MY_DEFS_Release := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
diff --git a/gpu/gles2_cmd_helper.target.linux-x86_64.mk b/gpu/gles2_cmd_helper.target.linux-x86_64.mk
index 1f3a9633fa..2cad5db532 100644
--- a/gpu/gles2_cmd_helper.target.linux-x86_64.mk
+++ b/gpu/gles2_cmd_helper.target.linux-x86_64.mk
@@ -64,7 +64,6 @@ MY_CFLAGS_Debug := \
MY_DEFS_Debug := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
@@ -162,7 +161,6 @@ MY_CFLAGS_Release := \
MY_DEFS_Release := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
diff --git a/gpu/gles2_implementation.target.darwin-arm.mk b/gpu/gles2_implementation.target.darwin-arm.mk
index 12fe25390b..fd058e9090 100644
--- a/gpu/gles2_implementation.target.darwin-arm.mk
+++ b/gpu/gles2_implementation.target.darwin-arm.mk
@@ -80,7 +80,6 @@ MY_CFLAGS_Debug := \
MY_DEFS_Debug := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
@@ -192,7 +191,6 @@ MY_CFLAGS_Release := \
MY_DEFS_Release := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
diff --git a/gpu/gles2_implementation.target.darwin-arm64.mk b/gpu/gles2_implementation.target.darwin-arm64.mk
index ceb06ce841..4b91a39b86 100644
--- a/gpu/gles2_implementation.target.darwin-arm64.mk
+++ b/gpu/gles2_implementation.target.darwin-arm64.mk
@@ -69,7 +69,6 @@ MY_CFLAGS_Debug := \
MY_DEFS_Debug := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
@@ -169,7 +168,6 @@ MY_CFLAGS_Release := \
MY_DEFS_Release := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
diff --git a/gpu/gles2_implementation.target.darwin-mips.mk b/gpu/gles2_implementation.target.darwin-mips.mk
index 6b9f02f043..5f3a62b426 100644
--- a/gpu/gles2_implementation.target.darwin-mips.mk
+++ b/gpu/gles2_implementation.target.darwin-mips.mk
@@ -74,7 +74,6 @@ MY_CFLAGS_Debug := \
MY_DEFS_Debug := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
@@ -180,7 +179,6 @@ MY_CFLAGS_Release := \
MY_DEFS_Release := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
diff --git a/gpu/gles2_implementation.target.darwin-x86.mk b/gpu/gles2_implementation.target.darwin-x86.mk
index 4b5aa5a250..5513f20a2d 100644
--- a/gpu/gles2_implementation.target.darwin-x86.mk
+++ b/gpu/gles2_implementation.target.darwin-x86.mk
@@ -75,7 +75,6 @@ MY_CFLAGS_Debug := \
MY_DEFS_Debug := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
@@ -181,7 +180,6 @@ MY_CFLAGS_Release := \
MY_DEFS_Release := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
diff --git a/gpu/gles2_implementation.target.darwin-x86_64.mk b/gpu/gles2_implementation.target.darwin-x86_64.mk
index c6f39e7159..02f22bc4a0 100644
--- a/gpu/gles2_implementation.target.darwin-x86_64.mk
+++ b/gpu/gles2_implementation.target.darwin-x86_64.mk
@@ -74,7 +74,6 @@ MY_CFLAGS_Debug := \
MY_DEFS_Debug := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
@@ -179,7 +178,6 @@ MY_CFLAGS_Release := \
MY_DEFS_Release := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
diff --git a/gpu/gles2_implementation.target.linux-arm.mk b/gpu/gles2_implementation.target.linux-arm.mk
index 12fe25390b..fd058e9090 100644
--- a/gpu/gles2_implementation.target.linux-arm.mk
+++ b/gpu/gles2_implementation.target.linux-arm.mk
@@ -80,7 +80,6 @@ MY_CFLAGS_Debug := \
MY_DEFS_Debug := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
@@ -192,7 +191,6 @@ MY_CFLAGS_Release := \
MY_DEFS_Release := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
diff --git a/gpu/gles2_implementation.target.linux-arm64.mk b/gpu/gles2_implementation.target.linux-arm64.mk
index ceb06ce841..4b91a39b86 100644
--- a/gpu/gles2_implementation.target.linux-arm64.mk
+++ b/gpu/gles2_implementation.target.linux-arm64.mk
@@ -69,7 +69,6 @@ MY_CFLAGS_Debug := \
MY_DEFS_Debug := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
@@ -169,7 +168,6 @@ MY_CFLAGS_Release := \
MY_DEFS_Release := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
diff --git a/gpu/gles2_implementation.target.linux-mips.mk b/gpu/gles2_implementation.target.linux-mips.mk
index 6b9f02f043..5f3a62b426 100644
--- a/gpu/gles2_implementation.target.linux-mips.mk
+++ b/gpu/gles2_implementation.target.linux-mips.mk
@@ -74,7 +74,6 @@ MY_CFLAGS_Debug := \
MY_DEFS_Debug := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
@@ -180,7 +179,6 @@ MY_CFLAGS_Release := \
MY_DEFS_Release := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
diff --git a/gpu/gles2_implementation.target.linux-x86.mk b/gpu/gles2_implementation.target.linux-x86.mk
index 4b5aa5a250..5513f20a2d 100644
--- a/gpu/gles2_implementation.target.linux-x86.mk
+++ b/gpu/gles2_implementation.target.linux-x86.mk
@@ -75,7 +75,6 @@ MY_CFLAGS_Debug := \
MY_DEFS_Debug := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
@@ -181,7 +180,6 @@ MY_CFLAGS_Release := \
MY_DEFS_Release := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
diff --git a/gpu/gles2_implementation.target.linux-x86_64.mk b/gpu/gles2_implementation.target.linux-x86_64.mk
index c6f39e7159..02f22bc4a0 100644
--- a/gpu/gles2_implementation.target.linux-x86_64.mk
+++ b/gpu/gles2_implementation.target.linux-x86_64.mk
@@ -74,7 +74,6 @@ MY_CFLAGS_Debug := \
MY_DEFS_Debug := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
@@ -179,7 +178,6 @@ MY_CFLAGS_Release := \
MY_DEFS_Release := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
diff --git a/gpu/gpu.gyp b/gpu/gpu.gyp
index aa2a8c1bd6..294f436e68 100644
--- a/gpu/gpu.gyp
+++ b/gpu/gpu.gyp
@@ -37,6 +37,7 @@
'target_name': 'gl_in_process_context',
'type': '<(component)',
'dependencies': [
+ 'command_buffer/command_buffer.gyp:gles2_utils',
'gles2_implementation',
'gpu',
'../base/base.gyp:base',
@@ -276,7 +277,6 @@
'config/gpu_control_list_entry_unittest.cc',
'config/gpu_control_list_number_info_unittest.cc',
'config/gpu_control_list_os_info_unittest.cc',
- 'config/gpu_control_list_string_info_unittest.cc',
'config/gpu_control_list_unittest.cc',
'config/gpu_control_list_version_info_unittest.cc',
'config/gpu_driver_bug_list_unittest.cc',
diff --git a/gpu/gpu.target.darwin-arm.mk b/gpu/gpu.target.darwin-arm.mk
index 97a8a85e93..a656e267e2 100644
--- a/gpu/gpu.target.darwin-arm.mk
+++ b/gpu/gpu.target.darwin-arm.mk
@@ -75,7 +75,6 @@ MY_CFLAGS_Debug := \
MY_DEFS_Debug := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
@@ -183,7 +182,6 @@ MY_CFLAGS_Release := \
MY_DEFS_Release := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
diff --git a/gpu/gpu.target.darwin-arm64.mk b/gpu/gpu.target.darwin-arm64.mk
index 43eb1390d8..a65f0abe05 100644
--- a/gpu/gpu.target.darwin-arm64.mk
+++ b/gpu/gpu.target.darwin-arm64.mk
@@ -64,7 +64,6 @@ MY_CFLAGS_Debug := \
MY_DEFS_Debug := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
@@ -160,7 +159,6 @@ MY_CFLAGS_Release := \
MY_DEFS_Release := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
diff --git a/gpu/gpu.target.darwin-mips.mk b/gpu/gpu.target.darwin-mips.mk
index be69798894..ffb5c26934 100644
--- a/gpu/gpu.target.darwin-mips.mk
+++ b/gpu/gpu.target.darwin-mips.mk
@@ -69,7 +69,6 @@ MY_CFLAGS_Debug := \
MY_DEFS_Debug := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
@@ -171,7 +170,6 @@ MY_CFLAGS_Release := \
MY_DEFS_Release := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
diff --git a/gpu/gpu.target.darwin-x86.mk b/gpu/gpu.target.darwin-x86.mk
index 46a5fdd849..4352c3bdd5 100644
--- a/gpu/gpu.target.darwin-x86.mk
+++ b/gpu/gpu.target.darwin-x86.mk
@@ -70,7 +70,6 @@ MY_CFLAGS_Debug := \
MY_DEFS_Debug := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
@@ -172,7 +171,6 @@ MY_CFLAGS_Release := \
MY_DEFS_Release := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
diff --git a/gpu/gpu.target.darwin-x86_64.mk b/gpu/gpu.target.darwin-x86_64.mk
index e1b73a1a0c..f9a2eeaf6e 100644
--- a/gpu/gpu.target.darwin-x86_64.mk
+++ b/gpu/gpu.target.darwin-x86_64.mk
@@ -69,7 +69,6 @@ MY_CFLAGS_Debug := \
MY_DEFS_Debug := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
@@ -170,7 +169,6 @@ MY_CFLAGS_Release := \
MY_DEFS_Release := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
diff --git a/gpu/gpu.target.linux-arm.mk b/gpu/gpu.target.linux-arm.mk
index 97a8a85e93..a656e267e2 100644
--- a/gpu/gpu.target.linux-arm.mk
+++ b/gpu/gpu.target.linux-arm.mk
@@ -75,7 +75,6 @@ MY_CFLAGS_Debug := \
MY_DEFS_Debug := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
@@ -183,7 +182,6 @@ MY_CFLAGS_Release := \
MY_DEFS_Release := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
diff --git a/gpu/gpu.target.linux-arm64.mk b/gpu/gpu.target.linux-arm64.mk
index 43eb1390d8..a65f0abe05 100644
--- a/gpu/gpu.target.linux-arm64.mk
+++ b/gpu/gpu.target.linux-arm64.mk
@@ -64,7 +64,6 @@ MY_CFLAGS_Debug := \
MY_DEFS_Debug := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
@@ -160,7 +159,6 @@ MY_CFLAGS_Release := \
MY_DEFS_Release := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
diff --git a/gpu/gpu.target.linux-mips.mk b/gpu/gpu.target.linux-mips.mk
index be69798894..ffb5c26934 100644
--- a/gpu/gpu.target.linux-mips.mk
+++ b/gpu/gpu.target.linux-mips.mk
@@ -69,7 +69,6 @@ MY_CFLAGS_Debug := \
MY_DEFS_Debug := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
@@ -171,7 +170,6 @@ MY_CFLAGS_Release := \
MY_DEFS_Release := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
diff --git a/gpu/gpu.target.linux-x86.mk b/gpu/gpu.target.linux-x86.mk
index 46a5fdd849..4352c3bdd5 100644
--- a/gpu/gpu.target.linux-x86.mk
+++ b/gpu/gpu.target.linux-x86.mk
@@ -70,7 +70,6 @@ MY_CFLAGS_Debug := \
MY_DEFS_Debug := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
@@ -172,7 +171,6 @@ MY_CFLAGS_Release := \
MY_DEFS_Release := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
diff --git a/gpu/gpu.target.linux-x86_64.mk b/gpu/gpu.target.linux-x86_64.mk
index e1b73a1a0c..f9a2eeaf6e 100644
--- a/gpu/gpu.target.linux-x86_64.mk
+++ b/gpu/gpu.target.linux-x86_64.mk
@@ -69,7 +69,6 @@ MY_CFLAGS_Debug := \
MY_DEFS_Debug := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
@@ -170,7 +169,6 @@ MY_CFLAGS_Release := \
MY_DEFS_Release := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
diff --git a/gpu/gpu_config.gypi b/gpu/gpu_config.gypi
index fc9306f89c..b90143f502 100644
--- a/gpu/gpu_config.gypi
+++ b/gpu/gpu_config.gypi
@@ -65,7 +65,7 @@
'../third_party/amd/amd_videocard_info_win.cc',
],
}],
- ['OS=="linux"', {
+ ['OS=="linux" and (use_x11==1 or use_ozone==1)', {
'dependencies': [
'../build/linux/system.gyp:libpci',
],
diff --git a/gpu/gpu_config.target.darwin-arm.mk b/gpu/gpu_config.target.darwin-arm.mk
index 213a79a9a2..c32ed84e0c 100644
--- a/gpu/gpu_config.target.darwin-arm.mk
+++ b/gpu/gpu_config.target.darwin-arm.mk
@@ -82,7 +82,6 @@ MY_CFLAGS_Debug := \
MY_DEFS_Debug := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
@@ -194,7 +193,6 @@ MY_CFLAGS_Release := \
MY_DEFS_Release := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
diff --git a/gpu/gpu_config.target.darwin-arm64.mk b/gpu/gpu_config.target.darwin-arm64.mk
index 54ca4a052a..f0ec85ac7a 100644
--- a/gpu/gpu_config.target.darwin-arm64.mk
+++ b/gpu/gpu_config.target.darwin-arm64.mk
@@ -71,7 +71,6 @@ MY_CFLAGS_Debug := \
MY_DEFS_Debug := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
@@ -171,7 +170,6 @@ MY_CFLAGS_Release := \
MY_DEFS_Release := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
diff --git a/gpu/gpu_config.target.darwin-mips.mk b/gpu/gpu_config.target.darwin-mips.mk
index 9d400040d6..554b8d451f 100644
--- a/gpu/gpu_config.target.darwin-mips.mk
+++ b/gpu/gpu_config.target.darwin-mips.mk
@@ -76,7 +76,6 @@ MY_CFLAGS_Debug := \
MY_DEFS_Debug := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
@@ -182,7 +181,6 @@ MY_CFLAGS_Release := \
MY_DEFS_Release := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
diff --git a/gpu/gpu_config.target.darwin-x86.mk b/gpu/gpu_config.target.darwin-x86.mk
index 4919a2dd4d..746e19b412 100644
--- a/gpu/gpu_config.target.darwin-x86.mk
+++ b/gpu/gpu_config.target.darwin-x86.mk
@@ -77,7 +77,6 @@ MY_CFLAGS_Debug := \
MY_DEFS_Debug := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
@@ -183,7 +182,6 @@ MY_CFLAGS_Release := \
MY_DEFS_Release := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
diff --git a/gpu/gpu_config.target.darwin-x86_64.mk b/gpu/gpu_config.target.darwin-x86_64.mk
index ad933799cc..ed3b9db860 100644
--- a/gpu/gpu_config.target.darwin-x86_64.mk
+++ b/gpu/gpu_config.target.darwin-x86_64.mk
@@ -76,7 +76,6 @@ MY_CFLAGS_Debug := \
MY_DEFS_Debug := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
@@ -181,7 +180,6 @@ MY_CFLAGS_Release := \
MY_DEFS_Release := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
diff --git a/gpu/gpu_config.target.linux-arm.mk b/gpu/gpu_config.target.linux-arm.mk
index 213a79a9a2..c32ed84e0c 100644
--- a/gpu/gpu_config.target.linux-arm.mk
+++ b/gpu/gpu_config.target.linux-arm.mk
@@ -82,7 +82,6 @@ MY_CFLAGS_Debug := \
MY_DEFS_Debug := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
@@ -194,7 +193,6 @@ MY_CFLAGS_Release := \
MY_DEFS_Release := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
diff --git a/gpu/gpu_config.target.linux-arm64.mk b/gpu/gpu_config.target.linux-arm64.mk
index 54ca4a052a..f0ec85ac7a 100644
--- a/gpu/gpu_config.target.linux-arm64.mk
+++ b/gpu/gpu_config.target.linux-arm64.mk
@@ -71,7 +71,6 @@ MY_CFLAGS_Debug := \
MY_DEFS_Debug := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
@@ -171,7 +170,6 @@ MY_CFLAGS_Release := \
MY_DEFS_Release := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
diff --git a/gpu/gpu_config.target.linux-mips.mk b/gpu/gpu_config.target.linux-mips.mk
index 9d400040d6..554b8d451f 100644
--- a/gpu/gpu_config.target.linux-mips.mk
+++ b/gpu/gpu_config.target.linux-mips.mk
@@ -76,7 +76,6 @@ MY_CFLAGS_Debug := \
MY_DEFS_Debug := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
@@ -182,7 +181,6 @@ MY_CFLAGS_Release := \
MY_DEFS_Release := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
diff --git a/gpu/gpu_config.target.linux-x86.mk b/gpu/gpu_config.target.linux-x86.mk
index 4919a2dd4d..746e19b412 100644
--- a/gpu/gpu_config.target.linux-x86.mk
+++ b/gpu/gpu_config.target.linux-x86.mk
@@ -77,7 +77,6 @@ MY_CFLAGS_Debug := \
MY_DEFS_Debug := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
@@ -183,7 +182,6 @@ MY_CFLAGS_Release := \
MY_DEFS_Release := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
diff --git a/gpu/gpu_config.target.linux-x86_64.mk b/gpu/gpu_config.target.linux-x86_64.mk
index ad933799cc..ed3b9db860 100644
--- a/gpu/gpu_config.target.linux-x86_64.mk
+++ b/gpu/gpu_config.target.linux-x86_64.mk
@@ -76,7 +76,6 @@ MY_CFLAGS_Debug := \
MY_DEFS_Debug := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
@@ -181,7 +180,6 @@ MY_CFLAGS_Release := \
MY_DEFS_Release := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
diff --git a/gpu/gpu_ipc.target.darwin-arm.mk b/gpu/gpu_ipc.target.darwin-arm.mk
index 8dbd2ffd80..0baef2dc82 100644
--- a/gpu/gpu_ipc.target.darwin-arm.mk
+++ b/gpu/gpu_ipc.target.darwin-arm.mk
@@ -71,7 +71,6 @@ MY_CFLAGS_Debug := \
MY_DEFS_Debug := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
@@ -176,7 +175,6 @@ MY_CFLAGS_Release := \
MY_DEFS_Release := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
diff --git a/gpu/gpu_ipc.target.darwin-arm64.mk b/gpu/gpu_ipc.target.darwin-arm64.mk
index 09cd51945e..0c006f524b 100644
--- a/gpu/gpu_ipc.target.darwin-arm64.mk
+++ b/gpu/gpu_ipc.target.darwin-arm64.mk
@@ -60,7 +60,6 @@ MY_CFLAGS_Debug := \
MY_DEFS_Debug := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
@@ -153,7 +152,6 @@ MY_CFLAGS_Release := \
MY_DEFS_Release := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
diff --git a/gpu/gpu_ipc.target.darwin-mips.mk b/gpu/gpu_ipc.target.darwin-mips.mk
index 3a0cc397dd..4a44c08f8b 100644
--- a/gpu/gpu_ipc.target.darwin-mips.mk
+++ b/gpu/gpu_ipc.target.darwin-mips.mk
@@ -65,7 +65,6 @@ MY_CFLAGS_Debug := \
MY_DEFS_Debug := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
@@ -164,7 +163,6 @@ MY_CFLAGS_Release := \
MY_DEFS_Release := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
diff --git a/gpu/gpu_ipc.target.darwin-x86.mk b/gpu/gpu_ipc.target.darwin-x86.mk
index 4b80e750c3..d6a6f2bac9 100644
--- a/gpu/gpu_ipc.target.darwin-x86.mk
+++ b/gpu/gpu_ipc.target.darwin-x86.mk
@@ -66,7 +66,6 @@ MY_CFLAGS_Debug := \
MY_DEFS_Debug := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
@@ -165,7 +164,6 @@ MY_CFLAGS_Release := \
MY_DEFS_Release := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
diff --git a/gpu/gpu_ipc.target.darwin-x86_64.mk b/gpu/gpu_ipc.target.darwin-x86_64.mk
index aff0abd474..74d2866b55 100644
--- a/gpu/gpu_ipc.target.darwin-x86_64.mk
+++ b/gpu/gpu_ipc.target.darwin-x86_64.mk
@@ -65,7 +65,6 @@ MY_CFLAGS_Debug := \
MY_DEFS_Debug := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
@@ -163,7 +162,6 @@ MY_CFLAGS_Release := \
MY_DEFS_Release := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
diff --git a/gpu/gpu_ipc.target.linux-arm.mk b/gpu/gpu_ipc.target.linux-arm.mk
index 8dbd2ffd80..0baef2dc82 100644
--- a/gpu/gpu_ipc.target.linux-arm.mk
+++ b/gpu/gpu_ipc.target.linux-arm.mk
@@ -71,7 +71,6 @@ MY_CFLAGS_Debug := \
MY_DEFS_Debug := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
@@ -176,7 +175,6 @@ MY_CFLAGS_Release := \
MY_DEFS_Release := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
diff --git a/gpu/gpu_ipc.target.linux-arm64.mk b/gpu/gpu_ipc.target.linux-arm64.mk
index 09cd51945e..0c006f524b 100644
--- a/gpu/gpu_ipc.target.linux-arm64.mk
+++ b/gpu/gpu_ipc.target.linux-arm64.mk
@@ -60,7 +60,6 @@ MY_CFLAGS_Debug := \
MY_DEFS_Debug := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
@@ -153,7 +152,6 @@ MY_CFLAGS_Release := \
MY_DEFS_Release := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
diff --git a/gpu/gpu_ipc.target.linux-mips.mk b/gpu/gpu_ipc.target.linux-mips.mk
index 3a0cc397dd..4a44c08f8b 100644
--- a/gpu/gpu_ipc.target.linux-mips.mk
+++ b/gpu/gpu_ipc.target.linux-mips.mk
@@ -65,7 +65,6 @@ MY_CFLAGS_Debug := \
MY_DEFS_Debug := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
@@ -164,7 +163,6 @@ MY_CFLAGS_Release := \
MY_DEFS_Release := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
diff --git a/gpu/gpu_ipc.target.linux-x86.mk b/gpu/gpu_ipc.target.linux-x86.mk
index 4b80e750c3..d6a6f2bac9 100644
--- a/gpu/gpu_ipc.target.linux-x86.mk
+++ b/gpu/gpu_ipc.target.linux-x86.mk
@@ -66,7 +66,6 @@ MY_CFLAGS_Debug := \
MY_DEFS_Debug := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
@@ -165,7 +164,6 @@ MY_CFLAGS_Release := \
MY_DEFS_Release := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
diff --git a/gpu/gpu_ipc.target.linux-x86_64.mk b/gpu/gpu_ipc.target.linux-x86_64.mk
index aff0abd474..74d2866b55 100644
--- a/gpu/gpu_ipc.target.linux-x86_64.mk
+++ b/gpu/gpu_ipc.target.linux-x86_64.mk
@@ -65,7 +65,6 @@ MY_CFLAGS_Debug := \
MY_DEFS_Debug := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
@@ -163,7 +162,6 @@ MY_CFLAGS_Release := \
MY_DEFS_Release := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
diff --git a/gpu/skia_bindings/gpu_skia_bindings.target.darwin-arm.mk b/gpu/skia_bindings/gpu_skia_bindings.target.darwin-arm.mk
index 68df924b39..4f6c7ac13c 100644
--- a/gpu/skia_bindings/gpu_skia_bindings.target.darwin-arm.mk
+++ b/gpu/skia_bindings/gpu_skia_bindings.target.darwin-arm.mk
@@ -72,7 +72,6 @@ MY_CFLAGS_Debug := \
MY_DEFS_Debug := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
@@ -204,7 +203,6 @@ MY_CFLAGS_Release := \
MY_DEFS_Release := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
diff --git a/gpu/skia_bindings/gpu_skia_bindings.target.darwin-arm64.mk b/gpu/skia_bindings/gpu_skia_bindings.target.darwin-arm64.mk
index 24a5ff67bb..37a6d29d94 100644
--- a/gpu/skia_bindings/gpu_skia_bindings.target.darwin-arm64.mk
+++ b/gpu/skia_bindings/gpu_skia_bindings.target.darwin-arm64.mk
@@ -61,7 +61,6 @@ MY_CFLAGS_Debug := \
MY_DEFS_Debug := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
@@ -181,7 +180,6 @@ MY_CFLAGS_Release := \
MY_DEFS_Release := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
diff --git a/gpu/skia_bindings/gpu_skia_bindings.target.darwin-mips.mk b/gpu/skia_bindings/gpu_skia_bindings.target.darwin-mips.mk
index f6ab22fe9c..f0b08996b1 100644
--- a/gpu/skia_bindings/gpu_skia_bindings.target.darwin-mips.mk
+++ b/gpu/skia_bindings/gpu_skia_bindings.target.darwin-mips.mk
@@ -66,7 +66,6 @@ MY_CFLAGS_Debug := \
MY_DEFS_Debug := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
@@ -192,7 +191,6 @@ MY_CFLAGS_Release := \
MY_DEFS_Release := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
diff --git a/gpu/skia_bindings/gpu_skia_bindings.target.darwin-x86.mk b/gpu/skia_bindings/gpu_skia_bindings.target.darwin-x86.mk
index 1e18b808b2..dcdb6fd037 100644
--- a/gpu/skia_bindings/gpu_skia_bindings.target.darwin-x86.mk
+++ b/gpu/skia_bindings/gpu_skia_bindings.target.darwin-x86.mk
@@ -67,7 +67,6 @@ MY_CFLAGS_Debug := \
MY_DEFS_Debug := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
@@ -193,7 +192,6 @@ MY_CFLAGS_Release := \
MY_DEFS_Release := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
diff --git a/gpu/skia_bindings/gpu_skia_bindings.target.darwin-x86_64.mk b/gpu/skia_bindings/gpu_skia_bindings.target.darwin-x86_64.mk
index a2b6e5776a..f0a76dc9ae 100644
--- a/gpu/skia_bindings/gpu_skia_bindings.target.darwin-x86_64.mk
+++ b/gpu/skia_bindings/gpu_skia_bindings.target.darwin-x86_64.mk
@@ -66,7 +66,6 @@ MY_CFLAGS_Debug := \
MY_DEFS_Debug := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
@@ -191,7 +190,6 @@ MY_CFLAGS_Release := \
MY_DEFS_Release := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
diff --git a/gpu/skia_bindings/gpu_skia_bindings.target.linux-arm.mk b/gpu/skia_bindings/gpu_skia_bindings.target.linux-arm.mk
index 68df924b39..4f6c7ac13c 100644
--- a/gpu/skia_bindings/gpu_skia_bindings.target.linux-arm.mk
+++ b/gpu/skia_bindings/gpu_skia_bindings.target.linux-arm.mk
@@ -72,7 +72,6 @@ MY_CFLAGS_Debug := \
MY_DEFS_Debug := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
@@ -204,7 +203,6 @@ MY_CFLAGS_Release := \
MY_DEFS_Release := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
diff --git a/gpu/skia_bindings/gpu_skia_bindings.target.linux-arm64.mk b/gpu/skia_bindings/gpu_skia_bindings.target.linux-arm64.mk
index 24a5ff67bb..37a6d29d94 100644
--- a/gpu/skia_bindings/gpu_skia_bindings.target.linux-arm64.mk
+++ b/gpu/skia_bindings/gpu_skia_bindings.target.linux-arm64.mk
@@ -61,7 +61,6 @@ MY_CFLAGS_Debug := \
MY_DEFS_Debug := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
@@ -181,7 +180,6 @@ MY_CFLAGS_Release := \
MY_DEFS_Release := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
diff --git a/gpu/skia_bindings/gpu_skia_bindings.target.linux-mips.mk b/gpu/skia_bindings/gpu_skia_bindings.target.linux-mips.mk
index f6ab22fe9c..f0b08996b1 100644
--- a/gpu/skia_bindings/gpu_skia_bindings.target.linux-mips.mk
+++ b/gpu/skia_bindings/gpu_skia_bindings.target.linux-mips.mk
@@ -66,7 +66,6 @@ MY_CFLAGS_Debug := \
MY_DEFS_Debug := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
@@ -192,7 +191,6 @@ MY_CFLAGS_Release := \
MY_DEFS_Release := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
diff --git a/gpu/skia_bindings/gpu_skia_bindings.target.linux-x86.mk b/gpu/skia_bindings/gpu_skia_bindings.target.linux-x86.mk
index 1e18b808b2..dcdb6fd037 100644
--- a/gpu/skia_bindings/gpu_skia_bindings.target.linux-x86.mk
+++ b/gpu/skia_bindings/gpu_skia_bindings.target.linux-x86.mk
@@ -67,7 +67,6 @@ MY_CFLAGS_Debug := \
MY_DEFS_Debug := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
@@ -193,7 +192,6 @@ MY_CFLAGS_Release := \
MY_DEFS_Release := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
diff --git a/gpu/skia_bindings/gpu_skia_bindings.target.linux-x86_64.mk b/gpu/skia_bindings/gpu_skia_bindings.target.linux-x86_64.mk
index a2b6e5776a..f0a76dc9ae 100644
--- a/gpu/skia_bindings/gpu_skia_bindings.target.linux-x86_64.mk
+++ b/gpu/skia_bindings/gpu_skia_bindings.target.linux-x86_64.mk
@@ -66,7 +66,6 @@ MY_CFLAGS_Debug := \
MY_DEFS_Debug := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \
@@ -191,7 +190,6 @@ MY_CFLAGS_Release := \
MY_DEFS_Release := \
'-DV8_DEPRECATION_WARNINGS' \
- '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' \
'-D_FILE_OFFSET_BITS=64' \
'-DNO_TCMALLOC' \
'-DDISABLE_NACL' \