diff options
author | jshin@chromium.org <jshin@chromium.org@4ff67af0-8c30-449e-8e8b-ad334ec8d88c> | 2012-02-17 01:21:04 +0000 |
---|---|---|
committer | jshin@chromium.org <jshin@chromium.org@4ff67af0-8c30-449e-8e8b-ad334ec8d88c> | 2012-02-17 01:21:04 +0000 |
commit | 38dfdc125c55d16a0aa51851da5906641ba1fbb7 (patch) | |
tree | d405912717e5d8312b86850bc181c7442b33a4a6 /icu.gyp | |
parent | cb71ead526647bd4a18ea981ef35031dcb608bdd (diff) | |
download | icu-38dfdc125c55d16a0aa51851da5906641ba1fbb7.tar.gz |
Take care of two Clang warnings.
- decNumber.c has several places where Clang complains about array index
out-of-bounds error. According to udecnum.h, it's done on purpose because
the array in question (lsu) is followed by additional spaces for digits.
So, we suppress 'array-bounds' warning with clang-specific pragmas.
GCC 4.6 also complains about this, but it's hard to make GCC 4.4 and
GCC 4.6 happy at the same time without getting too ugly because GCC 4.4
does not support 'pragra diagnostic {push|pop}'
See http://bugs.icu-project.org/trac/ticket/8954
- colldata.cpp copies an array of UnicodeString's with memcpy. It's changed to
to use a for-loop, instead. The upstream ToT has fixed this.
BUG=84851,92756
TEST=Compile with Clang and it does not complain any more in devNumber.c and colldata.cpp
Review URL: https://chromiumcodereview.appspot.com/9420032
git-svn-id: http://src.chromium.org/svn/trunk/deps/third_party/icu46@122423 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Diffstat (limited to 'icu.gyp')
-rw-r--r-- | icu.gyp | 5 |
1 files changed, 0 insertions, 5 deletions
@@ -333,10 +333,6 @@ # the header should use U_NAMESPACE_BEGIN instead. # http://bugs.icu-project.org/trac/ticket/9054 '-Wno-header-hygiene', - # ICU does some tricky array allocation that trips over - # -Warray-bounds. It seems to be harmless, see - # http://crbug.com/84851. - '-Wno-array-bounds', # Looks like a real issue, see http://crbug.com/114660 '-Wno-return-type-c-linkage', ], @@ -346,7 +342,6 @@ '-Wno-logical-op-parentheses', '-Wno-tautological-compare', '-Wno-header-hygiene', - '-Wno-array-bounds', '-Wno-return-type-c-linkage', ], }], |