diff options
| author | commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> | 2014-04-21 19:33:12 +0000 |
|---|---|---|
| committer | commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> | 2014-04-21 19:33:12 +0000 |
| commit | 6e773af83fe08119bdb50d8b720fcd46eebea74e (patch) | |
| tree | 8c617c3a4b402357848922f162cb239d73aee87b | |
| parent | 07d4e528ca5c3e9bb73381e0cd435884cf1f315a (diff) | |
| download | gyp-6e773af83fe08119bdb50d8b720fcd46eebea74e.tar.gz | |
Fixes for SkPictureShader.
Update comment in header to make it more clear that the picture
should be unaltered after creating the shader. We want our shaders
to be immutable, and this supports that.
Make the factory return NULL if the shader would have never drawn
anyway i.e. for a null picture or picture with no width/height.
Addresses comments I brought up in
https://codereview.chromium.org/221923007/#msg16.
BUG=skia:1976
R=reed@google.com, fmalita@chromium.org, robertphillips@google.com
Author: scroggo@google.com
Review URL: https://codereview.chromium.org/238253005
git-svn-id: http://skia.googlecode.com/svn/trunk/gyp@14288 2bbb7eff-a529-9590-31e7-b0007b416f81
| -rw-r--r-- | tests.gypi | 1 |
1 files changed, 1 insertions, 0 deletions
@@ -127,6 +127,7 @@ '../tests/PathTest.cpp', '../tests/PathUtilsTest.cpp', '../tests/PictureTest.cpp', + '../tests/PictureShaderTest.cpp', '../tests/PictureUtilsTest.cpp', '../tests/PixelRefTest.cpp', '../tests/PointTest.cpp', |