diff options
| author | commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> | 2014-04-22 20:05:35 +0000 |
|---|---|---|
| committer | commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> | 2014-04-22 20:05:35 +0000 |
| commit | bbbf16b9548b3517a32f7d5eb78a48b62d823626 (patch) | |
| tree | 2f7e13c6042a343e858a9a82472cafbaa590a5b6 | |
| parent | cf76f654f3c8b10c9b5c7ce8a1514ae68ab73f30 (diff) | |
| download | gyp-bbbf16b9548b3517a32f7d5eb78a48b62d823626.tar.gz | |
gyp: only include windows *_x64 targets if GYP_GENERATORS includes ninja
BUG=skia:2442
R=caryclark@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/247143003
git-svn-id: http://skia.googlecode.com/svn/trunk/gyp@14313 2bbb7eff-a529-9590-31e7-b0007b416f81
| -rw-r--r-- | common_conditions.gypi | 29 |
1 files changed, 18 insertions, 11 deletions
diff --git a/common_conditions.gypi b/common_conditions.gypi index 71dca26..175b8b0 100644 --- a/common_conditions.gypi +++ b/common_conditions.gypi @@ -91,6 +91,8 @@ }, }, }, + }, + 'conditions' : [ # Gyp's ninja generator depends on these specially named # configurations to build 64-bit on Windows. # See http://skbug.com/2348 @@ -98,17 +100,22 @@ # We handle the 64- vs 32-bit variations elsewhere, so I think it's # OK for us to just make these inherit non-archwidth-specific # configurations without modification. - 'Debug_x64': { - 'inherit_from': ['Debug'], - }, - 'Release_x64': { - 'inherit_from': ['Release'], - }, - 'Release_Developer_x64': { - 'inherit_from': ['Release_Developer'], - }, - }, - 'conditions' : [ + # + # See http://skbug.com/2442 : These targets cause problems in the + # MSVS build, so only include them if gyp is generating a ninja build. + [ '"ninja" in "<!(echo %GYP_GENERATORS%)"', { + 'configurations': { + 'Debug_x64': { + 'inherit_from': ['Debug'], + }, + 'Release_x64': { + 'inherit_from': ['Release'], + }, + 'Release_Developer_x64': { + 'inherit_from': ['Release_Developer'], + }, + }, + }], [ 'skia_arch_width == 64', { 'msvs_configuration_platform': 'x64', }], |