diff options
| author | senorblanco@chromium.org <senorblanco@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> | 2011-05-19 19:58:58 +0000 |
|---|---|---|
| committer | senorblanco@chromium.org <senorblanco@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> | 2011-05-19 19:58:58 +0000 |
| commit | 69c4163d1f27c5bb715884141f28b06f2cd781d7 (patch) | |
| tree | 04cf630fbfdbece0d3ecd71ade398d85c6ee8491 /common.gypi | |
| parent | aabea0bfa7e5fc9cfb1b8b097079f36ae4cb2896 (diff) | |
| download | gyp-69c4163d1f27c5bb715884141f28b06f2cd781d7.tar.gz | |
The plain Makefile was using -Wall, but the gyp build wasn't. This CL turns on
-Wall -Wextra and -Wno-unused in common.gypi. This revealed a lot of warnings
(and some actual bugs), all of which I fixed here. This is pretty mindless
stuff for the most part (order of intialization, missing initializers, && within
||, etc), but will allow us to build cleanly with -Wall and -Wextra (and
-Werror, if we so choose).
I put defaults into switches that were missing cases. I could put in the actual
missing enums instead if that's desired. I could also assert on missing enums
instead of break, if that's desired. I wasn't sure how to test the stuff in
"animator", so that should be looked at a bit more closely.
Review URL: http://codereview.appspot.com/4547055/
git-svn-id: http://skia.googlecode.com/svn/trunk/gyp@1386 2bbb7eff-a529-9590-31e7-b0007b416f81
Diffstat (limited to 'common.gypi')
| -rw-r--r-- | common.gypi | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/common.gypi b/common.gypi index aadaffb..78482a0 100644 --- a/common.gypi +++ b/common.gypi @@ -65,6 +65,7 @@ 'cflags': ['-O2'] }, }, + 'cflags': [ '-Wall', '-Wextra', '-Wno-unused' ] }, }, ], |