diff options
| author | bjornv@webrtc.org <bjornv@webrtc.org> | 2014-08-26 10:25:10 +0000 |
|---|---|---|
| committer | bjornv@webrtc.org <bjornv@webrtc.org> | 2014-08-26 10:25:10 +0000 |
| commit | 724e3f874a820dcd272d5e1b38b00066d9442b90 (patch) | |
| tree | db9a5babee112640eab80f79241801f0654d35a5 /common_audio | |
| parent | 782121c315548375ccbd6809d55e83d40f1e848f (diff) | |
| download | webrtc-724e3f874a820dcd272d5e1b38b00066d9442b90.tar.gz | |
Refactoring common_audio/signal_processing: Remove macro WEBRTC_SPL_UDIV
This macro is a direct use of the division operator without checking for division by zero. Hence, it is dangerous to use.
This CL replaces the macro with '/' at place.
BUG=3348,3353
TESTED=locally on linux and trybots
R=kwiberg@webrtc.org, tina.legrand@webrtc.org, turaj@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/14169004
git-svn-id: http://webrtc.googlecode.com/svn/trunk/webrtc@6976 4adac7df-926f-26a2-2b94-8c16560cd09d
Diffstat (limited to 'common_audio')
| -rw-r--r-- | common_audio/signal_processing/include/signal_processing_library.h | 2 | ||||
| -rw-r--r-- | common_audio/signal_processing/signal_processing_unittest.cc | 1 |
2 files changed, 0 insertions, 3 deletions
diff --git a/common_audio/signal_processing/include/signal_processing_library.h b/common_audio/signal_processing/include/signal_processing_library.h index 8e1059e5..a9cf3842 100644 --- a/common_audio/signal_processing/include/signal_processing_library.h +++ b/common_audio/signal_processing/include/signal_processing_library.h @@ -48,8 +48,6 @@ ((int32_t)(int16_t)(a) * (uint16_t)(b)) #define WEBRTC_SPL_DIV(a, b) \ ((int32_t) ((int32_t)(a) / (int32_t)(b))) -#define WEBRTC_SPL_UDIV(a, b) \ - ((uint32_t) ((uint32_t)(a) / (uint32_t)(b))) #ifndef WEBRTC_ARCH_ARM_V7 // For ARMv7 platforms, these are inline functions in spl_inl_armv7.h diff --git a/common_audio/signal_processing/signal_processing_unittest.cc b/common_audio/signal_processing/signal_processing_unittest.cc index 88ede79b..5d07f16e 100644 --- a/common_audio/signal_processing/signal_processing_unittest.cc +++ b/common_audio/signal_processing/signal_processing_unittest.cc @@ -48,7 +48,6 @@ TEST_F(SplTest, MacroTest) { a = b; b = -3; EXPECT_EQ(-5461, WEBRTC_SPL_DIV(a, b)); - EXPECT_EQ(0u, WEBRTC_SPL_UDIV(a, b)); EXPECT_EQ(-1, WEBRTC_SPL_MUL_16_32_RSFT16(a, b)); EXPECT_EQ(-1, WEBRTC_SPL_MUL_16_32_RSFT15(a, b)); |