summaryrefslogtreecommitdiff
path: root/typedefs.h
diff options
context:
space:
mode:
authorandrew@webrtc.org <andrew@webrtc.org>2014-08-28 16:28:26 +0000
committerandrew@webrtc.org <andrew@webrtc.org>2014-08-28 16:28:26 +0000
commit54ade8bbee7cea004418c02de3658ffc870fc968 (patch)
treeb3d16cb9bc096df8103e4f342bdf2901aa6ec3df /typedefs.h
parent84bd5249d97dcd38f37ef10b565986808f74abce (diff)
downloadwebrtc-54ade8bbee7cea004418c02de3658ffc870fc968.tar.gz
Add CHECK and friends from Chromium.
Replace FATAL_ERROR_IF with the more familiar (to Chromium developers) CHECK and DCHECK. The full Chromium implementation is fairly elaborate but I copied enough to get us most of the benefits. I believe the main missing component is a more advanced stack dump. For this bit I relied on the V8 implementation. There are a few minor modifications from the Chromium original: - The FatalMessage class is specialized for logging fatal error messages and aborting. Chromium uses the general LogMessage class, which we could consider moving towards in the future. - NOTIMPLEMENTED() and NOTREACHED() have been removed, partly because I don't want to rely on our logging.h until base/ and system_wrappers/ are consolidated. - FATAL() replaces LOG(FATAL). Minor modifications from V8's stack dump: - If parsing of a stack trace symbol fails, just print the unparsed symbol. (I noticed this happened on Mac.) - Use __GLIBCXX__ and __UCLIBC__. This is from examining the backtrace use in Chromium. UNREACHABLE() has been removed because its behavior is different than Chromium's NOTREACHED(), which is bound to cause confusion. The few uses were replaced with FATAL(), matching the previous behavior. Add a NO_RETURN macro, allowing us to remove unreachable return statements following a CHECK/FATAL. TESTED=the addition of dummy CHECK, DCHECK, CHECK_EQ and FATAL did the did the right things. Stack traces work on Mac, but I don't get symbols on Linux. R=henrik.lundin@webrtc.org, kwiberg@webrtc.org, tommi@webrtc.org Review URL: https://webrtc-codereview.appspot.com/22449004 git-svn-id: http://webrtc.googlecode.com/svn/trunk/webrtc@7003 4adac7df-926f-26a2-2b94-8c16560cd09d
Diffstat (limited to 'typedefs.h')
-rw-r--r--typedefs.h9
1 files changed, 9 insertions, 0 deletions
diff --git a/typedefs.h b/typedefs.h
index 38cda513..871f04ec 100644
--- a/typedefs.h
+++ b/typedefs.h
@@ -120,4 +120,13 @@ typedef unsigned __int64 uint64_t;
#endif
#endif
+// Annotate a function that will not return control flow to the caller.
+#if defined(_MSC_VER)
+#define NO_RETURN __declspec(noreturn)
+#elif defined(__GNUC__)
+#define NO_RETURN __attribute__((noreturn))
+#else
+#define NO_RETURN
+#endif
+
#endif // WEBRTC_TYPEDEFS_H_