diff options
| author | henrika@webrtc.org <henrika@webrtc.org@4adac7df-926f-26a2-2b94-8c16560cd09d> | 2014-02-19 08:58:08 +0000 |
|---|---|---|
| committer | henrika@webrtc.org <henrika@webrtc.org@4adac7df-926f-26a2-2b94-8c16560cd09d> | 2014-02-19 08:58:08 +0000 |
| commit | 4845ee04de9fa1d2cc9a6d9a41615a5eb90b6e85 (patch) | |
| tree | 0e113662259a0d997337bac9fda2614e0cc268a0 /voice_engine/channel.h | |
| parent | d4ce7ff9ea18eef8d52e3a3be975d4fd5cdffdd9 (diff) | |
| download | webrtc-4845ee04de9fa1d2cc9a6d9a41615a5eb90b6e85.tar.gz | |
Removes VoERTP_RTCP::InsertExtraRTPPacket.
Reasons for removing:
- Feels like a complete hack IMHO.
- Not used by any client.
- Unclear functionality regarding time stamp, marker bit etc.
- Causes several issues in tests due to a bad design which mainly depends on the fact that this API "breaks" an ongoing data/packet flow and it complicates the threading model and creates risks for deadlock and memory corruption. Not worth trying to fix given the very unclear benefit of maintaining the API. Better to remove the API instead.
- We also see lots of TSan races and memcheck errors related to this API.
BUG=2296,2240
R=mflodman@webrtc.org, niklas.enbom@webrtc.org, xians@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/8819004
git-svn-id: http://webrtc.googlecode.com/svn/trunk/webrtc@5574 4adac7df-926f-26a2-2b94-8c16560cd09d
Diffstat (limited to 'voice_engine/channel.h')
| -rw-r--r-- | voice_engine/channel.h | 6 |
1 files changed, 0 insertions, 6 deletions
diff --git a/voice_engine/channel.h b/voice_engine/channel.h index 3fadf929..ed2bfc42 100644 --- a/voice_engine/channel.h +++ b/voice_engine/channel.h @@ -279,9 +279,6 @@ public: int StartRTPDump(const char fileNameUTF8[1024], RTPDirections direction); int StopRTPDump(RTPDirections direction); bool RTPDumpIsActive(RTPDirections direction); - int InsertExtraRTPPacket(unsigned char payloadType, bool markerBit, - const char* payloadData, - unsigned short payloadSize); uint32_t LastRemoteTimeStamp() { return _lastRemoteTimeStamp; } // From AudioPacketizationCallback in the ACM @@ -528,9 +525,6 @@ private: bool _playOutbandDtmfEvent; bool _playInbandDtmfEvent; // VoeRTP_RTCP - uint8_t _extraPayloadType; - bool _insertExtraRTPPacket; - bool _extraMarkerBit; uint32_t _lastLocalTimeStamp; uint32_t _lastRemoteTimeStamp; int8_t _lastPayloadType; |