diff options
| author | pbos@webrtc.org <pbos@webrtc.org@4adac7df-926f-26a2-2b94-8c16560cd09d> | 2013-08-07 17:57:36 +0000 |
|---|---|---|
| committer | pbos@webrtc.org <pbos@webrtc.org@4adac7df-926f-26a2-2b94-8c16560cd09d> | 2013-08-07 17:57:36 +0000 |
| commit | b3ada1540827c60a63058570a94a57dfd260ad11 (patch) | |
| tree | 4111b0516651b8faa696542ec02b30fad770c879 /voice_engine/voe_base_impl.h | |
| parent | d7b06eca993d068de0d579a83511640d74ab9f77 (diff) | |
| download | webrtc-b3ada1540827c60a63058570a94a57dfd260ad11.tar.gz | |
Ref-counted rewrite of ChannelManager.
The complexity of the last ChannelManager and potentially usage of it as well caused race conditions and deadlocks in loopback voe_auto_test. This ref-counted solution takes no long-term locks, uses less locks overall and is significantly easier to understand.
ScopedChannel has been split up into a ChannelOwner with a reference to a channel and an Iterator over ChannelManager. Previous code was really used for both things. ChannelOwner is used as a shared pointer to a channel object, while an Iterator should work as expected.
BUG=2081
R=tommi@webrtc.org, xians@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1802004
git-svn-id: http://webrtc.googlecode.com/svn/trunk/webrtc@4502 4adac7df-926f-26a2-2b94-8c16560cd09d
Diffstat (limited to 'voice_engine/voe_base_impl.h')
| -rw-r--r-- | voice_engine/voe_base_impl.h | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/voice_engine/voe_base_impl.h b/voice_engine/voe_base_impl.h index b192ca20..6715c360 100644 --- a/voice_engine/voe_base_impl.h +++ b/voice_engine/voe_base_impl.h @@ -38,8 +38,6 @@ public: virtual int Terminate(); - virtual int MaxNumOfChannels(); - virtual int CreateChannel(); virtual int DeleteChannel(int channel); |