Age | Commit message (Collapse) | Author |
|
This commit was generated by merge_from_chromium.py.
Change-Id: I85bf9681e9c3bbef9f67d93b3d275289e6911e3c
|
|
https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git at 4a1b3e3a69d349b0d3e91f607f24e02d8b975688
This commit was generated by merge_from_chromium.py.
Change-Id: Iada7abd78f123301a98db982a6272cd9487de72f
|
|
size_t is more appropriate for array lengths, since int might
theoretically be too small for a really large array. But more
importantly, if the caller's value is naturally of type size_t and the
function requires an int, VC++ will trigger warning C4267
(http://msdn.microsoft.com/en-us/library/6kck0s93.aspx) because the
implicit cast might be lossy, forcing the caller to do a manual cast.
Typing the function with size_t in the first place resolves the
problem.
R=aluebs@webrtc.org, andrew@webrtc.org, minyue@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/21909004
git-svn-id: http://webrtc.googlecode.com/svn/trunk/webrtc@6702 4adac7df-926f-26a2-2b94-8c16560cd09d
|
|
This commit was generated by merge_from_chromium.py.
Change-Id: I85d3e5fb3d9291809471c199df114e462a4739d6
|
|
https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git at 138adbb0bcdab60afda25a8727e5a071abc4ae36
This commit was generated by merge_from_chromium.py.
Change-Id: Iffa5413ebfb78de36b84b4e85d94adc093f912df
|
|
We should avoid macros in general (see style guide). This shift macro is not a severe one, since there is a check for negativity.
BUG=3348,3353
TESTED=trybots and manually
R=kwiberg@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/15799004
git-svn-id: http://webrtc.googlecode.com/svn/trunk/webrtc@6591 4adac7df-926f-26a2-2b94-8c16560cd09d
|
|
This commit was generated by merge_from_chromium.py.
Change-Id: Ie631c1eeed85862b7bade8e178791c7b230573b3
|
|
https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git at c34b9e5d5cd44c31c4f9da649b71d0d3132cf516
This commit was generated by merge_from_chromium.py.
Change-Id: Ibdea97e7e6e800b2b7d7d3122a1d77e467cfbde4
|
|
This should work as a foundation for all the work that is
left to do to make the parts of WebRTC that Chromium uses
to build with GN.
I implemented some the smaller modules myself in this CL.
The remaining work (TODO's in the .gn files) will be distributed
to various team members.
I'm adding myself to OWNERS files for BUILD.gn files in all the
directories where I'm adding a BUILD.gn file.
BUG=3441
TEST=
Successful compilation of WebRTC as standalone:
gn gen out/Default --args="build_with_chromium=false" && ninja -C out/Default
gn gen out/Default --args="build_with_chromium=false is_clang=true clang_use_chrome_plugins=false" && ninja -C out/Default
I built successfully from a Chromium checkout (with
https://codereview.chromium.org/321313006/ applied) using:
gn gen out/Default && ninja -C out/Default webrtc
R=brettw@chromium.org, niklas.enbom@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/13749004
git-svn-id: http://webrtc.googlecode.com/svn/trunk/webrtc@6523 4adac7df-926f-26a2-2b94-8c16560cd09d
|
|
This commit was generated by merge_from_chromium.py.
Change-Id: I2e09453759ef2a9b23eb8b2cf0d92f70acc3ea89
|
|
https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git at 847dfa535730a30d57cf26d788d31070b70a02af
This commit was generated by merge_from_chromium.py.
Change-Id: Id1e94a534a8e364431bcb714b54729e7a410664d
|
|
This commit was generated by merge_from_chromium.py.
Change-Id: I35c59b36614d836accbb543178393a6c061586f1
|
|
https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git at 5fcef2b6df45ceab39ee96a616ab0a4d3c63b83a
This commit was generated by merge_from_chromium.py.
Change-Id: I58be5a5957c0a6b1be9beac86538af8d38058e9e
|
|
We should avoid macros in general (see style guide) and the shift ones are particular dangerous since they assume that the user apply a non-negative shift.
Related CL: https://webrtc-codereview.appspot.com/16669004
BUG=3348,3353
TESTED=trybots and manually on linux
R=turaj@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/19719004
git-svn-id: http://webrtc.googlecode.com/svn/trunk/webrtc@6444 4adac7df-926f-26a2-2b94-8c16560cd09d
|
|
Similar change to https://codereview.chromium.org/322403003/
This will make it possible to handle different
directory levels for special builds of WebRTC, without
breaking GYP when the .isolate files are processed and
their contents is verified.
Also update all our .isolate files to use the <(DEPTH)
variable.
BUG=343106
TEST=Successful compile+test on Linux using:
ninja -C out/Release
tools/swarming_client/isolate.py run -s out/Release/tools_unittests.isolated
Also trybots passing all tests.
R=pbos@webrtc.org
TBR=tina.legrand@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/13679004
git-svn-id: http://webrtc.googlecode.com/svn/trunk/webrtc@6427 4adac7df-926f-26a2-2b94-8c16560cd09d
|
|
This macro is only used at a few places and implies a cast to uint16_t before right shifting. All places already use uint16_t. Further, the amount of shifts applied in the macro has no sanity check for negativity, makes the macro dangerous to use.
BUG=3348,3353
TESTED=trybots and manually
R=kwiberg@webrtc.org, tina.legrand@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/16669004
git-svn-id: http://webrtc.googlecode.com/svn/trunk/webrtc@6393 4adac7df-926f-26a2-2b94-8c16560cd09d
|
|
This macro is only used by the fixed point version of iSAC. Replacing the (five) locations in arith_routines_logist.c, where it is used, with the actual operation.
BUG=3348,3353
TESTED=trybots and manually
R=kwiberg@webrtc.org, tina.legrand@webrtc.org, turaj@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/14659004
git-svn-id: http://webrtc.googlecode.com/svn/trunk/webrtc@6392 4adac7df-926f-26a2-2b94-8c16560cd09d
|
|
This commit was generated by merge_from_chromium.py.
Change-Id: I00be1885a20e1c8d4e5758fa281dca19d3ba4407
|
|
This should make project-wide changes for isolate files
easier and make it more obvious who's a suitable reviewer
for them.
BUG=
R=niklas.enbom@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/19689004
git-svn-id: http://webrtc.googlecode.com/svn/trunk/webrtc@6379 4adac7df-926f-26a2-2b94-8c16560cd09d
|
|
This commit was generated by merge_from_chromium.py.
Change-Id: Iad0f8b40d3547d8d6337888a84071a951f8302d6
|
|
This commit was generated by merge_from_chromium.py.
Change-Id: I9f8d417e25bac16cf9f0cea277d28da37190aab2
|
|
https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git at 81f8df9af96c6b4bf43234f2a0162146a5da6112
This commit was generated by merge_from_chromium.py.
Change-Id: I5e92e5b4b908703fa09deb90de067accd8e65be7
|
|
https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git at 00d9c49cb076626f711988332749a0ebe8d2a32f
This commit was generated by merge_from_chromium.py.
Change-Id: I96ad217da0f6ba1aff0d39f9ecffa44e04dc08df
|
|
The CL also includes same changes to filterbanks.c in iSAC fix and aecm_core_c.c
BUG=3370,3395,3439
TESTED=trybots
R=fdegans@chromium.org, glaznev@webrtc.org, kwiberg@webrtc.org, tina.legrand@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/14609004
git-svn-id: http://webrtc.googlecode.com/svn/trunk/webrtc@6337 4adac7df-926f-26a2-2b94-8c16560cd09d
|
|
WEBRTC_SPL_MUL_16_16_RSFT_WITH_FIXROUND
This macro was only used at two places in fixed point iSAC, where it has been replaced with the operation.
BUG=3348,3353
TESTED=trybots
R=tina.legrand@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/15669004
git-svn-id: http://webrtc.googlecode.com/svn/trunk/webrtc@6336 4adac7df-926f-26a2-2b94-8c16560cd09d
|
|
Ever since crrev.com/133053 OS==android implies:
gtest_target_type=shared_library
Similar to Chromium's crrev.com/271222 where base.gyp's conditions are changed
(which the affected conditions in this cl comes from).
R=henrike@webrtc.org, wu@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/13539004
git-svn-id: http://webrtc.googlecode.com/svn/trunk/webrtc@6332 4adac7df-926f-26a2-2b94-8c16560cd09d
|
|
This commit was generated by merge_from_chromium.py.
Change-Id: Iefab95a41a20f3168e99058b4bb2c8bdeea517b1
|
|
https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git at ff6b4a8eddca609ad2691b54f443b6f1e9342579
This commit was generated by merge_from_chromium.py.
Change-Id: I3dceea02410ec9709a6dc1ffab5962cba1821b63
|
|
This commit was generated by merge_from_chromium.py.
Change-Id: I70bf922138e2eb64db46440251a820768624f64a
|
|
This commit was generated by merge_from_chromium.py.
Change-Id: Ic7d92867c246d6f9d9ba437856c2158d5dff108d
|
|
In r6240 gcc was rolled from 4.6 to 4.8 changing the behavior on arm. The output of ComplexFFT differs causing both AECM and NS to perform worse. Looking at issues on gcc it says that there could be a memory shuffling/optimization despite using volatile affecting the output.
Splitting the three instructions in one call into two separate calls makes the compiler take proper actions resulting in correct outputs.
BUG=3370,3395
TESTED=trybots
R=kwiberg@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/21549004
git-svn-id: http://webrtc.googlecode.com/svn/trunk/webrtc@6261 4adac7df-926f-26a2-2b94-8c16560cd09d
|
|
https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git at e066d34bb747f730084f1726408ca8348ff25da7
This commit was generated by merge_from_chromium.py.
Change-Id: I94edbc99f9ae2b5f6ab2f155184548bffd2b57f9
|
|
This commit was generated by merge_from_chromium.py.
Change-Id: I193a8a178b0e7da4d04fc4068510d6e055907ada
|
|
This commit was generated by merge_from_chromium.py.
Change-Id: I7796770da8bb97d74f8c10c6c41d27e91dd77674
|
|
system_wrappers/interface/constructor_magic.h.
Same as https://webrtc-codereview.appspot.com/19519004. The issue in
http://chromegw.corp.google.com/i/internal.chromium.webrtc.fyi/builders/Linux...
is solved by this change
http://src.chromium.org/viewvc/chrome/trunk/src/third_party/libjingle/libjing...
(tested locally).
BUG=3380
R=andrew@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/17619005
git-svn-id: http://webrtc.googlecode.com/svn/trunk/webrtc@6218 4adac7df-926f-26a2-2b94-8c16560cd09d
|
|
> Switch to using base/constructormagic.h and remove system_wrappers/interface/constructor_magic.h.
>
> BUG=N/A
> R=andrew@webrtc.org
>
> Review URL: https://webrtc-codereview.appspot.com/19519004
TBR=henrike@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/14579007
git-svn-id: http://webrtc.googlecode.com/svn/trunk/webrtc@6210 4adac7df-926f-26a2-2b94-8c16560cd09d
|
|
system_wrappers/interface/constructor_magic.h.
BUG=N/A
R=andrew@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/19519004
git-svn-id: http://webrtc.googlecode.com/svn/trunk/webrtc@6202 4adac7df-926f-26a2-2b94-8c16560cd09d
|
|
they currently are broken with gcc 4.8.
BUG=3370
R=bjornv@webrtc.org, kjellander@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/14569004
git-svn-id: http://webrtc.googlecode.com/svn/trunk/webrtc@6197 4adac7df-926f-26a2-2b94-8c16560cd09d
|
|
https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git at 07818d1134a8fc4272ca0dd108d8f35d1753f9c3
This commit was generated by merge_from_chromium.py.
Change-Id: I230336bc8a5170a35b2000caeb37bc4f83ffeaf9
|
|
This commit was generated by merge_from_chromium.py.
Change-Id: I9f544c8ba5553156a8413c2512153949af8ffa52
|
|
This commit was generated by merge_from_chromium.py.
Change-Id: I8cc5b66e45946bb02401d537bc075914ac435395
|
|
https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git at da7c539c377367da25fc913d4399c5f0f69764ad
This commit was generated by merge_from_chromium.py.
Change-Id: Ieab52294a0a33f311c9f61dad4f7ab932a7280d5
|
|
This macro was only used on two lines in iSACfix and I replaced those with the operations the macro performed.
BUG=3348
TESTED=trybots, manual unittests
R=tina.legrand@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/14529004
git-svn-id: http://webrtc.googlecode.com/svn/trunk/webrtc@6184 4adac7df-926f-26a2-2b94-8c16560cd09d
|
|
Macro was only mapping a function used in one place.
BUG=3348
TESTED=trybots, unittests
R=tina.legrand@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/17499004
git-svn-id: http://webrtc.googlecode.com/svn/trunk/webrtc@6180 4adac7df-926f-26a2-2b94-8c16560cd09d
|
|
* Moved the macro to randomization_functions and made it static const.
* Made WebRtc_IncreaseSeed() static, since it is not used outside this function.
* Style guide changes.
BUG=3348,3353
TESTED=trybots, common_audio_unittests, modules_unittests, modules_tests
R=tina.legrand@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/21459004
git-svn-id: http://webrtc.googlecode.com/svn/trunk/webrtc@6179 4adac7df-926f-26a2-2b94-8c16560cd09d
|
|
* WEBRTC_SPL_MUL_32_32_RSFT32BI
* WEBRTC_SPL_IS_NEG
BUG=3348
TESTED=trybots, common_audio_unittests
R=tina.legrand@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/18449004
git-svn-id: http://webrtc.googlecode.com/svn/trunk/webrtc@6169 4adac7df-926f-26a2-2b94-8c16560cd09d
|
|
This commit was generated by merge_from_chromium.py.
Change-Id: Ia7fa63f08e76ed00046e843056e652b39cbac21c
|
|
This commit was generated by merge_from_chromium.py.
Change-Id: I6d63998085f0742a4941376900fef211d6f30dee
|
|
This commit was generated by merge_from_chromium.py.
Change-Id: I8d754e2f0604394449a111b3c2cbbc0c49e7ea23
|
|
https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git at 39d9fa5486157fb4b3ab28ae403aeaa6d651e92b
This commit was generated by merge_from_chromium.py.
Change-Id: I1cebd150247452024503e31c64ce6057c4b75b2a
|