summaryrefslogtreecommitdiff
path: root/typedefs.h
AgeCommit message (Collapse)Author
2014-08-28Add CHECK and friends from Chromium.andrew@webrtc.org
Replace FATAL_ERROR_IF with the more familiar (to Chromium developers) CHECK and DCHECK. The full Chromium implementation is fairly elaborate but I copied enough to get us most of the benefits. I believe the main missing component is a more advanced stack dump. For this bit I relied on the V8 implementation. There are a few minor modifications from the Chromium original: - The FatalMessage class is specialized for logging fatal error messages and aborting. Chromium uses the general LogMessage class, which we could consider moving towards in the future. - NOTIMPLEMENTED() and NOTREACHED() have been removed, partly because I don't want to rely on our logging.h until base/ and system_wrappers/ are consolidated. - FATAL() replaces LOG(FATAL). Minor modifications from V8's stack dump: - If parsing of a stack trace symbol fails, just print the unparsed symbol. (I noticed this happened on Mac.) - Use __GLIBCXX__ and __UCLIBC__. This is from examining the backtrace use in Chromium. UNREACHABLE() has been removed because its behavior is different than Chromium's NOTREACHED(), which is bound to cause confusion. The few uses were replaced with FATAL(), matching the previous behavior. Add a NO_RETURN macro, allowing us to remove unreachable return statements following a CHECK/FATAL. TESTED=the addition of dummy CHECK, DCHECK, CHECK_EQ and FATAL did the did the right things. Stack traces work on Mac, but I don't get symbols on Linux. R=henrik.lundin@webrtc.org, kwiberg@webrtc.org, tommi@webrtc.org Review URL: https://webrtc-codereview.appspot.com/22449004 git-svn-id: http://webrtc.googlecode.com/svn/trunk/webrtc@7003 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-08-25Fix WEBRTC_AEC_DEBUG_DUMP (broken by int16->float conversion)kwiberg@webrtc.org
And in the process, make it dump WAV files instead of raw PCM. R=andrew@webrtc.org, bjornv@webrtc.org Review URL: https://webrtc-codereview.appspot.com/19089004 git-svn-id: http://webrtc.googlecode.com/svn/trunk/webrtc@6959 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-05Remove ALLOW_UNUSED.andrew@webrtc.org
Turns out Chromium won't be applying this to COMPILE_ASSERT. We don't need it at all then. R=thakis@chromium.org TBR=thakis@chromium.org Review URL: https://webrtc-codereview.appspot.com/13469005 git-svn-id: http://webrtc.googlecode.com/svn/trunk/webrtc@6055 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-04Add ALLOW_UNUSED and update COMPILE_ASSERT to Chromium's latest.andrew@webrtc.org
Fixes building with gcc 4.8. TBR=fdegans@google.com BUG=chromium:321833 Review URL: https://webrtc-codereview.appspot.com/12439004 git-svn-id: http://webrtc.googlecode.com/svn/trunk/webrtc@6050 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-04-01Fix ARM64 detection.andrew@webrtc.org
Use only __aarch64__ and don't look for __arm64__ at all. It turns out that clang defines both and GCC only the former. Hence, looking only for __aarch64__ should be safe. BUG=chromium:354405,chromium:358092 R=andrew@webrtc.org Review URL: https://webrtc-codereview.appspot.com/10939004 Patch from Primiano Tucci <primiano@chromium.org>. git-svn-id: http://webrtc.googlecode.com/svn/trunk/webrtc@5821 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-03-27Add arm64 to typedefs.handrew@webrtc.org
This is the first step to get a buildable chrome_shell_apk for arm64. BUG=chromium:354405 R=andrew@webrtc.org Review URL: https://webrtc-codereview.appspot.com/10819004 Patch from Primiano Tucci <primiano@chromium.org>. git-svn-id: http://webrtc.googlecode.com/svn/trunk/webrtc@5802 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-03-07Moves WEBRTC_POSIX define from header file to gyp-settings.henrike@webrtc.org
Makes WEBRTC_POSIX defined in the same place as the other OSs also this is needed to prevent excessive changes to talk/base files when migrating them to webrtc/base BUG=N/A R=andrew@webrtc.org Review URL: https://webrtc-codereview.appspot.com/9499004 git-svn-id: http://webrtc.googlecode.com/svn/trunk/webrtc@5659 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-03-04Add a deinterleaved float interface to AudioProcessing.andrew@webrtc.org
This is mainly to support the native audio format in Chrome. Although this implementation just moves the float->int conversion under the hood, we will transition AudioProcessing towards supporting this format throughout. - Add a test which verifies we get identical output with the float and int interfaces. - The float and int wrappers are tasked with conversion to the AudioBuffer format. A new shared Process/Analyze method does most of the work. - Add a new field to the debug.proto to hold deinterleaved data. - Add helpers to audio_utils.cc, and start using numeric_limits. - Note that there was no performance difference between numeric_limits and a literal value when measured on Linux using gcc or clang. BUG=2894 R=aluebs@webrtc.org, bjornv@webrtc.org, henrikg@webrtc.org, tommi@webrtc.org, turaj@webrtc.org, xians@webrtc.org Review URL: https://webrtc-codereview.appspot.com/9179004 git-svn-id: http://webrtc.googlecode.com/svn/trunk/webrtc@5641 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-02-27Clean up CPU detection defines in SincResampler a little.andrew@webrtc.org
R=aluebs@webrtc.org Review URL: https://webrtc-codereview.appspot.com/9159004 git-svn-id: http://webrtc.googlecode.com/svn/trunk/webrtc@5615 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-02-19Added architecture for compiling under chrome NaCl.andresp@webrtc.org
R=tommi@webrtc.org Review URL: https://webrtc-codereview.appspot.com/8899004 git-svn-id: http://webrtc.googlecode.com/svn/trunk/webrtc@5577 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-10Correctly define OVERRIDE when building with g++ 4.7 and C++11 supportandrew@webrtc.org
g++ 4.7 and later support explicit virtual overrides when building with C++11 support enabled. However, webrtc does not detect that and makes OVERRIDE a no-op. This CL updates typedefs.h to define OVERRIDE properly when g++ 4.7 is used with C++11 support enabled. See this page for GCC support of C++11 features: http://gcc.gnu.org/projects/cxx0x.html R=andrew@webrtc.org, fischman@webrtc.org Review URL: https://webrtc-codereview.appspot.com/5149005 Patch from Chris Dumez <ch.dumez@samsung.com>. git-svn-id: http://webrtc.googlecode.com/svn/trunk/webrtc@5253 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-10-23Check if WARN_UNUSED_RESULT and COMPILE_ASSERT are defined.andrew@webrtc.org
Works around a multiple definition error from webrtc and libjingle. Corresponds to the libjingle change here: https://critique.corp.google.com/#review/55489575-p10 TESTED=trybots R=wu@webrtc.org Review URL: https://webrtc-codereview.appspot.com/2809004 git-svn-id: http://webrtc.googlecode.com/svn/trunk/webrtc@5025 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-10-22Upgrade scoped_ptr to Chromium's latest version.andrew@webrtc.org
Analogous to the recent libjingle change: http://cl/54929753-p10. This supports scoped_ptr<T[]> and scoped_ptr<C, FreeDeleter> rather than scoped_array and scoped_ptr_malloc respectively. - Add Chromium's template-based COMPILE_ASSERT. We didn't have this previously in order to support the macro in C. Instead, move the existing macro to compile_assert_c.h. - Additionally copy the move.h and template_util.h depedencies and add the WARN_UNUSED_RESULT macro. - Leave scoped_array and scoped_ptr_malloc for now, but mark as deprecated. - Remove scoped_ptr foo(NULL) use. The default constructor handles it. - Remove the now redundant COMPILE_ASSERT from peerconnection_jni.cc. - Add a CHECK_ARRAY_SIZE macro to rtp_format_vp8_unittest.cc to remove some repeated code. TESTED=trybots R=pbos@webrtc.org, tommi@webrtc.org Review URL: https://webrtc-codereview.appspot.com/2449005 git-svn-id: http://webrtc.googlecode.com/svn/trunk/webrtc@5015 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-10-22WEBRTC_{BIG, LITTLE}_ENDIAN -> WEBRTC_ARCH_{BIG, LITTLE}_ENDIAN.andrew@webrtc.org
Mostly to remove a long-standing TODO... TESTED=trybots R=turaj@webrtc.org Review URL: https://webrtc-codereview.appspot.com/2369005 git-svn-id: http://webrtc.googlecode.com/svn/trunk/webrtc@5013 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-08Disable clang C++11 warnings to permit OVERRIDE keyword.pbos@webrtc.org
BUG=1623 R=tommi@webrtc.org Review URL: https://webrtc-codereview.appspot.com/1431004 git-svn-id: http://webrtc.googlecode.com/svn/trunk/webrtc@3980 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-03Revert 3934 "Revert 3933 "Remove traces of deprecated WebRtc_Wor..."pbos@webrtc.org
> Revert 3933 "Remove traces of deprecated WebRtc_Word types." > > > Remove traces of deprecated WebRtc_Word types. > > > > BUG=314 > > R=tommi@webrtc.org > > > > Review URL: https://webrtc-codereview.appspot.com/1385004 > > TBR=pbos@webrtc.org > > Review URL: https://webrtc-codereview.appspot.com/1386004 TBR=pbos@webrtc.org Review URL: https://webrtc-codereview.appspot.com/1397004 git-svn-id: http://webrtc.googlecode.com/svn/trunk/webrtc@3948 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-02Revert 3933 "Remove traces of deprecated WebRtc_Word types."pbos@webrtc.org
> Remove traces of deprecated WebRtc_Word types. > > BUG=314 > R=tommi@webrtc.org > > Review URL: https://webrtc-codereview.appspot.com/1385004 TBR=pbos@webrtc.org Review URL: https://webrtc-codereview.appspot.com/1386004 git-svn-id: http://webrtc.googlecode.com/svn/trunk/webrtc@3934 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-02Remove traces of deprecated WebRtc_Word types.pbos@webrtc.org
BUG=314 R=tommi@webrtc.org Review URL: https://webrtc-codereview.appspot.com/1385004 git-svn-id: http://webrtc.googlecode.com/svn/trunk/webrtc@3933 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-04-10Replace legacy G_CONST with const.pbos@webrtc.org
BUG=1608 Review URL: https://webrtc-codereview.appspot.com/1310005 git-svn-id: http://webrtc.googlecode.com/svn/trunk/webrtc@3814 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-03-25Add some VoE and AudioProcessing mocks.andrew@webrtc.org
Includes a bit of shared helpers in fake_common.h. Review URL: https://webrtc-codereview.appspot.com/1221004 git-svn-id: http://webrtc.googlecode.com/svn/trunk/webrtc@3722 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-10-22Move src/ -> webrtc/andrew@webrtc.org
TBR=niklas.enbom@webrtc.org Review URL: https://webrtc-codereview.appspot.com/915006 git-svn-id: http://webrtc.googlecode.com/svn/trunk/webrtc@2963 4adac7df-926f-26a2-2b94-8c16560cd09d
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-03 16:59:27 +0000