Age | Commit message (Collapse) | Author |
|
R=juberti@google.com, mflodman@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/10099005
git-svn-id: http://webrtc.googlecode.com/svn/trunk/webrtc@5746 4adac7df-926f-26a2-2b94-8c16560cd09d
|
|
BUG=1577
R=mflodman@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/9299006
git-svn-id: http://webrtc.googlecode.com/svn/trunk/webrtc@5736 4adac7df-926f-26a2-2b94-8c16560cd09d
|
|
- An RTX packet with no payload should be dropped prior to parsing RTX header since it doesn't have an RTX header. This can for example happen when sending padding-only packets over the RTX stream.
- The retransmit code path when the pacer is disabled doesn't properly update the abs-send-time and ts-offset header extensions.
TEST=trybots
R=mflodman@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/9189004
git-svn-id: http://webrtc.googlecode.com/svn/trunk/webrtc@5728 4adac7df-926f-26a2-2b94-8c16560cd09d
|
|
New interface uses two bitrates (max/min). The pace multiplier is also
removed from the interface and instead utilized outside. Min bitrate
will be filled with padding if there's not enough media to transmit.
Also fixes a bug in minimum transmission bitrate that made it ignore
REMBs. A regression test has been added to catch it.
BUG=3014
R=mflodman@webrtc.org, stefan@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/10059004
git-svn-id: http://webrtc.googlecode.com/svn/trunk/webrtc@5723 4adac7df-926f-26a2-2b94-8c16560cd09d
|
|
The deadlock can happen when using HW encoder. HW encoder calls
the encode complete callback on libjingle worker thread instead
of ViECaptureThread. The capture thread can hold VieEncoder::|data_cs_|
and wait for ModuleRtpRtcpImpl::|critical_section_module_ptrs_|.
When libjingle worker thread runs encode complete callback, it
can hold ModuleRtpRtcpImpl::|critical_section_module_ptrs_| and
wait for VieEncoder::|data_cs_|.
|default_rtp_rtcp_| is not guarded by |data_cs|. So move it out of
the critical section to avoid the deadlock.
BUG=chromium:352567
TEST=Run apprtc loopback on CrOS.
Run apprtc between CrOS and Linux.
Run vie_auto_test.
R=henrik.lundin@webrtc.org, pbos@webrtc.org, stefan@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/10039004
git-svn-id: http://webrtc.googlecode.com/svn/trunk/webrtc@5721 4adac7df-926f-26a2-2b94-8c16560cd09d
|
|
Utilizing minimum transmission bitrate prevents low remote bitrate
estimates (bitrate estimation dips) when encoding non-complex content
such as screenshare of a static image even though there's nothing wrong
with the link.
Requires pacing to be enabled for now, pending issue 3036.
BUG=3014
R=mflodman@webrtc.org, stefan@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/9719004
git-svn-id: http://webrtc.googlecode.com/svn/trunk/webrtc@5694 4adac7df-926f-26a2-2b94-8c16560cd09d
|
|
BUG=chromium:348222
R=mflodman@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/9519004
git-svn-id: http://webrtc.googlecode.com/svn/trunk/webrtc@5660 4adac7df-926f-26a2-2b94-8c16560cd09d
|
|
The new test is based upon the exisiting rampup test, but also adds
a low-rate period. The main purpose of the test is to verify the
SuspendBelowMinBitrate functionality, which must be enabled for the
test to pass.
The CL also adds a change to the min bitrate in the send-side bandwidth
estimator when SuspendBelowMinBitrate is enabled.
An anonymous namespace is added around the StreamObserver classes
in the test to avoid silent linker conflicts that could happen
otherwise.
Note: this CL depends on https://webrtc-codereview.appspot.com/9049004/
BUG=2636
R=stefan@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/9059004
git-svn-id: http://webrtc.googlecode.com/svn/trunk/webrtc@5646 4adac7df-926f-26a2-2b94-8c16560cd09d
|
|
BUG=2775
R=stefan@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/8959005
git-svn-id: http://webrtc.googlecode.com/svn/trunk/webrtc@5621 4adac7df-926f-26a2-2b94-8c16560cd09d
|
|
BUG=2638
R=mflodman@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/8979005
git-svn-id: http://webrtc.googlecode.com/svn/trunk/webrtc@5601 4adac7df-926f-26a2-2b94-8c16560cd09d
|
|
TBR= wu@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/8979004
git-svn-id: http://webrtc.googlecode.com/svn/trunk/webrtc@5589 4adac7df-926f-26a2-2b94-8c16560cd09d
|
|
BUG=1577
R=mflodman@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/8949005
git-svn-id: http://webrtc.googlecode.com/svn/trunk/webrtc@5585 4adac7df-926f-26a2-2b94-8c16560cd09d
|
|
NACK and FIR).
Add counter to RTCP sender and RTCP receiver.
Add video api GetRtcpPacketTypes().
BUG=2638
R=mflodman@webrtc.org, stefan@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/8179004
git-svn-id: http://webrtc.googlecode.com/svn/trunk/webrtc@5575 4adac7df-926f-26a2-2b94-8c16560cd09d
|
|
BUG=
R=henrika@webrtc.org, henrikg@webrtc.org, phoglund@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/8459004
git-svn-id: http://webrtc.googlecode.com/svn/trunk/webrtc@5564 4adac7df-926f-26a2-2b94-8c16560cd09d
|
|
jitter if stop sending).
Add delay before start processing after a reset.
BUG=1577
R=mflodman@webrtc.org, stefan@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/8699006
git-svn-id: http://webrtc.googlecode.com/svn/trunk/webrtc@5561 4adac7df-926f-26a2-2b94-8c16560cd09d
|
|
This fixes a race caught by the linux tsan bot.
R=kjellander@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/8739004
git-svn-id: http://webrtc.googlecode.com/svn/trunk/webrtc@5551 4adac7df-926f-26a2-2b94-8c16560cd09d
|
|
BUG=1577
R=stefan@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/8629004
git-svn-id: http://webrtc.googlecode.com/svn/trunk/webrtc@5544 4adac7df-926f-26a2-2b94-8c16560cd09d
|
|
TEST=trybots
R=mflodman@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/8619004
git-svn-id: http://webrtc.googlecode.com/svn/trunk/webrtc@5543 4adac7df-926f-26a2-2b94-8c16560cd09d
|
|
Before the change no padding was allowed before the first remote bitrate
estimation was received. This bitrate estimation is based on what's
actually sent. In tests I set codec.startBitrate to 300 instead of
325, which incidentally means that only the first layer gets encoded.
As we only send ~150kbps instead of 300, the first REMB will
significantly pull down the remote bitrate estimate instead of keeping
the existing rate, even though there's no problem with the link.
This was detected in RampUpTest.PacingWithRtx,
(send_config.codec.startBitrate=300), which caused the tests to become a
lot slower, and flake out more. By allowing padding initially we're able
to keep our initial bitrate estimate.
R=stefan@webrtc.org
TEST=Running RampUpTest.WithPacingAndRtx with startBandwidth=300.
BUG=
Review URL: https://webrtc-codereview.appspot.com/8529004
git-svn-id: http://webrtc.googlecode.com/svn/trunk/webrtc@5534 4adac7df-926f-26a2-2b94-8c16560cd09d
|
|
BUG=
R=mflodman@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/8079005
git-svn-id: http://webrtc.googlecode.com/svn/trunk/webrtc@5525 4adac7df-926f-26a2-2b94-8c16560cd09d
|
|
BUG=crbug/338380
R=stefan@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/8119004
git-svn-id: http://webrtc.googlecode.com/svn/trunk/webrtc@5519 4adac7df-926f-26a2-2b94-8c16560cd09d
|
|
This is the second CL for this change. Connection to the ViE API
remains to be done.
BUG=2698
R=mflodman@webrtc.org, stefan@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/5769004
git-svn-id: http://webrtc.googlecode.com/svn/trunk/webrtc@5455 4adac7df-926f-26a2-2b94-8c16560cd09d
|
|
We reverted the r5421 to allow us roll webrtc to chrome without any modifications
to libjingle. Since webrtc is rolled with r5444, we can add back the original CL
and changes to libjingle will be upstreamed in the next roll.
TBR=andresp@webrtc.org
> Revert 5421 "Fix deadlock on register/unregister observer while ..."
>
> Failure to compile on Chromium Internal bots, because of API changes.
>
> http://chromegw.corp.google.com/i/internal.chromium.webrtc.fyi/builders/Mac/builds/2805/steps/compile/logs/stdio
>
> You need to follow the steps mentioned in
> https://docs.google.com/a/google.com/document/d/1aHrmXECnu3-Jovc2-zYI267EaQCYz-IclYyBp9iA9Fc/edit that of a API changer.
>
> Since I will be rolling the libjingle this week, I can push your changes along with libjingle roll, if you prepare the CLs
> as mentioned in the doc.
>
> > Fix deadlock on register/unregister observer while there is a an going callback.
> >
> > BUG=2835
> > R=mallinath@webrtc.org
> >
> > Review URL: https://webrtc-codereview.appspot.com/7119005
>
> TBR=andresp@webrtc.org
>
> Review URL: https://webrtc-codereview.appspot.com/7679004
TBR=mallinath@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/7729005
git-svn-id: http://webrtc.googlecode.com/svn/trunk/webrtc@5453 4adac7df-926f-26a2-2b94-8c16560cd09d
|
|
Failure to compile on Chromium Internal bots, because of API changes.
http://chromegw.corp.google.com/i/internal.chromium.webrtc.fyi/builders/Mac/builds/2805/steps/compile/logs/stdio
You need to follow the steps mentioned in
https://docs.google.com/a/google.com/document/d/1aHrmXECnu3-Jovc2-zYI267EaQCYz-IclYyBp9iA9Fc/edit that of a API changer.
Since I will be rolling the libjingle this week, I can push your changes along with libjingle roll, if you prepare the CLs
as mentioned in the doc.
> Fix deadlock on register/unregister observer while there is a an going callback.
>
> BUG=2835
> R=mallinath@webrtc.org
>
> Review URL: https://webrtc-codereview.appspot.com/7119005
TBR=andresp@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/7679004
git-svn-id: http://webrtc.googlecode.com/svn/trunk/webrtc@5444 4adac7df-926f-26a2-2b94-8c16560cd09d
|
|
BUG=2835
R=mallinath@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/7119005
git-svn-id: http://webrtc.googlecode.com/svn/trunk/webrtc@5421 4adac7df-926f-26a2-2b94-8c16560cd09d
|
|
This allows a listener to receive new statistics (byte/packet counts, etc) as it
is generated - avoiding the need to poll. This also makes handling stats from
multiple RTP streams more tractable. The change is primarily targeted at the new
video engine API.
TEST=Unit test in ReceiveStatisticsTest.
Integration tests to follow as call tests when fully wired up.
BUG=2235
R=mflodman@webrtc.org, pbos@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/6259004
git-svn-id: http://webrtc.googlecode.com/svn/trunk/webrtc@5416 4adac7df-926f-26a2-2b94-8c16560cd09d
|
|
video api.
R=mflodman@webrtc.org, pbos@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/6989004
git-svn-id: http://webrtc.googlecode.com/svn/trunk/webrtc@5401 4adac7df-926f-26a2-2b94-8c16560cd09d
|
|
R=andrew@webrtc.org, henrike@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/6939004
git-svn-id: http://webrtc.googlecode.com/svn/trunk/webrtc@5385 4adac7df-926f-26a2-2b94-8c16560cd09d
|
|
R=wu@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/7049004
git-svn-id: http://webrtc.googlecode.com/svn/trunk/webrtc@5374 4adac7df-926f-26a2-2b94-8c16560cd09d
|
|
BUG=2164
R=andrew@webrtc.org, pbos@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/6269004
git-svn-id: http://webrtc.googlecode.com/svn/trunk/webrtc@5373 4adac7df-926f-26a2-2b94-8c16560cd09d
|
|
Note, this CL does not contain any tests. Those are implemeted as call
tests and will be submitted when the receive stream is wired up as well.
BUG=2235
R=mflodman@webrtc.org, pbos@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/5559006
git-svn-id: http://webrtc.googlecode.com/svn/trunk/webrtc@5344 4adac7df-926f-26a2-2b94-8c16560cd09d
|
|
TESTED: As expected clang bots catched a few issues which are fixed with this CL, other bots ignore the annotations and compile fine.
R=niklas.enbom@webrtc.org, phoglund@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/6209004
git-svn-id: http://webrtc.googlecode.com/svn/trunk/webrtc@5328 4adac7df-926f-26a2-2b94-8c16560cd09d
|
|
bitrate, cap the star rate accordingly.
BUG=2720
R=asapersson@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/6239004
git-svn-id: http://webrtc.googlecode.com/svn/trunk/webrtc@5327 4adac7df-926f-26a2-2b94-8c16560cd09d
|
|
Critical section ViECapturer.observer_cs_ should be taken when
registering an observer.
BUG=2734
R=mflodman@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/5999004
git-svn-id: http://webrtc.googlecode.com/svn/trunk/webrtc@5326 4adac7df-926f-26a2-2b94-8c16560cd09d
|
|
R=wu@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/6189004
git-svn-id: http://webrtc.googlecode.com/svn/trunk/webrtc@5324 4adac7df-926f-26a2-2b94-8c16560cd09d
|
|
This allows a listener to receive new statistics as it is generated - avoiding the need to poll. This also makes handling stats from multiple RTP streams more tractable.
The change is primarily targeted at the new video engine API.
TEST=Unit test in ReceiveStatisticsTest. Integration tests to follow as call tests when fully wired up.
BUG=2235
R=henrika@webrtc.org, pbos@webrtc.org, stefan@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/5089004
git-svn-id: http://webrtc.googlecode.com/svn/trunk/webrtc@5323 4adac7df-926f-26a2-2b94-8c16560cd09d
|
|
TEST=trybots
R=mflodman@webrtc.org, pbos@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/5529004
git-svn-id: http://webrtc.googlecode.com/svn/trunk/webrtc@5321 4adac7df-926f-26a2-2b94-8c16560cd09d
|
|
BUG=
R=mflodman@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/6139004
git-svn-id: http://webrtc.googlecode.com/svn/trunk/webrtc@5318 4adac7df-926f-26a2-2b94-8c16560cd09d
|
|
To fix races in test each stream now owns its own encoder/decoder.
R=mflodman@webrtc.org
BUG=
Review URL: https://webrtc-codereview.appspot.com/5919004
git-svn-id: http://webrtc.googlecode.com/svn/trunk/webrtc@5297 4adac7df-926f-26a2-2b94-8c16560cd09d
|
|
> Auto instantiate RBE depending on whether AST or TOF is available in incoming packet stream.
>
> BUG=
> R=mflodman@webrtc.org, stefan@webrtc.org
>
> Review URL: https://webrtc-codereview.appspot.com/5409004
TBR=solenberg@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/5889004
git-svn-id: http://webrtc.googlecode.com/svn/trunk/webrtc@5294 4adac7df-926f-26a2-2b94-8c16560cd09d
|
|
incoming packet stream.
BUG=
R=mflodman@webrtc.org, stefan@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/5409004
git-svn-id: http://webrtc.googlecode.com/svn/trunk/webrtc@5293 4adac7df-926f-26a2-2b94-8c16560cd09d
|
|
Issue https://webrtc-codereview.appspot.com/4459004/ was commited as
r5259, after which flakiness was detected and a rollback was performed
at r5261.
Patch Set 1 of this issue is the code submitted in r5259. Subsequent
patch sets fixes a race condition which caused the seen problems.
The root cause was a dead lock between a thread sending rtp packets and
and a timed module processing thread:
webrtc::RTPSender::BitrateUpdated() // Get RTPSender stats lock
webrtc::Bitrate::Process() // Get Bitrate lock
webrtc::RTPSender::ProcessBitrate()
webrtc::ModuleRtpRtcpImpl::Process()
...
webrtc::Bitrate::Update() // Get Bitrate lock
webrtc::RTPSender::UpdateRtpStats() // Get RTPSender stats lock
webrtc::RTPSender::SendToNetwork()
...
This is fixed in Bitrate::Process() by releasing the lock before
calling the callback.
BUG=2235
R=mflodman@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/5619004
git-svn-id: http://webrtc.googlecode.com/svn/trunk/webrtc@5281 4adac7df-926f-26a2-2b94-8c16560cd09d
|
|
Tested manually. I'll make a follow CL with a proper test once review.webrtc.org/5619004 has been committed.
R=pbos@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/5509004
git-svn-id: http://webrtc.googlecode.com/svn/trunk/webrtc@5280 4adac7df-926f-26a2-2b94-8c16560cd09d
|
|
The minimum bitrate can now be configured from WrappingBitrateEstimator.
BUG=2698
R=stefan@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/5699004
git-svn-id: http://webrtc.googlecode.com/svn/trunk/webrtc@5279 4adac7df-926f-26a2-2b94-8c16560cd09d
|
|
https://webrtc-codereview.appspot.com/5309005/.
R=mallinath@webrtc.org, niklas.enbom@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/5719004
git-svn-id: http://webrtc.googlecode.com/svn/trunk/webrtc@5277 4adac7df-926f-26a2-2b94-8c16560cd09d
|
|
> Update talk to 58113193 together with https://webrtc-codereview.appspot.com/5309005/.
>
> R=mallinath@webrtc.org, niklas.enbom@webrtc.org
>
> Review URL: https://webrtc-codereview.appspot.com/5719004
TBR=wu@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/5729004
git-svn-id: http://webrtc.googlecode.com/svn/trunk/webrtc@5275 4adac7df-926f-26a2-2b94-8c16560cd09d
|
|
https://webrtc-codereview.appspot.com/5309005/.
R=mallinath@webrtc.org, niklas.enbom@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/5719004
git-svn-id: http://webrtc.googlecode.com/svn/trunk/webrtc@5274 4adac7df-926f-26a2-2b94-8c16560cd09d
|
|
BUG=2122
R=andrew@webrtc.org, fischman@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/3669004
git-svn-id: http://webrtc.googlecode.com/svn/trunk/webrtc@5273 4adac7df-926f-26a2-2b94-8c16560cd09d
|
|
R=mflodman@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/5199005
git-svn-id: http://webrtc.googlecode.com/svn/trunk/webrtc@5272 4adac7df-926f-26a2-2b94-8c16560cd09d
|
|
Optionally prevents doing a frame copy when putting frames into a
VideoSendStream. PutFrame() is still there, which copies the frame.
Also removes time_since_capture_ms as a parameter, since
I420VideoFrame::render_time_ms() denotes when the frame was captured.
BUG=2657
R=mflodman@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/5119004
git-svn-id: http://webrtc.googlecode.com/svn/trunk/webrtc@5265 4adac7df-926f-26a2-2b94-8c16560cd09d
|