diff options
| author | thakis@chromium.org <thakis@chromium.org@78cadc50-ecff-11dd-a971-7dbc132099af> | 2013-08-12 15:48:28 +0000 |
|---|---|---|
| committer | thakis@chromium.org <thakis@chromium.org@78cadc50-ecff-11dd-a971-7dbc132099af> | 2013-08-12 15:48:28 +0000 |
| commit | 793f69bbc09792052636dbe6038678b24d68e11b (patch) | |
| tree | e033aabaa12bbeb4fee3b25a2a1cce9c24ba1c77 | |
| parent | 8fcfea42b6d343297e8b6b786d85fa5ad862fc30 (diff) | |
| download | gyp-793f69bbc09792052636dbe6038678b24d68e11b.tar.gz | |
ninja/mac: Warn on conditional keys.
Now that ARCHS is supported, someone might try to use FOO[arch=i386], that
shouldn't fail silently.
BUG=chromium:122592,chromium:90185
R=scottmg@chromium.org
Review URL: https://codereview.chromium.org/22846002
git-svn-id: http://gyp.googlecode.com/svn/trunk@1693 78cadc50-ecff-11dd-a971-7dbc132099af
| -rw-r--r-- | pylib/gyp/xcode_emulation.py | 9 |
1 files changed, 9 insertions, 0 deletions
diff --git a/pylib/gyp/xcode_emulation.py b/pylib/gyp/xcode_emulation.py index 6dda4c86..5e8f2b78 100644 --- a/pylib/gyp/xcode_emulation.py +++ b/pylib/gyp/xcode_emulation.py @@ -39,6 +39,15 @@ class XcodeSettings(object): None): self.isIOS = True + # If you need this, speak up at http://crbug.com/122592 + conditional_keys = [key for key in self.xcode_settings[configname] + if key.endswith(']')] + if conditional_keys: + print 'Warning: Conditional keys not implemented, ignoring:', \ + ' '.join(conditional_keys) + for key in conditional_keys: + del self.xcode_settings[configname][key] + # This is only non-None temporarily during the execution of some methods. self.configname = None |