From b38e5f2f93fa5b31a6001bd21b9d8dcbf73e44e7 Mon Sep 17 00:00:00 2001 From: "scottmg@chromium.org" Date: Tue, 19 Aug 2014 00:32:02 +0000 Subject: ninja win: don't expect pdb to be generated when GenerateDebugInformation: false if comparison was incorrect for truthy values when added at https://codereview.chromium.org/126443004/ (such as 'false'). Test addition fails before this CL. R=thakis@chromium.org, sky@chromium.org BUG=chromium:404872 Review URL: https://codereview.chromium.org/483133002 git-svn-id: http://gyp.googlecode.com/svn/trunk@1967 78cadc50-ecff-11dd-a971-7dbc132099af --- pylib/gyp/msvs_emulation.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'pylib/gyp/msvs_emulation.py') diff --git a/pylib/gyp/msvs_emulation.py b/pylib/gyp/msvs_emulation.py index 5f71e9e1..5384df1c 100644 --- a/pylib/gyp/msvs_emulation.py +++ b/pylib/gyp/msvs_emulation.py @@ -370,7 +370,7 @@ class MsvsSettings(object): output_file = self._Setting(('VCLinkerTool', 'ProgramDatabaseFile'), config) generate_debug_info = self._Setting( ('VCLinkerTool', 'GenerateDebugInformation'), config) - if generate_debug_info: + if generate_debug_info == 'true': if output_file: return expand_special(self.ConvertVSMacros(output_file, config=config)) else: -- cgit v1.2.3