summaryrefslogtreecommitdiff
path: root/build/skia_gold_common/PRESUBMIT.py
diff options
context:
space:
mode:
Diffstat (limited to 'build/skia_gold_common/PRESUBMIT.py')
-rw-r--r--build/skia_gold_common/PRESUBMIT.py34
1 files changed, 17 insertions, 17 deletions
diff --git a/build/skia_gold_common/PRESUBMIT.py b/build/skia_gold_common/PRESUBMIT.py
index ba2fa89dc..f3cc772d8 100644
--- a/build/skia_gold_common/PRESUBMIT.py
+++ b/build/skia_gold_common/PRESUBMIT.py
@@ -9,31 +9,31 @@ for more details on the presubmit API built into depot_tools.
USE_PYTHON3 = True
+PRESUBMIT_VERSION = '2.0.0'
-def CommonChecks(input_api, output_api):
- output = []
+
+def _GetSkiaGoldEnv(input_api):
+ """Gets the common environment for running Skia Gold tests."""
build_path = input_api.os_path.join(input_api.PresubmitLocalPath(), '..')
skia_gold_env = dict(input_api.environ)
skia_gold_env.update({
'PYTHONPATH': build_path,
'PYTHONDONTWRITEBYTECODE': '1',
})
- output.extend(
- input_api.canned_checks.RunUnitTestsInDirectory(
- input_api,
- output_api,
- input_api.PresubmitLocalPath(), [r'^.+_unittest\.py$'],
- env=skia_gold_env,
- run_on_python2=False,
- skip_shebang_check=True))
- output.extend(
- input_api.canned_checks.RunPylint(input_api, output_api, version='2.7'))
- return output
+ return skia_gold_env
-def CheckChangeOnUpload(input_api, output_api):
- return CommonChecks(input_api, output_api)
+def CheckSkiaGoldCommonUnittests(input_api, output_api):
+ """Runs the unittests for the build/skia_gold_common/ directory."""
+ return input_api.canned_checks.RunUnitTestsInDirectory(
+ input_api,
+ output_api,
+ input_api.PresubmitLocalPath(), [r'^.+_unittest\.py$'],
+ env=_GetSkiaGoldEnv(input_api),
+ run_on_python2=False,
+ skip_shebang_check=True)
-def CheckChangeOnCommit(input_api, output_api):
- return CommonChecks(input_api, output_api)
+def CheckPylint(input_api, output_api):
+ """Runs pylint on all directory content and subdirectories."""
+ return input_api.canned_checks.RunPylint(input_api, output_api, version='2.7')