diff options
| author | Brad Corso <bcorso@google.com> | 2020-09-03 16:26:36 -0700 |
|---|---|---|
| committer | Dagger Team <dagger-dev+copybara@google.com> | 2020-09-03 16:28:09 -0700 |
| commit | e861c27a0bec900bd34f9d05ee80c2b0155a8f66 (patch) | |
| tree | 9aede175c745b64f626b64ca46a16340f7f97a26 /util | |
| parent | b15fa610d2279b74b211338d8f56377db9d624e9 (diff) | |
| download | dagger2-e861c27a0bec900bd34f9d05ee80c2b0155a8f66.tar.gz | |
Fix redundant memoization for scoped bindings in fastInit.
This is done by splitting the SwitchingProviders into separate classes based on scoping:
1. Unscoped: SwitchingProvider<T> implements Provider<T>
2. SingleCheck: SingleCheckSwitchingProvider extends SingleCheck<T>
3. DoubleCheck: DoubleCheckSwitchingProvider extends DoubleCheck<T>
This allows SingleCheck and DoubleCheck to properly bypass memoization when it's not needed.
RELNOTES=Fix redundant DCL for scoped bindings requested as Lazy
PiperOrigin-RevId: 330015462
Diffstat (limited to 'util')
| -rwxr-xr-x | util/deploy-library.sh | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/util/deploy-library.sh b/util/deploy-library.sh index 73e4749c2..a744402ba 100755 --- a/util/deploy-library.sh +++ b/util/deploy-library.sh @@ -22,7 +22,7 @@ deploy_library() { bazel build --define=pom_version="$version_name" \ $library $pomfile - # TODO(user): Consider moving this into the "gen_maven_artifact" macro, this + # TODO(bcorso): Consider moving this into the "gen_maven_artifact" macro, this # requires having the version checked-in for the build system. add_tracking_version \ $(bazel_output_file $library) \ |