aboutsummaryrefslogtreecommitdiff
path: root/javatests/dagger/functional/subcomponent/SubcomponentBuilderMultibindingsTest.java
blob: 7065acc208c06d7828df8f3154e9454d9bca5c70 (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
/*
 * Copyright (C) 2015 The Dagger Authors.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 *
 * http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */

package dagger.functional.subcomponent;

import static com.google.common.truth.Truth.assertThat;

import dagger.Component;
import dagger.Module;
import dagger.Provides;
import dagger.Subcomponent;
import dagger.multibindings.IntoSet;
import java.lang.annotation.Retention;
import java.lang.annotation.RetentionPolicy;
import java.util.Set;
import javax.inject.Inject;
import javax.inject.Qualifier;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.junit.runners.JUnit4;

/**
 * Regression tests for an issue where subcomponent builder bindings were incorrectly reused from
 * a parent even if the subcomponent were redeclared on the child component. This manifested via
 * multibindings, especially since subcomponent builder bindings are special in that we cannot
 * traverse them to see if they depend on local multibinding contributions.
 */
@RunWith(JUnit4.class)
public final class SubcomponentBuilderMultibindingsTest {

  @Retention(RetentionPolicy.RUNTIME)
  @Qualifier
  public @interface ParentFoo{}

  @Retention(RetentionPolicy.RUNTIME)
  @Qualifier
  public @interface ChildFoo{}

  public static final class Foo {
    final Set<String> multi;
    @Inject Foo(Set<String> multi) {
      this.multi = multi;
    }
  }

  // This tests the case where a subcomponent is installed in both the parent and child component.
  // In this case, we expect two subcomponents to be generated with the child one including the
  // child multibinding contribution.
  public static final class ChildInstallsFloating {
    @Component(modules = ParentModule.class)
    public interface Parent {
      @ParentFoo Foo getParentFoo();

      Child getChild();
    }

    @Subcomponent(modules = ChildModule.class)
    public interface Child {
      @ChildFoo Foo getChildFoo();
    }

    @Subcomponent
    public interface FloatingSub {
      Foo getFoo();

      @Subcomponent.Builder
      public interface Builder {
        FloatingSub build();
      }
    }

    @Module(subcomponents = FloatingSub.class)
    public interface ParentModule {
      @Provides
      @IntoSet
      static String provideStringMulti() {
         return "parent";
      }

      @Provides
      @ParentFoo
      static Foo provideParentFoo(FloatingSub.Builder builder) {
        return builder.build().getFoo();
      }
    }

    // The subcomponent installation of FloatingSub here is the key difference
    @Module(subcomponents = FloatingSub.class)
    public interface ChildModule {
      @Provides
      @IntoSet
      static String provideStringMulti() {
         return "child";
      }

      @Provides
      @ChildFoo
      static Foo provideChildFoo(FloatingSub.Builder builder) {
        return builder.build().getFoo();
      }
    }

    private ChildInstallsFloating() {}
  }

  // This is the same as the above, except this time the child does not install the subcomponent
  // builder. Here, we expect the child to reuse the parent subcomponent binding (we want to avoid
  // any mistakes that might implicitly create a new subcomponent relationship) and so therefore
  // we expect only one subcomponent to be generated in the parent resulting in the child not seeing
  // the child multibinding contribution.
  public static final class ChildDoesNotInstallFloating {
    @Component(modules = ParentModule.class)
    public interface Parent {
      @ParentFoo Foo getParentFoo();

      Child getChild();
    }

    @Subcomponent(modules = ChildModule.class)
    public interface Child {
      @ChildFoo Foo getChildFoo();
    }

    @Subcomponent
    public interface FloatingSub {
      Foo getFoo();

      @Subcomponent.Builder
      public interface Builder {
        FloatingSub build();
      }
    }

    @Module(subcomponents = FloatingSub.class)
    public interface ParentModule {
      @Provides
      @IntoSet
      static String provideStringMulti() {
         return "parent";
      }

      @Provides
      @ParentFoo
      static Foo provideParentFoo(FloatingSub.Builder builder) {
        return builder.build().getFoo();
      }
    }

    // The lack of a subcomponent installation of FloatingSub here is the key difference
    @Module
    public interface ChildModule {
      @Provides
      @IntoSet
      static String provideStringMulti() {
         return "child";
      }

      @Provides
      @ChildFoo
      static Foo provideChildFoo(FloatingSub.Builder builder) {
        return builder.build().getFoo();
      }
    }

    private ChildDoesNotInstallFloating() {}
  }

  // This is similar to the first, except this time the components installs the subcomponent via
  // factory methods. Here, we expect the child to get a new subcomponent and so should see its
  // multibinding contribution.
  public static final class ChildInstallsFloatingFactoryMethod {
    @Component(modules = ParentModule.class)
    public interface Parent {
      @ParentFoo Foo getParentFoo();

      Child getChild();

      FloatingSub getFloatingSub();
    }

    @Subcomponent(modules = ChildModule.class)
    public interface Child {
      @ChildFoo Foo getChildFoo();

      FloatingSub getFloatingSub();
    }

    @Subcomponent
    public interface FloatingSub {
      Foo getFoo();
    }

    @Module
    public interface ParentModule {
      @Provides
      @IntoSet
      static String provideStringMulti() {
         return "parent";
      }

      @Provides
      @ParentFoo
      static Foo provideParentFoo(Parent componentSelf) {
        return componentSelf.getFloatingSub().getFoo();
      }
    }

    @Module
    public interface ChildModule {
      @Provides
      @IntoSet
      static String provideStringMulti() {
         return "child";
      }

      @Provides
      @ChildFoo
      static Foo provideChildFoo(Child componentSelf) {
        return componentSelf.getFloatingSub().getFoo();
      }
    }

    private ChildInstallsFloatingFactoryMethod() {}
  }

  @Test
  public void testChildInstallsFloating() {
    ChildInstallsFloating.Parent parentComponent =
        DaggerSubcomponentBuilderMultibindingsTest_ChildInstallsFloating_Parent.create();
    assertThat(parentComponent.getParentFoo().multi).containsExactly("parent");
    assertThat(parentComponent.getChild().getChildFoo().multi).containsExactly("parent", "child");
  }

  @Test
  public void testChildDoesNotInstallFloating() {
    ChildDoesNotInstallFloating.Parent parentComponent =
        DaggerSubcomponentBuilderMultibindingsTest_ChildDoesNotInstallFloating_Parent.create();
    assertThat(parentComponent.getParentFoo().multi).containsExactly("parent");
    // Don't expect the child contribution because the child didn't redeclare the subcomponent
    // dependency, meaning it intends to just use the subcomponent relationship from the parent
    // component.
    assertThat(parentComponent.getChild().getChildFoo().multi).containsExactly("parent");
  }

  @Test
  public void testChildInstallsFloatingFactoryMethod() {
    ChildInstallsFloatingFactoryMethod.Parent parentComponent =
        DaggerSubcomponentBuilderMultibindingsTest_ChildInstallsFloatingFactoryMethod_Parent.create();
    assertThat(parentComponent.getParentFoo().multi).containsExactly("parent");
    assertThat(parentComponent.getChild().getChildFoo().multi).containsExactly("parent", "child");
  }
}