chromeos-dbus-bindings: Extract common code into functions

Moved common code used to parse D-Bus object/interface names
such as "org.chromium.TestInterface" into a class, NameParser.
This allows it to be used to extract the nested namespaces,
produce properly-formed variable names and so on.

Did the same with generating const references for non-integral
types.

BUG=chromium:431737
TEST=FEATURES=test emerge-link chromeos-dbus-bindings

Change-Id: I011639b9c7c355fd0e693b200840811a6e3c33ca
Reviewed-on: https://chromium-review.googlesource.com/232404
Reviewed-by: Vitaly Buka <vitalybuka@chromium.org>
Tested-by: Alex Vakulenko <avakulenko@chromium.org>
Reviewed-by: Christopher Wiley <wiley@chromium.org>
Commit-Queue: Alex Vakulenko <avakulenko@chromium.org>

1 files changed, 3 insertions, 10 deletions

diff --git a/chromeos-dbus-bindings/header_generator.h b/chromeos-dbus-bindings/header_generator.h
index 938e93b..55b1265 100644
--- a/chromeos-dbus-bindings/header_generator.h
+++ b/chromeos-dbus-bindings/header_generator.h
@@ -30,19 +30,12 @@ class HeaderGenerator {
   // Create a unique header guard string to protect multiple includes of header.
   static std::string GenerateHeaderGuard(const base::FilePath& output_file);
 
-  // Returns a vector of nesting namespaces.
-  static bool GetNamespacesAndClassName(const std::string& interface_name,
-                                        std::vector<std::string>* namespaces,
-                                        std::string* class_name);
-
-  // Returns a fully-qualified class name like "ns1::ns2::class_name".
-  static std::string GetFullClassName(
-      const std::vector<std::string>& namespaces,
-      const std::string& class_name);
-
   // Used to decide whether the argument should be a const reference.
   static bool IsIntegralType(const std::string& type);
 
+  // If |type| is a non-integral type, converts it into a const reference.
+  static void MakeConstReferenceIfNeeded(std::string* type);
+
   // Writes indented text to a file.
   static bool WriteTextToFile(const base::FilePath& output_file,
                               const IndentedText& text);