diff options
Diffstat (limited to 'src/amberscript')
-rw-r--r-- | src/amberscript/parser.cc | 123 | ||||
-rw-r--r-- | src/amberscript/parser.h | 1 | ||||
-rw-r--r-- | src/amberscript/parser_bind_test.cc | 257 | ||||
-rw-r--r-- | src/amberscript/parser_viewport_test.cc | 388 |
4 files changed, 768 insertions, 1 deletions
diff --git a/src/amberscript/parser.cc b/src/amberscript/parser.cc index 50760f0..809baa1 100644 --- a/src/amberscript/parser.cc +++ b/src/amberscript/parser.cc @@ -602,6 +602,8 @@ Result Parser::ParsePipelineBody(const std::string& cmd_name, r = ParsePipelineShaderOptimizations(pipeline.get()); } else if (tok == "FRAMEBUFFER_SIZE") { r = ParsePipelineFramebufferSize(pipeline.get()); + } else if (tok == "VIEWPORT") { + r = ParsePipelineViewport(pipeline.get()); } else if (tok == "BIND") { r = ParsePipelineBind(pipeline.get()); } else if (tok == "VERTEX_DATA") { @@ -949,6 +951,75 @@ Result Parser::ParsePipelineFramebufferSize(Pipeline* pipeline) { return ValidateEndOfStatement("FRAMEBUFFER_SIZE command"); } +Result Parser::ParsePipelineViewport(Pipeline* pipeline) { + Viewport vp; + vp.mind = 0.0f; + vp.maxd = 1.0f; + + float val[2]; + for (int i = 0; i < 2; i++) { + auto token = tokenizer_->NextToken(); + if (token->IsEOL() || token->IsEOS()) + return Result("missing offset for VIEWPORT command"); + Result r = token->ConvertToDouble(); + if (!r.IsSuccess()) + return Result("invalid offset for VIEWPORT command"); + + val[i] = token->AsFloat(); + } + vp.x = val[0]; + vp.y = val[1]; + + auto token = tokenizer_->NextToken(); + if (!token->IsIdentifier() || token->AsString() != "SIZE") + return Result("missing SIZE for VIEWPORT command"); + + for (int i = 0; i < 2; i++) { + token = tokenizer_->NextToken(); + if (token->IsEOL() || token->IsEOS()) + return Result("missing size for VIEWPORT command"); + Result r = token->ConvertToDouble(); + if (!r.IsSuccess()) + return Result("invalid size for VIEWPORT command"); + + val[i] = token->AsFloat(); + } + vp.w = val[0]; + vp.h = val[1]; + + token = tokenizer_->PeekNextToken(); + while (token->IsIdentifier()) { + if (token->AsString() == "MIN_DEPTH") { + tokenizer_->NextToken(); + token = tokenizer_->NextToken(); + if (token->IsEOL() || token->IsEOS()) + return Result("missing min_depth for VIEWPORT command"); + Result r = token->ConvertToDouble(); + if (!r.IsSuccess()) + return Result("invalid min_depth for VIEWPORT command"); + + vp.mind = token->AsFloat(); + } + if (token->AsString() == "MAX_DEPTH") { + tokenizer_->NextToken(); + token = tokenizer_->NextToken(); + if (token->IsEOL() || token->IsEOS()) + return Result("missing max_depth for VIEWPORT command"); + Result r = token->ConvertToDouble(); + if (!r.IsSuccess()) + return Result("invalid max_depth for VIEWPORT command"); + + vp.maxd = token->AsFloat(); + } + + token = tokenizer_->PeekNextToken(); + } + + pipeline->GetPipelineData()->SetViewport(vp); + + return ValidateEndOfStatement("VIEWPORT command"); +} + Result Parser::ToBufferType(const std::string& name, BufferType* type) { assert(type); if (name == "color") @@ -1172,10 +1243,60 @@ Result Parser::ParsePipelineBind(Pipeline* pipeline) { } } + // Set default descriptor buffer offsets to 0 and descriptor buffer + // ranges to VK_WHOLE_SIZE (~0ULL). + std::vector<uint64_t> descriptor_offsets(buffers.size(), 0); + std::vector<uint64_t> descriptor_ranges(buffers.size(), ~0ULL); + if (buffer_type == BufferType::kUniformDynamic || + buffer_type == BufferType::kStorageDynamic || + buffer_type == BufferType::kStorage || + buffer_type == BufferType::kUniform) { + token = tokenizer_->PeekNextToken(); + if (token->IsIdentifier() && + token->AsString() == "DESCRIPTOR_OFFSET") { + token = tokenizer_->NextToken(); + for (size_t i = 0; i < buffers.size(); i++) { + token = tokenizer_->NextToken(); + if (!token->IsInteger()) { + if (i > 0) { + return Result( + "expecting a DESCRIPTOR_OFFSET value for each buffer in " + "the array"); + } else { + return Result( + "expecting an integer value for DESCRIPTOR_OFFSET"); + } + } + descriptor_offsets[i] = token->AsUint64(); + } + } + + token = tokenizer_->PeekNextToken(); + if (token->IsIdentifier() && + token->AsString() == "DESCRIPTOR_RANGE") { + token = tokenizer_->NextToken(); + for (size_t i = 0; i < buffers.size(); i++) { + token = tokenizer_->NextToken(); + if (!token->IsInteger()) { + if (i > 0) { + return Result( + "expecting a DESCRIPTOR_RANGE value for each buffer in " + "the array"); + } else { + return Result( + "expecting an integer value for DESCRIPTOR_RANGE"); + } + } + descriptor_ranges[i] = token->AsUint64(); + } + } + } + pipeline->ClearBuffers(descriptor_set, binding); for (size_t i = 0; i < buffers.size(); i++) { pipeline->AddBuffer(buffers[i], buffer_type, descriptor_set, binding, - base_mip_level, dynamic_offsets[i]); + base_mip_level, dynamic_offsets[i], + descriptor_offsets[i], descriptor_ranges[i]); } } else if (token->IsIdentifier() && token->AsString() == "KERNEL") { token = tokenizer_->NextToken(); diff --git a/src/amberscript/parser.h b/src/amberscript/parser.h index e8cb835..6fb25ce 100644 --- a/src/amberscript/parser.h +++ b/src/amberscript/parser.h @@ -65,6 +65,7 @@ class Parser : public amber::Parser { Result ParsePipelineShaderCompileOptions(Pipeline*); Result ParsePipelineSubgroup(Pipeline* pipeline); Result ParsePipelineFramebufferSize(Pipeline*); + Result ParsePipelineViewport(Pipeline*); Result ParsePipelineBind(Pipeline*); Result ParsePipelineVertexData(Pipeline*); Result ParsePipelineIndexData(Pipeline*); diff --git a/src/amberscript/parser_bind_test.cc b/src/amberscript/parser_bind_test.cc index 64f3948..a39b69e 100644 --- a/src/amberscript/parser_bind_test.cc +++ b/src/amberscript/parser_bind_test.cc @@ -1393,11 +1393,53 @@ END EXPECT_EQ(BufferType::kUniform, bufs[0].type); EXPECT_EQ(1U, bufs[0].descriptor_set); EXPECT_EQ(2U, bufs[0].binding); + EXPECT_EQ(0U, bufs[0].descriptor_offset); + EXPECT_EQ(~0ULL, bufs[0].descriptor_range); EXPECT_EQ(static_cast<uint32_t>(0), bufs[0].location); EXPECT_EQ(FormatType::kR32G32B32A32_SFLOAT, bufs[0].buffer->GetFormat()->GetFormatType()); } +TEST_F(AmberScriptParserTest, BindBufferDescriptorOffsetAndRange) { + std::string in = R"( +SHADER vertex my_shader PASSTHROUGH +SHADER fragment my_fragment GLSL +# GLSL Shader +END +BUFFER my_buf FORMAT R32G32B32A32_SFLOAT + +PIPELINE graphics my_pipeline + ATTACH my_shader + ATTACH my_fragment + + BIND BUFFER my_buf AS uniform DESCRIPTOR_SET 1 BINDING 2 DESCRIPTOR_OFFSET 256 DESCRIPTOR_RANGE 512 + BIND BUFFER my_buf AS uniform DESCRIPTOR_SET 1 BINDING 3 DESCRIPTOR_OFFSET 256 DESCRIPTOR_RANGE -1 +END +)"; + + Parser parser; + Result r = parser.Parse(in); + ASSERT_TRUE(r.IsSuccess()) << r.Error(); + + auto script = parser.GetScript(); + const auto& pipelines = script->GetPipelines(); + ASSERT_EQ(1U, pipelines.size()); + + const auto* pipeline = pipelines[0].get(); + const auto& bufs = pipeline->GetBuffers(); + ASSERT_EQ(2U, bufs.size()); + EXPECT_EQ(BufferType::kUniform, bufs[0].type); + EXPECT_EQ(1U, bufs[0].descriptor_set); + EXPECT_EQ(2U, bufs[0].binding); + EXPECT_EQ(256U, bufs[0].descriptor_offset); + EXPECT_EQ(512U, bufs[0].descriptor_range); + EXPECT_EQ(static_cast<uint32_t>(0), bufs[0].location); + EXPECT_EQ(FormatType::kR32G32B32A32_SFLOAT, + bufs[0].buffer->GetFormat()->GetFormatType()); + // Verify the descriptor range from the second buffer. + EXPECT_EQ(~0ULL, bufs[1].descriptor_range); +} + TEST_F(AmberScriptParserTest, BindBufferMissingBindingValue) { std::string in = R"( SHADER vertex my_shader PASSTHROUGH @@ -2859,6 +2901,33 @@ END)"; EXPECT_EQ("13: missing BINDING for BIND command", r.Error()); } +TEST_F(AmberScriptParserTest, BindDescriptorOffsetWithUnsupportedBufferType) { + std::string unsupported_buffer_types[] = {"uniform_texel_buffer", + "storage_texel_buffer", + "sampled_image", "storage_image"}; + + for (const auto& buffer_type : unsupported_buffer_types) { + std::ostringstream in; + in << R"( +SHADER compute compute_shader GLSL +# GLSL Shader +END + +BUFFER texture FORMAT R8G8B8A8_UNORM + +PIPELINE compute pipeline + ATTACH compute_shader + BIND BUFFER texture AS )" + << buffer_type << R"( DESCRIPTOR_SET 0 BINDING 0 DESCRIPTOR_OFFSET 0 +END)"; + Parser parser; + Result r = parser.Parse(in.str()); + ASSERT_FALSE(r.IsSuccess()); + EXPECT_EQ("10: extra parameters after BIND command: DESCRIPTOR_OFFSET", + r.Error()); + } +} + TEST_F(AmberScriptParserTest, BindBufferArray) { std::string in = R"( SHADER vertex my_shader PASSTHROUGH @@ -2891,12 +2960,200 @@ END EXPECT_EQ(BufferType::kUniform, bufs[i].type); EXPECT_EQ(1U, bufs[i].descriptor_set); EXPECT_EQ(2U, bufs[i].binding); + EXPECT_EQ(0U, bufs[i].descriptor_offset); + EXPECT_EQ(~0ULL, bufs[i].descriptor_range); + EXPECT_EQ(static_cast<uint32_t>(0), bufs[i].location); + EXPECT_EQ(FormatType::kR32G32B32A32_SFLOAT, + bufs[i].buffer->GetFormat()->GetFormatType()); + } +} + +TEST_F(AmberScriptParserTest, BindBufferArrayWithDescriptorOffsetAndRange) { + std::string in = R"( +SHADER vertex my_shader PASSTHROUGH +SHADER fragment my_fragment GLSL +# GLSL Shader +END +BUFFER my_buf1 FORMAT R32G32B32A32_SFLOAT + +PIPELINE graphics my_pipeline + ATTACH my_shader + ATTACH my_fragment + + BIND BUFFER_ARRAY my_buf1 my_buf1 AS uniform DESCRIPTOR_SET 1 BINDING 2 DESCRIPTOR_OFFSET 256 512 DESCRIPTOR_RANGE 1024 2048 +END +)"; + + Parser parser; + Result r = parser.Parse(in); + ASSERT_TRUE(r.IsSuccess()) << r.Error(); + + auto script = parser.GetScript(); + const auto& pipelines = script->GetPipelines(); + ASSERT_EQ(1U, pipelines.size()); + + const auto* pipeline = pipelines[0].get(); + const auto& bufs = pipeline->GetBuffers(); + ASSERT_EQ(2U, bufs.size()); + for (size_t i = 0; i < 2; i++) { + EXPECT_EQ(BufferType::kUniform, bufs[i].type); + EXPECT_EQ(1U, bufs[i].descriptor_set); + EXPECT_EQ(2U, bufs[i].binding); + EXPECT_EQ(256U * (i + 1), bufs[i].descriptor_offset); + EXPECT_EQ(1024U * (i + 1), bufs[i].descriptor_range); EXPECT_EQ(static_cast<uint32_t>(0), bufs[i].location); EXPECT_EQ(FormatType::kR32G32B32A32_SFLOAT, bufs[i].buffer->GetFormat()->GetFormatType()); } } +TEST_F(AmberScriptParserTest, + BindDynamicBufferArrayWithDescriptorOffsetAndRange) { + std::string in = R"( +SHADER vertex my_shader PASSTHROUGH +SHADER fragment my_fragment GLSL +# GLSL Shader +END +BUFFER my_buf1 FORMAT R32G32B32A32_SFLOAT + +PIPELINE graphics my_pipeline + ATTACH my_shader + ATTACH my_fragment + + BIND BUFFER_ARRAY my_buf1 my_buf1 AS uniform_dynamic DESCRIPTOR_SET 1 BINDING 2 OFFSET 16 32 DESCRIPTOR_OFFSET 256 512 DESCRIPTOR_RANGE 1024 2048 +END +)"; + + Parser parser; + Result r = parser.Parse(in); + ASSERT_TRUE(r.IsSuccess()) << r.Error(); + + auto script = parser.GetScript(); + const auto& pipelines = script->GetPipelines(); + ASSERT_EQ(1U, pipelines.size()); + + const auto* pipeline = pipelines[0].get(); + const auto& bufs = pipeline->GetBuffers(); + ASSERT_EQ(2U, bufs.size()); + for (size_t i = 0; i < 2; i++) { + EXPECT_EQ(BufferType::kUniformDynamic, bufs[i].type); + EXPECT_EQ(1U, bufs[i].descriptor_set); + EXPECT_EQ(2U, bufs[i].binding); + EXPECT_EQ(16U * (i + 1), bufs[i].dynamic_offset); + EXPECT_EQ(256U * (i + 1), bufs[i].descriptor_offset); + EXPECT_EQ(1024U * (i + 1), bufs[i].descriptor_range); + EXPECT_EQ(static_cast<uint32_t>(0), bufs[i].location); + EXPECT_EQ(FormatType::kR32G32B32A32_SFLOAT, + bufs[i].buffer->GetFormat()->GetFormatType()); + } +} + +TEST_F(AmberScriptParserTest, BindBufferArrayOnlyOneDescriptorOffset) { + std::string in = R"( +SHADER vertex my_shader PASSTHROUGH +SHADER fragment my_fragment GLSL +# GLSL Shader +END +BUFFER my_buf FORMAT R32G32B32A32_SFLOAT + +PIPELINE graphics my_pipeline + ATTACH my_shader + ATTACH my_fragment + + BIND BUFFER_ARRAY my_buf my_buf AS uniform DESCRIPTOR_SET 1 BINDING 2 DESCRIPTOR_OFFSET 256 +END +)"; + + Parser parser; + Result r = parser.Parse(in); + + ASSERT_FALSE(r.IsSuccess()); + EXPECT_EQ( + "13: expecting a DESCRIPTOR_OFFSET value for each buffer in the array", + r.Error()); +} + +TEST_F(AmberScriptParserTest, BindBufferArrayOnlyOneDescriptorRange) { + std::string in = R"( +SHADER vertex my_shader PASSTHROUGH +SHADER fragment my_fragment GLSL +# GLSL Shader +END +BUFFER my_buf FORMAT R32G32B32A32_SFLOAT + +PIPELINE graphics my_pipeline + ATTACH my_shader + ATTACH my_fragment + + BIND BUFFER_ARRAY my_buf my_buf AS uniform DESCRIPTOR_SET 1 BINDING 2 DESCRIPTOR_RANGE 256 +END +)"; + + Parser parser; + Result r = parser.Parse(in); + + ASSERT_FALSE(r.IsSuccess()); + EXPECT_EQ( + "13: expecting a DESCRIPTOR_RANGE value for each buffer in the array", + r.Error()); +} + +TEST_F(AmberScriptParserTest, BindUniformBufferEmptyDescriptorOffset) { + std::string in = R"( +BUFFER my_buf FORMAT R32G32B32A32_SFLOAT +PIPELINE graphics my_pipeline + BIND BUFFER my_buf AS uniform DESCRIPTOR_SET 1 BINDING 2 DESCRIPTOR_OFFSET +END +)"; + + Parser parser; + Result r = parser.Parse(in); + ASSERT_FALSE(r.IsSuccess()); + EXPECT_EQ("5: expecting an integer value for DESCRIPTOR_OFFSET", r.Error()); +} + +TEST_F(AmberScriptParserTest, BindUniformBufferInvalidDescriptorOffset) { + std::string in = R"( +BUFFER my_buf FORMAT R32G32B32A32_SFLOAT +PIPELINE graphics my_pipeline + BIND BUFFER my_buf AS uniform DESCRIPTOR_SET 1 BINDING 2 DESCRIPTOR_OFFSET foo +END +)"; + + Parser parser; + Result r = parser.Parse(in); + ASSERT_FALSE(r.IsSuccess()); + EXPECT_EQ("4: expecting an integer value for DESCRIPTOR_OFFSET", r.Error()); +} + +TEST_F(AmberScriptParserTest, BindUniformBufferEmptyDescriptorRange) { + std::string in = R"( +BUFFER my_buf FORMAT R32G32B32A32_SFLOAT +PIPELINE graphics my_pipeline + BIND BUFFER my_buf AS uniform DESCRIPTOR_SET 1 BINDING 2 DESCRIPTOR_RANGE +END +)"; + + Parser parser; + Result r = parser.Parse(in); + ASSERT_FALSE(r.IsSuccess()); + EXPECT_EQ("5: expecting an integer value for DESCRIPTOR_RANGE", r.Error()); +} + +TEST_F(AmberScriptParserTest, BindUniformBufferInvalidDescriptorRange) { + std::string in = R"( +BUFFER my_buf FORMAT R32G32B32A32_SFLOAT +PIPELINE graphics my_pipeline + BIND BUFFER my_buf AS uniform DESCRIPTOR_SET 1 BINDING 2 DESCRIPTOR_RANGE foo +END +)"; + + Parser parser; + Result r = parser.Parse(in); + ASSERT_FALSE(r.IsSuccess()); + EXPECT_EQ("4: expecting an integer value for DESCRIPTOR_RANGE", r.Error()); +} + TEST_F(AmberScriptParserTest, BindBufferArrayOnlyOneBuffer) { std::string in = R"( SHADER vertex my_shader PASSTHROUGH diff --git a/src/amberscript/parser_viewport_test.cc b/src/amberscript/parser_viewport_test.cc new file mode 100644 index 0000000..ec19fb2 --- /dev/null +++ b/src/amberscript/parser_viewport_test.cc @@ -0,0 +1,388 @@ +// Copyright 2021 The Amber Authors. +// +// Licensed under the Apache License, Version 2.0 (the "License"); +// you may not use this file except in compliance with the License. +// You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, software +// distributed under the License is distributed on an "AS IS" BASIS, +// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or parseried. +// See the License for the specific language governing permissions and +// limitations under the License. + +#include "gtest/gtest.h" +#include "src/amberscript/parser.h" + +namespace amber { +namespace amberscript { + +using AmberScriptParserTest = testing::Test; + +TEST_F(AmberScriptParserTest, NoViewport) { + std::string in = R"( +SHADER vertex my_shader PASSTHROUGH +SHADER fragment my_fragment GLSL +# GLSL Shader +END +BUFFER my_fb FORMAT R32G32B32A32_SFLOAT +BUFFER my_ds FORMAT D32_SFLOAT_S8_UINT + +PIPELINE graphics my_pipeline + ATTACH my_shader + ATTACH my_fragment + BIND BUFFER my_fb AS color LOCATION 0 + BIND BUFFER my_ds AS depth_stencil +END)"; + + Parser parser; + Result r = parser.Parse(in); + ASSERT_TRUE(r.IsSuccess()) << r.Error(); + + auto script = parser.GetScript(); + const auto& pipelines = script->GetPipelines(); + ASSERT_EQ(1U, pipelines.size()); + + auto* pipeline = pipelines[0].get(); + ASSERT_FALSE(pipeline->GetPipelineData()->HasViewportData()); +} + +TEST_F(AmberScriptParserTest, ViewportNoDepth) { + std::string in = R"( +SHADER vertex my_shader PASSTHROUGH +SHADER fragment my_fragment GLSL +# GLSL Shader +END +BUFFER my_fb FORMAT R32G32B32A32_SFLOAT +BUFFER my_ds FORMAT D32_SFLOAT_S8_UINT + +PIPELINE graphics my_pipeline + ATTACH my_shader + ATTACH my_fragment + BIND BUFFER my_fb AS color LOCATION 0 + BIND BUFFER my_ds AS depth_stencil + + VIEWPORT 5.0 7.0 SIZE 10.0 12.0 +END)"; + + Parser parser; + Result r = parser.Parse(in); + ASSERT_TRUE(r.IsSuccess()) << r.Error(); + + auto script = parser.GetScript(); + const auto& pipelines = script->GetPipelines(); + ASSERT_EQ(1U, pipelines.size()); + + auto* pipeline = pipelines[0].get(); + ASSERT_TRUE(pipeline->GetPipelineData()->HasViewportData()); + ASSERT_FLOAT_EQ(5.0f, pipeline->GetPipelineData()->GetViewport().x); + ASSERT_FLOAT_EQ(7.0f, pipeline->GetPipelineData()->GetViewport().y); + ASSERT_FLOAT_EQ(10.0f, pipeline->GetPipelineData()->GetViewport().w); + ASSERT_FLOAT_EQ(12.0f, pipeline->GetPipelineData()->GetViewport().h); + ASSERT_FLOAT_EQ(0.0f, pipeline->GetPipelineData()->GetViewport().mind); + ASSERT_FLOAT_EQ(1.0f, pipeline->GetPipelineData()->GetViewport().maxd); +} + +TEST_F(AmberScriptParserTest, ViewportMinDepth) { + std::string in = R"( +SHADER vertex my_shader PASSTHROUGH +SHADER fragment my_fragment GLSL +# GLSL Shader +END +BUFFER my_fb FORMAT R32G32B32A32_SFLOAT +BUFFER my_ds FORMAT D32_SFLOAT_S8_UINT + +PIPELINE graphics my_pipeline + ATTACH my_shader + ATTACH my_fragment + BIND BUFFER my_fb AS color LOCATION 0 + BIND BUFFER my_ds AS depth_stencil + + VIEWPORT 12.2 9.7 SIZE 0.5 106.1 MIN_DEPTH 0.3 +END)"; + + Parser parser; + Result r = parser.Parse(in); + ASSERT_TRUE(r.IsSuccess()) << r.Error(); + + auto script = parser.GetScript(); + const auto& pipelines = script->GetPipelines(); + ASSERT_EQ(1U, pipelines.size()); + + auto* pipeline = pipelines[0].get(); + ASSERT_TRUE(pipeline->GetPipelineData()->HasViewportData()); + ASSERT_FLOAT_EQ(12.2f, pipeline->GetPipelineData()->GetViewport().x); + ASSERT_FLOAT_EQ(9.7f, pipeline->GetPipelineData()->GetViewport().y); + ASSERT_FLOAT_EQ(0.5f, pipeline->GetPipelineData()->GetViewport().w); + ASSERT_FLOAT_EQ(106.1f, pipeline->GetPipelineData()->GetViewport().h); + ASSERT_FLOAT_EQ(0.3f, pipeline->GetPipelineData()->GetViewport().mind); + ASSERT_FLOAT_EQ(1.0f, pipeline->GetPipelineData()->GetViewport().maxd); +} + +TEST_F(AmberScriptParserTest, ViewportMaxDepth) { + std::string in = R"( +SHADER vertex my_shader PASSTHROUGH +SHADER fragment my_fragment GLSL +# GLSL Shader +END +BUFFER my_fb FORMAT R32G32B32A32_SFLOAT +BUFFER my_ds FORMAT D32_SFLOAT_S8_UINT + +PIPELINE graphics my_pipeline + ATTACH my_shader + ATTACH my_fragment + BIND BUFFER my_fb AS color LOCATION 0 + BIND BUFFER my_ds AS depth_stencil + + VIEWPORT 12.2 9.7 SIZE 0.5 106.1 MAX_DEPTH 0.456 +END)"; + + Parser parser; + Result r = parser.Parse(in); + ASSERT_TRUE(r.IsSuccess()) << r.Error(); + + auto script = parser.GetScript(); + const auto& pipelines = script->GetPipelines(); + ASSERT_EQ(1U, pipelines.size()); + + auto* pipeline = pipelines[0].get(); + ASSERT_TRUE(pipeline->GetPipelineData()->HasViewportData()); + ASSERT_FLOAT_EQ(12.2f, pipeline->GetPipelineData()->GetViewport().x); + ASSERT_FLOAT_EQ(9.7f, pipeline->GetPipelineData()->GetViewport().y); + ASSERT_FLOAT_EQ(0.5f, pipeline->GetPipelineData()->GetViewport().w); + ASSERT_FLOAT_EQ(106.1f, pipeline->GetPipelineData()->GetViewport().h); + ASSERT_FLOAT_EQ(0.0f, pipeline->GetPipelineData()->GetViewport().mind); + ASSERT_FLOAT_EQ(0.456f, pipeline->GetPipelineData()->GetViewport().maxd); +} + +TEST_F(AmberScriptParserTest, ViewportAllValues) { + std::string in = R"( +SHADER vertex my_shader PASSTHROUGH +SHADER fragment my_fragment GLSL +# GLSL Shader +END +BUFFER my_fb FORMAT R32G32B32A32_SFLOAT +BUFFER my_ds FORMAT D32_SFLOAT_S8_UINT + +PIPELINE graphics my_pipeline + ATTACH my_shader + ATTACH my_fragment + BIND BUFFER my_fb AS color LOCATION 0 + BIND BUFFER my_ds AS depth_stencil + + VIEWPORT -0.6 5.2 SIZE 13.8 9.4 MIN_DEPTH 0.5 MAX_DEPTH 0.6 +END)"; + + Parser parser; + Result r = parser.Parse(in); + ASSERT_TRUE(r.IsSuccess()) << r.Error(); + + auto script = parser.GetScript(); + const auto& pipelines = script->GetPipelines(); + ASSERT_EQ(1U, pipelines.size()); + + auto* pipeline = pipelines[0].get(); + ASSERT_TRUE(pipeline->GetPipelineData()->HasViewportData()); + ASSERT_FLOAT_EQ(-0.6f, pipeline->GetPipelineData()->GetViewport().x); + ASSERT_FLOAT_EQ(5.2f, pipeline->GetPipelineData()->GetViewport().y); + ASSERT_FLOAT_EQ(13.8f, pipeline->GetPipelineData()->GetViewport().w); + ASSERT_FLOAT_EQ(9.4f, pipeline->GetPipelineData()->GetViewport().h); + ASSERT_FLOAT_EQ(0.5f, pipeline->GetPipelineData()->GetViewport().mind); + ASSERT_FLOAT_EQ(0.6f, pipeline->GetPipelineData()->GetViewport().maxd); +} + +TEST_F(AmberScriptParserTest, ViewportIntegers) { + std::string in = R"( +SHADER vertex my_shader PASSTHROUGH +SHADER fragment my_fragment GLSL +# GLSL Shader +END +BUFFER my_fb FORMAT R32G32B32A32_SFLOAT +BUFFER my_ds FORMAT D32_SFLOAT_S8_UINT + +PIPELINE graphics my_pipeline + ATTACH my_shader + ATTACH my_fragment + BIND BUFFER my_fb AS color LOCATION 0 + BIND BUFFER my_ds AS depth_stencil + + VIEWPORT -2 7 SIZE 15 20 MIN_DEPTH 1 MAX_DEPTH 2 +END)"; + + Parser parser; + Result r = parser.Parse(in); + ASSERT_TRUE(r.IsSuccess()) << r.Error(); + + auto script = parser.GetScript(); + const auto& pipelines = script->GetPipelines(); + ASSERT_EQ(1U, pipelines.size()); + + auto* pipeline = pipelines[0].get(); + ASSERT_TRUE(pipeline->GetPipelineData()->HasViewportData()); + ASSERT_FLOAT_EQ(-2.0f, pipeline->GetPipelineData()->GetViewport().x); + ASSERT_FLOAT_EQ(7.0f, pipeline->GetPipelineData()->GetViewport().y); + ASSERT_FLOAT_EQ(15.0f, pipeline->GetPipelineData()->GetViewport().w); + ASSERT_FLOAT_EQ(20.0f, pipeline->GetPipelineData()->GetViewport().h); + ASSERT_FLOAT_EQ(1.0f, pipeline->GetPipelineData()->GetViewport().mind); + ASSERT_FLOAT_EQ(2.0f, pipeline->GetPipelineData()->GetViewport().maxd); +} + +TEST_F(AmberScriptParserTest, ViewportMixedIntegers) { + std::string in = R"( +SHADER vertex my_shader PASSTHROUGH +SHADER fragment my_fragment GLSL +# GLSL Shader +END +BUFFER my_fb FORMAT R32G32B32A32_SFLOAT +BUFFER my_ds FORMAT D32_SFLOAT_S8_UINT + +PIPELINE graphics my_pipeline + ATTACH my_shader + ATTACH my_fragment + BIND BUFFER my_fb AS color LOCATION 0 + BIND BUFFER my_ds AS depth_stencil + + VIEWPORT -2 13.1 SIZE 15.9 20 +END)"; + + Parser parser; + Result r = parser.Parse(in); + ASSERT_TRUE(r.IsSuccess()) << r.Error(); + + auto script = parser.GetScript(); + const auto& pipelines = script->GetPipelines(); + ASSERT_EQ(1U, pipelines.size()); + + auto* pipeline = pipelines[0].get(); + ASSERT_TRUE(pipeline->GetPipelineData()->HasViewportData()); + ASSERT_FLOAT_EQ(-2.0f, pipeline->GetPipelineData()->GetViewport().x); + ASSERT_FLOAT_EQ(13.1f, pipeline->GetPipelineData()->GetViewport().y); + ASSERT_FLOAT_EQ(15.9f, pipeline->GetPipelineData()->GetViewport().w); + ASSERT_FLOAT_EQ(20.0f, pipeline->GetPipelineData()->GetViewport().h); + ASSERT_FLOAT_EQ(0.0f, pipeline->GetPipelineData()->GetViewport().mind); + ASSERT_FLOAT_EQ(1.0f, pipeline->GetPipelineData()->GetViewport().maxd); +} + +TEST_F(AmberScriptParserTest, ViewportInvalidMissingSize) { + std::string in = R"( +SHADER vertex my_shader PASSTHROUGH +SHADER fragment my_fragment GLSL +# GLSL Shader +END +BUFFER my_fb FORMAT R32G32B32A32_SFLOAT +BUFFER my_ds FORMAT D32_SFLOAT_S8_UINT + +PIPELINE graphics my_pipeline + ATTACH my_shader + ATTACH my_fragment + BIND BUFFER my_fb AS color LOCATION 0 + BIND BUFFER my_ds AS depth_stencil + + VIEWPORT 0.0 2.0 12.0 24.0 +END)"; + + Parser parser; + Result r = parser.Parse(in); + ASSERT_FALSE(r.IsSuccess()) << r.Error(); + EXPECT_EQ("15: missing SIZE for VIEWPORT command", r.Error()); +} + +TEST_F(AmberScriptParserTest, ViewportInvalidSizeNotOptional) { + std::string in = R"( +SHADER vertex my_shader PASSTHROUGH +SHADER fragment my_fragment GLSL +# GLSL Shader +END +BUFFER my_fb FORMAT R32G32B32A32_SFLOAT +BUFFER my_ds FORMAT D32_SFLOAT_S8_UINT + +PIPELINE graphics my_pipeline + ATTACH my_shader + ATTACH my_fragment + BIND BUFFER my_fb AS color LOCATION 0 + BIND BUFFER my_ds AS depth_stencil + + VIEWPORT 0.0 2.0 +END)"; + + Parser parser; + Result r = parser.Parse(in); + ASSERT_FALSE(r.IsSuccess()) << r.Error(); + EXPECT_EQ("16: missing SIZE for VIEWPORT command", r.Error()); +} + +TEST_F(AmberScriptParserTest, ViewportInvalidMissingOffset) { + std::string in = R"( +SHADER vertex my_shader PASSTHROUGH +SHADER fragment my_fragment GLSL +# GLSL Shader +END +BUFFER my_fb FORMAT R32G32B32A32_SFLOAT +BUFFER my_ds FORMAT D32_SFLOAT_S8_UINT + +PIPELINE graphics my_pipeline + ATTACH my_shader + ATTACH my_fragment + BIND BUFFER my_fb AS color LOCATION 0 + BIND BUFFER my_ds AS depth_stencil + + VIEWPORT 0.0 SIZE 12.0 24.0 +END)"; + + Parser parser; + Result r = parser.Parse(in); + ASSERT_FALSE(r.IsSuccess()) << r.Error(); + EXPECT_EQ("15: invalid offset for VIEWPORT command", r.Error()); +} + +TEST_F(AmberScriptParserTest, ViewportInvalidMissingSizeValue) { + std::string in = R"( +SHADER vertex my_shader PASSTHROUGH +SHADER fragment my_fragment GLSL +# GLSL Shader +END +BUFFER my_fb FORMAT R32G32B32A32_SFLOAT +BUFFER my_ds FORMAT D32_SFLOAT_S8_UINT + +PIPELINE graphics my_pipeline + ATTACH my_shader + ATTACH my_fragment + BIND BUFFER my_fb AS color LOCATION 0 + BIND BUFFER my_ds AS depth_stencil + + VIEWPORT 0.0 2.0 SIZE 12.0 +END)"; + + Parser parser; + Result r = parser.Parse(in); + ASSERT_FALSE(r.IsSuccess()) << r.Error(); + EXPECT_EQ("16: missing size for VIEWPORT command", r.Error()); +} + +TEST_F(AmberScriptParserTest, ViewportInvalidMissingDepthValue) { + std::string in = R"( +SHADER vertex my_shader PASSTHROUGH +SHADER fragment my_fragment GLSL +# GLSL Shader +END +BUFFER my_fb FORMAT R32G32B32A32_SFLOAT +BUFFER my_ds FORMAT D32_SFLOAT_S8_UINT + +PIPELINE graphics my_pipeline + ATTACH my_shader + ATTACH my_fragment + BIND BUFFER my_fb AS color LOCATION 0 + BIND BUFFER my_ds AS depth_stencil + + VIEWPORT 0.0 2.0 SIZE 12.0 24.0 MIN_DEPTH MAX_DEPTH 1.0 +END)"; + + Parser parser; + Result r = parser.Parse(in); + ASSERT_FALSE(r.IsSuccess()) << r.Error(); + EXPECT_EQ("15: invalid min_depth for VIEWPORT command", r.Error()); +} + +} // namespace amberscript +} // namespace amber |