From a80dbbd3b1233b274ee2e5bdec8f30e1e8ea73f7 Mon Sep 17 00:00:00 2001 From: dan sinclair Date: Tue, 2 Apr 2019 09:02:11 -0400 Subject: [vulkan] Use LOAD_OP_LOAD for the default attachment description (#438) This CL changes the default attachment description from LOAD_OP_DONT_CARE to LOAD_OP_LOAD. We want image data in the framebuffer to persist over render calls. Fixes #436 --- src/vulkan/graphics_pipeline.cc | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) (limited to 'src') diff --git a/src/vulkan/graphics_pipeline.cc b/src/vulkan/graphics_pipeline.cc index b3176bb..ab1c046 100644 --- a/src/vulkan/graphics_pipeline.cc +++ b/src/vulkan/graphics_pipeline.cc @@ -27,11 +27,10 @@ namespace vulkan { namespace { const VkAttachmentDescription kDefaultAttachmentDesc = { - 0, /* flags */ - VK_FORMAT_UNDEFINED, /* format */ - VK_SAMPLE_COUNT_1_BIT, /* samples */ - // TODO(jaebaek): Set up proper loadOp, StoreOp. - VK_ATTACHMENT_LOAD_OP_DONT_CARE, /* loadOp */ + 0, /* flags */ + VK_FORMAT_UNDEFINED, /* format */ + VK_SAMPLE_COUNT_1_BIT, /* samples */ + VK_ATTACHMENT_LOAD_OP_LOAD, /* loadOp */ VK_ATTACHMENT_STORE_OP_STORE, /* storeOp */ VK_ATTACHMENT_LOAD_OP_LOAD, /* stencilLoadOp */ VK_ATTACHMENT_STORE_OP_STORE, /* stencilStoreOp */ -- cgit v1.2.3