diff options
| author | John Stultz <john.stultz@linaro.org> | 2021-08-24 04:59:25 +0000 |
|---|---|---|
| committer | John Stultz <john.stultz@linaro.org> | 2021-08-24 05:02:12 +0000 |
| commit | 66763d51428e5ca834e9cc29ad86299ac06381dd (patch) | |
| tree | 055f946087c005dd226247491f9f1fff539659e8 | |
| parent | 8adf544306db75a3fb0843b9977693d2a817bf5d (diff) | |
| download | drm_hwcomposer-66763d51428e5ca834e9cc29ad86299ac06381dd.tar.gz | |
drm_hwcomposer: Quiet noisy errors when planes don't support various attributes
If a plane doesn't support alpha or rotation, and IsValidForLayer()
fails, we see lots of logcat noise to the effect of:
08-24 04:45:42.957 453 453 E hwc-platform: Failed to emplace layer 0, dropping it
08-24 04:45:42.957 453 453 E hwc-platform: Failed provision stage with ret -22
08-24 04:45:42.957 453 453 E hwc-drm-display-composition: Planner failed provisioning planes ret=-22
08-24 04:45:42.957 453 453 E hwc-drm-two: Failed to plan the composition ret=-22
This noise is unneccessarily worrisome, as they don't really
help explain why things fail, and we still fall back to client
composing and frames are correctly composited.
Thus, this patch switches the errors to verbose-level warnings,
which match the level in IsValidForLayer() which explain what
actually is going wrong.
Change-Id: I7ed06906b8d9e02e6ec0ac50a94346e9f9c05ac6
Signed-off-by: John Stultz <john.stultz@linaro.org>
| -rw-r--r-- | DrmHwcTwo.cpp | 2 | ||||
| -rw-r--r-- | compositor/DrmDisplayComposition.cpp | 2 | ||||
| -rw-r--r-- | compositor/Planner.cpp | 4 |
3 files changed, 4 insertions, 4 deletions
diff --git a/DrmHwcTwo.cpp b/DrmHwcTwo.cpp index d141f16..02667cf 100644 --- a/DrmHwcTwo.cpp +++ b/DrmHwcTwo.cpp @@ -675,7 +675,7 @@ HWC2::Error DrmHwcTwo::HwcDisplay::CreateComposition(bool test) { std::vector<DrmPlane *> overlay_planes(overlay_planes_); ret = composition->Plan(&primary_planes, &overlay_planes); if (ret) { - ALOGE("Failed to plan the composition ret=%d", ret); + ALOGV("Failed to plan the composition ret=%d", ret); return HWC2::Error::BadConfig; } diff --git a/compositor/DrmDisplayComposition.cpp b/compositor/DrmDisplayComposition.cpp index 13760ef..49dff0e 100644 --- a/compositor/DrmDisplayComposition.cpp +++ b/compositor/DrmDisplayComposition.cpp @@ -101,7 +101,7 @@ int DrmDisplayComposition::Plan(std::vector<DrmPlane *> *primary_planes, primary_planes, overlay_planes); if (ret) { - ALOGE("Planner failed provisioning planes ret=%d", ret); + ALOGV("Planner failed provisioning planes ret=%d", ret); return ret; } diff --git a/compositor/Planner.cpp b/compositor/Planner.cpp index 42259d1..9db03c3 100644 --- a/compositor/Planner.cpp +++ b/compositor/Planner.cpp @@ -60,7 +60,7 @@ std::tuple<int, std::vector<DrmCompositionPlane>> Planner::ProvisionPlanes( for (auto &i : stages_) { int ret = i->ProvisionPlanes(&composition, layers, &planes); if (ret) { - ALOGE("Failed provision stage with ret %d", ret); + ALOGV("Failed provision stage with ret %d", ret); return std::make_tuple(ret, std::vector<DrmCompositionPlane>()); } } @@ -105,7 +105,7 @@ int PlanStageGreedy::ProvisionPlanes( break; if (ret) { - ALOGE("Failed to emplace layer %zu, dropping it", i->first); + ALOGV("Failed to emplace layer %zu, dropping it", i->first); return ret; } } |