From d518a0594a3535a450128102163529e1f319fb37 Mon Sep 17 00:00:00 2001 From: Roman Stratiienko Date: Thu, 25 Feb 2021 19:15:14 +0200 Subject: drm_hwcomposer: CI: Initial build and clang-tidy checks Build android-agnostic code in linux environment. Enable static code analysis using clang-tidy. Signed-off-by: Roman Stratiienko --- drm/DrmCrtc.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'drm/DrmCrtc.cpp') diff --git a/drm/DrmCrtc.cpp b/drm/DrmCrtc.cpp index 4ce8cfc..3c05ba8 100644 --- a/drm/DrmCrtc.cpp +++ b/drm/DrmCrtc.cpp @@ -18,8 +18,8 @@ #include "DrmCrtc.h" -#include #include +#include #include #include "DrmDevice.h" -- cgit v1.2.3 From e2f2c929243fa52fc1683bc8b22f550446d9535b Mon Sep 17 00:00:00 2001 From: Roman Stratiienko Date: Sat, 13 Feb 2021 10:57:47 +0200 Subject: drm_hwcomposer: enable code analysis using clang-tidy Drm hwcomposer project has some code-style inconsistencies. This is the initial step to unify code-style of the code. Clang-tidy is a great tool which can not only suggest correct styling, but also allow predicting the errors in the code and suggest correct coding approaches to avoid potential weaknesses. CI was tuned to check clang-tidy recommendation for some part of the code which is ready ATM (can be built outside AOSP tree). For this part a limited set of clang-tidy checks has applied (coarse check). Header files aren't checked at all. Starting from now new code files must be included into the list that is checked by almost all clang-tidy checks (fine checklist). New header files should be also included into this list. See '.gitlab-ci-clang-tidy-fine.sh'. Signed-off-by: Roman Stratiienko --- drm/DrmCrtc.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'drm/DrmCrtc.cpp') diff --git a/drm/DrmCrtc.cpp b/drm/DrmCrtc.cpp index 3c05ba8..4da08fe 100644 --- a/drm/DrmCrtc.cpp +++ b/drm/DrmCrtc.cpp @@ -18,10 +18,11 @@ #include "DrmCrtc.h" -#include #include #include +#include + #include "DrmDevice.h" namespace android { -- cgit v1.2.3