diff options
author | Pierre-Clément Tosi <ptosi@google.com> | 2023-10-12 10:18:30 +0000 |
---|---|---|
committer | Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com> | 2023-10-12 10:18:30 +0000 |
commit | 98f5673dc61f8b80def876aee73b054fef03dd85 (patch) | |
tree | 8a40c4f9b84fa7cd74ca92be31880cb7da83edb2 | |
parent | 885653f48b9b5d0e4fe79cda429e9d1db70f40fa (diff) | |
parent | 350d496637f065eaf085c95d31e225840e58f26f (diff) | |
download | dtc-98f5673dc61f8b80def876aee73b054fef03dd85.tar.gz |
ANDROID: Use -Wall and more when building libfdt am: 170bf1d4ce am: 350d496637
Original change: https://android-review.googlesource.com/c/platform/external/dtc/+/2784258
Change-Id: I2d07fa447fcd0ff3c77eaae93fb4bd53705279b3
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
-rw-r--r-- | Android.bp | 11 | ||||
-rw-r--r-- | BUILD.bazel | 24 | ||||
-rw-r--r-- | libfdt/Android.bp | 7 |
3 files changed, 20 insertions, 22 deletions
@@ -44,14 +44,21 @@ license { } cc_defaults { - name: "dt_defaults", + name: "dtc_cflags_defaults", cflags: [ "-Wall", "-Werror", "-Wno-macro-redefined", - "-Wno-sign-compare", "-Wno-missing-field-initializers", + "-Wno-sign-compare", "-Wno-unused-parameter", + ], +} + +cc_defaults { + name: "dt_defaults", + defaults: ["dtc_cflags_defaults"], + cflags: [ "-DNO_YAML" ], diff --git a/BUILD.bazel b/BUILD.bazel index 5ef46e7..d9fdb9a 100644 --- a/BUILD.bazel +++ b/BUILD.bazel @@ -1,26 +1,22 @@ +COPTS = [ + "-Wall", + "-Werror", + "-Wno-macro-redefined", + "-Wno-missing-field-initializers", + "-Wno-sign-compare", + "-Wno-unused-parameter", +] + cc_library( name = "libfdt", srcs = glob([ "libfdt/*.h", "libfdt/*.c", ]), - copts = [ - "-Werror", - "-Wno-macro-redefined", - "-Wno-sign-compare", - ], + copts = COPTS, includes = ["libfdt"], ) -COPTS = [ - "-Wall", - "-Werror", - "-Wno-macro-redefined", - "-Wno-sign-compare", - "-Wno-missing-field-initializers", - "-Wno-unused-parameter", -] - genrule( name = "lexer", srcs = [ diff --git a/libfdt/Android.bp b/libfdt/Android.bp index 8f4bdfd..0bf631a 100644 --- a/libfdt/Android.bp +++ b/libfdt/Android.bp @@ -7,12 +7,7 @@ package { cc_library { name: "libfdt", host_supported: true, - - cflags: [ - "-Werror", - "-Wno-macro-redefined", - "-Wno-sign-compare", - ], + defaults: ["dtc_cflags_defaults"], srcs: [ "fdt.c", "fdt_check.c", |