aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorTreehugger Robot <treehugger-gerrit@google.com>2022-01-31 19:06:19 +0000
committerAutomerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>2022-01-31 19:06:19 +0000
commitf2fd5fd30571408a05656e8953c34718a2adbe14 (patch)
tree2f320d2aec343d16266c192d520f957e05cf3b5a
parent932e0584e29a31b50830144d0bbc189d56955797 (diff)
parentc7d887b3c9be8aa305db57786dde885d89c6f18d (diff)
downloadelfutils-f2fd5fd30571408a05656e8953c34718a2adbe14.tar.gz
Merge "dwfl: fix potential overflow when reporting on kernel modules" am: 325ecbcd3c am: c7d887b3c9
Original change: https://android-review.googlesource.com/c/platform/external/elfutils/+/1960724 Change-Id: Id167834cf0035246956711bff845b78a496c8653
-rw-r--r--libdwfl/ChangeLog5
-rw-r--r--libdwfl/linux-kernel-modules.c2
2 files changed, 6 insertions, 1 deletions
diff --git a/libdwfl/ChangeLog b/libdwfl/ChangeLog
index f7e24a21..57b2c494 100644
--- a/libdwfl/ChangeLog
+++ b/libdwfl/ChangeLog
@@ -1,3 +1,8 @@
+2021-11-18 Matthias Maennich <maennich@google.com>
+
+ * linux-kernel-modules.c (dwfl_linux_kernel_report_modules):
+ Add one to modname array size.
+
2021-02-14 Alexander Miller <alex.miller@gmx.de>
* core-file.c (dwfl_core_file_report): Move NEW_VERSION before
diff --git a/libdwfl/linux-kernel-modules.c b/libdwfl/linux-kernel-modules.c
index c0f8dfa4..58c0c417 100644
--- a/libdwfl/linux-kernel-modules.c
+++ b/libdwfl/linux-kernel-modules.c
@@ -1008,7 +1008,7 @@ dwfl_linux_kernel_report_modules (Dwfl *dwfl)
int result = 0;
Dwarf_Addr modaddr;
unsigned long int modsz;
- char modname[128];
+ char modname[128+1];
char *line = NULL;
size_t linesz = 0;
/* We can't just use fscanf here because it's not easy to distinguish \n