Errorprone: Update to 2.3.2

Move to Errorprone 2.3.2 (with javac 9+181-r4173-1 and checker
framework 2.5.3).

Bug: 114129741
Test: m javac-check RUN_ERROR_PRONE=true
Change-Id: I7fb34881a623ffb115a92bfffb108b503d4645ad

1 files changed, 61 insertions, 9 deletions

diff --git a/soong/error_prone.go b/soong/error_prone.go
index 1926c5e..8f4e426 100644
--- a/soong/error_prone.go
+++ b/soong/error_prone.go
@@ -22,11 +22,11 @@ func init() {
 	// These values are set into build/soong/java/config/config.go so that soong doesn't have any
 	// references to external/error_prone, which may not always exist.
 	config.ErrorProneClasspath = []string{
-		"external/error_prone/error_prone/error_prone_core-2.3.1-with-dependencies.jar",
-		"external/error_prone/error_prone/error_prone_annotations-2.3.1.jar",
-		"external/error_prone/error_prone/error_prone_type_annotations-2.3.1.jar",
-		"external/error_prone/checkerframework/dataflow-2.5.0.jar",
-		"external/error_prone/checkerframework/javacutil-2.5.0.jar",
+		"external/error_prone/error_prone/error_prone_core-2.3.2-with-dependencies.jar",
+		"external/error_prone/error_prone/error_prone_annotations-2.3.2.jar",
+		"external/error_prone/error_prone/error_prone_type_annotations-2.3.2.jar",
+		"external/error_prone/checkerframework/dataflow-2.5.3.jar",
+		"external/error_prone/checkerframework/javacutil-2.5.3.jar",
 		"external/error_prone/jFormatString/jFormatString-3.0.0.jar",
 	}
 
@@ -45,7 +45,6 @@ func init() {
 		"-Xep:ComparisonOutOfRange:ERROR",
 		"-Xep:CompatibleWithAnnotationMisuse:ERROR",
 		"-Xep:CompileTimeConstant:ERROR",
-		"-Xep:ComplexBooleanConstant:ERROR",
 		"-Xep:ConstantOverflow:ERROR",
 		"-Xep:DaggerProvidesNull:ERROR",
 		"-Xep:DeadException:ERROR",
@@ -119,24 +118,31 @@ func init() {
 		"-Xep:ArraysAsListPrimitiveArray:WARN",
 		"-Xep:BadShiftAmount:WARN",
 		"-Xep:ComparableType:WARN",
+		"-Xep:ComparingThisWithNull:WARN",
+		"-Xep:ComplexBooleanConstant:WARN",
 		"-Xep:ConditionalExpressionNumericPromotion:WARN",
 		"-Xep:EqualsReference:WARN",
+		"-Xep:EqualsWrongThing:WARN",
 		"-Xep:FormatString:WARN",
 		"-Xep:GetClassOnAnnotation:WARN",
 		"-Xep:GetClassOnClass:WARN",
 		"-Xep:GuardedBy:WARN",
 		"-Xep:HashtableContains:WARN",
 		"-Xep:IdentityBinaryExpression:WARN",
+		"-Xep:InjectOnMemberAndConstructor:WARN",
 		"-Xep:InvalidTimeZoneID:WARN",
 		"-Xep:IsLoggableTagLength:WARN",
+		"-Xep:MathRoundIntLong:WARN",
 		"-Xep:MislabeledAndroidString:WARN",
 		"-Xep:MissingSuperCall:WARN",
+		"-Xep:MissingTestCall:WARN",
 		"-Xep:MisusedWeekYear:WARN",
 		"-Xep:ModifyingCollectionWithItself:WARN",
 		"-Xep:NonRuntimeAnnotation:WARN",
 		"-Xep:NullTernary:WARN",
 		"-Xep:OverridesJavaxInjectableMethod:WARN",
 		"-Xep:ParcelableCreator:WARN",
+		"-Xep:ProtoStringFieldReferenceEquality:WARN",
 		"-Xep:ProtocolBufferOrdinal:WARN",
 		"-Xep:RandomModInteger:WARN",
 		"-Xep:RectIntersectReturnValueIgnored:WARN",
@@ -145,17 +151,24 @@ func init() {
 		"-Xep:SelfEquals:WARN",
 		"-Xep:SizeGreaterThanOrEqualsZero:WARN",
 		"-Xep:StringBuilderInitWithChar:WARN",
+		"-Xep:SubstringOfZero:WARN",
 		"-Xep:TryFailThrowable:WARN",
 		"-Xep:UnusedCollectionModifiedInPlace:WARN",
 
 		// Errorprone default severity WARNING
 		// "-Xep:AmbiguousMethodReference:WARN",
 		// "-Xep:ArgumentSelectionDefectChecker:WARN",
+		// "-Xep:ArrayAsKeyOfSetOrMap:WARN",
 		// "-Xep:AssertEqualsArgumentOrderChecker:WARN",
 		// "-Xep:AssertThrowsMultipleStatements:WARN",
 		// "-Xep:AssertionFailureIgnored:WARN",
+		// "-Xep:AutoValueFinalMethods:WARN",
 		// "-Xep:BadAnnotationImplementation:WARN",
 		// "-Xep:BadComparable:WARN",
+		// "-Xep:BadImport:WARN",
+		// "-Xep:BadInstanceof:WARN",
+		// "-Xep:BigDecimalEquals:WARN",
+		// "-Xep:BigDecimalLiteralDouble:WARN",
 		// "-Xep:BoxedPrimitiveConstructor:WARN",
 		// "-Xep:ByteBufferBackingArray:WARN",
 		// "-Xep:CannotMockFinalClass:WARN",
@@ -164,18 +177,25 @@ func init() {
 		// "-Xep:CatchFail:WARN",
 		// "-Xep:ClassCanBeStatic:WARN",
 		// "-Xep:ClassNewInstance:WARN",
+		// "-Xep:CloseableProvides:WARN",
 		// "-Xep:CollectionToArraySafeParameter:WARN",
 		// "-Xep:CollectorShouldNotUseState:WARN",
 		// "-Xep:ComparableAndComparator:WARN",
 		// "-Xep:DateFormatConstant:WARN",
 		// "-Xep:DefaultCharset:WARN",
+		// "-Xep:DeprecatedThreadMethods:WARN",
 		// "-Xep:DoubleBraceInitialization:WARN",
 		// "-Xep:DoubleCheckedLocking:WARN",
+		// "-Xep:EqualsGetClass:WARN",
 		// "-Xep:EqualsHashCode:WARN",
 		// "-Xep:EqualsIncompatibleType:WARN",
+		// "-Xep:EqualsUnsafeCast:WARN",
+		// "-Xep:EqualsUsingHashCode:WARN",
+		// "-Xep:ExtendingJUnitAssert:WARN",
 		// "-Xep:FallThrough:WARN",
 		// "-Xep:Finally:WARN",
 		// "-Xep:FloatCast:WARN",
+		// "-Xep:FloatingPointAssertionWithinEpsilon:WARN",
 		// "-Xep:FloatingPointLiteralPrecision:WARN",
 		// "-Xep:FragmentInjection:WARN",
 		// "-Xep:FragmentNotInstantiable:WARN",
@@ -186,6 +206,7 @@ func init() {
 		// "-Xep:ImmutableEnumChecker:WARN",
 		// "-Xep:IncompatibleModifiers:WARN",
 		// "-Xep:InconsistentCapitalization:WARN",
+		// "-Xep:InconsistentHashCode:WARN",
 		// "-Xep:IncrementInForLoopAndHeader:WARN",
 		// "-Xep:InjectOnConstructorOfAbstractClass:WARN",
 		// "-Xep:InputStreamSlowMultibyteRead:WARN",
@@ -197,10 +218,13 @@ func init() {
 		// "-Xep:JUnitAmbiguousTestClass:WARN",
 		// "-Xep:JavaLangClash:WARN",
 		// "-Xep:JdkObsolete:WARN",
+		// "-Xep:LockNotBeforeTry:WARN",
 		// "-Xep:LogicalAssignment:WARN",
+		// "-Xep:MathAbsoluteRandom:WARN",
 		// "-Xep:MissingCasesInEnumSwitch:WARN",
 		// "-Xep:MissingFail:WARN",
 		// "-Xep:MissingOverride:WARN",
+		// "-Xep:ModifiedButNotUsed:WARN",
 		// "-Xep:ModifyCollectionInEnhancedForLoop:WARN",
 		// "-Xep:MultipleParallelOrSequentialCalls:WARN",
 		// "-Xep:MutableConstantField:WARN",
@@ -212,6 +236,7 @@ func init() {
 		// "-Xep:NullablePrimitive:WARN",
 		// "-Xep:NullableVoid:WARN",
 		// "-Xep:ObjectToString:WARN",
+		// "-Xep:ObjectsHashCodePrimitive:WARN",
 		// "-Xep:OperatorPrecedence:WARN",
 		// "-Xep:OptionalNotPresent:WARN",
 		// "-Xep:OrphanedFormatString:WARN",
@@ -220,7 +245,7 @@ func init() {
 		// "-Xep:OverridesGuiceInjectableMethod:WARN",
 		// "-Xep:ParameterName:WARN",
 		// "-Xep:PreconditionsInvalidPlaceholder:WARN",
-		// "-Xep:ProtoFieldPreconditionsCheckNotNull:WARN",
+		// "-Xep:ProtoRedundantSet:WARN",
 		// "-Xep:QualifierOrScopeOnInjectMethod:WARN",
 		// "-Xep:ReachabilityFenceUsage:WARN",
 		// "-Xep:ReferenceEquality:WARN",
@@ -229,18 +254,27 @@ func init() {
 		// "-Xep:StaticGuardedByInstance:WARN",
 		// "-Xep:StreamResourceLeak:WARN",
 		// "-Xep:StringSplitter:WARN",
+		// "-Xep:SwigMemoryLeak:WARN",
 		// "-Xep:SynchronizeOnNonFinalField:WARN",
 		// "-Xep:ThreadJoinLoop:WARN",
 		// "-Xep:ThreadLocalUsage:WARN",
+		// "-Xep:ThreadPriorityCheck:WARN",
 		// "-Xep:ThreeLetterTimeZoneID:WARN",
+		// "-Xep:ToStringReturnsNull:WARN",
+		// "-Xep:TruthAssertExpected:WARN",
 		// "-Xep:TruthConstantAsserts:WARN",
 		// "-Xep:TruthIncompatibleType:WARN",
+		// "-Xep:TypeNameShadowing:WARN",
 		// "-Xep:TypeParameterShadowing:WARN",
 		// "-Xep:TypeParameterUnusedInFormals:WARN",
 		// "-Xep:URLEqualsHashCode:WARN",
+		// "-Xep:UndefinedEquals:WARN",
+		// "-Xep:UnnecessaryParentheses:WARN",
 		// "-Xep:UnsafeFinalization:WARN",
+		// "-Xep:UnsafeReflectiveConstructionCast:WARN",
 		// "-Xep:UnsynchronizedOverridesSynchronized:WARN",
 		// "-Xep:UseCorrectAssertInTests:WARN",
+		// "-Xep:VariableNameSameAsType:WARN",
 		// "-Xep:WaitNotInLoop:WARN",
 		// "-Xep:WakelockReleasedDangerously:WARN",
 
@@ -251,6 +285,7 @@ func init() {
 	// and simple experiments.
 	config.ErrorProneChecksDefaultDisabled = []string{
 		// Errorprone default severity ERROR
+		// "-Xep:AndroidJdkLibsChecker:ERROR",
 		// "-Xep:AssistedInjectAndInjectOnSameConstructor:ERROR",
 		// "-Xep:AutoFactoryAtInject:ERROR",
 		// "-Xep:ClassName:ERROR",
@@ -267,49 +302,64 @@ func init() {
 		// "-Xep:InsecureCryptoUsage:ERROR",
 		// "-Xep:IterablePathParameter:ERROR",
 		// "-Xep:JMockTestWithoutRunWithOrRuleAnnotation:ERROR",
+		// "-Xep:Java7ApiChecker:ERROR",
 		// "-Xep:JavaxInjectOnFinalField:ERROR",
 		// "-Xep:LockMethodChecker:ERROR",
 		// "-Xep:LongLiteralLowerCaseSuffix:ERROR",
 		// "-Xep:NoAllocation:ERROR",
 		// "-Xep:NumericEquality:ERROR",
 		// "-Xep:ParameterPackage:ERROR",
-		// "-Xep:ProtoStringFieldReferenceEquality:ERROR",
 		// "-Xep:RestrictTo:ERROR",
 		// "-Xep:StaticOrDefaultInterfaceMethod:ERROR",
 		// "-Xep:UnlockMethod:ERROR",
 
 		// Errorprone default severity WARNING
+		// "-Xep:AnnotateFormatMethod:WARN",
+		// "-Xep:AnnotationPosition:WARN",
 		// "-Xep:AssertFalse:WARN",
 		// "-Xep:AssistedInjectAndInjectOnConstructors:WARN",
-		// "-Xep:BigDecimalLiteralDouble:WARN",
 		// "-Xep:BinderIdentityRestoredDangerously:WARN",
 		// "-Xep:BindingToUnqualifiedCommonType:WARN",
 		// "-Xep:ConstructorInvokesOverridable:WARN",
 		// "-Xep:ConstructorLeaksThis:WARN",
 		// "-Xep:EmptyTopLevelDeclaration:WARN",
+		// "-Xep:EqualsBrokenForNull:WARN",
 		// "-Xep:ExpectedExceptionChecker:WARN",
 		// "-Xep:FunctionalInterfaceClash:WARN",
 		// "-Xep:HardCodedSdCardPath:WARN",
 		// "-Xep:InconsistentOverloads:WARN",
+		// "-Xep:InvalidParam:WARN",
+		// "-Xep:InvalidTag:WARN",
+		// "-Xep:InvalidThrows:WARN",
 		// "-Xep:MissingDefault:WARN",
 		// "-Xep:MutableMethodReturnType:WARN",
+		// "-Xep:NoFunctionalReturnType:WARN",
 		// "-Xep:NonCanonicalStaticMemberImport:WARN",
+		// "-Xep:NullableDereference:WARN",
 		// "-Xep:PrimitiveArrayPassedToVarargsMethod:WARN",
+		// "-Xep:ProtosAsKeyOfSetOrMap:WARN",
 		// "-Xep:ProvidesFix:WARN",
 		// "-Xep:QualifierWithTypeUse:WARN",
 		// "-Xep:RedundantThrows:WARN",
+		// "-Xep:ReturnFromVoid:WARN",
 		// "-Xep:StaticQualifiedUsingExpression:WARN",
 		// "-Xep:StringEquality:WARN",
+		// "-Xep:SystemExitOutsideMain:WARN",
 		// "-Xep:TestExceptionChecker:WARN",
 		// "-Xep:UnnecessaryDefaultInEnumSwitch:WARN",
+		// "-Xep:Unused:WARN",
+		// "-Xep:UnusedException:WARN",
 		// "-Xep:Var:WARN",
 
 		// Errorprone default severity SUGGESTION
 		// "-Xep:BooleanParameter:SUGGESTION",
+		// "-Xep:ClassNamedLikeTypeParameter:SUGGESTION",
 		// "-Xep:ConstantField:SUGGESTION",
 		// "-Xep:EmptySetMultibindingContributions:SUGGESTION",
+		// "-Xep:ExpectedExceptionRefactoring:SUGGESTION",
 		// "-Xep:FieldCanBeFinal:SUGGESTION",
 		// "-Xep:FieldMissingNullable:SUGGESTION",
+		// "-Xep:ImmutableRefactoring:SUGGESTION",
 		// "-Xep:LambdaFunctionalInterface:SUGGESTION",
 		// "-Xep:MethodCanBeStatic:SUGGESTION",
 		// "-Xep:MixedArrayDimensions:SUGGESTION",
@@ -325,7 +375,9 @@ func init() {
 		// "-Xep:ReturnMissingNullable:SUGGESTION",
 		// "-Xep:ScopeOnModule:SUGGESTION",
 		// "-Xep:SwitchDefault:SUGGESTION",
+		// "-Xep:TestExceptionRefactoring:SUGGESTION",
 		// "-Xep:ThrowsUncheckedException:SUGGESTION",
+		// "-Xep:TryFailRefactoring:SUGGESTION",
 		// "-Xep:TypeParameterNaming:SUGGESTION",
 		// "-Xep:UngroupedOverloads:SUGGESTION",
 		// "-Xep:UnnecessarySetDefault:SUGGESTION",