diff options
| author | Andreas Gampe <agampe@google.com> | 2018-10-18 14:24:00 -0700 |
|---|---|---|
| committer | Andreas Gampe <agampe@google.com> | 2018-10-18 14:24:00 -0700 |
| commit | d7d0dad8bc90203fbda1334d31c0bb8383ad155f (patch) | |
| tree | 5dfa8e8db21f47518d7e982b6e1ba2f150127abe /soong/error_prone.go | |
| parent | 8cf4a18a2f23d097b2e25fbd8a38aa5e00cdfe96 (diff) | |
| download | error_prone-d7d0dad8bc90203fbda1334d31c0bb8383ad155f.tar.gz | |
Errorprone: Move new 2.3.2 ERROR warnings to ERROR
Readjust the list of errors to include new by-default-error
checkers.
Bug: 114129741
Test: m javac-check RUN_ERROR_PRONE=true
Change-Id: Id2651ed6a1e0fd73bee69b92e71af77997f991c5
Diffstat (limited to 'soong/error_prone.go')
| -rw-r--r-- | soong/error_prone.go | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/soong/error_prone.go b/soong/error_prone.go index b5989fb..980065a 100644 --- a/soong/error_prone.go +++ b/soong/error_prone.go @@ -42,6 +42,7 @@ func init() { "-Xep:ChainingConstructorIgnoresParameter:ERROR", "-Xep:CheckReturnValue:ERROR", "-Xep:CollectionIncompatibleType:ERROR", + "-Xep:ComparingThisWithNull:ERROR", "-Xep:ComparisonOutOfRange:ERROR", "-Xep:CompatibleWithAnnotationMisuse:ERROR", "-Xep:CompileTimeConstant:ERROR", @@ -51,6 +52,7 @@ func init() { "-Xep:DeadThread:ERROR", "-Xep:DoNotCall:ERROR", "-Xep:EqualsNaN:ERROR", + "-Xep:EqualsWrongThing:ERROR", "-Xep:ForOverride:ERROR", "-Xep:FormatStringAnnotation:ERROR", "-Xep:FunctionalInterfaceMethodChanged:ERROR", @@ -65,6 +67,7 @@ func init() { "-Xep:InexactVarargsConditional:ERROR", "-Xep:InfiniteRecursion:ERROR", "-Xep:InjectMoreThanOneScopeAnnotationOnClass:ERROR", + "-Xep:InjectOnMemberAndConstructor:ERROR", "-Xep:InvalidPatternSyntax:ERROR", "-Xep:IsInstanceOfClass:ERROR", "-Xep:JUnit3TestNotRun:ERROR", @@ -76,6 +79,7 @@ func init() { "-Xep:JavaxInjectOnAbstractMethod:ERROR", "-Xep:LiteByteStringUtf8:ERROR", "-Xep:LoopConditionChecker:ERROR", + "-Xep:MissingTestCall:ERROR", "-Xep:MockitoCast:ERROR", "-Xep:MockitoUsage:ERROR", "-Xep:MoreThanOneInjectableConstructor:ERROR", @@ -91,12 +95,14 @@ func init() { "-Xep:PredicateIncompatibleType:ERROR", "-Xep:PrivateSecurityContractProtoAccess:ERROR", "-Xep:ProtoFieldNullComparison:ERROR", + "-Xep:ProtoStringFieldReferenceEquality:ERROR", "-Xep:ProvidesMethodOutsideOfModule:ERROR", "-Xep:RandomCast:ERROR", "-Xep:RestrictedApiChecker:ERROR", "-Xep:SelfAssignment:ERROR", "-Xep:ShouldHaveEvenArgs:ERROR", "-Xep:StreamToString:ERROR", + "-Xep:SubstringOfZero:ERROR", "-Xep:SuppressWarningsDeprecated:ERROR", "-Xep:ThrowIfUncheckedKnownChecked:ERROR", "-Xep:ThrowNull:ERROR", @@ -118,31 +124,26 @@ func init() { "-Xep:ArraysAsListPrimitiveArray:WARN", "-Xep:BadShiftAmount:WARN", "-Xep:ComparableType:WARN", - "-Xep:ComparingThisWithNull:WARN", "-Xep:ComplexBooleanConstant:WARN", "-Xep:ConditionalExpressionNumericPromotion:WARN", "-Xep:EqualsReference:WARN", - "-Xep:EqualsWrongThing:WARN", "-Xep:FormatString:WARN", "-Xep:GetClassOnAnnotation:WARN", "-Xep:GetClassOnClass:WARN", "-Xep:GuardedBy:WARN", "-Xep:HashtableContains:WARN", "-Xep:IdentityBinaryExpression:WARN", - "-Xep:InjectOnMemberAndConstructor:WARN", "-Xep:InvalidTimeZoneID:WARN", "-Xep:IsLoggableTagLength:WARN", "-Xep:MathRoundIntLong:WARN", "-Xep:MislabeledAndroidString:WARN", "-Xep:MissingSuperCall:WARN", - "-Xep:MissingTestCall:WARN", "-Xep:MisusedWeekYear:WARN", "-Xep:ModifyingCollectionWithItself:WARN", "-Xep:NonRuntimeAnnotation:WARN", "-Xep:NullTernary:WARN", "-Xep:OverridesJavaxInjectableMethod:WARN", "-Xep:ParcelableCreator:WARN", - "-Xep:ProtoStringFieldReferenceEquality:WARN", "-Xep:ProtocolBufferOrdinal:WARN", "-Xep:RandomModInteger:WARN", "-Xep:RectIntersectReturnValueIgnored:WARN", @@ -151,7 +152,6 @@ func init() { "-Xep:SelfEquals:WARN", "-Xep:SizeGreaterThanOrEqualsZero:WARN", "-Xep:StringBuilderInitWithChar:WARN", - "-Xep:SubstringOfZero:WARN", "-Xep:TryFailThrowable:WARN", "-Xep:UnusedCollectionModifiedInPlace:WARN", |