summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2015-03-06Fix segfault with client/server and minimal outputJens Axboe
Fixes: bf2921f02651 Reported-by: Ben England <bengland@redhat.com> Signed-off-by: Jens Axboe <axboe@fb.com>
2015-03-06sha256: fix verify failureJens Axboe
After the checksumming update, it's required that we call the _final() to get consistent checksums between data generation and data verification. Seems to only affect sha256, but we should do it for sha1 and md5 too. Fixes: f99d67f932ab Signed-off-by: Jens Axboe <axboe@fb.com>
2015-03-06sha256: fix verify failureJens Axboe
After the checksumming update, it's required that we call the _final() to get consistent checksums between data generation and data verification. Seems to only affect sha256, but we should do it for sha1 and md5 too. Fixes: f99d67f932ab Signed-off-by: Jens Axboe <axboe@fb.com>
2015-03-06verify: always check completion list for low depth verifiesJens Axboe
If we have done less IO than the depth, we need to check the pending list. Signed-off-by: Jens Axboe <axboe@fb.com>
2015-03-06ioengine: if we get BUSY in queuing, adjust accountingJens Axboe
Signed-off-by: Jens Axboe <axboe@fb.com>
2015-03-06Improve precision of the io_limit settingJens Axboe
For async engines, we look only at completions. But we could have a bunch inflight with a high queue depth, making us go higher than we should. Signed-off-by: Jens Axboe <axboe@fb.com>
2015-03-06Improve rate limitingJens Axboe
If we have pending IO, we should commit it before going to sleep, not just wait for IO that has already been issued. Also improve the delay functions to return the time spent, so that users don't have to track tha separately if they care about the precision. Signed-off-by: Jens Axboe <axboe@fb.com>
2015-03-06rbd example: 'invalidate=false' no longer necessaryJens Axboe
As of commit 903b2812e9c7, rbd does support cache invalidation. Signed-off-by: Jens Axboe <axboe@fb.com>
2015-03-06client: take better care to return failure from fio_handle_clients()Jens Axboe
If any error has been noted in the ->error field, we need to pass back a non-zero return from fio_handle_clients(). Signed-off-by: Jens Axboe <axboe@fb.com>
2015-03-06smalloc: limit to 1 pool, and bump size to 16MBJens Axboe
We can easily add new pools, but if we do this after jobs have been forked off, then it wont really be shared storage as the new mmap mappings will only apply to the process that instantiated them. Since we moved the randommap mappings to private storage, we should not need a lot of room for shared allocations. Hence I hope the 16MB will suffice. Signed-off-by: Jens Axboe <axboe@fb.com>
2015-03-06axmap: random maps are private, don't get them from smallocJens Axboe
Signed-off-by: Jens Axboe <axboe@fb.com>
2015-03-06filelock: fix segfault on some use cases of log file lockingJens Axboe
If we end up diving into a new smalloc pool, we could add file lock references that meant nothing to other processes. Fixes: 243bfe190245 Signed-off-by: Jens Axboe <axboe@fb.com>
2015-03-06mmap backend invalidate fixYoshinori Sato
madvice before mmap. moved later. Signed-off-by Yoshinori Sato <yo-satoh@sios.com> Signed-off-by: Jens Axboe <axboe@fb.com>
2015-03-06Fix disk utils being updated too oftenJens Axboe
Fixes: f893b76d5745 Signed-off-by: Jens Axboe <axboe@fb.com>
2015-03-06Adjust ctime_r buf down to 32Jens Axboe
We need 'at least 26 bytes', but not all 64. Signed-off-by: Jens Axboe <axboe@fb.com>
2015-03-06Add timestamp to json outputSteve ODriscoll
Modified by Jens to add humanly readable time as well. Signed-off-by: Jens Axboe <axboe@fb.com>
2015-03-06gettime: include min/max cycle counts for CPU clockJens Axboe
Signed-off-by: Jens Axboe <axboe@fb.com>
2015-03-06server: use fio_gettime() for timeout variablesJens Axboe
Signed-off-by: Jens Axboe <axboe@fb.com>
2015-03-06verify: fix potentially unterminated nameJens Axboe
Signed-off-by: Jens Axboe <axboe@fb.com>
2015-03-06memory: double check that mmapfd isn't -1 before closingJens Axboe
Signed-off-by: Jens Axboe <axboe@fb.com>
2015-03-06gluster: io_u->error should be a positive error valueJens Axboe
Signed-off-by: Jens Axboe <axboe@fb.com>
2015-03-06client: fix potential buffer overrun in server name copyJens Axboe
Not an issue right now since pdu.server is larger than the buffer, but that could change at some point. Better be safe. Signed-off-by: Jens Axboe <axboe@fb.com>
2015-03-06init: fix potential mem leak on multiple trigger optionsJens Axboe
Free the ones we already set, if any. Signed-off-by: Jens Axboe <axboe@fb.com>
2015-03-06Avoid potential buffer overflow in make_filename()Jens Axboe
Signed-off-by: Jens Axboe <axboe@fb.com>
2015-03-06cleanup: add defines for default pareto or zipf valuesJens Axboe
Signed-off-by: Jens Axboe <axboe@fb.com>
2015-03-06Fio 2.2.4Jens Axboe
Signed-off-by: Jens Axboe <axboe@fb.com>
2015-03-06bloom: kill unused functionJens Axboe
Signed-off-by: Jens Axboe <axboe@fb.com>
2015-03-06axmap: make axmap_first_free() staticMing Lei
Pulled from an earlier patch from Ming, that we no longer need. Signed-off-by: Jens Axboe <axboe@fb.com>
2015-03-06Revert "axmap: ensure we lock down the maps for shared access"Jens Axboe
This reverts commit 12bde3697fc230d7af560cecc8ac469ab47643f8.
2015-03-06Revert "axmap: fix deadlock"Jens Axboe
This reverts commit d555a23db84364ab942361a719a4379605bdbc41.
2015-03-06Get rid of lockfile callbackJens Axboe
We don't need it, since the option priorities take care of ordering. Signed-off-by: Jens Axboe <axboe@fb.com>
2015-03-06axmap: fix deadlockMing Lei
axmap_first_free() is always called with axmap->lock held, so needn't to acquire the lock inside the function. The deadlock is introduced in commit 12bde3697fc230d7a(axmap: ensure we lock down the maps for shared access). Given axmap_first_free() is only called inside lib/axmap.c, this patch declares the function as static. In the future, if external users need the function, axmap lock can be considered at that time. Reported-by: Sedat Dilek <sedat.dilek@gmail.com> Signed-off-by: Ming Lei <ming.lei@canonical.com> Tested-by: Sedat Dilek <sedat.dilek@gmail.com> Signed-off-by: Jens Axboe <axboe@fb.com>
2015-03-06gettime: add basic init cpuclock testJens Axboe
Some systems claim to have a synced and constant rate tsc, even if they don't. So add the basic cpuclock-test test as part of fio trusting the CPU clock, to avoid using the CPU clock on a system where the TSC truly isn't synced between CPUs. Signed-off-by: Jens Axboe <axboe@fb.com>
2015-03-06Fio 2.2.3Jens Axboe
Signed-off-by: Jens Axboe <axboe@fb.com>
2015-03-06options: ensure that we check all candidates on is_set checkJens Axboe
We can have multiple options that touch the same variable. One example is cpus_allowed or cpumask, both will set the same backend variable. But if we set cpumask= and later check if cpus_allowed is set, then we want that to report true. This breaks certain options since b2a9e6496494. Reported-by: Vincent Fu <Vincent.Fu@sandisk.com> Signed-off-by: Jens Axboe <axboe@fb.com>
2015-03-06Fio 2.2.2Jens Axboe
Signed-off-by: Jens Axboe <axboe@fb.com>
2015-03-06Fix default scrambling of buffersJens Axboe
Commit 1bf2498d3111 inadvertently made us not scramble by default. The logic was a bit convoluted, so clear it up and scramble if: - Asked so by adding scramble_buffers=1 - Or, if not asked to explicitly, but zero_buffers not set to 1. Reported-by: Chris Wilson <Chris.Wilson@nutanix.com> Signed-off-by: Jens Axboe <axboe@fb.com>
2015-03-06gettime: hide fio_gtod_cpumask if not usedJens Axboe
Signed-off-by: Jens Axboe <axboe@fb.com>
2015-03-06gettime: only use CPU affinity if availableJens Axboe
Signed-off-by: Jens Axboe <axboe@fb.com>
2015-03-06Fio 2.2.1Jens Axboe
Signed-off-by: Jens Axboe <axboe@fb.com>
2015-03-06axmap: ensure we lock down the maps for shared accessJens Axboe
Signed-off-by: Jens Axboe <axboe@fb.com>
2015-03-06options: turn missing options into debug parse messagesJens Axboe
It's not an error, we expect it to happen if we try and check for set options that aren't available (due to being platform specific, libraries missing, etc). This fixes cases where fio would spew: fio: no option found at offset 1240 and other offsets. Signed-off-by: Jens Axboe <axboe@fb.com>
2015-03-06options: add debug code for failure to lookup option namesJens Axboe
Signed-off-by: Jens Axboe <axboe@fb.com>
2015-03-06mutex: add __fio_mutex_remove()Jens Axboe
We have to remember to free the condvar, so add a __fio_mutex_remove() for cases that init a mutex inside an smalloc'ed region with __fio_mutex_init(). Signed-off-by: Jens Axboe <axboe@fb.com>
2015-03-06t/btrace2fio: add ability to add specific options through -aJens Axboe
Can be used multiple times to add more options. Signed-off-by: Jens Axboe <axboe@fb.com>
2015-03-06parse: remove the arithmetic parser checkingJens Axboe
Signed-off-by: Jens Axboe <axboe@fb.com>
2015-03-06Fio 2.2.0Jens Axboe
Signed-off-by: Jens Axboe <axboe@fb.com>
2015-03-06gettime: fix compile warning for !ARCH_HAVE_CPU_CLOCKJens Axboe
Signed-off-by: Jens Axboe <axboe@fb.com>
2015-03-06gettime: offset CPU cycle counter by initial valueJens Axboe
Should then be safe for the full 2^64 cycles, and we push the more expensive variable division to later in the run (which is probably never). Signed-off-by: Jens Axboe <axboe@fb.com>
2015-03-06stat: always show disk util in terse v3/v4Jens Axboe
Signed-off-by: Jens Axboe <axboe@fb.com>