internal/event: move event/core.Tag to event/label.Label

Also moves core.Key to label.Key, but leaves the implementations
behind for now.
After using for a while, the word Tag conveys slightly the wrong
concept, tagging implies the entire set of information, label maps
better to a single named piece of information.
A label is just a named key/value pair, it is not really tied to the
event package, separating it makes it much easier to understand the
public symbols of the event and core packages, and allows us to also
move the key implementations somewhere else, which otherwise dominate
the API.

Change-Id: I46275d531cec91e28af6ab1e74a2713505d52533
Reviewed-on: https://go-review.googlesource.com/c/tools/+/229239
Run-TryBot: Ian Cottrell <iancottrell@google.com>
Reviewed-by: Robert Findley <rfindley@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>

1 files changed, 6 insertions, 6 deletions

diff --git a/internal/lsp/debug/metrics.go b/internal/lsp/debug/metrics.go
index 94b582ead..8efc1d495 100644
--- a/internal/lsp/debug/metrics.go
+++ b/internal/lsp/debug/metrics.go
@@ -5,8 +5,8 @@
 package debug
 
 import (
-	"golang.org/x/tools/internal/event/core"
 	"golang.org/x/tools/internal/event/export/metric"
+	"golang.org/x/tools/internal/event/label"
 	"golang.org/x/tools/internal/lsp/debug/tag"
 )
 
@@ -18,34 +18,34 @@ var (
 	receivedBytes = metric.HistogramInt64{
 		Name:        "received_bytes",
 		Description: "Distribution of received bytes, by method.",
-		Keys:        []core.Key{tag.RPCDirection, tag.Method},
+		Keys:        []label.Key{tag.RPCDirection, tag.Method},
 		Buckets:     bytesDistribution,
 	}
 
 	sentBytes = metric.HistogramInt64{
 		Name:        "sent_bytes",
 		Description: "Distribution of sent bytes, by method.",
-		Keys:        []core.Key{tag.RPCDirection, tag.Method},
+		Keys:        []label.Key{tag.RPCDirection, tag.Method},
 		Buckets:     bytesDistribution,
 	}
 
 	latency = metric.HistogramFloat64{
 		Name:        "latency",
 		Description: "Distribution of latency in milliseconds, by method.",
-		Keys:        []core.Key{tag.RPCDirection, tag.Method},
+		Keys:        []label.Key{tag.RPCDirection, tag.Method},
 		Buckets:     millisecondsDistribution,
 	}
 
 	started = metric.Scalar{
 		Name:        "started",
 		Description: "Count of RPCs started by method.",
-		Keys:        []core.Key{tag.RPCDirection, tag.Method},
+		Keys:        []label.Key{tag.RPCDirection, tag.Method},
 	}
 
 	completed = metric.Scalar{
 		Name:        "completed",
 		Description: "Count of RPCs completed by method and status.",
-		Keys:        []core.Key{tag.RPCDirection, tag.Method, tag.StatusCode},
+		Keys:        []label.Key{tag.RPCDirection, tag.Method, tag.StatusCode},
 	}
 )