diff options
| author | Rebecca Stambler <rstambler@golang.org> | 2020-04-17 00:21:51 -0400 |
|---|---|---|
| committer | Rebecca Stambler <rstambler@golang.org> | 2020-04-17 14:00:56 +0000 |
| commit | c07e33ef3290829dccb52f723d2b5676c837a330 (patch) | |
| tree | b2c05e19c75c67bcfd586449037f27917cd8b446 /internal/lsp | |
| parent | e33929705bc08181006947ca424fb77f043dfeca (diff) | |
| download | golang-x-tools-c07e33ef3290829dccb52f723d2b5676c837a330.tar.gz | |
internal/lsp/source: enable type error analyzers
I had intended to enable these after gopls/v0.4.0 was released so that
people who test at master can try these out. Also, mark "fillreturns" as
high confidence so users can get it applied on save, much like
goreturns.
Change-Id: I71aa0b723b2e9b69474ceed7cb1d7da7c929d65d
Reviewed-on: https://go-review.googlesource.com/c/tools/+/228724
Run-TryBot: Rebecca Stambler <rstambler@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Robert Findley <rfindley@google.com>
Diffstat (limited to 'internal/lsp')
| -rw-r--r-- | internal/lsp/source/options.go | 13 |
1 files changed, 7 insertions, 6 deletions
diff --git a/internal/lsp/source/options.go b/internal/lsp/source/options.go index 06b56b74d..8037b4e58 100644 --- a/internal/lsp/source/options.go +++ b/internal/lsp/source/options.go @@ -498,23 +498,24 @@ func (r *OptionResult) setBool(b *bool) { func typeErrorAnalyzers() map[string]Analyzer { return map[string]Analyzer{ fillreturns.Analyzer.Name: { - Analyzer: fillreturns.Analyzer, - enabled: false, - FixesError: fillreturns.FixesError, + Analyzer: fillreturns.Analyzer, + enabled: true, + FixesError: fillreturns.FixesError, + HighConfidence: true, }, nonewvars.Analyzer.Name: { Analyzer: nonewvars.Analyzer, - enabled: false, + enabled: true, FixesError: nonewvars.FixesError, }, noresultvalues.Analyzer.Name: { Analyzer: noresultvalues.Analyzer, - enabled: false, + enabled: true, FixesError: noresultvalues.FixesError, }, undeclaredname.Analyzer.Name: { Analyzer: undeclaredname.Analyzer, - enabled: false, + enabled: true, FixesError: undeclaredname.FixesError, }, } |