From a5b4c53f6e8bdcafa95a94671bf2d1203365858b Mon Sep 17 00:00:00 2001 From: Yury Smolsky Date: Sun, 20 May 2018 10:57:22 +0300 Subject: playground.js: display vet errors when program has no output When program has no output and vet errors are encountered, initialize data.Events as an empty array. Fixes golang/go#25455. Change-Id: Icedd77685b784505da3bb6383629cdfa8b8b22e9 Reviewed-on: https://go-review.googlesource.com/113875 Run-TryBot: Yury Smolsky TryBot-Result: Gobot Gobot Reviewed-by: Andrew Bonventre --- godoc/static/playground.js | 5 ++++- godoc/static/static.go | 5 ++++- 2 files changed, 8 insertions(+), 2 deletions(-) (limited to 'godoc') diff --git a/godoc/static/playground.js b/godoc/static/playground.js index aad459fa3..1b7be65ac 100644 --- a/godoc/static/playground.js +++ b/godoc/static/playground.js @@ -109,7 +109,10 @@ function HTTPTransport(enableVet) { dataType: "json", success: function(dataVet) { if (dataVet.Errors) { - // inject errors from the vet as the first event in the output + if (!data.Events) { + data.Events = []; + } + // inject errors from the vet as the first events in the output data.Events.unshift({Message: 'Go vet exited.\n\n', Kind: 'system', Delay: 0}); data.Events.unshift({Message: dataVet.Errors, Kind: 'stderr', Delay: 0}); } diff --git a/godoc/static/static.go b/godoc/static/static.go index 051176213..20edbe6c8 100644 --- a/godoc/static/static.go +++ b/godoc/static/static.go @@ -2398,7 +2398,10 @@ function HTTPTransport(enableVet) { dataType: "json", success: function(dataVet) { if (dataVet.Errors) { - // inject errors from the vet as the first event in the output + if (!data.Events) { + data.Events = []; + } + // inject errors from the vet as the first events in the output data.Events.unshift({Message: 'Go vet exited.\n\n', Kind: 'system', Delay: 0}); data.Events.unshift({Message: dataVet.Errors, Kind: 'stderr', Delay: 0}); } -- cgit v1.2.3