1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
|
// Copyright 2020 The Go Authors. All rights reserved.
// Use of this source code is governed by a BSD-style
// license that can be found in the LICENSE file.
// Package noresultvalues defines an Analyzer that applies suggested fixes
// to errors of the type "no result values expected".
package noresultvalues
import (
"bytes"
"go/ast"
"go/format"
"golang.org/x/tools/go/analysis"
"golang.org/x/tools/go/analysis/passes/inspect"
"golang.org/x/tools/go/ast/inspector"
"golang.org/x/tools/internal/analysisinternal"
)
const Doc = `suggested fixes for "no result values expected"
This checker provides suggested fixes for type errors of the
type "no result values expected". For example:
func z() { return nil }
will turn into
func z() { return }
`
var Analyzer = &analysis.Analyzer{
Name: string(analysisinternal.NoResultValues),
Doc: Doc,
Requires: []*analysis.Analyzer{inspect.Analyzer},
Run: run,
RunDespiteErrors: true,
}
const noResultValuesMsg = "no result values expected"
func run(pass *analysis.Pass) (interface{}, error) {
inspect := pass.ResultOf[inspect.Analyzer].(*inspector.Inspector)
errors := analysisinternal.GetTypeErrors(pass)
nodeFilter := []ast.Node{(*ast.ReturnStmt)(nil)}
inspect.Preorder(nodeFilter, func(n ast.Node) {
retStmt, _ := n.(*ast.ReturnStmt)
var file *ast.File
for _, f := range pass.Files {
if f.Pos() <= retStmt.Pos() && retStmt.Pos() < f.End() {
file = f
break
}
}
if file == nil {
return
}
for _, err := range errors {
if err.Msg != noResultValuesMsg {
continue
}
if retStmt.Pos() >= err.Pos || err.Pos >= retStmt.End() {
continue
}
var buf bytes.Buffer
if err := format.Node(&buf, pass.Fset, file); err != nil {
continue
}
pass.Report(analysis.Diagnostic{
Pos: err.Pos,
End: analysisinternal.TypeErrorEndPos(pass.Fset, buf.Bytes(), err.Pos),
Message: err.Msg,
SuggestedFixes: []analysis.SuggestedFix{{
Message: "Delete return values",
TextEdits: []analysis.TextEdit{{
Pos: retStmt.Pos(),
End: retStmt.End(),
NewText: []byte("return"),
}},
}},
})
}
})
return nil, nil
}
|
