diff options
| author | Eric <eric@efcs.ca> | 2018-05-29 06:25:32 -0600 |
|---|---|---|
| committer | Dominic Hamon <dominichamon@users.noreply.github.com> | 2018-05-29 13:25:32 +0100 |
| commit | 7b8d0249d8d66040ce9ffe6b94cc8421ef3e61d8 (patch) | |
| tree | 3bf92240267cda6e261cdcfe725b950bf1050747 /CMakeLists.txt | |
| parent | 16703ff83c1ae6d53e5155df3bb3ab0bc96083be (diff) | |
| download | google-benchmark-7b8d0249d8d66040ce9ffe6b94cc8421ef3e61d8.tar.gz | |
Deprecate CSVReporter - A first step to overhauling reporting. (#488)
As @dominichamon and I have discussed, the current reporter interface
is poor at best. And something should be done to fix it.
I strongly suspect such a fix will require an entire reimagining
of the API, and therefore breaking backwards compatibility fully.
For that reason we should start deprecating and removing parts
that we don't intend to replace. One of these parts, I argue,
is the CSVReporter. I propose that the new reporter interface
should choose a single output format (JSON) and traffic entirely
in that. If somebody really wanted to replace the functionality
of the CSVReporter they would do so as an external tool which
transforms the JSON.
For these reasons I propose deprecating the CSVReporter.
Diffstat (limited to 'CMakeLists.txt')
| -rw-r--r-- | CMakeLists.txt | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/CMakeLists.txt b/CMakeLists.txt index b1c1d3d..f647c59 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -130,7 +130,6 @@ else() # Turn compiler warnings up to 11 add_cxx_compiler_flag(-Wall) - add_cxx_compiler_flag(-Wextra) add_cxx_compiler_flag(-Wshadow) add_cxx_compiler_flag(-Werror RELEASE) @@ -141,6 +140,9 @@ else() add_cxx_compiler_flag(-Wshorten-64-to-32) add_cxx_compiler_flag(-Wfloat-equal) add_cxx_compiler_flag(-fstrict-aliasing) + # Disable warnings regarding deprecated parts of the library while building + # and testing those parts of the library. + add_cxx_compiler_flag(-Wno-deprecated-declarations) if (NOT BENCHMARK_ENABLE_EXCEPTIONS) add_cxx_compiler_flag(-fno-exceptions) endif() |