diff options
| author | Steven Arzt <Steven.Arzt@sit.fraunhofer.de> | 2021-09-15 09:42:57 +0200 |
|---|---|---|
| committer | Ben Gruver <bgruv@google.com> | 2022-03-08 14:50:22 -0600 |
| commit | 85334314da621070e0a2675cab01fcdb8cb650ba (patch) | |
| tree | fc45630578c5d1f7de748cc65e7720e3db511bd2 | |
| parent | 78a829342fbeaca464a06f0ec4c9e96047616ae9 (diff) | |
| download | google-smali-85334314da621070e0a2675cab01fcdb8cb650ba.tar.gz | |
Check whether we have a next element instead of accessing it and catching the exception. Exceptions are notoriously slow in Java, so we want to avoid that.
| -rw-r--r-- | dexlib2/src/main/java/org/jf/util/CollectionUtils.java | 10 |
1 files changed, 4 insertions, 6 deletions
diff --git a/dexlib2/src/main/java/org/jf/util/CollectionUtils.java b/dexlib2/src/main/java/org/jf/util/CollectionUtils.java index 23e23dc9..c2aa33e2 100644 --- a/dexlib2/src/main/java/org/jf/util/CollectionUtils.java +++ b/dexlib2/src/main/java/org/jf/util/CollectionUtils.java @@ -78,11 +78,10 @@ public class CollectionUtils { Iterator<? extends T> elements2 = it2.iterator(); for (T element1: it1) { T element2; - try { - element2 = elements2.next(); - } catch (NoSuchElementException ex) { + if (!elements2.hasNext()) { return 1; } + element2 = elements2.next(); int res = comparator.compare(element1, element2); if (res != 0) return res; } @@ -97,11 +96,10 @@ public class CollectionUtils { Iterator<? extends T> elements2 = it2.iterator(); for (T element1: it1) { T element2; - try { - element2 = elements2.next(); - } catch (NoSuchElementException ex) { + if (!elements2.hasNext()) { return 1; } + element2 = elements2.next(); int res = element1.compareTo(element2); if (res != 0) return res; } |