aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorGennadiy Civil <misterg@google.com>2019-02-13 11:56:42 -0500
committerGennadiy Civil <misterg@google.com>2019-02-13 11:56:43 -0500
commitea43be9d1a781b73dbd573954ee4a371c233a583 (patch)
tree98397c6f50eae6e098aab4995b6b674ca2053e3b
parente5e846da7fda1c6bc764091000a16e12dc8f8a35 (diff)
parented2fe122f8dc9aca844d724986d1d5cf5b65ea4e (diff)
downloadgoogletest-ea43be9d1a781b73dbd573954ee4a371c233a583.tar.gz
Merge pull request #2119 from ngie-eign:clang-wunused-private-field
PiperOrigin-RevId: 233762751
-rw-r--r--googlemock/test/gmock-matchers_test.cc2
-rw-r--r--googletest/test/googletest-param-test-test.cc2
2 files changed, 4 insertions, 0 deletions
diff --git a/googlemock/test/gmock-matchers_test.cc b/googlemock/test/gmock-matchers_test.cc
index c2f1d0ad..cdca2300 100644
--- a/googlemock/test/gmock-matchers_test.cc
+++ b/googlemock/test/gmock-matchers_test.cc
@@ -982,6 +982,8 @@ class Unprintable {
Unprintable() : c_('a') {}
bool operator==(const Unprintable& /* rhs */) const { return true; }
+ // -Wunused-private-field: dummy accessor for `c_`.
+ char dummy_c() { return c_; }
private:
char c_;
};
diff --git a/googletest/test/googletest-param-test-test.cc b/googletest/test/googletest-param-test-test.cc
index 2ab9b1ba..6c187dff 100644
--- a/googletest/test/googletest-param-test-test.cc
+++ b/googletest/test/googletest-param-test-test.cc
@@ -964,6 +964,8 @@ INSTANTIATE_TEST_SUITE_P(StatefulNamingFunctor, StatefulNamingTest, Range(0, 5),
class Unstreamable {
public:
explicit Unstreamable(int value) : value_(value) {}
+ // -Wunused-private-field: dummy accessor for `value_`.
+ const int& dummy_value() const { return value_; }
private:
int value_;